From 7c0101f6bd2bcec736aec8d5044d4b9af1909730 Mon Sep 17 00:00:00 2001
From: Markus Zolliker <markus.zolliker@psi.ch>
Date: Thu, 11 Mar 2021 15:33:21 +0100
Subject: [PATCH] fix user friendly reporting of config errors

Change-Id: I42ec1ad2e18a0363fb7317c86743ff2f6665f049
---
 secop/server.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/secop/server.py b/secop/server.py
index 2ccad9a..e22cd13 100644
--- a/secop/server.py
+++ b/secop/server.py
@@ -235,15 +235,15 @@ class Server:
                 classname = opts.pop('class')
                 cls = get_class(classname)
                 modobj = cls(modname, self.log.getChild(modname), opts, self)
+                # all used args should be popped from opts!
+                if opts:
+                    errors.append(self.unknown_options(cls, opts))
+                self.modules[modname] = modobj
             except ConfigError as e:
                 errors.append(str(e))
             except Exception as e:
                 badclass = classname
                 errors.append('error while loading %s' % badclass)
-            # all used args should be popped from opts!
-            if opts:
-                self.unknown_options(cls, opts)
-            self.modules[modname] = modobj
 
         poll_table = dict()
         # all objs created, now start them up and interconnect