linse/frappy
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

flamedil as of 2023-07-03

Browse Source
This commit is contained in:
l_samenv
2023-07-03 17:11:07 +02:00
parent b4cfdcfc1a
commit 6ac3938b78
3 changed files with 48 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
frappy_psi/ls372.py
View File

@ -207,8 +207,17 @@ class ResChannel(Channel):
STATUS_MASK = 0x3f # mask T_OVER and T_UNDER
def communicate(self, command):
# TODO: remove this and change to query
return self.switcher.communicate(command)
def query(self, command):
return parse(self.switcher.communicate(command))
def change(self, command, *args):
cmd, _, qarg = command.partition(' ')
args = ','.join([qarg] + [f'{a:g}' for a in args])
return parse(self.switcher.communicate(f'{command}?{qarg};{command} {args}'))
def read_status(self):
if not self.enabled:
return [self.Status.DISABLED, 'disabled']
@ -361,6 +370,7 @@ class TemperatureChannel(ResChannel):
class TemperatureLoop(HasConvergence, TemperatureChannel, Drivable):
loop = Property('lakshore loop', IntRange(0, 1), default=0) # TODO: implemented specific issues of loop 1
target = Parameter('setpoint', FloatRange(0, unit='$'))
control_active = Parameter('we are controlling', BoolType(), default=0)
minheater = Parameter('minimal heater current', FloatRange(0, 0.01, unit='A'), readonly=False, default=0)
@ -373,7 +383,7 @@ class TemperatureLoop(HasConvergence, TemperatureChannel, Drivable):
def control_off(self):
"""switch control off"""
self._control_active = False
self.communicate(f'RANGE 0,0;RANGE?0')
self.communicate(f'RANGE {self.loop},0;RANGE?{self.loop}')
self.read_control_active()
def min_percent(self):
@ -384,21 +394,21 @@ class TemperatureLoop(HasConvergence, TemperatureChannel, Drivable):
def set_htrrng(self):
if self._control_active:
newhtr = int(self.htrrng) if self._control_active else 0
htrrng = int(self.communicate('RANGE?0'))
htrrng = int(self.communicate(f'RANGE?{self.loop}'))
if htrrng != newhtr:
if newhtr:
self.log.info('switched heater on %d', newhtr)
self.communicate(f'RANGE 0,{newhtr};RANGE?0')
self.communicate(f'RANGE {self.loop},{newhtr};RANGE?{self.loop}')
if self.minheater:
self.log.info('underflow open loop')
self._underflow = True
self.communicate(f'OUTMODE 0,2,{self.channel},0,0,1,3;*OPC?')
self.communicate(f'MOUT {self.min_percent()};*OPC?')
self.communicate(f'OUTMODE {self.loop},2,{self.channel},0,0,1,3;*OPC?')
self.communicate(f'MOUT {self.loop}{self.min_percent()};*OPC?')
elif self._underflow:
self.log.info('switch to control after underflow')
self._underflow = False
self.communicate(f'OUTMODE 0,5,{self.channel},0,0,1,3;*OPC?')
self.communicate(f'SETP 0,{self.target};SETP?0')
self.communicate(f'OUTMODE {self.loop},5,{self.channel},0,0,1,3;*OPC?')
self.communicate(f'SETP {self.loop},{self.target};*OPC?')
def read_control_active(self):
self.set_htrrng()
@ -406,23 +416,31 @@ class TemperatureLoop(HasConvergence, TemperatureChannel, Drivable):
def read_target(self):
if self._control_active:
return float(self.communicate('SETP?0'))
return float(self.communicate('SETP?{self.loop}'))
return 0
def write_htrrng(self, value):
if self._control_active:
self.communicate('RANGE 0,{int(value)};*OPC?')
self.communicate('RANGE {self.loop},{int(value)};*OPC?')
return value
def write_target(self, target):
outmode = (5, self.channel, 0, 0, 1, 3)
prev = parse(self.communicate('OUTMODE?0'))
prev = parse(self.communicate('OUTMODE?{self.loop}'))
if outmode != prev:
self.communicate('OUTMODE 0, %g,%g,%g,%g,%g,%g;*OPC?' % tuple(outmode))
self.communicate('MOUT 0,{self.min_percent()};*OPC?')
self.communicate('OUTMODE {self.loop}, %g,%g,%g,%g,%g,%g;*OPC?' % tuple(outmode))
self.communicate('MOUT {self.loop},{self.min_percent()};*OPC?')
for chan in self.switcher.channels.values():
chan._control_active = False
self._control_active = True
self.read_control_active()
self.convergence_start()
return float(self.communicate(f'SETP 0,{target};SETP?0'))
return float(self.communicate(f'SETP {self.loop},{target};SETP?{self.loop}'))
#def write_ctrlpars(self, ctrlpars):
# p, i, d = self.change(f'PID {self.loop}', ctrlpars['p'], ctrlpars['i'], ctrlpars['d'])
# return {'p': p, 'i': i, 'd': d}
#def read_ctrlpars(self):
# p, i, d = self.query(f'PID? {self.loop}')
# return {'p': p, 'i': i, 'd': d}