From 679559c1e7b6535fd5b70849226812a2edf95994 Mon Sep 17 00:00:00 2001 From: Markus Zolliker Date: Wed, 23 Oct 2019 08:52:49 +0200 Subject: [PATCH] readonly is mandatory for SECoP but still optional with default True for frappy Parameter Change-Id: I416c835af324ec3875aaa785cd0aefb28f9bfaa3 Reviewed-on: https://forge.frm2.tum.de/review/c/sine2020/secop/playground/+/21457 Tested-by: JenkinsCodeReview Reviewed-by: Enrico Faulhaber Reviewed-by: Markus Zolliker --- secop/params.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/secop/params.py b/secop/params.py index 6b4f9c8..705635d 100644 --- a/secop/params.py +++ b/secop/params.py @@ -98,7 +98,7 @@ class Parameter(Accessible): 'datatype': Property('Datatype of the Parameter', DataTypeType(), extname='datainfo', mandatory=True), 'readonly': Property('Is the Parameter readonly? (vs. changeable via SECoP)', BoolType(), - extname='readonly', default=True), + extname='readonly', mandatory=True), 'group': Property('Optional parameter group this parameter belongs to', StringType(), extname='group', default=''), 'visibility': Property('Optional visibility hint', EnumType('visibility', user=1, advanced=2, expert=3), @@ -130,6 +130,7 @@ class Parameter(Accessible): kwds['description'] = description kwds['datatype'] = datatype + kwds['readonly'] = kwds.get('readonly', True) # for frappy optional, for SECoP mandatory if unit is not None: # for legacy code only datatype.setProperty('unit', unit) super(Parameter, self).__init__(**kwds)