From 4bb11e249d8a4fe41c17462a92ebb89e5b1c40b4 Mon Sep 17 00:00:00 2001
From: Markus Zolliker <markus.zolliker@psi.ch>
Date: Wed, 26 Feb 2020 11:36:28 +0100
Subject: [PATCH] stringio now works with serial connections

also allow SECoP client connections via serial

Change-Id: I10c02532a9f8e9b8f16599b98c439742da6d8f5c
Reviewed-on: https://forge.frm2.tum.de/review/c/sine2020/secop/playground/+/22525
Tested-by: JenkinsCodeReview <bjoern_pedersen@frm2.tum.de>
Reviewed-by: Markus Zolliker <markus.zolliker@psi.ch>
---
 secop/lib/asynconn.py | 128 +++++++++++++++++++++++++++++++++++++-----
 secop/stringio.py     | 124 +++++++++-------------------------------
 2 files changed, 141 insertions(+), 111 deletions(-)

diff --git a/secop/lib/asynconn.py b/secop/lib/asynconn.py
index d7c3e26..5569fe2 100644
--- a/secop/lib/asynconn.py
+++ b/secop/lib/asynconn.py
@@ -16,21 +16,25 @@
 # 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 #
 # Module authors:
-#   Enrico Faulhaber <enrico.faulhaber@frm2.tum.de>
 #   Markus Zolliker <markus.zolliker@psi.ch>
 #
 # *****************************************************************************
 
-"""asynchonous connections
+"""asynchronous connections
 
 generic class for byte oriented communication
 includes implementation for TCP connections
+support for asynchronous communication, but may be used also for StringIO
 """
 
 import socket
+import select
 import time
+import ast
+from serial import Serial
 
 from secop.lib import parseHostPort, tcpSocket, closeSocket
+from secop.errors import ConfigError
 
 
 class ConnectionClosed(ConnectionError):
@@ -43,7 +47,7 @@ class AsynConn:
     connection = None  # is not None, if connected
     defaultport = None
 
-    def __new__(cls, uri):
+    def __new__(cls, uri, end_of_line=b'\n'):
         scheme = uri.split('://')[0]
         iocls = cls.SCHEME_MAP.get(scheme, None)
         if not iocls:
@@ -51,12 +55,19 @@ class AsynConn:
             try:
                 host_port = parseHostPort(uri, cls.defaultport)
             except (ValueError, TypeError, AssertionError):
+                if 'COM' in uri:
+                    raise ValueError("the correct uri for a COM port is: "
+                                     "'serial://COM<i>[?<option>=<value>[+<option>=value ...]]'" )
+                if '/dev' in uri:
+                    raise ValueError("the correct uri for a serial port is: "
+                                     "'serial:///dev/<tty>[?<option>=<value>[+<option>=value ...]]'" )
                 raise ValueError('invalid uri: %s' % uri)
             iocls = cls.SCHEME_MAP['tcp']
             uri = 'tcp://%s:%d' % host_port
         return object.__new__(iocls)
 
-    def __init__(self, *args):
+    def __init__(self, uri, end_of_line=b'\n'):
+        self.end_of_line = end_of_line
         self._rxbuffer = b''
 
     def __del__(self):
@@ -84,33 +95,40 @@ class AsynConn:
         """
         raise NotImplementedError
 
+    def flush_recv(self):
+        """flush all available bytes (return them)"""
+        raise NotImplementedError
+
     def readline(self, timeout=None):
         """read one line
 
-        return either a complete line or None in case of timeout
-        the timeout argument may increase, but not decrease the default timeout
+        return either a complete line or None if no data available within 1 sec (self.timeout)
+        if a non-zero timeout is given, a timeout error is raised instead of returning None
+        the timeout effectively used will not be lower than self.timeout (1 sec)
         """
         if timeout:
             end = time.time() + timeout
-        while b'\n' not in self._rxbuffer:
+        while True:
+            splitted = self._rxbuffer.split(self.end_of_line, 1)
+            if len(splitted) == 2:
+                line, self._rxbuffer = splitted
+                return line
             data = self.recv()
             if not data:
                 if timeout:
                     if time.time() < end:
                         continue
-                    raise TimeoutError('timeout in readline')
+                    raise TimeoutError('timeout in readline (%g sec)' % timeout)
                 return None
             self._rxbuffer += data
-        line, self._rxbuffer = self._rxbuffer.split(b'\n', 1)
-        return line
 
     def writeline(self, line):
-        self.send(line + b'\n')
+        self.send(line + self.end_of_line)
 
 
 class AsynTcp(AsynConn):
-    def __init__(self, uri):
-        super().__init__()
+    def __init__(self, uri, *args, **kwargs):
+        super().__init__(uri, *args, **kwargs)
         self.uri = uri
         if uri.startswith('tcp://'):
             # should be the case always
@@ -126,6 +144,13 @@ class AsynTcp(AsynConn):
         """send data (bytes!)"""
         self.connection.sendall(data)
 
+    def flush_recv(self):
+        """flush recv buffer"""
+        data = []
+        while select.select([self.connection], [], [], 0)[0]:
+            data.append(self.recv())
+        return b''.join(data)
+
     def recv(self):
         """return bytes received within 1 sec"""
         try:
@@ -138,3 +163,80 @@ class AsynTcp(AsynConn):
         raise ConnectionClosed()  # marks end of connection
 
 AsynTcp.register_scheme('tcp')
+
+
+class AsynSerial(AsynConn):
+    """a serial connection using pyserial
+
+    uri syntax:
+    serial://<path>?[<option>=<value>[+<option>=<value> ...]]
+
+    options (defaults, other examples):
+
+    baudrate=9600  # 4800, 115200
+    bytesize=8     # 5,6,7
+    parity=none    # even, odd, mark, space
+    stopbits=1     # 1.5, 2
+    xonxoff=False  # True
+
+    and others (see documentation of serial.Serial)
+    """
+    PARITY_NAMES = {name[0]: name for name in ['NONE', 'ODD', 'EVEN', 'MASK', 'SPACE']}
+
+    def __init__(self, uri, *args, **kwargs):
+        super().__init__(uri, *args, **kwargs)
+        self.uri = uri
+        if uri.startswith('serial://'):
+            # should be the case always
+            uri = uri[9:]
+        uri = uri.split('?', 1)
+        dev = uri[0]
+        try:
+            options = dict((kv.split('=') for kv in uri[1].split('+')))
+        except IndexError:  # no uri[1], no options
+            options = {}
+        except ValueError:
+            raise ConfigError('illegal serial options')
+        parity = options.pop('parity', None)  # only parity is to be treated as text
+        for k, v in options.items():
+            try:
+                options[k] = ast.literal_eval(v.title())  # title(): turn false/true into False/True
+            except ValueError:
+                pass
+        if parity is not None:
+            name = parity.upper()
+            fullname = self.PARITY_NAMES[name[0]]
+            if not fullname.startswith(name):
+                raise ConfigError('illegal parity: %s' % parity)
+            options['parity'] = name[0]
+        if 'timeout' not in options:
+            options['timeout'] = self.timeout
+        try:
+            self.connection = Serial(dev, **options)
+        except ValueError as e:
+            raise ConfigError(e)
+
+    def disconnect(self):
+        if self.connection:
+            self.connection.close()
+        self.connection = None
+
+    def send(self, data):
+        """send data (bytes!)"""
+        self.connection.write(data)
+
+    def flush_recv(self):
+        return self.connection.read(self.connection.in_waiting)
+
+    def recv(self):
+        """return bytes received within 1 sec"""
+        if not self.connection:  # disconnect() might have been called in between
+            raise ConnectionClosed()
+        n = self.connection.in_waiting
+        if n:
+            return self.connection.read(n)
+        data = self.connection.read(1)
+        return data + self.connection.read(self.connection.in_waiting)
+
+
+AsynSerial.register_scheme('serial')
diff --git a/secop/stringio.py b/secop/stringio.py
index b535a79..adcc67b 100644
--- a/secop/stringio.py
+++ b/secop/stringio.py
@@ -24,9 +24,9 @@ implements TCP/IP and is be used as a base for SerialIO
 """
 
 import time
-import socket
 import threading
 import re
+from secop.lib.asynconn import AsynConn, ConnectionClosed
 from secop.modules import Module, Communicator, Parameter, Command, Property, Attached
 from secop.datatypes import StringType, FloatRange, ArrayOf, BoolType, TupleOf
 from secop.errors import CommunicationFailedError, CommunicationSilentError
@@ -34,14 +34,9 @@ from secop.poller import REGULAR
 from secop.metaclass import Done
 
 
-
 class StringIO(Communicator):
     """line oriented communicator
 
-    implementation for TCP/IP streams.
-    other types have to override the following methods:
-    createConnection, readWithTimeout, writeBytes, closeConnection
-
     self healing is assured by polling the parameter 'is_connected'
     """
     properties = {
@@ -76,82 +71,35 @@ class StringIO(Communicator):
     _reconnectCallbacks = None
 
     def earlyInit(self):
-        self._stream = None
+        self._conn = None
         self._lock = threading.RLock()
         self._end_of_line = self.end_of_line.encode(self.encoding)
         self._connect_error = None
         self._last_error = None
 
-    def createConnection(self):
-        """create connection
-
-        in case of success, self.is_connected MUST be set to True by implementors
-        """
-        uri = self.uri
-        if uri.startswith('tcp://'):
-            uri = uri[6:]
-        try:
-            host, port = uri.split(':')
-            self._stream = socket.create_connection((host, int(port)), 10)
-            self.is_connected = True
-        except (ConnectionRefusedError, socket.gaierror) as e:
-            raise CommunicationFailedError(str(e))
-        except Exception as e:
-            # this is really bad, do not try again
-            self._connect_error = e
-            raise
-
-    def readWithTimeout(self, timeout):
-        """read with timeout
-
-        Read bytes available now, or wait at most the specified timeout until some bytes
-        are available. Throw an error, if disconnected.
-        If no bytes are available, return b''
-
-        to be overwritten for other stream types
-        """
-        if timeout is None or timeout < 0:
-            raise ValueError('illegal timeout %r' % timeout)
+    def connectStart(self):
         if not self.is_connected:
-            raise CommunicationSilentError(self._last_error or 'not connected')
-        self._stream.settimeout(timeout)
-        try:
-            reply = self._stream.recv(4096)
-            if reply:
-                return reply
-        except (BlockingIOError, socket.timeout):
-            return b''
-        except Exception as e:
-            self.closeConnection()
-            raise CommunicationFailedError('disconnected because of %s' % e)
-        # other end disconnected
-        self.closeConnection()
-        raise CommunicationFailedError('other end disconnected')
-
-    def writeBytes(self, data):
-        """write bytes
-
-        to be overwritten for other stream types
-        """
-        self._stream.sendall(data)
-
+            uri = self.uri
+            try:
+                self._conn = AsynConn(uri, self._end_of_line)
+                self.is_connected = True
+            except Exception as e:
+                # this is really bad, do not try again
+                self._connect_error = e
+                raise
+            for command, regexp in self.identification:
+                reply = self.do_communicate(command)
+                if not re.match(regexp, reply):
+                    self.closeConnection()
+                    raise CommunicationFailedError('bad response: %s does not match %s' %
+                                                   (reply, regexp))
     def closeConnection(self):
         """close connection
 
         self.is_connected MUST be set to False by implementors
         """
-        if not self._stream:
-            return
-        self.log.debug('disconnect %s' % self.uri)
-        try:
-            self._stream.shutdown(socket.SHUT_RDWR)
-        except socket.error:
-            pass
-        try:
-            self._stream.close()
-        except socket.error:
-            pass
-        self._stream = None
+        self._conn.disconnect()
+        self._conn = None
         self.is_connected = False
 
     def read_is_connected(self):
@@ -185,16 +133,6 @@ class StringIO(Communicator):
             return False
         return self.read_is_connected()
 
-    def connectStart(self):
-        if not self.is_connected:
-            self.createConnection()
-            for command, regexp in self.identification:
-                reply = self.do_communicate(command)
-                if not re.match(regexp, reply):
-                    self.closeConnection()
-                    raise CommunicationFailedError('bad response: %s does not match %s' %
-                                                   (reply, regexp))
-
     def registerReconnectCallback(self, name, func):
         """register reconnect callback
 
@@ -236,25 +174,15 @@ class StringIO(Communicator):
                     if self.wait_before:
                         time.sleep(self.wait_before)
                     if garbage is None:  # read garbage only once
-                        garbage = b''
-                        data = self.readWithTimeout(0)
-                        while data:
-                            garbage += data
-                            data = self.readWithTimeout(0)
+                        garbage = self._conn.flush_recv()
                         if garbage:
                             self.log.debug('garbage: %s', garbage.decode(self.encoding))
-                    self.writeBytes((cmd + self.end_of_line).encode(self.encoding))
-                timeout = self.timeout
-                buffer = b''
-                data = True
-                while data:
-                    data = self.readWithTimeout(timeout)
-                    buffer += data
-                    if self._end_of_line in buffer:
-                        break
-                else:
-                    raise CommunicationFailedError('timeout')
-                reply = buffer.split(self._end_of_line, 1)[0].decode(self.encoding)
+                    self._conn.send((cmd + self.end_of_line).encode(self.encoding))
+                try:
+                    reply = self._conn.readline(self.timeout)
+                except ConnectionClosed:
+                    raise CommunicationFailedError('disconnected')
+                reply = reply.decode(self.encoding)
                 self.log.debug('recv: %s', reply)
                 return reply
         except Exception as e: