linse/frappy
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

show first instead of last traceback on multiple errors

Browse Source 
on initialization, the error message are collected and
shown before starting the server together with the traceback
of the last error. This should be the traceback of the
first error instead.

Change-Id: I86d4b42f7d4f98f2ab3b692cd6548e62acffa11b
Reviewed-on: https://forge.frm2.tum.de/review/c/sine2020/secop/playground/+/27011
Tested-by: Jenkins Automated Tests <pedersen+jenkins@frm2.tum.de>
Reviewed-by: Enrico Faulhaber <enrico.faulhaber@frm2.tum.de>
Reviewed-by: Markus Zolliker <markus.zolliker@psi.ch>
This commit is contained in:
zolliker 2021-11-02 15:18:42 +01:00
parent 3140d454ae
commit 41489a4a24
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
secop/server.py
View File

@ -228,7 +228,7 @@ class Server:
if opts: if opts:
errors.append(self.unknown_options(cls, opts)) errors.append(self.unknown_options(cls, opts))
self.modules = OrderedDict() self.modules = OrderedDict()
failure_traceback = None # traceback for the last error failure_traceback = None # traceback for the first error
failed = set() # python modules failed to load failed = set() # python modules failed to load
self.lastError = None self.lastError = None
for modname, options in self.module_cfg.items(): for modname, options in self.module_cfg.items():
@ -245,7 +245,8 @@ class Server:
errors.append('%s not found' % classname) errors.append('%s not found' % classname)
else: else:
failed.add(pymodule) failed.add(pymodule)
failure_traceback = traceback.format_exc() if failure_traceback is None:
failure_traceback = traceback.format_exc()
errors.append('error importing %s' % classname) errors.append('error importing %s' % classname)
else: else:
try: try:
@ -259,7 +260,8 @@ class Server:
for errtxt in e.args[0] if isinstance(e.args[0], list) else [e.args[0]]: for errtxt in e.args[0] if isinstance(e.args[0], list) else [e.args[0]]:
errors.append(' ' + errtxt) errors.append(' ' + errtxt)
except Exception: except Exception:
failure_traceback = traceback.format_exc() if failure_traceback is None:
failure_traceback = traceback.format_exc()
errors.append('error creating %s' % modname) errors.append('error creating %s' % modname)
poll_table = dict() poll_table = dict()
@ -288,7 +290,8 @@ class Server:
try: try:
modobj.initModule() modobj.initModule()
except Exception as e: except Exception as e:
failure_traceback = traceback.format_exc() if failure_traceback is None:
failure_traceback = traceback.format_exc()
errors.append('error initializing %s: %r' % (modname, e)) errors.append('error initializing %s: %r' % (modname, e))
if errors: if errors: