From 3d3558ccd831885b08b6a1c0c961f0c6122f0cef Mon Sep 17 00:00:00 2001 From: Enrico Faulhaber Date: Mon, 18 Sep 2017 14:10:21 +0200 Subject: [PATCH] make StringType default maximum size = 255 Bytes Change-Id: I0c26fc24ad99ff4185ff5a0b9b8ada9a10817b8b Reviewed-on: https://forge.frm2.tum.de/review/16269 Tested-by: JenkinsCodeReview Reviewed-by: Enrico Faulhaber --- secop/datatypes.py | 2 +- test/test_datatypes.py | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/secop/datatypes.py b/secop/datatypes.py index 3f76544..885ccd2 100644 --- a/secop/datatypes.py +++ b/secop/datatypes.py @@ -260,7 +260,7 @@ class StringType(DataType): minsize = None maxsize = None - def __init__(self, maxsize=None, minsize=0): + def __init__(self, maxsize=255, minsize=0): if maxsize is None: raise ValueError('StringType needs a maximum bytes count!') minsize, maxsize = min(minsize, maxsize), max(minsize, maxsize) diff --git a/test/test_datatypes.py b/test/test_datatypes.py index 8b39adc..b8c9143 100644 --- a/test/test_datatypes.py +++ b/test/test_datatypes.py @@ -145,8 +145,7 @@ def test_BLOBType(): def test_StringType(): # test constructor catching illegal arguments - with pytest.raises(ValueError): - dt = StringType() + dt = StringType() dt = StringType(12) assert dt.as_json == ['string', 12]