fix overriding Parameter with value
a property declared in a base class may be overriden with a parameter in a subclass. this is already allowed. if then, in the subsubclass it is overridden by a bare value, it fails. Patchset 1: add a test for this Patchset 4: add the fix Change-Id: Ia5a26076a9ee98439932643a03878342d56f8396 Reviewed-on: https://forge.frm2.tum.de/review/c/secop/frappy/+/35932 Reviewed-by: Markus Zolliker <markus.zolliker@psi.ch> Tested-by: Jenkins Automated Tests <pedersen+jenkins@frm2.tum.de>
This commit is contained in:
@ -131,14 +131,16 @@ class HasProperties(HasDescriptors):
|
||||
properties = {}
|
||||
# using cls.__bases__ and base.propertyDict for this would fail on some multiple inheritance cases
|
||||
for base in reversed(cls.__mro__):
|
||||
properties.update({k: v for k, v in base.__dict__.items() if isinstance(v, Property)})
|
||||
for key, value in base.__dict__.items():
|
||||
if isinstance(value, Property):
|
||||
properties[key] = value
|
||||
elif isinstance(value, HasProperties): # value is a Parameter. allow to override
|
||||
properties.pop(key, None)
|
||||
cls.propertyDict = properties
|
||||
# treat overriding properties with bare values
|
||||
for pn, po in list(properties.items()):
|
||||
value = getattr(cls, pn, po)
|
||||
if isinstance(value, HasProperties): # value is a Parameter, allow override
|
||||
properties.pop(pn)
|
||||
elif not isinstance(value, Property): # attribute may be a bare value
|
||||
if not isinstance(value, Property): # attribute may be a bare value
|
||||
po = po.copy()
|
||||
try:
|
||||
# try to apply bare value to Property
|
||||
|
Reference in New Issue
Block a user