linse/frappy
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

core: do not call register_module on error

Browse Source 
Dispatcher.get_module_instance returns None on failure.
If that is the case, the dispatcher should not try to register the
None value as a module.

Change-Id: Ie33b8debc2a829d480d56cafc1eb0ab610181d67
Reviewed-on: https://forge.frm2.tum.de/review/c/secop/frappy/+/31713
Reviewed-by: Enrico Faulhaber <enrico.faulhaber@frm2.tum.de>
Reviewed-by: Alexander Zaft <a.zaft@fz-juelich.de>
Tested-by: Jenkins Automated Tests <pedersen+jenkins@frm2.tum.de>
This commit is contained in:
Alexander Zaft 2023-07-19 15:35:02 +02:00 committed by Markus Zolliker
parent 0bc8accaaa
commit 267acf644c
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
frappy/protocol/dispatcher.py
View File

@ -239,8 +239,9 @@ class Dispatcher:
self.traceback_counter += 1 self.traceback_counter += 1
self.errors.append(f'error creating {modulename}') self.errors.append(f'error creating {modulename}')
modobj = None modobj = None
self.register_module(modobj, modulename, modobj.export) if modobj:
self.srv.modules[modulename] = modobj # IS HERE THE CORRECT PLACE? self.register_module(modobj, modulename, modobj.export)
self.srv.modules[modulename] = modobj # IS HERE THE CORRECT PLACE?
return modobj return modobj
def remove_module(self, modulename_or_obj): def remove_module(self, modulename_or_obj):