From 10d2d1645387baec5097e04a245d0953134ee79a Mon Sep 17 00:00:00 2001
From: Alexander Zaft <a.zaft@fz-juelich.de>
Date: Wed, 22 Mar 2023 15:32:58 +0100
Subject: [PATCH] gui: full module description only in detailed mode

* take only the first line of the description, this makes the normal
  view more condensed if it is formatted like a git commit message or
  similar

Change-Id: I268dce0aa09d3ad5133815fe33577532bf0a2e96
Reviewed-on: https://forge.frm2.tum.de/review/c/secop/frappy/+/30749
Tested-by: Jenkins Automated Tests <pedersen+jenkins@frm2.tum.de>
Reviewed-by: Alexander Zaft <a.zaft@fz-juelich.de>
---
 frappy/gui/modulewidget.py    | 11 +++++++++--
 frappy/gui/ui/modulewidget.ui |  4 ++--
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/frappy/gui/modulewidget.py b/frappy/gui/modulewidget.py
index 5731a7a..cf092c1 100644
--- a/frappy/gui/modulewidget.py
+++ b/frappy/gui/modulewidget.py
@@ -226,8 +226,10 @@ class ModuleWidget(QWidget):
     def _initModuleInfo(self):
         props = dict(self._node.getModuleProperties(self._name))
         self.moduleName.setText(self._name)
-        self.moduleDescription.setText(props.pop('description',
-                                                 'no description provided'))
+        self._moduleDescription = props.pop('description',
+                                            'no description provided')
+        text = self._moduleDescription.split('\n', 1)[0]
+        self.moduleDescription.setText(text)
 
         self.groupInfo.setText(props.pop('group', '-'))
         feats = ','.join(props.pop('features', [])) or '-'
@@ -401,6 +403,11 @@ class ModuleWidget(QWidget):
                 self._setParamHidden(param, True)
 
     def showDetails(self, show):
+        if show:
+            self.moduleDescription.setText(self._moduleDescription)
+        else:
+            text = self._moduleDescription.split('\n', 1)[0]
+            self.moduleDescription.setText(text)
         self.infoGrid.setHidden(not show)
         for param in self.independentParams:
             if param in ['value', 'status', 'target']:
diff --git a/frappy/gui/ui/modulewidget.ui b/frappy/gui/ui/modulewidget.ui
index c41ddad..8334829 100644
--- a/frappy/gui/ui/modulewidget.ui
+++ b/frappy/gui/ui/modulewidget.ui
@@ -21,7 +21,7 @@
     <number>6</number>
    </property>
    <item>
-    <layout class="QHBoxLayout" name="horizontalLayout" stretch="1,1,10,0,0">
+    <layout class="QHBoxLayout" name="horizontalLayout" stretch="1,0,10,0,0">
      <item>
       <widget class="AnimatedLabel" name="moduleName">
        <property name="font">
@@ -46,7 +46,7 @@
        </property>
        <property name="sizeHint" stdset="0">
         <size>
-         <width>40</width>
+         <width>20</width>
          <height>20</height>
         </size>
        </property>