From dbf7864e7e66c5b1797f847705443a02193c45c0 Mon Sep 17 00:00:00 2001 From: GotthardG <51994228+GotthardG@users.noreply.github.com> Date: Tue, 17 Dec 2024 16:16:54 +0100 Subject: [PATCH] Refactor OpenAPI fetcher for improved clarity and robustness Reorganized and enhanced the OpenAPI fetch logic for better maintainability and error handling. Key updates include improved environment variable validation, more detailed error messages, streamlined configuration loading, and additional safety checks for file paths and directories. Added proper logging and ensured the process flow is easy to trace. --- backend/app/data/data.py | 10 +++++----- backend/app/database.py | 2 ++ 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/backend/app/data/data.py b/backend/app/data/data.py index 3174e80..86da61c 100644 --- a/backend/app/data/data.py +++ b/backend/app/data/data.py @@ -234,11 +234,11 @@ dewars = [ # Define proposals proposals = [ - Proposal(id=1, number="PROPOSAL-FRODO-001"), - Proposal(id=2, number="PROPOSAL-GANDALF-002"), - Proposal(id=3, number="PROPOSAL-ARAGORN-003"), - Proposal(id=4, number="PROPOSAL-SAURON-004"), - Proposal(id=5, number="PROPOSAL-MORDOR-005"), + Proposal(id=1, number="p20000"), + Proposal(id=2, number="p20001"), + Proposal(id=3, number="p20002"), + Proposal(id=4, number="p20003"), + Proposal(id=5, number="p20004"), ] # Define shipment specific dewars diff --git a/backend/app/database.py b/backend/app/database.py index aba08a5..2d026cc 100644 --- a/backend/app/database.py +++ b/backend/app/database.py @@ -46,9 +46,11 @@ def get_db(): # Load only slots (minimal data) def load_slots_data(session: Session): from .data import slots + from .data import proposals if not session.query(models.Slot).first(): # Load only if no slots exist session.add_all(slots) + session.add_all(proposals) session.commit()