Refactor dewar and sample handling; improve grid data binding

Updated Dewar and Sample schemas, added nested relationships, and adjusted API responses for better data handling. Simplified puck normalization, enhanced data grid logic in the frontend, and implemented a PUT endpoint for updating samples. Incremented backend version to 0.1.0a15 and added new HTTP request example.
This commit is contained in:
GotthardG
2025-01-09 13:01:52 +01:00
parent ae20d6112a
commit 9bfcc30981
7 changed files with 188 additions and 124 deletions

View File

@ -17,7 +17,12 @@ from app.schemas import (
DewarTypeCreate,
DewarSerialNumber as DewarSerialNumberSchema,
DewarSerialNumberCreate,
Shipment as ShipmentSchema, # Clearer name for schema
Shipment as ShipmentSchema,
Dewar,
SampleUpdate,
Sample,
Puck,
SampleEventResponse, # Clearer name for schema
)
from app.models import (
Dewar as DewarModel,
@ -308,41 +313,86 @@ async def download_dewar_label(dewar_id: int, db: Session = Depends(get_db)):
)
@router.get("/dewars/{dewar_id}/samples", response_model=dict)
@router.get("/dewars/{dewar_id}/samples", response_model=Dewar)
async def get_dewar_samples(dewar_id: int, db: Session = Depends(get_db)):
# Fetch Dewar, associated Pucks, and Samples
# Fetch the Dewar with nested relationships
dewar = db.query(DewarModel).filter(DewarModel.id == dewar_id).first()
if not dewar:
raise HTTPException(status_code=404, detail="Dewar not found")
pucks = db.query(PuckModel).filter(PuckModel.dewar_id == dewar.id).all()
data = {"dewar": {"id": dewar.id, "dewar_name": dewar.dewar_name}, "pucks": []}
for puck in pucks:
samples = db.query(SampleModel).filter(SampleModel.puck_id == puck.id).all()
data["pucks"].append(
{
"id": puck.id,
"name": puck.puck_name,
"type": puck.puck_type,
"samples": [
{
"id": sample.id,
"position": sample.position,
"dewar_name": dewar.dewar_name,
"sample_name": sample.sample_name,
"priority": sample.priority,
"comments": sample.comments,
"proteinname": sample.proteinname,
**(sample.data_collection_parameters or {}),
}
for sample in samples
# Explicitly map nested relationships
dewar_data = {
"id": dewar.id,
"dewar_name": dewar.dewar_name,
"tracking_number": dewar.tracking_number,
"status": dewar.status,
"number_of_pucks": len(dewar.pucks), # Calculate number of pucks
"number_of_samples": sum(
len(puck.samples) for puck in dewar.pucks
), # Calculate total samples
"ready_date": dewar.ready_date,
"shipping_date": dewar.shipping_date,
"arrival_date": dewar.arrival_date,
"returning_date": dewar.returning_date,
"contact_person_id": dewar.contact_person.id if dewar.contact_person else None,
"return_address_id": dewar.return_address.id if dewar.return_address else None,
"shipment_id": dewar.shipment_id,
"contact_person": dewar.contact_person,
"return_address": dewar.return_address,
"pucks": [
Puck(
id=puck.id,
puck_name=puck.puck_name,
puck_type=puck.puck_type,
puck_location_in_dewar=puck.puck_location_in_dewar,
dewar_id=dewar.id,
samples=[
Sample(
id=sample.id,
sample_name=sample.sample_name,
position=sample.position,
puck_id=sample.puck_id,
crystalname=getattr(sample, "crystalname", None),
proteinname=getattr(sample, "proteinname", None),
positioninpuck=getattr(sample, "positioninpuck", None),
priority=sample.priority,
comments=sample.comments,
data_collection_parameters=sample.data_collection_parameters,
events=[
SampleEventResponse.from_orm(event)
for event in sample.events
],
)
for sample in puck.samples
],
}
)
)
for puck in dewar.pucks
],
}
return data
# Return the Pydantic Dewar model
return Dewar(**dewar_data)
@router.put("/samples/{sample_id}", response_model=Sample)
async def update_sample(
sample_id: int,
sample_update: SampleUpdate,
db: Session = Depends(get_db),
):
sample = db.query(SampleModel).filter(SampleModel.id == sample_id).first()
if not sample:
raise HTTPException(status_code=404, detail="Sample not found")
# Apply updates
for key, value in sample_update.dict(exclude_unset=True).items():
if hasattr(sample, key):
setattr(sample, key, value)
# Save changes
db.commit()
db.refresh(sample)
return Sample.from_orm(sample)
@router.get("/", response_model=List[DewarSchema])