Set gist visibility via Git push options (#215)

internal/hooks/hook.go

@@ -0,0 +1,24 @@
+package hooks
+
+import (
+	"fmt"
+	"os"
+	"strconv"
+	"strings"
+)
+
+const BaseHash = "0000000000000000000000000000000000000000"
+
+func pushOptions() map[string]string {
+	opts := make(map[string]string)
+	if pushCount, err := strconv.Atoi(os.Getenv("GIT_PUSH_OPTION_COUNT")); err == nil {
+		for i := 0; i < pushCount; i++ {
+			opt := os.Getenv(fmt.Sprintf("GIT_PUSH_OPTION_%d", i))
+			kv := strings.SplitN(opt, "=", 2)
+			if len(kv) == 2 {
+				opts[kv[0]] = kv[1]
+			}
+		}
+	}
+	return opts
+}

internal/hooks/post-receive.go

@@ -1,43 +0,0 @@
-package hooks
-
-import (
-	"bufio"
-	"fmt"
-	"io"
-	"os"
-	"os/exec"
-	"strings"
-)
-
-func PostReceive(in io.Reader, out, er io.Writer) error {
-	scanner := bufio.NewScanner(in)
-	for scanner.Scan() {
-		line := scanner.Text()
-		parts := strings.Fields(line)
-		if len(parts) != 3 {
-			_, _ = fmt.Fprintln(er, "Invalid input")
-			return fmt.Errorf("invalid input")
-		}
-		oldrev, _, refname := parts[0], parts[1], parts[2]
-
-		if err := verifyHEAD(); err != nil {
-			setSymbolicRef(refname)
-		}
-
-		if oldrev == BaseHash {
-			_, _ = fmt.Fprintf(out, "\nYour new repository has been created here: %s\n\n", os.Getenv("OPENGIST_REPOSITORY_URL_INTERNAL"))
-			_, _ = fmt.Fprintln(out, "If you want to keep working with your gist, you could set the remote URL via:")
-			_, _ = fmt.Fprintf(out, "git remote set-url origin %s\n\n", os.Getenv("OPENGIST_REPOSITORY_URL_INTERNAL"))
-		}
-	}
-
-	return nil
-}
-
-func verifyHEAD() error {
-	return exec.Command("git", "rev-parse", "--verify", "--quiet", "HEAD").Run()
-}
-
-func setSymbolicRef(refname string) {
-	_ = exec.Command("git", "symbolic-ref", "HEAD", refname).Run()
-}

internal/hooks/post_receive.go

@@ -0,0 +1,77 @@
+package hooks
+
+import (
+	"bufio"
+	"fmt"
+	"github.com/thomiceli/opengist/internal/db"
+	"github.com/thomiceli/opengist/internal/git"
+	"io"
+	"os"
+	"os/exec"
+	"slices"
+	"strings"
+)
+
+func PostReceive(in io.Reader, out, er io.Writer) error {
+	opts := pushOptions()
+	scanner := bufio.NewScanner(in)
+	for scanner.Scan() {
+		line := scanner.Text()
+		parts := strings.Fields(line)
+		if len(parts) != 3 {
+			_, _ = fmt.Fprintln(er, "Invalid input")
+			return fmt.Errorf("invalid input")
+		}
+		oldrev, _, refname := parts[0], parts[1], parts[2]
+
+		if err := verifyHEAD(); err != nil {
+			setSymbolicRef(refname)
+		}
+
+		if oldrev == BaseHash {
+			_, _ = fmt.Fprintf(out, "\nYour new repository has been created here: %s\n\n", os.Getenv("OPENGIST_REPOSITORY_URL_INTERNAL"))
+			_, _ = fmt.Fprintln(out, "If you want to keep working with your gist, you could set the remote URL via:")
+			_, _ = fmt.Fprintf(out, "git remote set-url origin %s\n\n", os.Getenv("OPENGIST_REPOSITORY_URL_INTERNAL"))
+		}
+	}
+
+	gist, err := db.GetGistByID(os.Getenv("OPENGIST_REPOSITORY_ID"))
+	if err != nil {
+		_, _ = fmt.Fprintln(er, "Failed to get gist")
+		return fmt.Errorf("failed to get gist: %w", err)
+	}
+
+	if slices.Contains([]string{"public", "unlisted", "private"}, opts["visibility"]) {
+		gist.Private, _ = db.ParseVisibility(opts["visibility"])
+		_, _ = fmt.Fprintf(out, "\nGist visibility set to %s\n\n", opts["visibility"])
+	}
+
+	if hasNoCommits, err := git.HasNoCommits(gist.User.Username, gist.Uuid); err != nil {
+		_, _ = fmt.Fprintln(er, "Failed to check if gist has no commits")
+		return fmt.Errorf("failed to check if gist has no commits: %w", err)
+	} else if hasNoCommits {
+		if err = gist.Delete(); err != nil {
+			_, _ = fmt.Fprintln(er, "Failed to delete gist")
+			return fmt.Errorf("failed to delete gist: %w", err)
+		}
+	}
+
+	_ = gist.SetLastActiveNow()
+	err = gist.UpdatePreviewAndCount(true)
+	if err != nil {
+		_, _ = fmt.Fprintln(er, "Failed to update gist")
+		return fmt.Errorf("failed to update gist: %w", err)
+	}
+
+	gist.AddInIndex()
+
+	return nil
+}
+
+func verifyHEAD() error {
+	return exec.Command("git", "rev-parse", "--verify", "--quiet", "HEAD").Run()
+}
+
+func setSymbolicRef(refname string) {
+	_ = exec.Command("git", "symbolic-ref", "HEAD", refname).Run()
+}

internal/hooks/pre_receive.go

@@ -9,8 +9,6 @@ import (
 	"strings"
 )
 
-const BaseHash = "0000000000000000000000000000000000000000"
-
 func PreReceive(in io.Reader, out, er io.Writer) error {
 	var err error
 	var disallowedFiles []string

internal/hooks/pre_receive_test.go

@@ -0,0 +1,54 @@
+package hooks
+
+import (
+	"bytes"
+	"fmt"
+	"github.com/stretchr/testify/require"
+	"github.com/thomiceli/opengist/internal/git"
+	"os"
+	"testing"
+)
+
+func TestPreReceiveHook(t *testing.T) {
+	git.SetupTest(t)
+	defer git.TeardownTest(t)
+	var lastCommitHash string
+	err := os.Chdir(git.RepositoryPath("thomas", "gist1"))
+	require.NoError(t, err, "Could not change directory")
+
+	git.CommitToBare(t, "thomas", "gist1", map[string]string{
+		"my_file.txt":  "some allowed file",
+		"my_file2.txt": "some allowed file\nagain",
+	})
+	lastCommitHash = git.LastHashOfCommit(t, "thomas", "gist1")
+	err = PreReceive(bytes.NewBufferString(fmt.Sprintf("%s %s %s", BaseHash, lastCommitHash, "refs/heads/master")), os.Stdout, os.Stderr)
+	require.NoError(t, err, "Should not have an error on pre-receive hook for commit+push 1")
+
+	git.CommitToBare(t, "thomas", "gist1", map[string]string{
+		"my_file.txt":     "some allowed file",
+		"dir/my_file.txt": "some disallowed file suddenly",
+	})
+	lastCommitHash = git.LastHashOfCommit(t, "thomas", "gist1")
+	err = PreReceive(bytes.NewBufferString(fmt.Sprintf("%s %s %s", BaseHash, lastCommitHash, "refs/heads/master")), os.Stdout, os.Stderr)
+	require.Error(t, err, "Should have an error on pre-receive hook for commit+push 2")
+	require.Equal(t, "pushing files in directories is not allowed: [dir/my_file.txt]", err.Error(), "Error message is not correct")
+
+	git.CommitToBare(t, "thomas", "gist1", map[string]string{
+		"my_file.txt":           "some allowed file",
+		"dir/ok/afileagain.txt": "some disallowed file\nagain",
+	})
+	lastCommitHash = git.LastHashOfCommit(t, "thomas", "gist1")
+	err = PreReceive(bytes.NewBufferString(fmt.Sprintf("%s %s %s", BaseHash, lastCommitHash, "refs/heads/master")), os.Stdout, os.Stderr)
+	require.Error(t, err, "Should have an error on pre-receive hook for commit+push 3")
+	require.Equal(t, "pushing files in directories is not allowed: [dir/ok/afileagain.txt dir/my_file.txt]", err.Error(), "Error message is not correct")
+
+	git.CommitToBare(t, "thomas", "gist1", map[string]string{
+		"allowedfile.txt": "some allowed file only",
+	})
+	lastCommitHash = git.LastHashOfCommit(t, "thomas", "gist1")
+	err = PreReceive(bytes.NewBufferString(fmt.Sprintf("%s %s %s", BaseHash, lastCommitHash, "refs/heads/master")), os.Stdout, os.Stderr)
+	require.Error(t, err, "Should have an error on pre-receive hook for commit+push 4")
+	require.Equal(t, "pushing files in directories is not allowed: [dir/ok/afileagain.txt dir/my_file.txt]", err.Error(), "Error message is not correct")
+
+	_ = os.Chdir(os.TempDir()) // Leave the current dir to avoid errors on teardown
+}