Added private visibility

* Changed gist type and added HTML button on creation

* Adapted label and edit button

* Changed rules for git HTTP and SSH

* Adapt Readme features

internal/web/gist.go

@@ -80,7 +80,7 @@ func gistInit(next echo.HandlerFunc) echo.HandlerFunc {
 			setData(ctx, "hasLiked", hasLiked)
 		}
 
-		if gist.Private {
+		if gist.Private > 0 {
 			setData(ctx, "NoIndex", true)
 		}
 
@@ -88,6 +88,22 @@ func gistInit(next echo.HandlerFunc) echo.HandlerFunc {
 	}
 }
 
+// gistSoftInit try to load a gist (same as gistInit) but does not return a 404 if the gist is not found
+// useful for git clients using HTTP to obfuscate the existence of a private gist
+func gistSoftInit(next echo.HandlerFunc) echo.HandlerFunc {
+	return func(ctx echo.Context) error {
+		userName := ctx.Param("user")
+		gistName := ctx.Param("gistname")
+
+		gistName = strings.TrimSuffix(gistName, ".git")
+
+		gist, _ := models.GetGist(userName, gistName)
+		setData(ctx, "gist", gist)
+
+		return next(ctx)
+	}
+}
+
 func allGists(ctx echo.Context) error {
 	var err error
 	var urlPage string
@@ -400,7 +416,7 @@ func processCreate(ctx echo.Context) error {
 func toggleVisibility(ctx echo.Context) error {
 	var gist = getData(ctx, "gist").(*models.Gist)
 
-	gist.Private = !gist.Private
+	gist.Private = (gist.Private + 1) % 3
 	if err := gist.Update(); err != nil {
 		return errorRes(500, "Error updating this gist", err)
 	}

internal/web/git_http.go

@@ -47,16 +47,23 @@ func gitHttp(ctx echo.Context) error {
 
 			gist := getData(ctx, "gist").(*models.Gist)
 
+			// Shows basic auth if :
+			// - user wants to push the gist
+			// - user wants to clone a private gist
+			// - gist is not found (obfuscation)
+			// - admin setting to require login is set to true
 			noAuth := (ctx.QueryParam("service") == "git-upload-pack" ||
 				strings.HasSuffix(ctx.Request().URL.Path, "git-upload-pack") ||
 				ctx.Request().Method == "GET") &&
+				gist.Private != 2 &&
+				gist.ID != 0 &&
 				!getData(ctx, "RequireLogin").(bool)
 
 			repositoryPath := git.RepositoryPath(gist.User.Username, gist.Uuid)
 
 			if _, err := os.Stat(repositoryPath); os.IsNotExist(err) {
 				if err != nil {
-					return errorRes(500, "Repository does not exist", err)
+					return errorRes(404, "Repository directory does not exist", err)
 				}
 			}
 
@@ -82,12 +89,16 @@ func gitHttp(ctx echo.Context) error {
 				return basicAuth(ctx)
 			}
 
+			if gist.ID == 0 {
+				return errorRes(404, "Not found", nil)
+			}
+
 			if ok, err := argon2id.verify(authPassword, gist.User.Password); !ok || gist.User.Username != authUsername {
 				if err != nil {
 					return errorRes(500, "Cannot verify password", err)
 				}
 				log.Warn().Msg("Invalid HTTP authentication attempt from " + ctx.RealIP())
-				return errorRes(403, "Unauthorized", nil)
+				return errorRes(404, "Not found", nil)
 			}
 
 			return route.handler(ctx)

internal/web/run.go

@@ -30,11 +30,11 @@ var re = regexp.MustCompile("[^a-z0-9]+")
 var fm = template.FuncMap{
 	"split":     strings.Split,
 	"indexByte": strings.IndexByte,
-	"toInt": func(i string) int64 {
-		val, _ := strconv.ParseInt(i, 10, 64)
+	"toInt": func(i string) int {
+		val, _ := strconv.Atoi(i)
 		return val
 	},
-	"inc": func(i int64) int64 {
+	"inc": func(i int) int {
 		return i + 1
 	},
 	"splitGit": func(i string) []string {
@@ -88,6 +88,20 @@ var fm = template.FuncMap{
 		return config.C.ExternalUrl + "/" + manifestEntries[jsfile].File
 	},
 	"defaultAvatar": defaultAvatar,
+	"visibilityStr": func(visibility int, lowercase bool) string {
+		s := "Public"
+		switch visibility {
+		case 1:
+			s = "Unlisted"
+		case 2:
+			s = "Private"
+		}
+
+		if lowercase {
+			return strings.ToLower(s)
+		}
+		return s
+	},
 }
 
 var EmbedFS fs.FS
@@ -226,7 +240,7 @@ func Start() {
 	debugStr := ""
 	// Git HTTP routes
 	if config.C.HttpGit {
-		e.Any("/:user/:gistname/*", gitHttp, gistInit)
+		e.Any("/:user/:gistname/*", gitHttp, gistSoftInit)
 		debugStr = " (with Git over HTTP)"
 	}