chore: remove tracing codes

This commit is contained in:
Jason Song
2022-10-20 15:29:23 +08:00
parent 41b5fa6b55
commit 2f879c41c4
3 changed files with 17 additions and 47 deletions

View File

@ -12,8 +12,6 @@ import (
"github.com/avast/retry-go/v4"
"github.com/bufbuild/connect-go"
"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
log "github.com/sirupsen/logrus"
"google.golang.org/protobuf/proto"
"google.golang.org/protobuf/types/known/timestamppb"
@ -61,9 +59,7 @@ func (r *Reporter) Fire(entry *log.Entry) error {
timestamp := entry.Time
if r.state.StartedAt == nil {
r.updateState(func() {
r.state.StartedAt = timestamppb.New(timestamp)
})
r.state.StartedAt = timestamppb.New(timestamp)
}
var step *runnerv1.StepState
@ -76,15 +72,13 @@ func (r *Reporter) Fire(entry *log.Entry) error {
if step == nil {
if v, ok := entry.Data["jobResult"]; ok {
if jobResult, ok := r.parseResult(v); ok {
r.updateState(func() {
r.state.Result = jobResult
r.state.StoppedAt = timestamppb.New(timestamp)
for _, s := range r.state.Steps {
if s.Result == runnerv1.Result_RESULT_UNSPECIFIED {
s.Result = runnerv1.Result_RESULT_CANCELLED
}
r.state.Result = jobResult
r.state.StoppedAt = timestamppb.New(timestamp)
for _, s := range r.state.Steps {
if s.Result == runnerv1.Result_RESULT_UNSPECIFIED {
s.Result = runnerv1.Result_RESULT_CANCELLED
}
})
}
}
}
if !r.duringSteps() {
@ -94,19 +88,15 @@ func (r *Reporter) Fire(entry *log.Entry) error {
}
if step.StartedAt == nil {
r.updateState(func() {
step.StartedAt = timestamppb.New(timestamp)
})
step.StartedAt = timestamppb.New(timestamp)
}
if v, ok := entry.Data["raw_output"]; ok {
if rawOutput, ok := v.(bool); ok && rawOutput {
r.updateState(func() {
if step.LogLength == 0 {
step.LogIndex = int64(r.logOffset + len(r.logRows))
}
step.LogLength++
})
if step.LogLength == 0 {
step.LogIndex = int64(r.logOffset + len(r.logRows))
}
step.LogLength++
r.logRows = append(r.logRows, r.parseLogRow(entry))
return nil
}
@ -114,13 +104,11 @@ func (r *Reporter) Fire(entry *log.Entry) error {
if v, ok := entry.Data["stepResult"]; ok {
if stepResult, ok := r.parseResult(v); ok {
r.updateState(func() {
if step.LogLength == 0 {
step.LogIndex = int64(r.logOffset + len(r.logRows))
}
step.Result = stepResult
step.StoppedAt = timestamppb.New(timestamp)
})
if step.LogLength == 0 {
step.LogIndex = int64(r.logOffset + len(r.logRows))
}
step.Result = stepResult
step.StoppedAt = timestamppb.New(timestamp)
}
}
@ -274,19 +262,3 @@ func (r *Reporter) parseLogRow(entry *log.Entry) *runnerv1.LogRow {
Content: strings.TrimSuffix(entry.Message, "\r\n"),
}
}
func (r *Reporter) updateState(update func()) {
if log.GetLevel() < log.TraceLevel {
update()
return
}
before := proto.Clone(r.state)
update()
diff := cmp.Diff(before, r.state, cmpopts.IgnoreUnexported(
runnerv1.TaskState{},
runnerv1.StepState{},
timestamppb.Timestamp{},
))
log.Tracef("update state %d: %s", r.state.Id, diff)
}