From b8d204e35c88bb78fb7609a9cf56e0570ad436b9 Mon Sep 17 00:00:00 2001 From: Michael Davidsaver Date: Fri, 18 Dec 2020 14:04:36 -0800 Subject: [PATCH] proto bug: client search requests incorrectly set Server direction --- documentation/releasenotes.rst | 3 +++ src/client.cpp | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/documentation/releasenotes.rst b/documentation/releasenotes.rst index c24612f..695ccb7 100644 --- a/documentation/releasenotes.rst +++ b/documentation/releasenotes.rst @@ -10,6 +10,9 @@ Pre-production release series. * 0.1.1 (UNRELEASED) + * Client search requests incorrectly set Server direction bit. + (existing servers don't enforce this) + * 0.1.0 (Dec 2020) * Initial Release diff --git a/src/client.cpp b/src/client.cpp index 1efe179..6e4c511 100644 --- a/src/client.cpp +++ b/src/client.cpp @@ -697,7 +697,7 @@ void Context::Pvt::tickSearch() auto consumed = M.save() - searchMsg.data(); { FixedBuf H(true, searchMsg.data(), 8); - to_wire(H, Header{CMD_SEARCH, pva_flags::Server, uint32_t(consumed-8u)}); + to_wire(H, Header{CMD_SEARCH, 0, uint32_t(consumed-8u)}); } for(auto& pair : searchDest) { *pflags = pair.second ? 0x80 : 0x00;