a little bit of cleanup and minor opt

2018-02-05 16:02:44 -08:00
parent 4cca194000
commit 786575c3de
2 changed files with 13 additions and 14 deletions
--- a/src/factory/FieldCreateFactory.cpp
+++ b/src/factory/FieldCreateFactory.cpp
@@ -460,11 +460,10 @@ string Structure::getID() const
 }

 FieldConstPtr  Structure::getField(string const & fieldName) const {
-    size_t numberFields = fields.size();
-    for(size_t i=0; i<numberFields; i++) {
-        FieldConstPtr pfield = fields[i];
-        int result = fieldName.compare(fieldNames[i]);
-        if(result==0) return pfield;
+    for(size_t i=0, N=fields.size(); i<N; i++) {
+        if(fieldName==fieldNames[i]) {
+            return fields[i];
+        }
    }
    return FieldConstPtr();
 }