From d59346261348735b1f5381c41ca40117df38b2a2 Mon Sep 17 00:00:00 2001
From: Michael Davidsaver <mdavidsaver@gmail.com>
Date: Wed, 1 May 2019 14:15:58 -0700
Subject: [PATCH] yet more osdGetRoles

---
 src/utils/getgroups.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/utils/getgroups.cpp b/src/utils/getgroups.cpp
index 721cb58..6d81dba 100644
--- a/src/utils/getgroups.cpp
+++ b/src/utils/getgroups.cpp
@@ -82,12 +82,12 @@ void osdGetRoles(const std::string& account, PeerInfo::roles_t& roles)
             int gcount = int(gtemp.size());
             int ret = getgrouplist(user->pw_name, user->pw_gid, &gtemp[0], &gcount);
 
-            if(ret!=-1 && gcount>=0 && gcount <= int(gtemp.size())) {
+            if(ret>=0 && gcount>=0 && gcount <= int(gtemp.size())) {
                 // success
                 gtemp.resize(gcount);
                 break;
 
-            } else if(ret!=-1) {
+            } else if(ret>=0) {
                 // success, but invalid count?  give up
                 gtemp.clear();
                 break;