epics/pvAccess
0
0
Fork 0
Code Issues Pull Requests Projects Wiki Activity

Remove dead code

Browse Source 
aliveNotification() and unresponsiveTransport() never called.
Remove these, and code only referenced through these methods.
This commit is contained in:
Michael Davidsaver
2019-05-20 22:29:01 -07:00
parent c9bd214f7c
commit a6e7d7f5fc
8 changed files with 0 additions and 123 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
src/remote/codec.cpp
View File

@@ -1697,7 +1697,6 @@ BlockingClientTCPTransportCodec::BlockingClientTCPTransportCodec(
BlockingTCPTransportCodec(false, context, channel, responseHandler,
sendBufferSize, receiveBufferSize, priority),
_connectionTimeout(heartbeatInterval),
_unresponsiveTransport(false),
_verifyOrEcho(true),
sendQueued(true) // don't start sending echo until after auth complete
{
@@ -1746,22 +1745,6 @@ void BlockingClientTCPTransportCodec::callback()
catch (std::exception &e) { LOG(logLevelError, "Unhandled exception caught from code at %s:%d: %s", __FILE__, __LINE__, e.what()); } \
catch (...) { LOG(logLevelError, "Unhandled exception caught from code at %s:%d.", __FILE__, __LINE__); }
void BlockingClientTCPTransportCodec::unresponsiveTransport() {
Lock lock(_mutex);
if(!_unresponsiveTransport) {
_unresponsiveTransport = true;
TransportClientMap_t::iterator it = _owners.begin();
for(; it!=_owners.end(); it++) {
ClientChannelImpl::shared_pointer client = it->second.lock();
if (client)
{
EXCEPTION_GUARD(client->transportUnresponsive());
}
}
}
}
bool BlockingClientTCPTransportCodec::acquire(ClientChannelImpl::shared_pointer const & client) {
Lock lock(_mutex);
if(isClosed()) return false;
@@ -1835,42 +1818,8 @@ void BlockingClientTCPTransportCodec::release(pvAccessID clientID) {
}
}
void BlockingClientTCPTransportCodec::aliveNotification() {
// TODO: dead code
Lock guard(_mutex);
//epicsTimeGetCurrent(&_aliveTimestamp);
if(_unresponsiveTransport) responsiveTransport();
}
void BlockingClientTCPTransportCodec::responsiveTransport() {
Lock lock(_mutex);
if(_unresponsiveTransport) {
_unresponsiveTransport = false;
Transport::shared_pointer thisSharedPtr = shared_from_this();
TransportClientMap_t::iterator it = _owners.begin();
for(; it!=_owners.end(); it++) {
ClientChannelImpl::shared_pointer client = it->second.lock();
if (client)
{
EXCEPTION_GUARD(client->transportResponsive(thisSharedPtr));
}
}
}
}
void BlockingClientTCPTransportCodec::changedTransport() {
_outgoingIR.reset();
Lock lock(_mutex);
TransportClientMap_t::iterator it = _owners.begin();
for(; it!=_owners.end(); it++) {
ClientChannelImpl::shared_pointer client = it->second.lock();
if (client)
{
EXCEPTION_GUARD(client->transportChanged());
}
}
}
void BlockingClientTCPTransportCodec::send(ByteBuffer* buffer,