From 6f39f02f3ae745c5681ef1cd47ebc934d8e187e6 Mon Sep 17 00:00:00 2001 From: Michael Davidsaver Date: Thu, 16 Nov 2017 14:56:48 -0600 Subject: [PATCH] more client locking violations As with #72 more use of m_pendingRequest w/o locking --- src/remoteClient/clientContextImpl.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/remoteClient/clientContextImpl.cpp b/src/remoteClient/clientContextImpl.cpp index da79f38..271a75c 100644 --- a/src/remoteClient/clientContextImpl.cpp +++ b/src/remoteClient/clientContextImpl.cpp @@ -470,7 +470,7 @@ public: control->startMessage((int8)CMD_PROCESS, 9); buffer->putInt(m_channel->getServerChannelID()); buffer->putInt(m_ioid); - buffer->putByte((int8)m_pendingRequest); + buffer->putByte((int8)pendingRequest); if (pendingRequest & QOS_INIT) { @@ -609,7 +609,7 @@ public: control->startMessage((int8)CMD_GET, 9); buffer->putInt(m_channel->getServerChannelID()); buffer->putInt(m_ioid); - buffer->putByte((int8)m_pendingRequest); + buffer->putByte((int8)pendingRequest); if (initStage) { @@ -797,7 +797,7 @@ public: control->startMessage((int8)CMD_PUT, 9); buffer->putInt(m_channel->getServerChannelID()); buffer->putInt(m_ioid); - buffer->putByte((int8)m_pendingRequest); + buffer->putByte((int8)pendingRequest); if (pendingRequest & QOS_INIT) { @@ -1346,8 +1346,8 @@ public: control->startMessage((int8)CMD_RPC, 9); buffer->putInt(m_channel->getServerChannelID()); buffer->putInt(m_ioid); - if ((m_pendingRequest & QOS_INIT) == 0) - buffer->putByte((int8)m_pendingRequest); + if ((pendingRequest & QOS_INIT) == 0) + buffer->putByte((int8)pendingRequest); if (pendingRequest & QOS_INIT) { @@ -1535,7 +1535,7 @@ public: control->startMessage((int8)CMD_ARRAY, 9); buffer->putInt(m_channel->getServerChannelID()); buffer->putInt(m_ioid); - buffer->putByte((int8)m_pendingRequest); + buffer->putByte((int8)pendingRequest); if (pendingRequest & QOS_INIT) {