privatize some API details

hide a number of APIs which should not
be public APIs.

src/server/Makefile

@@ -3,10 +3,7 @@
 SRC_DIRS += $(PVACCESS_SRC)/server
 
 INC += pv/serverContext.h
-INC += pv/responseHandlers.h
 INC += pv/serverChannelImpl.h
-INC += pv/baseChannelRequester.h
-INC += pv/beaconEmitter.h
 INC += pv/beaconServerStatusProvider.h
 
 LIBSRCS += responseHandlers.cpp

src/server/pv/serverContext.h

@@ -7,15 +7,13 @@
 #ifndef SERVERCONTEXT_H_
 #define SERVERCONTEXT_H_
 
-#include <pv/remote.h>
+#include <epicsTime.h>
+
+#include <pv/pvaDefs.h>
 #include <pv/beaconServerStatusProvider.h>
 #include <pv/pvaConstants.h>
 #include <pv/pvaVersion.h>
 #include <pv/pvAccess.h>
-#include <pv/blockingUDP.h>
-#include <pv/blockingTCP.h>
-#include <pv/beaconEmitter.h>
-#include <pv/logger.h>
 
 #include <shareLib.h>
 

src/server/pv/serverContextImpl.h

@@ -1,6 +1,10 @@
 #ifndef SERVERCONTEXTIMPL_H
 #define SERVERCONTEXTIMPL_H
 
+#include <pv/blockingUDP.h>
+#include <pv/blockingTCP.h>
+#include <pv/beaconEmitter.h>
+
 #include "serverContext.h"
 
 namespace epics {

src/server/responseHandlers.cpp

@@ -39,7 +39,7 @@
 #include <pv/logger.h>
 #include <pv/pvAccessMB.h>
 #include <pv/rpcServer.h>
-#include <pv/security.h>
+#include <pv/securityImpl.h>
 
 using std::string;
 using std::ostringstream;

src/server/serverContext.cpp

@@ -653,7 +653,7 @@ ServerContext::shared_pointer startPVAServer(std::string const & providerNames,
 
     if (runInSeparateThread)
     {
-        // delete left to the thread
+        // delete left to the thread (which doesn't)
         auto_ptr<ThreadRunnerParam> param(new ThreadRunnerParam());
         param->ctx = ctx;
         param->timeToRun = timeToRun;
@@ -665,6 +665,7 @@ ServerContext::shared_pointer startPVAServer(std::string const & providerNames,
                           threadRunner, param.get());
 
         param.release();
+        // leak...
     }
     else
     {