From 8069d9d80b87313bd334d5a1f392eac3d09b1796 Mon Sep 17 00:00:00 2001 From: Andrew Johnson Date: Tue, 28 Feb 2017 20:55:05 -0600 Subject: [PATCH] dbUnitTest: Improve output slightly --- src/ioc/db/dbUnitTest.c | 18 +++++++++--------- src/libCom/error/makeStatTbl.pl | 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/ioc/db/dbUnitTest.c b/src/ioc/db/dbUnitTest.c index f4994c854..35264abdd 100644 --- a/src/ioc/db/dbUnitTest.c +++ b/src/ioc/db/dbUnitTest.c @@ -106,8 +106,8 @@ long testdbVPutField(const char* pv, short dbrType, va_list ap) DBADDR addr; union anybuf pod; - if(dbNameToAddr(pv, &addr)) { - testFail("Missing PV %s", pv); + if (dbNameToAddr(pv, &addr)) { + testFail("Missing PV \"%s\"", pv); return S_dbLib_recNotFound; } @@ -152,7 +152,7 @@ void testdbPutFieldOk(const char* pv, short dbrType, ...) ret = testdbVPutField(pv, dbrType, ap); va_end(ap); - testOk(ret==0, "dbPutField(%s, %d, ...) -> %ld (%s)", pv, dbrType, ret, errSymMsg(ret)); + testOk(ret==0, "dbPutField(\"%s\", %d, ...) -> %#lx (%s)", pv, dbrType, ret, errSymMsg(ret)); } void testdbPutFieldFail(long status, const char* pv, short dbrType, ...) @@ -164,7 +164,7 @@ void testdbPutFieldFail(long status, const char* pv, short dbrType, ...) ret = testdbVPutField(pv, dbrType, ap); va_end(ap); - testOk(ret==status, "dbPutField(\"%s\", %d, ...) -> %ld (%s) == %ld (%s)", + testOk(ret==status, "dbPutField(\"%s\", %d, ...) -> %#lx (%s) == %#lx (%s)", pv, dbrType, status, errSymMsg(status), ret, errSymMsg(ret)); } @@ -185,13 +185,13 @@ void testdbVGetFieldEqual(const char* pv, short dbrType, va_list ap) long status; if(dbNameToAddr(pv, &addr)) { - testFail("Missing PV %s", pv); + testFail("Missing PV \"%s\"", pv); return; } status = dbGetField(&addr, dbrType, pod.bytes, NULL, &nReq, NULL); - if(status) { - testFail("dbGetField(\"%s\",%d,...) returns %ld", pv, dbrType, status); + if (status) { + testFail("dbGetField(\"%s\", %d, ...) -> %#lx (%s)", pv, dbrType, status, errSymMsg(status)); return; } @@ -224,8 +224,8 @@ dbCommon* testdbRecordPtr(const char* pv) { DBADDR addr; - if(dbNameToAddr(pv, &addr)) - testAbort("Missing record %s", pv); + if (dbNameToAddr(pv, &addr)) + testAbort("Missing record \"%s\"", pv); return addr.precord; } diff --git a/src/libCom/error/makeStatTbl.pl b/src/libCom/error/makeStatTbl.pl index 8bc63e23c..4f53901f3 100644 --- a/src/libCom/error/makeStatTbl.pl +++ b/src/libCom/error/makeStatTbl.pl @@ -86,7 +86,7 @@ foreach $line ( @err_sym_line ) { print OUT "$line\n"; # define S_symbol /* comment */ - if ($line =~ m'[ \t#]define[ \t]*(S_[A-Za-z0-9_]+).*\/\*(.+)\*\/') + if ($line =~ m'[ \t#]define[ \t]*(S_[A-Za-z0-9_]+).*\/\* ?(.+?) ?\*\/') { $symbol[$count] = $1; $comment[$count]= $2;