epics/pcas
0
0
Fork 0
Code Issues Pull Requests Projects Wiki Activity

fixed race condition in virtual circuit shutdown sequence

Browse Source
This commit is contained in:
Jeff Hill
2003-08-06 18:11:34 +00:00
parent ecc3206e11
commit 78b532ee75
1 changed files with 34 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
src/ca/cac.cpp
View File

@@ -1538,32 +1538,44 @@ void cac::initiateAbortShutdown ( tcpiiu & iiu )
void cac::destroyIIU ( tcpiiu & iiu )
{
epicsGuard < callbackMutex > cbGuard ( this->cbMutex );
epicsGuard < cacMutex > guard ( this->mutex );
if ( iiu.channelCount() ) {
char hostNameTmp[64];
iiu.hostName ( hostNameTmp, sizeof ( hostNameTmp ) );
genLocalExcep ( cbGuard, *this, ECA_DISCONN, hostNameTmp );
}
osiSockAddr addr = iiu.getNetworkAddress();
if ( addr.sa.sa_family == AF_INET ) {
inetAddrID tmp ( addr.ia );
bhe * pBHE = this->beaconTable.lookup ( tmp );
if ( pBHE ) {
pBHE->unregisterIIU ( iiu );
{
epicsGuard < callbackMutex > cbGuard ( this->cbMutex );
epicsGuard < cacMutex > guard ( this->mutex );
if ( iiu.channelCount() ) {
char hostNameTmp[64];
iiu.hostName ( hostNameTmp, sizeof ( hostNameTmp ) );
genLocalExcep ( cbGuard, *this, ECA_DISCONN, hostNameTmp );
}
osiSockAddr addr = iiu.getNetworkAddress();
if ( addr.sa.sa_family == AF_INET ) {
inetAddrID tmp ( addr.ia );
bhe * pBHE = this->beaconTable.lookup ( tmp );
if ( pBHE ) {
pBHE->unregisterIIU ( iiu );
}
}
assert ( this->pudpiiu );
iiu.removeAllChannels ( cbGuard, guard, *this );
}
assert ( this->pudpiiu );
iiu.removeAllChannels ( cbGuard, guard, *this );
this->serverTable.remove ( iiu );
this->serverList.remove ( iiu );
iiu.~tcpiiu ();
this->freeListVirtualCircuit.release ( & iiu );
{
// this lock synchronizes with a blocking loop
// in ~cac waiting until no circuits are installed.
// After the cac lock is released here we must not
// access any part of the cac (including the
// callback lock) because ~cac is allowed to
// complete.
epicsGuard < cacMutex > guard ( this->mutex );
// signal iiu uninstal event so that cac can properly shut down
this->iiuUninstall.signal();
this->serverTable.remove ( iiu );
this->serverList.remove ( iiu );
iiu.~tcpiiu ();
this->freeListVirtualCircuit.release ( & iiu );
// signal iiu uninstal event so that cac can properly shut down
this->iiuUninstall.signal();
}
}
double cac::beaconPeriod ( const nciu & chan ) const