From 63b059c35e4b95c2a50059f403d8709cf7742b40 Mon Sep 17 00:00:00 2001 From: Andrew Johnson Date: Wed, 7 Dec 2016 17:51:00 -0600 Subject: [PATCH] Resolve additional cppcheck issues; fix iOS build --- src/ioc/db/db_test.c | 1 + src/ioc/rsrv/camessage.c | 1 + src/libCom/iocsh/iocsh.cpp | 2 ++ src/libCom/test/epicsEventTest.cpp | 7 +++++++ src/libCom/test/epicsMutexTest.cpp | 6 ++++++ src/libCom/test/ringBytesTest.c | 4 ++++ 6 files changed, 21 insertions(+) diff --git a/src/ioc/db/db_test.c b/src/ioc/db/db_test.c index bc9ac32a8..8d7ad31b1 100644 --- a/src/ioc/db/db_test.c +++ b/src/ioc/db/db_test.c @@ -243,6 +243,7 @@ int tpn(const char *pname, const char *pvalue) ptpnInfo = calloc(1, sizeof(tpnInfo)); if (!ptpnInfo) { printf("calloc failed\n"); + free(ppn); dbChannelDelete(chan); return -1; } diff --git a/src/ioc/rsrv/camessage.c b/src/ioc/rsrv/camessage.c index 057731777..b13883b5a 100644 --- a/src/ioc/rsrv/camessage.c +++ b/src/ioc/rsrv/camessage.c @@ -26,6 +26,7 @@ #include "epicsEvent.h" #include "epicsMutex.h" #include "epicsStdio.h" +#include "epicsString.h" #include "epicsThread.h" #include "epicsTime.h" #include "errlog.h" diff --git a/src/libCom/iocsh/iocsh.cpp b/src/libCom/iocsh/iocsh.cpp index d8701532e..21253bbc9 100644 --- a/src/libCom/iocsh/iocsh.cpp +++ b/src/libCom/iocsh/iocsh.cpp @@ -559,6 +559,7 @@ iocshBody (const char *pathname, const char *commandLine, const char *macros) if (macros) { if (macParseDefns(NULL, macros, &defines) < 0) { + free(redirects); return -1; } } @@ -571,6 +572,7 @@ iocshBody (const char *pathname, const char *commandLine, const char *macros) if (handle == NULL) { if (macCreateHandle(&handle, pairs)) { errlogMessage("iocsh: macCreateHandle failed."); + free(redirects); return -1; } diff --git a/src/libCom/test/epicsEventTest.cpp b/src/libCom/test/epicsEventTest.cpp index b0d79613f..7c1a24141 100644 --- a/src/libCom/test/epicsEventTest.cpp +++ b/src/libCom/test/epicsEventTest.cpp @@ -250,5 +250,12 @@ MAIN(epicsEventTest) eventWaitTest(); eventWakeupTest(); + free(name); + free(id); + epicsRingPointerDelete(pinfo->ring); + epicsMutexDestroy(pinfo->lockRing); + epicsEventDestroy(event); + free(pinfo); + return testDone(); } diff --git a/src/libCom/test/epicsMutexTest.cpp b/src/libCom/test/epicsMutexTest.cpp index 87cf0a460..d44e5c0f1 100644 --- a/src/libCom/test/epicsMutexTest.cpp +++ b/src/libCom/test/epicsMutexTest.cpp @@ -279,5 +279,11 @@ MAIN(epicsMutexTest) epicsMutexPerformance (); + free(pinfo); + free(arg); + free(name); + free(id); + epicsMutexDestroy(mutex); + return testDone(); } diff --git a/src/libCom/test/ringBytesTest.c b/src/libCom/test/ringBytesTest.c index ecfd991be..6cef93334 100644 --- a/src/libCom/test/ringBytesTest.c +++ b/src/libCom/test/ringBytesTest.c @@ -115,5 +115,9 @@ MAIN(ringBytesTest) testOk(n==1, "ring get %d", 1); check(ring, RINGSIZE); + epicsRingBytesDelete(ring); + epicsEventDestroy(consumerEvent); + free(pinfo); + return testDone(); }