Sang Woo Kim
ef06b34ee4
get_precision() walks pvalue and plvalue over the A-L and LA-LL fields, then compares paddr->pfield against &pvalue and &plvalue -- the addresses of the two local pointer variables, not of the fields they point at. Those are stack addresses, so neither test has ever matched and every A-L or LA-LL precision request falls through to recGblGetPrec(). The line just above gets it right: prec->val is a field and needs the &, whereas pvalue and plvalue are already pointers. Both tests date frome87551df24, the commit that added the loop, and have been dead ever since, so every release since R3.12 has this. They carried a (void *) cast until6d85a36397removed it, which is why the compiler was never shown a double ** to complain about. That the fields were meant to be covered is not in doubt: this record's get_graphic_double() and get_control_double() both name A-L and LA-LL. This changes what those fields report. recGblGetPrec() substitutes 15 for a DOUBLE precision outside 0 to 15, so today A-L and LA-LL answer 15 for a PREC of 17 while VAL answers 17. They now answer PREC unclamped, which is what VAL has always done. Add selTest, reading the precision of VAL, A, L, LA, LL and HIHI from a record with PREC=17. The four A-L and LA-LL cases report 15 before this fix; VAL and HIHI pin the two paths either side of them.
69 lines
1.7 KiB
C
69 lines
1.7 KiB
C
/*************************************************************************\
|
|
* SPDX-License-Identifier: EPICS
|
|
* EPICS BASE is distributed subject to a Software License Agreement found
|
|
* in file LICENSE that is included with this distribution.
|
|
\*************************************************************************/
|
|
|
|
#include "dbUnitTest.h"
|
|
#include "testMain.h"
|
|
#include "errlog.h"
|
|
#include "dbAccess.h"
|
|
|
|
void recTestIoc_registerRecordDeviceDriver(struct dbBase *);
|
|
|
|
static
|
|
void testPrecEqual(const char *pv, long expected){
|
|
DBADDR addr;
|
|
struct {
|
|
DBRprecision
|
|
epicsFloat64 value;
|
|
} buf;
|
|
long options = DBR_PRECISION;
|
|
long nRequest = 1;
|
|
|
|
if (dbNameToAddr(pv, &addr) ||
|
|
dbGetField(&addr, DBR_DOUBLE, &buf, &options, &nRequest, NULL)) {
|
|
testFail("Can't read the precision of %s", pv);
|
|
return;
|
|
}
|
|
testOk(buf.precision.dp == expected, "%s precision (%ld) == %ld",
|
|
pv, buf.precision.dp, expected);
|
|
}
|
|
|
|
/*
|
|
* PREC gives the precision of VAL and of the A-L and LA-LL fields.
|
|
* The remaining DOUBLE fields get theirs from recGblGetPrec(), which
|
|
* substitutes 15 for a PREC outside the range it can print.
|
|
* */
|
|
static
|
|
void testSelPrecision(void){
|
|
testPrecEqual("sel0.VAL", 17);
|
|
testPrecEqual("sel0.A", 17);
|
|
testPrecEqual("sel0.L", 17);
|
|
testPrecEqual("sel0.LA", 17);
|
|
testPrecEqual("sel0.LL", 17);
|
|
testPrecEqual("sel0.HIHI", 15);
|
|
}
|
|
|
|
MAIN(selTest) {
|
|
testPlan(6);
|
|
|
|
testdbPrepare();
|
|
|
|
testdbReadDatabase("recTestIoc.dbd", NULL, NULL);
|
|
recTestIoc_registerRecordDeviceDriver(pdbbase);
|
|
|
|
testdbReadDatabase("selTest.db", NULL, NULL);
|
|
|
|
eltc(0);
|
|
testIocInitOk();
|
|
eltc(1);
|
|
|
|
testSelPrecision();
|
|
|
|
testIocShutdownOk();
|
|
testdbCleanup();
|
|
|
|
return testDone();
|
|
}
|