From d3d40689c8c4ed4637d47e723e41a5d997500903 Mon Sep 17 00:00:00 2001 From: Ralph Lange Date: Tue, 9 Jun 2020 13:12:03 +0200 Subject: [PATCH] libcom/osi: fix dangerous usage of strncat (WIN32) (found by sonar/cppcheck) --- src/libCom/osi/os/WIN32/osdSock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libCom/osi/os/WIN32/osdSock.c b/src/libCom/osi/os/WIN32/osdSock.c index b8c8363fb..8b9869423 100644 --- a/src/libCom/osi/os/WIN32/osdSock.c +++ b/src/libCom/osi/os/WIN32/osdSock.c @@ -64,10 +64,10 @@ epicsShareFunc int epicsShareAPI osiSockAttach() DWORD titleLength = GetConsoleTitle(title, sizeof(title)); if (titleLength) { titleLength = strlen (title); - strncat (title, " " EPICS_VERSION_STRING, sizeof(title)); + strncat (title, " " EPICS_VERSION_STRING, sizeof(title)-1); } else { - strncpy(title, EPICS_VERSION_STRING, sizeof(title)); + strncpy(title, EPICS_VERSION_STRING, sizeof(title)-1); } title[sizeof(title)-1]= '\0'; SetConsoleTitle(title);