diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 27dd1ee..e1b69d1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -544,7 +544,7 @@ jobs: ./test/config.hcl targets: app env: - DOCKER_BUILD_NO_SUMMARY: true + DOCKER_BUILD_SUMMARY_DISABLE: true summary-not-supported: runs-on: ubuntu-latest diff --git a/README.md b/README.md index 669d9e3..a18e617 100644 --- a/README.md +++ b/README.md @@ -281,7 +281,7 @@ The following outputs are available | Name | Type | Description | |--------------------------------------|--------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| -| `DOCKER_BUILD_NO_SUMMARY` | Bool | If `true`, [build summary](https://docs.docker.com/build/ci/github-actions/build-summary/) generation is disabled | +| `DOCKER_BUILD_SUMMARY_DISABLE` | Bool | If `true`, [build summary](https://docs.docker.com/build/ci/github-actions/build-summary/) generation is disabled | | `DOCKER_BUILD_EXPORT_RETENTION_DAYS` | Number | Duration after which build export artifact will expire in days. Defaults to repository/org [retention settings](https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration#artifact-and-log-retention-policy) if unset or `0` | ## Contributing diff --git a/src/main.ts b/src/main.ts index 493deb4..5265192 100644 --- a/src/main.ts +++ b/src/main.ts @@ -164,7 +164,7 @@ actionsToolkit.run( }); await core.group(`Check build summary support`, async () => { - if (process.env.DOCKER_BUILD_NO_SUMMARY && Util.parseBool(process.env.DOCKER_BUILD_NO_SUMMARY)) { + if (buildSummaryDisabled()) { core.info('Build summary disabled'); } else if (GitHub.isGHES) { core.warning('Build summary is not yet supported on GHES'); @@ -244,6 +244,16 @@ async function buildRefs(toolkit: Toolkit, since: Date, builder?: string): Promi return refs; } +function buildSummaryDisabled(): boolean { + if (process.env.DOCKER_BUILD_NO_SUMMARY) { + core.warning('DOCKER_BUILD_NO_SUMMARY is deprecated. Use DOCKER_BUILD_SUMMARY_DISABLE instead.'); + return Util.parseBool(process.env.DOCKER_BUILD_NO_SUMMARY); + } else if (process.env.DOCKER_BUILD_SUMMARY_DISABLE) { + return Util.parseBool(process.env.DOCKER_BUILD_SUMMARY_DISABLE); + } + return false; +} + function buildExportRetentionDays(): number | undefined { if (process.env.DOCKER_BUILD_EXPORT_RETENTION_DAYS) { const res = parseInt(process.env.DOCKER_BUILD_EXPORT_RETENTION_DAYS);