Merge pull request #1347 from slsdetectorgroup/fix/self-assign

clang-tidy [unhandled-self-assignment]

.clang-tidy

@@ -29,7 +29,6 @@ Checks:          '*,
                     -llvmlibc-*'
 
 HeaderFilterRegex: \.h
-AnalyzeTemporaryDtors: false
 FormatStyle:     none
 CheckOptions:
   - { key: readability-identifier-naming.NamespaceCase,       value: lower_case }

RELEASE.txt

@@ -37,8 +37,6 @@ Experimental support for building the detector client (including python bindings
 
 ``rx_dbitlist`` keeps the order of the passed bit list 
 
-Marked unused functions readDataFile/writeDataFile deprecated in file_utils.h
-
 2  On-board Detector Server Compatibility
 ==========================================
 

slsSupportLib/include/sls/file_utils.h

@@ -16,7 +16,6 @@ namespace sls {
  * @param nch number of channels
  * @param offset start channel value
  */
-[[deprecated]]
 int readDataFile(std::ifstream &infile, short int *data, int nch,
                  int offset = 0);
 
@@ -24,7 +23,6 @@ int readDataFile(std::ifstream &infile, short int *data, int nch,
  * @param data array of data value
  * @param nch number of channels
  */
-[[deprecated]]
 int readDataFile(std::string fname, short int *data, int nch);
 
 std::vector<char> readBinaryFile(const std::string &fname,
@@ -35,7 +33,6 @@ std::vector<char> readBinaryFile(const std::string &fname,
  * @param data array of data values
  * @param offset start channel number
  */
-[[deprecated]]
 int writeDataFile(std::ofstream &outfile, int nch, short int *data,
                   int offset = 0);
 
@@ -43,7 +40,6 @@ int writeDataFile(std::ofstream &outfile, int nch, short int *data,
  * @param nch number of channels
  * @param data array of data values
  */
-[[deprecated]]
 int writeDataFile(std::string fname, int nch, short int *data);
 
 // mkdir -p path implemented by recursive calls

slsSupportLib/include/sls/sls_detector_defs.h

@@ -804,6 +804,8 @@ typedef struct {
     }
 
     sls_detector_module &operator=(const sls_detector_module &other) {
+        if(this == &other)
+            return *this;
         delete[] dacs;
         delete[] chanregs;
         serialnumber = other.serialnumber;