From fdebe53ab7f9da461be7b14d15c5542e6a7eea1b Mon Sep 17 00:00:00 2001 From: Dhanya Thattil Date: Tue, 24 Mar 2026 12:08:09 +0100 Subject: [PATCH] fix dac default names and test for dacs --- python/slsdet/dacs.py | 2 +- python/tests/test_det_api.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/python/slsdet/dacs.py b/python/slsdet/dacs.py index 547a43277..e92c74914 100755 --- a/python/slsdet/dacs.py +++ b/python/slsdet/dacs.py @@ -49,7 +49,7 @@ class NamedDacs: #only get the dacnames if we have modules attached if detector.size() == 0: - self._dacnames = [f"dac{i}" for i in range(18)] + self._dacnames = [f"DAC{i}" for i in range(18)] else: self._dacnames = [n.replace(" ", "") for n in detector.getDacNames()] diff --git a/python/tests/test_det_api.py b/python/tests/test_det_api.py index bd98ba65a..be4cfa6c5 100644 --- a/python/tests/test_det_api.py +++ b/python/tests/test_det_api.py @@ -626,8 +626,8 @@ def test_dac(session_simulator, request): prev_dac_list = c.daclist invalid_assignments = [ - (c.dacs, "vb_comp", 1200), # set random dac - (c.dacs, "DAC18", 1200), # set dac 18 + (c.dacs, "vb_comp", "1200"), # set random dac + (c.dacs, "DAC18", "1200"), # set dac 18 (c.dacs, "DAC0", "-1"), (c.dacs, "DAC0", "4096") ]