From f9d41f1d66f05e95a6ab356c7b7fe23d5ff26afb Mon Sep 17 00:00:00 2001
From: Dhanya Thattil <dhanya.thattil@psi.ch>
Date: Thu, 3 Jul 2025 10:58:44 +0200
Subject: [PATCH] to avoid confusion, moved default initialized, single sized
 declared vector of roi to be created at setDetectorType

---
 slsReceiverSoftware/src/Implementation.cpp | 4 +---
 slsReceiverSoftware/src/Implementation.h   | 4 ++--
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/slsReceiverSoftware/src/Implementation.cpp b/slsReceiverSoftware/src/Implementation.cpp
index 7c033f498..faf3bf031 100644
--- a/slsReceiverSoftware/src/Implementation.cpp
+++ b/slsReceiverSoftware/src/Implementation.cpp
@@ -156,9 +156,7 @@ void Implementation::setDetectorType(const detectorType d) {
     }
 
     // number of portrois should be equal to number of interfaces
-    if (d == EIGER) {
-        ResetRois();
-    }
+    ResetRois();
 
     SetLocalNetworkParameters();
     SetupFifoStructure();
diff --git a/slsReceiverSoftware/src/Implementation.h b/slsReceiverSoftware/src/Implementation.h
index 5764a8d09..31359930f 100644
--- a/slsReceiverSoftware/src/Implementation.h
+++ b/slsReceiverSoftware/src/Implementation.h
@@ -309,8 +309,8 @@ class Implementation : private virtual slsDetectorDefs {
     bool framePadding{true};
     pid_t parentThreadId;
     pid_t tcpThreadId;
-    std::vector<slsDetectorDefs::ROI> portRois{1};
-    std::vector<slsDetectorDefs::ROI> multiRoiMetadata{1};
+    std::vector<slsDetectorDefs::ROI> portRois;
+    std::vector<slsDetectorDefs::ROI> multiRoiMetadata;
 
     // file parameters
     fileFormat fileFormatType{BINARY};