diff --git a/CMakeLists.txt b/CMakeLists.txt index e2b4b1403..4db277142 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -137,8 +137,6 @@ sls_enable_cxx_warning("-Wnull-dereference") sls_enable_cxx_warning("-Wduplicated-cond") sls_disable_cxx_warning("-Wclass-memaccess") sls_disable_c_warning("-Wstringop-truncation") -sls_disable_c_warning("-Wformat-nonliteral") -sls_disable_c_warning("-Wformat-truncation") if(SLS_USE_SANITIZER) diff --git a/slsDetectorServers/ctbDetectorServer/bin/ctbDetectorServer_developer b/slsDetectorServers/ctbDetectorServer/bin/ctbDetectorServer_developer index ae38e8da4..bd4da43da 100755 Binary files a/slsDetectorServers/ctbDetectorServer/bin/ctbDetectorServer_developer and b/slsDetectorServers/ctbDetectorServer/bin/ctbDetectorServer_developer differ diff --git a/slsDetectorServers/eigerDetectorServer/bin/eigerDetectorServer_developer b/slsDetectorServers/eigerDetectorServer/bin/eigerDetectorServer_developer index 7d866e97b..5a167a967 100755 Binary files a/slsDetectorServers/eigerDetectorServer/bin/eigerDetectorServer_developer and b/slsDetectorServers/eigerDetectorServer/bin/eigerDetectorServer_developer differ diff --git a/slsDetectorServers/gotthard2DetectorServer/bin/gotthard2DetectorServer_developer b/slsDetectorServers/gotthard2DetectorServer/bin/gotthard2DetectorServer_developer index c7b0f8d14..35b3545c0 100755 Binary files a/slsDetectorServers/gotthard2DetectorServer/bin/gotthard2DetectorServer_developer and b/slsDetectorServers/gotthard2DetectorServer/bin/gotthard2DetectorServer_developer differ diff --git a/slsDetectorServers/gotthardDetectorServer/bin/gotthardDetectorServer_developer b/slsDetectorServers/gotthardDetectorServer/bin/gotthardDetectorServer_developer index 0dcbd56bd..004ff7e60 100755 Binary files a/slsDetectorServers/gotthardDetectorServer/bin/gotthardDetectorServer_developer and b/slsDetectorServers/gotthardDetectorServer/bin/gotthardDetectorServer_developer differ diff --git a/slsDetectorServers/jungfrauDetectorServer/bin/jungfrauDetectorServer_developer b/slsDetectorServers/jungfrauDetectorServer/bin/jungfrauDetectorServer_developer index 8b8b7f117..0b31a5ffb 100755 Binary files a/slsDetectorServers/jungfrauDetectorServer/bin/jungfrauDetectorServer_developer and b/slsDetectorServers/jungfrauDetectorServer/bin/jungfrauDetectorServer_developer differ diff --git a/slsDetectorServers/moenchDetectorServer/bin/moenchDetectorServer_developer b/slsDetectorServers/moenchDetectorServer/bin/moenchDetectorServer_developer index 77912233f..e936ffdbb 100755 Binary files a/slsDetectorServers/moenchDetectorServer/bin/moenchDetectorServer_developer and b/slsDetectorServers/moenchDetectorServer/bin/moenchDetectorServer_developer differ diff --git a/slsDetectorServers/mythen3DetectorServer/bin/mythen3DetectorServer_developer b/slsDetectorServers/mythen3DetectorServer/bin/mythen3DetectorServer_developer index beac4adcb..5f2bb2c8f 100755 Binary files a/slsDetectorServers/mythen3DetectorServer/bin/mythen3DetectorServer_developer and b/slsDetectorServers/mythen3DetectorServer/bin/mythen3DetectorServer_developer differ diff --git a/slsDetectorServers/slsDetectorServer/src/common.c b/slsDetectorServers/slsDetectorServer/src/common.c index dda73cd4a..0f72571c6 100644 --- a/slsDetectorServers/slsDetectorServer/src/common.c +++ b/slsDetectorServers/slsDetectorServer/src/common.c @@ -477,8 +477,9 @@ int setupDetectorServer(char *mess, char *sname) { LOG(logINFO, ("\tinittab: DetectoServer line deleted\n")); // add new link name to /etc/inittab - char *format = "echo 'ttyS0::respawn:/./%s' >> /etc/inittab"; - if (snprintf(cmd, MAX_STR_LENGTH, format, linkname) >= MAX_STR_LENGTH) { + if (snprintf(cmd, MAX_STR_LENGTH, + "echo 'ttyS0::respawn:/./%s' >> /etc/inittab", + linkname) >= MAX_STR_LENGTH) { strcpy(mess, "Could not copy detector server. Command " "to add new server for spawning is too long\n"); LOG(logERROR, (mess)); @@ -584,8 +585,8 @@ int moveBinaryFile(char *mess, char *dest, char *src, char *errorPrefix) { // one can move into the current process binary (will not interfere in // kernel mode) - char *format = "mv %s %s"; - if (snprintf(cmd, MAX_STR_LENGTH, format, src, dest) >= MAX_STR_LENGTH) { + if (snprintf(cmd, MAX_STR_LENGTH, "mv %s %s", src, dest) >= + MAX_STR_LENGTH) { sprintf(mess, "Could not %s. Command to move binary is too long\n", errorPrefix); LOG(logERROR, (mess)); diff --git a/slsDetectorServers/slsDetectorServer/src/programViaBlackfin.c b/slsDetectorServers/slsDetectorServer/src/programViaBlackfin.c index 7e8aba0e2..662de51e7 100644 --- a/slsDetectorServers/slsDetectorServer/src/programViaBlackfin.c +++ b/slsDetectorServers/slsDetectorServer/src/programViaBlackfin.c @@ -225,8 +225,7 @@ int emptyTempFolder(char *mess) { char cmd[MAX_STR_LENGTH] = {0}; char retvals[MAX_STR_LENGTH] = {0}; - char *format = "rm -fr %s"; - if (snprintf(cmd, MAX_STR_LENGTH, format, + if (snprintf(cmd, MAX_STR_LENGTH, "rm -fr %s", TEMP_PROG_FOLDER_NAME_ALL_FILES) >= MAX_STR_LENGTH) { sprintf(mess, "Could not update %s. Command to empty %s folder is too long\n", @@ -433,8 +432,7 @@ int eraseFlash(char *mess) { #endif char cmd[MAX_STR_LENGTH] = {0}; char retvals[MAX_STR_LENGTH] = {0}; - char *format = "flash_eraseall %s"; - if (snprintf(cmd, MAX_STR_LENGTH, format, flashDriveName) >= + if (snprintf(cmd, MAX_STR_LENGTH, "flash_eraseall %s", flashDriveName) >= MAX_STR_LENGTH) { sprintf(mess, "Could not %s. Command to erase flash is too long\n", messageType); diff --git a/slsDetectorServers/slsDetectorServer/src/programViaNios.c b/slsDetectorServers/slsDetectorServer/src/programViaNios.c index bcb8fabc6..c81598650 100644 --- a/slsDetectorServers/slsDetectorServer/src/programViaNios.c +++ b/slsDetectorServers/slsDetectorServer/src/programViaNios.c @@ -167,8 +167,7 @@ int eraseFlash(char *mess) { char cmd[MAX_STR_LENGTH] = {0}; char retvals[MAX_STR_LENGTH] = {0}; - char *format = "flash_erase %s 0 0"; - if (snprintf(cmd, MAX_STR_LENGTH, format, flashDriveName) >= + if (snprintf(cmd, MAX_STR_LENGTH, "flash_erase %s 0 0", flashDriveName) >= MAX_STR_LENGTH) { sprintf(mess, "Could not %s. Command to erase flash is too long\n", messageType); diff --git a/slsDetectorServers/slsDetectorServer/src/slsDetectorServer_funcs.c b/slsDetectorServers/slsDetectorServer/src/slsDetectorServer_funcs.c index b4980676c..da7b40c10 100644 --- a/slsDetectorServers/slsDetectorServer/src/slsDetectorServer_funcs.c +++ b/slsDetectorServers/slsDetectorServer/src/slsDetectorServer_funcs.c @@ -4144,9 +4144,8 @@ int copy_detector_server(int file_des) { char cmd[MAX_STR_LENGTH] = {0}; // tftp server - char *format = "tftp %s -r %s -g"; - if (snprintf(cmd, MAX_STR_LENGTH, format, hostname, sname) >= - MAX_STR_LENGTH) { + if (snprintf(cmd, MAX_STR_LENGTH, "tftp %s -r %s -g", hostname, + sname) >= MAX_STR_LENGTH) { ret = FAIL; strcpy(mess, "Could not copy detector server. Command to copy " "server too long\n"); @@ -9255,8 +9254,11 @@ int get_kernel_version(int file_des) { // get only ret = getKernelVersion(retvals); if (ret == FAIL) { - snprintf(mess, MAX_STR_LENGTH, "Could not get kernel version. %s\n", - retvals); + if (snprintf(mess, MAX_STR_LENGTH, "Could not get kernel version. %s\n", + retvals) >= MAX_STR_LENGTH) { + ret = FAIL; + strcpy(mess, "Could not get kernel version. Reason too long to copy\n"); + } LOG(logERROR, (mess)); } else { LOG(logDEBUG1, ("kernel version: [%s]\n", retvals)); diff --git a/slsSupportLib/include/sls/versionAPI.h b/slsSupportLib/include/sls/versionAPI.h index 274bd81f9..681ddae93 100644 --- a/slsSupportLib/include/sls/versionAPI.h +++ b/slsSupportLib/include/sls/versionAPI.h @@ -6,10 +6,10 @@ #define APILIB 0x211027 #define APIRECEIVER 0x211020 #define APIGUI 0x211021 -#define APICTB 0x211111 -#define APIGOTTHARD 0x211111 -#define APIGOTTHARD2 0x211111 -#define APIJUNGFRAU 0x211111 -#define APIMYTHEN3 0x211111 +#define APICTB 0x211117 +#define APIGOTTHARD 0x211117 +#define APIGOTTHARD2 0x211117 +#define APIJUNGFRAU 0x211117 +#define APIMYTHEN3 0x211117 #define APIMOENCH 0x211111 -#define APIEIGER 0x211111 +#define APIEIGER 0x211117