detectors/slsDetectorPackage
25
0
Fork 0
mirror of https://github.com/slsdetectorgroup/slsDetectorPackage.git synced 2025-06-13 05:17:13 +02:00
Code Issues Actions Packages Releases Activity

clang-tidy

Browse Source
This commit is contained in:
Erik Frojdh
2019-11-27 18:42:16 +01:00
parent d53082c615
commit f4cdd759b0
3 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
slsDetectorSoftware/include/Detector.h
View File

@ -406,7 +406,7 @@ class Detector {
Result<bool> getTenGiga(Positions pos = {}) const; Result<bool> getTenGiga(Positions pos = {}) const;
/** [Eiger][CTB] */ /** [Eiger][CTB] */
void setTenGiga(bool enable, Positions pos = {}); void setTenGiga(bool value, Positions pos = {});
/** [Eiger, Jungfrau] */ /** [Eiger, Jungfrau] */
Result<bool> getTenGigaFlowControl(Positions pos = {}) const; Result<bool> getTenGigaFlowControl(Positions pos = {}) const;
@ -525,7 +525,7 @@ class Detector {
Result<std::string> getFilePath(Positions pos = {}) const; Result<std::string> getFilePath(Positions pos = {}) const;
void setFilePath(const std::string &fname, Positions pos = {}); void setFilePath(const std::string &fpath, Positions pos = {});
Result<std::string> getFileNamePrefix(Positions pos = {}) const; Result<std::string> getFileNamePrefix(Positions pos = {}) const;
@ -755,7 +755,7 @@ class Detector {
/** [Eiger] Advanced /** [Eiger] Advanced
* used for pulsing chips */ * used for pulsing chips */
void setPartialReset(bool enable, Positions pos = {}); void setPartialReset(bool value, Positions pos = {});
/** [Eiger] Advanced /** [Eiger] Advanced
* Pulse Pixel n times at x and y coordinates */ * Pulse Pixel n times at x and y coordinates */

2
slsDetectorSoftware/src/CmdProxy.cpp
View File

@ -91,7 +91,7 @@ std::string CmdProxy::ListCommands(int action) {
if (args[0] == "deprecated") { if (args[0] == "deprecated") {
std::cout << "The following " << depreciated_functions.size() std::cout << "The following " << depreciated_functions.size()
<< " commands are deprecated\n"; << " commands are deprecated\n";
size_t field_width = 20; const size_t field_width = 20;
for (const auto &it : depreciated_functions) { for (const auto &it : depreciated_functions) {
std::cout << std::right << std::setw(field_width) << it.first std::cout << std::right << std::setw(field_width) << it.first
<< " -> " << it.second << '\n'; << " -> " << it.second << '\n';

18
slsDetectorSoftware/src/Detector.cpp
View File

@ -86,8 +86,8 @@ Result<std::string> Detector::getHostname(Positions pos) const {
return pimpl->Parallel(&slsDetector::getHostname, pos); return pimpl->Parallel(&slsDetector::getHostname, pos);
} }
void Detector::setHostname(const std::vector<std::string> &value) { void Detector::setHostname(const std::vector<std::string> &hostname) {
pimpl->setHostname(value); pimpl->setHostname(hostname);
} }
void Detector::setVirtualDetectorServers(int numServers, int startingPort) { void Detector::setVirtualDetectorServers(int numServers, int startingPort) {
@ -760,9 +760,9 @@ Result<bool> Detector::getRxZmqDataStream(Positions pos) const {
-1); -1);
} }
void Detector::setRxZmqDataStream(bool enable, Positions pos) { void Detector::setRxZmqDataStream(bool value, Positions pos) {
pimpl->Parallel(&slsDetector::enableDataStreamingFromReceiver, pos, pimpl->Parallel(&slsDetector::enableDataStreamingFromReceiver, pos,
static_cast<int>(enable)); static_cast<int>(value));
} }
Result<int> Detector::getRxZmqFrequency(Positions pos) const { Result<int> Detector::getRxZmqFrequency(Positions pos) const {
@ -887,8 +887,8 @@ void Detector::setSettingsPath(const std::string &value, Positions pos) {
pimpl->Parallel(&slsDetector::setSettingsDir, pos, value); pimpl->Parallel(&slsDetector::setSettingsDir, pos, value);
} }
void Detector::loadTrimbits(const std::string &value, Positions pos) { void Detector::loadTrimbits(const std::string &fname, Positions pos) {
pimpl->Parallel(&slsDetector::loadSettingsFile, pos, value); pimpl->Parallel(&slsDetector::loadSettingsFile, pos, fname);
} }
Result<bool> Detector::getRxAddGapPixels(Positions pos) const { Result<bool> Detector::getRxAddGapPixels(Positions pos) const {
@ -1030,12 +1030,12 @@ Result<bool> Detector::getQuad(Positions pos) const {
return pimpl->Parallel(&slsDetector::getQuad, pos); return pimpl->Parallel(&slsDetector::getQuad, pos);
} }
void Detector::setQuad(const bool value) { void Detector::setQuad(const bool enable) {
if (value && size() > 1) { if (enable && size() > 1) {
throw RuntimeError("Cannot set Quad type as it is available only for 1 " throw RuntimeError("Cannot set Quad type as it is available only for 1 "
"Eiger Quad Half module."); "Eiger Quad Half module.");
} }
pimpl->Parallel(&slsDetector::setQuad, {}, value); pimpl->Parallel(&slsDetector::setQuad, {}, enable);
} }
// Jungfrau Specific // Jungfrau Specific