diff --git a/.clang-tidy b/.clang-tidy index 562531bd3..d16f3e786 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -28,8 +28,9 @@ Checks: '*, -modernize-use-trailing-return-type, -llvmlibc-*' -HeaderFilterRegex: \.h -AnalyzeTemporaryDtors: false +# HeaderFilterRegex: \.h +HeaderFilterRegex: '^(?!.*([/\\])libs([/\\])).*' +#AnalyzeTemporaryDtors: false FormatStyle: none CheckOptions: - { key: readability-identifier-naming.NamespaceCase, value: lower_case } diff --git a/docs/src/gendoc.cpp b/docs/src/gendoc.cpp index 2854f6d22..bf99dc00a 100644 --- a/docs/src/gendoc.cpp +++ b/docs/src/gendoc.cpp @@ -19,7 +19,7 @@ std::string replace_all(const std::string &src, const std::string &from, const std::string &to) { std::string results; - std::string::const_iterator end = src.end(); + std::string::const_iterator const end = src.end(); std::string::const_iterator current = src.begin(); std::string::const_iterator next = std::search(current, end, from.begin(), from.end()); diff --git a/python/src/duration.cpp b/python/src/duration.cpp index ed8927c90..84bd09f13 100644 --- a/python/src/duration.cpp +++ b/python/src/duration.cpp @@ -24,7 +24,7 @@ void init_duration(py::module &m) { m.def( "test_return_DurationWrapper", []() { - DurationWrapper t(1.3); + DurationWrapper const t(1.3); return t; }, R"( diff --git a/python/src/enums.cpp b/python/src/enums.cpp index f7302df80..12f3cb41c 100644 --- a/python/src/enums.cpp +++ b/python/src/enums.cpp @@ -9,7 +9,7 @@ #include "sls/sls_detector_defs.h" namespace py = pybind11; void init_enums(py::module &m) { - py::class_ Defs(m, "slsDetectorDefs"); + py::class_ const Defs(m, "slsDetectorDefs"); py::class_ xy(m, "xy"); xy.def(py::init()); xy.def(py::init()); diff --git a/python/src/pattern.cpp b/python/src/pattern.cpp index 67447fff3..723532124 100644 --- a/python/src/pattern.cpp +++ b/python/src/pattern.cpp @@ -15,7 +15,7 @@ void init_pattern(py::module &m) { patternParameters.def(py::init()); patternParameters.def("numpy_view", [](py::object &obj) { - pat &o = obj.cast(); + pat const&o = obj.cast(); return py::array_t(1, &o, obj); }); diff --git a/slsDetectorSoftware/include/sls/detectorData.h b/slsDetectorSoftware/include/sls/detectorData.h index c55906482..6241c200e 100644 --- a/slsDetectorSoftware/include/sls/detectorData.h +++ b/slsDetectorSoftware/include/sls/detectorData.h @@ -25,21 +25,21 @@ class detectorData { ~detectorData(){}; int64_t getChannel(int i) { - int off = dynamicRange / 8; + const int off = dynamicRange / 8; if (off == 1) { - char val = *(data + i); + const char val = *(data + i); return val; } if (off == 2) { - int16_t val = *((int16_t *)(data + i * off)); + const int16_t val = *((int16_t *)(data + i * off)); return val; } if (off == 4) { - int32_t val = *((int32_t *)(data + i * off)); + const int32_t val = *((int32_t *)(data + i * off)); return val; } if (off == 8) { - int64_t val = *((int64_t *)(data + i * off)); + const int64_t val = *((int64_t *)(data + i * off)); return val; } return -1; diff --git a/slsDetectorSoftware/src/Caller.cpp b/slsDetectorSoftware/src/Caller.cpp index 292b881f8..c978a32a7 100644 --- a/slsDetectorSoftware/src/Caller.cpp +++ b/slsDetectorSoftware/src/Caller.cpp @@ -1093,7 +1093,7 @@ std::string Caller::blockingtrigger(int action) { } if (args.size() == 0) { - bool block = true; + bool const block = true; } } @@ -1107,7 +1107,7 @@ std::string Caller::blockingtrigger(int action) { // generate code for each action if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 0) { - bool block = true; + bool const block = true; if (det_id != -1) { throw RuntimeError( "Cannot execute blockingtrigger at module level"); @@ -1153,7 +1153,7 @@ std::string Caller::burstperiod(int action) { if (args.size() == 1) { try { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); } catch (...) { throw RuntimeError("Could not convert argument to time::ns"); @@ -1192,7 +1192,7 @@ std::string Caller::burstperiod(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 1) { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); det->setBurstPeriod(converted_time, std::vector{det_id}); os << args[0] << '\n'; @@ -1648,7 +1648,7 @@ std::string Caller::clkdiv(int action) { } if (args.size() == 1) { - defs::detectorType type = + defs::detectorType const type = det->getDetectorType().squash(defs::GENERIC); ; try { @@ -1666,7 +1666,7 @@ std::string Caller::clkdiv(int action) { } if (args.size() == 2) { - defs::detectorType type = + defs::detectorType const type = det->getDetectorType().squash(defs::GENERIC); ; try { @@ -1692,7 +1692,7 @@ std::string Caller::clkdiv(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - defs::detectorType type = + defs::detectorType const type = det->getDetectorType().squash(defs::GENERIC); ; if (type != defs::GOTTHARD2 && type != defs::MYTHEN3) { @@ -1706,7 +1706,7 @@ std::string Caller::clkdiv(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 2) { - defs::detectorType type = + defs::detectorType const type = det->getDetectorType().squash(defs::GENERIC); ; if (type != defs::GOTTHARD2 && type != defs::MYTHEN3) { @@ -1742,7 +1742,7 @@ std::string Caller::clkfreq(int action) { } if (args.size() == 1) { - defs::detectorType type = + defs::detectorType const type = det->getDetectorType().squash(defs::GENERIC); ; try { @@ -1763,7 +1763,7 @@ std::string Caller::clkfreq(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - defs::detectorType type = + defs::detectorType const type = det->getDetectorType().squash(defs::GENERIC); ; if (type != defs::GOTTHARD2 && type != defs::MYTHEN3) { @@ -1798,7 +1798,7 @@ std::string Caller::clkphase(int action) { } if (args.size() == 1) { - defs::detectorType type = + defs::detectorType const type = det->getDetectorType().squash(defs::GENERIC); ; try { @@ -1809,7 +1809,7 @@ std::string Caller::clkphase(int action) { } if (args.size() == 2) { - defs::detectorType type = + defs::detectorType const type = det->getDetectorType().squash(defs::GENERIC); ; try { @@ -1827,7 +1827,7 @@ std::string Caller::clkphase(int action) { } if (args.size() == 2) { - defs::detectorType type = + defs::detectorType const type = det->getDetectorType().squash(defs::GENERIC); ; try { @@ -1843,7 +1843,7 @@ std::string Caller::clkphase(int action) { } if (args.size() == 3) { - defs::detectorType type = + defs::detectorType const type = det->getDetectorType().squash(defs::GENERIC); ; try { @@ -1869,7 +1869,7 @@ std::string Caller::clkphase(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - defs::detectorType type = + defs::detectorType const type = det->getDetectorType().squash(defs::GENERIC); ; if (type != defs::GOTTHARD2 && type != defs::MYTHEN3) { @@ -1882,7 +1882,7 @@ std::string Caller::clkphase(int action) { } if (args.size() == 2) { - defs::detectorType type = + defs::detectorType const type = det->getDetectorType().squash(defs::GENERIC); ; if (type != defs::GOTTHARD2 && type != defs::MYTHEN3) { @@ -1902,7 +1902,7 @@ std::string Caller::clkphase(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 2) { - defs::detectorType type = + defs::detectorType const type = det->getDetectorType().squash(defs::GENERIC); ; if (type != defs::GOTTHARD2 && type != defs::MYTHEN3) { @@ -1916,7 +1916,7 @@ std::string Caller::clkphase(int action) { } if (args.size() == 3) { - defs::detectorType type = + defs::detectorType const type = det->getDetectorType().squash(defs::GENERIC); ; if (type != defs::GOTTHARD2 && type != defs::MYTHEN3) { @@ -2096,7 +2096,7 @@ std::string Caller::compdisabletime(int action) { if (args.size() == 1) { try { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); } catch (...) { throw RuntimeError("Could not convert argument to time::ns"); @@ -2135,7 +2135,7 @@ std::string Caller::compdisabletime(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 1) { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); det->setComparatorDisableTime(converted_time, std::vector{det_id}); @@ -2338,7 +2338,7 @@ std::string Caller::dac(int action) { } if (args.size() == 1) { - defs::dacIndex dacIndex = + defs::dacIndex const dacIndex = ((det->getDetectorType().squash() == defs::CHIPTESTBOARD || det->getDetectorType().squash() == defs::XILINX_CHIPTESTBOARD) && @@ -2353,7 +2353,7 @@ std::string Caller::dac(int action) { } if (args.size() == 2) { - defs::dacIndex dacIndex = + defs::dacIndex const dacIndex = ((det->getDetectorType().squash() == defs::CHIPTESTBOARD || det->getDetectorType().squash() == defs::XILINX_CHIPTESTBOARD) && @@ -2375,7 +2375,7 @@ std::string Caller::dac(int action) { } if (args.size() == 2) { - defs::dacIndex dacIndex = + defs::dacIndex const dacIndex = ((det->getDetectorType().squash() == defs::CHIPTESTBOARD || det->getDetectorType().squash() == defs::XILINX_CHIPTESTBOARD) && @@ -2395,7 +2395,7 @@ std::string Caller::dac(int action) { } if (args.size() == 3) { - defs::dacIndex dacIndex = + defs::dacIndex const dacIndex = ((det->getDetectorType().squash() == defs::CHIPTESTBOARD || det->getDetectorType().squash() == defs::XILINX_CHIPTESTBOARD) && @@ -2425,7 +2425,7 @@ std::string Caller::dac(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - defs::dacIndex dacIndex = + defs::dacIndex const dacIndex = ((det->getDetectorType().squash() == defs::CHIPTESTBOARD || det->getDetectorType().squash() == defs::XILINX_CHIPTESTBOARD) && @@ -2445,7 +2445,7 @@ std::string Caller::dac(int action) { } if (args.size() == 2) { - defs::dacIndex dacIndex = + defs::dacIndex const dacIndex = ((det->getDetectorType().squash() == defs::CHIPTESTBOARD || det->getDetectorType().squash() == defs::XILINX_CHIPTESTBOARD) && @@ -2471,7 +2471,7 @@ std::string Caller::dac(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 2) { - defs::dacIndex dacIndex = + defs::dacIndex const dacIndex = ((det->getDetectorType().squash() == defs::CHIPTESTBOARD || det->getDetectorType().squash() == defs::XILINX_CHIPTESTBOARD) && @@ -2492,7 +2492,7 @@ std::string Caller::dac(int action) { } if (args.size() == 3) { - defs::dacIndex dacIndex = + defs::dacIndex const dacIndex = ((det->getDetectorType().squash() == defs::CHIPTESTBOARD || det->getDetectorType().squash() == defs::XILINX_CHIPTESTBOARD) && @@ -2534,7 +2534,7 @@ std::string Caller::dacindex(int action) { } if (args.size() == 1) { - defs::dacIndex index = defs::DAC_0; + defs::dacIndex const index = defs::DAC_0; } } @@ -2548,7 +2548,7 @@ std::string Caller::dacindex(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - defs::dacIndex index = defs::DAC_0; + defs::dacIndex const index = defs::DAC_0; if (det->getDetectorType().squash(defs::GENERIC) != defs::CHIPTESTBOARD && det->getDetectorType().squash(defs::GENERIC) != @@ -2661,7 +2661,7 @@ std::string Caller::dacname(int action) { } if (args.size() == 1) { - defs::dacIndex index = defs::DAC_0; + defs::dacIndex const index = defs::DAC_0; } } @@ -2672,7 +2672,7 @@ std::string Caller::dacname(int action) { } if (args.size() == 2) { - defs::dacIndex index = defs::DAC_0; + defs::dacIndex const index = defs::DAC_0; } } @@ -2686,7 +2686,7 @@ std::string Caller::dacname(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - defs::dacIndex index = defs::DAC_0; + defs::dacIndex const index = defs::DAC_0; if (det->getDetectorType().squash(defs::GENERIC) != defs::CHIPTESTBOARD && det->getDetectorType().squash(defs::GENERIC) != @@ -2704,7 +2704,7 @@ std::string Caller::dacname(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 2) { - defs::dacIndex index = defs::DAC_0; + defs::dacIndex const index = defs::DAC_0; if (det->getDetectorType().squash(defs::GENERIC) != defs::CHIPTESTBOARD && det->getDetectorType().squash(defs::GENERIC) != @@ -3255,7 +3255,7 @@ std::string Caller::delay(int action) { if (args.size() == 1) { try { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); } catch (...) { throw RuntimeError("Could not convert argument to time::ns"); @@ -3294,7 +3294,7 @@ std::string Caller::delay(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 1) { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); det->setDelayAfterTrigger(converted_time, std::vector{det_id}); os << args[0] << '\n'; @@ -3771,7 +3771,7 @@ std::string Caller::exptime(int action) { if (args.size() == 1) { try { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); } catch (...) { throw RuntimeError("Could not convert argument to time::ns"); @@ -3827,7 +3827,7 @@ std::string Caller::exptime(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 1) { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); det->setExptime(converted_time, std::vector{det_id}); os << args[0] << '\n'; @@ -3861,11 +3861,11 @@ std::string Caller::exptime1(int action) { } if (args.size() == 0) { - int gateIndex = 0; + int const gateIndex = 0; } if (args.size() == 1) { - int gateIndex = 0; + int const gateIndex = 0; } } @@ -3876,10 +3876,10 @@ std::string Caller::exptime1(int action) { } if (args.size() == 1) { - int gateIndex = 0; + int const gateIndex = 0; try { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); } catch (...) { throw RuntimeError("Could not convert argument to time::ns"); @@ -3887,7 +3887,7 @@ std::string Caller::exptime1(int action) { } if (args.size() == 2) { - int gateIndex = 0; + int const gateIndex = 0; try { StringTo(args[0], args[1]); } catch (...) { @@ -3906,13 +3906,13 @@ std::string Caller::exptime1(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 0) { - int gateIndex = 0; + int const gateIndex = 0; auto t = det->getExptime(gateIndex, std::vector{det_id}); os << OutString(t) << '\n'; } if (args.size() == 1) { - int gateIndex = 0; + int const gateIndex = 0; auto t = det->getExptime(gateIndex, std::vector{det_id}); os << OutString(t, args[0]) << '\n'; } @@ -3920,9 +3920,9 @@ std::string Caller::exptime1(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 1) { - int gateIndex = 0; + int const gateIndex = 0; std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); det->setExptime(gateIndex, converted_time, std::vector{det_id}); @@ -3930,7 +3930,7 @@ std::string Caller::exptime1(int action) { } if (args.size() == 2) { - int gateIndex = 0; + int const gateIndex = 0; auto converted_time = StringTo(args[0], args[1]); det->setExptime(gateIndex, converted_time, std::vector{det_id}); @@ -3959,11 +3959,11 @@ std::string Caller::exptime2(int action) { } if (args.size() == 0) { - int gateIndex = 1; + int const gateIndex = 1; } if (args.size() == 1) { - int gateIndex = 1; + int const gateIndex = 1; } } @@ -3974,10 +3974,10 @@ std::string Caller::exptime2(int action) { } if (args.size() == 1) { - int gateIndex = 1; + int const gateIndex = 1; try { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); } catch (...) { throw RuntimeError("Could not convert argument to time::ns"); @@ -3985,7 +3985,7 @@ std::string Caller::exptime2(int action) { } if (args.size() == 2) { - int gateIndex = 1; + int const gateIndex = 1; try { StringTo(args[0], args[1]); } catch (...) { @@ -4004,13 +4004,13 @@ std::string Caller::exptime2(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 0) { - int gateIndex = 1; + int const gateIndex = 1; auto t = det->getExptime(gateIndex, std::vector{det_id}); os << OutString(t) << '\n'; } if (args.size() == 1) { - int gateIndex = 1; + int const gateIndex = 1; auto t = det->getExptime(gateIndex, std::vector{det_id}); os << OutString(t, args[0]) << '\n'; } @@ -4018,9 +4018,9 @@ std::string Caller::exptime2(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 1) { - int gateIndex = 1; + int const gateIndex = 1; std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); det->setExptime(gateIndex, converted_time, std::vector{det_id}); @@ -4028,7 +4028,7 @@ std::string Caller::exptime2(int action) { } if (args.size() == 2) { - int gateIndex = 1; + int const gateIndex = 1; auto converted_time = StringTo(args[0], args[1]); det->setExptime(gateIndex, converted_time, std::vector{det_id}); @@ -4057,11 +4057,11 @@ std::string Caller::exptime3(int action) { } if (args.size() == 0) { - int gateIndex = 2; + int const gateIndex = 2; } if (args.size() == 1) { - int gateIndex = 2; + int const gateIndex = 2; } } @@ -4072,10 +4072,10 @@ std::string Caller::exptime3(int action) { } if (args.size() == 1) { - int gateIndex = 2; + int const gateIndex = 2; try { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); } catch (...) { throw RuntimeError("Could not convert argument to time::ns"); @@ -4083,7 +4083,7 @@ std::string Caller::exptime3(int action) { } if (args.size() == 2) { - int gateIndex = 2; + int const gateIndex = 2; try { StringTo(args[0], args[1]); } catch (...) { @@ -4102,13 +4102,13 @@ std::string Caller::exptime3(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 0) { - int gateIndex = 2; + int const gateIndex = 2; auto t = det->getExptime(gateIndex, std::vector{det_id}); os << OutString(t) << '\n'; } if (args.size() == 1) { - int gateIndex = 2; + int const gateIndex = 2; auto t = det->getExptime(gateIndex, std::vector{det_id}); os << OutString(t, args[0]) << '\n'; } @@ -4116,9 +4116,9 @@ std::string Caller::exptime3(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 1) { - int gateIndex = 2; + int const gateIndex = 2; std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); det->setExptime(gateIndex, converted_time, std::vector{det_id}); @@ -4126,7 +4126,7 @@ std::string Caller::exptime3(int action) { } if (args.size() == 2) { - int gateIndex = 2; + int const gateIndex = 2; auto converted_time = StringTo(args[0], args[1]); det->setExptime(gateIndex, converted_time, std::vector{det_id}); @@ -5536,10 +5536,10 @@ std::string Caller::gatedelay(int action) { } if (args.size() == 1) { - int gateIndex = -1; + int const gateIndex = -1; try { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); } catch (...) { throw RuntimeError("Could not convert argument to time::ns"); @@ -5547,7 +5547,7 @@ std::string Caller::gatedelay(int action) { } if (args.size() == 2) { - int gateIndex = -1; + int const gateIndex = -1; try { StringTo(args[0], args[1]); } catch (...) { @@ -5578,9 +5578,9 @@ std::string Caller::gatedelay(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 1) { - int gateIndex = -1; + int const gateIndex = -1; std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); det->setGateDelay(gateIndex, converted_time, std::vector{det_id}); @@ -5588,7 +5588,7 @@ std::string Caller::gatedelay(int action) { } if (args.size() == 2) { - int gateIndex = -1; + int const gateIndex = -1; auto converted_time = StringTo(args[0], args[1]); det->setGateDelay(gateIndex, converted_time, std::vector{det_id}); @@ -5617,11 +5617,11 @@ std::string Caller::gatedelay1(int action) { } if (args.size() == 0) { - int gateIndex = 0; + int const gateIndex = 0; } if (args.size() == 1) { - int gateIndex = 0; + int const gateIndex = 0; } } @@ -5632,10 +5632,10 @@ std::string Caller::gatedelay1(int action) { } if (args.size() == 1) { - int gateIndex = 0; + int const gateIndex = 0; try { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); } catch (...) { throw RuntimeError("Could not convert argument to time::ns"); @@ -5643,7 +5643,7 @@ std::string Caller::gatedelay1(int action) { } if (args.size() == 2) { - int gateIndex = 0; + int const gateIndex = 0; try { StringTo(args[0], args[1]); } catch (...) { @@ -5662,13 +5662,13 @@ std::string Caller::gatedelay1(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 0) { - int gateIndex = 0; + int const gateIndex = 0; auto t = det->getGateDelay(gateIndex, std::vector{det_id}); os << OutString(t) << '\n'; } if (args.size() == 1) { - int gateIndex = 0; + int const gateIndex = 0; auto t = det->getGateDelay(gateIndex, std::vector{det_id}); os << OutString(t, args[0]) << '\n'; } @@ -5676,9 +5676,9 @@ std::string Caller::gatedelay1(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 1) { - int gateIndex = 0; + int const gateIndex = 0; std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); det->setGateDelay(gateIndex, converted_time, std::vector{det_id}); @@ -5686,7 +5686,7 @@ std::string Caller::gatedelay1(int action) { } if (args.size() == 2) { - int gateIndex = 0; + int const gateIndex = 0; auto converted_time = StringTo(args[0], args[1]); det->setGateDelay(gateIndex, converted_time, std::vector{det_id}); @@ -5715,11 +5715,11 @@ std::string Caller::gatedelay2(int action) { } if (args.size() == 0) { - int gateIndex = 1; + int const gateIndex = 1; } if (args.size() == 1) { - int gateIndex = 1; + int const gateIndex = 1; } } @@ -5730,10 +5730,10 @@ std::string Caller::gatedelay2(int action) { } if (args.size() == 1) { - int gateIndex = 1; + int const gateIndex = 1; try { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); } catch (...) { throw RuntimeError("Could not convert argument to time::ns"); @@ -5741,7 +5741,7 @@ std::string Caller::gatedelay2(int action) { } if (args.size() == 2) { - int gateIndex = 1; + int const gateIndex = 1; try { StringTo(args[0], args[1]); } catch (...) { @@ -5760,13 +5760,13 @@ std::string Caller::gatedelay2(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 0) { - int gateIndex = 1; + int const gateIndex = 1; auto t = det->getGateDelay(gateIndex, std::vector{det_id}); os << OutString(t) << '\n'; } if (args.size() == 1) { - int gateIndex = 1; + int const gateIndex = 1; auto t = det->getGateDelay(gateIndex, std::vector{det_id}); os << OutString(t, args[0]) << '\n'; } @@ -5774,9 +5774,9 @@ std::string Caller::gatedelay2(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 1) { - int gateIndex = 1; + int const gateIndex = 1; std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); det->setGateDelay(gateIndex, converted_time, std::vector{det_id}); @@ -5784,7 +5784,7 @@ std::string Caller::gatedelay2(int action) { } if (args.size() == 2) { - int gateIndex = 1; + int const gateIndex = 1; auto converted_time = StringTo(args[0], args[1]); det->setGateDelay(gateIndex, converted_time, std::vector{det_id}); @@ -5813,11 +5813,11 @@ std::string Caller::gatedelay3(int action) { } if (args.size() == 0) { - int gateIndex = 2; + int const gateIndex = 2; } if (args.size() == 1) { - int gateIndex = 2; + int const gateIndex = 2; } } @@ -5828,10 +5828,10 @@ std::string Caller::gatedelay3(int action) { } if (args.size() == 1) { - int gateIndex = 2; + int const gateIndex = 2; try { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); } catch (...) { throw RuntimeError("Could not convert argument to time::ns"); @@ -5839,7 +5839,7 @@ std::string Caller::gatedelay3(int action) { } if (args.size() == 2) { - int gateIndex = 2; + int const gateIndex = 2; try { StringTo(args[0], args[1]); } catch (...) { @@ -5858,13 +5858,13 @@ std::string Caller::gatedelay3(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 0) { - int gateIndex = 2; + int const gateIndex = 2; auto t = det->getGateDelay(gateIndex, std::vector{det_id}); os << OutString(t) << '\n'; } if (args.size() == 1) { - int gateIndex = 2; + int const gateIndex = 2; auto t = det->getGateDelay(gateIndex, std::vector{det_id}); os << OutString(t, args[0]) << '\n'; } @@ -5872,9 +5872,9 @@ std::string Caller::gatedelay3(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 1) { - int gateIndex = 2; + int const gateIndex = 2; std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); det->setGateDelay(gateIndex, converted_time, std::vector{det_id}); @@ -5882,7 +5882,7 @@ std::string Caller::gatedelay3(int action) { } if (args.size() == 2) { - int gateIndex = 2; + int const gateIndex = 2; auto converted_time = StringTo(args[0], args[1]); det->setGateDelay(gateIndex, converted_time, std::vector{det_id}); @@ -6961,7 +6961,7 @@ std::string Caller::maxclkphaseshift(int action) { } if (args.size() == 1) { - defs::detectorType type = + defs::detectorType const type = det->getDetectorType().squash(defs::GENERIC); ; try { @@ -6982,7 +6982,7 @@ std::string Caller::maxclkphaseshift(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - defs::detectorType type = + defs::detectorType const type = det->getDetectorType().squash(defs::GENERIC); ; if (type != defs::GOTTHARD2 && type != defs::MYTHEN3) { @@ -7779,7 +7779,7 @@ std::string Caller::patloop(int action) { } if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); } } @@ -7790,9 +7790,9 @@ std::string Caller::patloop(int action) { } if (args.size() == 3) { - int level = StringTo(args[0]); - int start = StringTo(args[1]); - int stop = StringTo(args[2]); + int const level = StringTo(args[0]); + int const start = StringTo(args[1]); + int const stop = StringTo(args[2]); } } @@ -7806,7 +7806,7 @@ std::string Caller::patloop(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); auto t = det->getPatternLoopAddresses(level, std::vector{det_id}); os << level << ' ' << OutStringHex(t, 4) << '\n'; @@ -7815,9 +7815,9 @@ std::string Caller::patloop(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 3) { - int level = StringTo(args[0]); - int start = StringTo(args[1]); - int stop = StringTo(args[2]); + int const level = StringTo(args[0]); + int const start = StringTo(args[1]); + int const stop = StringTo(args[2]); det->setPatternLoopAddresses(level, start, stop, std::vector{det_id}); os << level << ' ' << '[' << ToStringHex(start, 4) << ", " @@ -7847,7 +7847,7 @@ std::string Caller::patloop0(int action) { } if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); } } @@ -7858,9 +7858,9 @@ std::string Caller::patloop0(int action) { } if (args.size() == 3) { - int level = StringTo(args[0]); - int start = StringTo(args[1]); - int stop = StringTo(args[2]); + int const level = StringTo(args[0]); + int const start = StringTo(args[1]); + int const stop = StringTo(args[2]); } } @@ -7874,7 +7874,7 @@ std::string Caller::patloop0(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); auto t = det->getPatternLoopAddresses(level, std::vector{det_id}); os << OutStringHex(t, 4) << '\n'; @@ -7883,9 +7883,9 @@ std::string Caller::patloop0(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 3) { - int level = StringTo(args[0]); - int start = StringTo(args[1]); - int stop = StringTo(args[2]); + int const level = StringTo(args[0]); + int const start = StringTo(args[1]); + int const stop = StringTo(args[2]); det->setPatternLoopAddresses(level, start, stop, std::vector{det_id}); os << '[' << ToStringHex(start, 4) << ", " << ToStringHex(stop, 4) @@ -7915,7 +7915,7 @@ std::string Caller::patloop1(int action) { } if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); } } @@ -7926,9 +7926,9 @@ std::string Caller::patloop1(int action) { } if (args.size() == 3) { - int level = StringTo(args[0]); - int start = StringTo(args[1]); - int stop = StringTo(args[2]); + int const level = StringTo(args[0]); + int const start = StringTo(args[1]); + int const stop = StringTo(args[2]); } } @@ -7942,7 +7942,7 @@ std::string Caller::patloop1(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); auto t = det->getPatternLoopAddresses(level, std::vector{det_id}); os << OutStringHex(t, 4) << '\n'; @@ -7951,9 +7951,9 @@ std::string Caller::patloop1(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 3) { - int level = StringTo(args[0]); - int start = StringTo(args[1]); - int stop = StringTo(args[2]); + int const level = StringTo(args[0]); + int const start = StringTo(args[1]); + int const stop = StringTo(args[2]); det->setPatternLoopAddresses(level, start, stop, std::vector{det_id}); os << '[' << ToStringHex(start, 4) << ", " << ToStringHex(stop, 4) @@ -7983,7 +7983,7 @@ std::string Caller::patloop2(int action) { } if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); } } @@ -7994,9 +7994,9 @@ std::string Caller::patloop2(int action) { } if (args.size() == 3) { - int level = StringTo(args[0]); - int start = StringTo(args[1]); - int stop = StringTo(args[2]); + int const level = StringTo(args[0]); + int const start = StringTo(args[1]); + int const stop = StringTo(args[2]); } } @@ -8010,7 +8010,7 @@ std::string Caller::patloop2(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); auto t = det->getPatternLoopAddresses(level, std::vector{det_id}); os << OutStringHex(t, 4) << '\n'; @@ -8019,9 +8019,9 @@ std::string Caller::patloop2(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 3) { - int level = StringTo(args[0]); - int start = StringTo(args[1]); - int stop = StringTo(args[2]); + int const level = StringTo(args[0]); + int const start = StringTo(args[1]); + int const stop = StringTo(args[2]); det->setPatternLoopAddresses(level, start, stop, std::vector{det_id}); os << '[' << ToStringHex(start, 4) << ", " << ToStringHex(stop, 4) @@ -8114,7 +8114,7 @@ std::string Caller::patnloop(int action) { } if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); } } @@ -8125,8 +8125,8 @@ std::string Caller::patnloop(int action) { } if (args.size() == 2) { - int level = StringTo(args[0]); - int nloops = StringTo(args[1]); + int const level = StringTo(args[0]); + int const nloops = StringTo(args[1]); } } @@ -8140,7 +8140,7 @@ std::string Caller::patnloop(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); auto t = det->getPatternLoopCycles(level, std::vector{det_id}); os << level << ' ' << OutString(t) << '\n'; } @@ -8148,8 +8148,8 @@ std::string Caller::patnloop(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 2) { - int level = StringTo(args[0]); - int nloops = StringTo(args[1]); + int const level = StringTo(args[0]); + int const nloops = StringTo(args[1]); det->setPatternLoopCycles(level, nloops, std::vector{det_id}); os << level << ' ' << nloops << '\n'; } @@ -8177,7 +8177,7 @@ std::string Caller::patnloop0(int action) { } if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); } } @@ -8188,8 +8188,8 @@ std::string Caller::patnloop0(int action) { } if (args.size() == 2) { - int level = StringTo(args[0]); - int nloops = StringTo(args[1]); + int const level = StringTo(args[0]); + int const nloops = StringTo(args[1]); } } @@ -8203,7 +8203,7 @@ std::string Caller::patnloop0(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); auto t = det->getPatternLoopCycles(level, std::vector{det_id}); os << OutString(t) << '\n'; } @@ -8211,8 +8211,8 @@ std::string Caller::patnloop0(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 2) { - int level = StringTo(args[0]); - int nloops = StringTo(args[1]); + int const level = StringTo(args[0]); + int const nloops = StringTo(args[1]); det->setPatternLoopCycles(level, nloops, std::vector{det_id}); os << nloops << '\n'; } @@ -8240,7 +8240,7 @@ std::string Caller::patnloop1(int action) { } if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); } } @@ -8251,8 +8251,8 @@ std::string Caller::patnloop1(int action) { } if (args.size() == 2) { - int level = StringTo(args[0]); - int nloops = StringTo(args[1]); + int const level = StringTo(args[0]); + int const nloops = StringTo(args[1]); } } @@ -8266,7 +8266,7 @@ std::string Caller::patnloop1(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); auto t = det->getPatternLoopCycles(level, std::vector{det_id}); os << OutString(t) << '\n'; } @@ -8274,8 +8274,8 @@ std::string Caller::patnloop1(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 2) { - int level = StringTo(args[0]); - int nloops = StringTo(args[1]); + int const level = StringTo(args[0]); + int const nloops = StringTo(args[1]); det->setPatternLoopCycles(level, nloops, std::vector{det_id}); os << nloops << '\n'; } @@ -8303,7 +8303,7 @@ std::string Caller::patnloop2(int action) { } if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); } } @@ -8314,8 +8314,8 @@ std::string Caller::patnloop2(int action) { } if (args.size() == 2) { - int level = StringTo(args[0]); - int nloops = StringTo(args[1]); + int const level = StringTo(args[0]); + int const nloops = StringTo(args[1]); } } @@ -8329,7 +8329,7 @@ std::string Caller::patnloop2(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); auto t = det->getPatternLoopCycles(level, std::vector{det_id}); os << OutString(t) << '\n'; } @@ -8337,8 +8337,8 @@ std::string Caller::patnloop2(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 2) { - int level = StringTo(args[0]); - int nloops = StringTo(args[1]); + int const level = StringTo(args[0]); + int const nloops = StringTo(args[1]); det->setPatternLoopCycles(level, nloops, std::vector{det_id}); os << nloops << '\n'; } @@ -8507,7 +8507,7 @@ std::string Caller::patwait(int action) { } if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); } } @@ -8518,8 +8518,8 @@ std::string Caller::patwait(int action) { } if (args.size() == 2) { - int level = StringTo(args[0]); - int addr = StringTo(args[1]); + int const level = StringTo(args[0]); + int const addr = StringTo(args[1]); } } @@ -8533,7 +8533,7 @@ std::string Caller::patwait(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); auto t = det->getPatternWaitAddr(level, std::vector{det_id}); os << level << ' ' << OutStringHex(t, 4) << '\n'; } @@ -8541,8 +8541,8 @@ std::string Caller::patwait(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 2) { - int level = StringTo(args[0]); - int addr = StringTo(args[1]); + int const level = StringTo(args[0]); + int const addr = StringTo(args[1]); det->setPatternWaitAddr(level, addr, std::vector{det_id}); os << level << ' ' << ToStringHex(addr, 4) << '\n'; } @@ -8570,7 +8570,7 @@ std::string Caller::patwait0(int action) { } if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); } } @@ -8581,8 +8581,8 @@ std::string Caller::patwait0(int action) { } if (args.size() == 2) { - int level = StringTo(args[0]); - int addr = StringTo(args[1]); + int const level = StringTo(args[0]); + int const addr = StringTo(args[1]); } } @@ -8596,7 +8596,7 @@ std::string Caller::patwait0(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); auto t = det->getPatternWaitAddr(level, std::vector{det_id}); os << OutStringHex(t, 4) << '\n'; } @@ -8604,8 +8604,8 @@ std::string Caller::patwait0(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 2) { - int level = StringTo(args[0]); - int addr = StringTo(args[1]); + int const level = StringTo(args[0]); + int const addr = StringTo(args[1]); det->setPatternWaitAddr(level, addr, std::vector{det_id}); os << ToStringHex(addr, 4) << '\n'; } @@ -8633,7 +8633,7 @@ std::string Caller::patwait1(int action) { } if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); } } @@ -8644,8 +8644,8 @@ std::string Caller::patwait1(int action) { } if (args.size() == 2) { - int level = StringTo(args[0]); - int addr = StringTo(args[1]); + int const level = StringTo(args[0]); + int const addr = StringTo(args[1]); } } @@ -8659,7 +8659,7 @@ std::string Caller::patwait1(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); auto t = det->getPatternWaitAddr(level, std::vector{det_id}); os << OutStringHex(t, 4) << '\n'; } @@ -8667,8 +8667,8 @@ std::string Caller::patwait1(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 2) { - int level = StringTo(args[0]); - int addr = StringTo(args[1]); + int const level = StringTo(args[0]); + int const addr = StringTo(args[1]); det->setPatternWaitAddr(level, addr, std::vector{det_id}); os << ToStringHex(addr, 4) << '\n'; } @@ -8696,7 +8696,7 @@ std::string Caller::patwait2(int action) { } if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); } } @@ -8707,8 +8707,8 @@ std::string Caller::patwait2(int action) { } if (args.size() == 2) { - int level = StringTo(args[0]); - int addr = StringTo(args[1]); + int const level = StringTo(args[0]); + int const addr = StringTo(args[1]); } } @@ -8722,7 +8722,7 @@ std::string Caller::patwait2(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - int level = StringTo(args[0]); + int const level = StringTo(args[0]); auto t = det->getPatternWaitAddr(level, std::vector{det_id}); os << OutStringHex(t, 4) << '\n'; } @@ -8730,8 +8730,8 @@ std::string Caller::patwait2(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 2) { - int level = StringTo(args[0]); - int addr = StringTo(args[1]); + int const level = StringTo(args[0]); + int const addr = StringTo(args[1]); det->setPatternWaitAddr(level, addr, std::vector{det_id}); os << ToStringHex(addr, 4) << '\n'; } @@ -8929,7 +8929,7 @@ std::string Caller::period(int action) { if (args.size() == 1) { try { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); } catch (...) { throw RuntimeError("Could not convert argument to time::ns"); @@ -8968,7 +8968,7 @@ std::string Caller::period(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 1) { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); det->setPeriod(converted_time, std::vector{det_id}); os << args[0] << '\n'; @@ -9240,7 +9240,7 @@ std::string Caller::powerindex(int action) { } if (args.size() == 1) { - defs::dacIndex index = defs::V_POWER_A; + defs::dacIndex const index = defs::V_POWER_A; } } @@ -9254,7 +9254,7 @@ std::string Caller::powerindex(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - defs::dacIndex index = defs::V_POWER_A; + defs::dacIndex const index = defs::V_POWER_A; if (det->getDetectorType().squash(defs::GENERIC) != defs::CHIPTESTBOARD && det->getDetectorType().squash(defs::GENERIC) != @@ -9366,7 +9366,7 @@ std::string Caller::powername(int action) { } if (args.size() == 1) { - defs::dacIndex index = defs::V_POWER_A; + defs::dacIndex const index = defs::V_POWER_A; } } @@ -9377,7 +9377,7 @@ std::string Caller::powername(int action) { } if (args.size() == 2) { - defs::dacIndex index = defs::V_POWER_A; + defs::dacIndex const index = defs::V_POWER_A; } } @@ -9391,7 +9391,7 @@ std::string Caller::powername(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - defs::dacIndex index = defs::V_POWER_A; + defs::dacIndex const index = defs::V_POWER_A; if (det->getDetectorType().squash(defs::GENERIC) != defs::CHIPTESTBOARD && det->getDetectorType().squash(defs::GENERIC) != @@ -9409,7 +9409,7 @@ std::string Caller::powername(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 2) { - defs::dacIndex index = defs::V_POWER_A; + defs::dacIndex const index = defs::V_POWER_A; if (det->getDetectorType().squash(defs::GENERIC) != defs::CHIPTESTBOARD && det->getDetectorType().squash(defs::GENERIC) != @@ -9461,7 +9461,7 @@ std::string Caller::powervalues(int action) { if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 0) { - std::string suffix = " mV"; + std::string const suffix = " mV"; auto t = det->getPowerList(); auto names = det->getPowerNames(); @@ -9571,7 +9571,7 @@ std::string Caller::pulse(int action) { } if (args.size() == 3) { - defs::xy c = + defs::xy const c = defs::xy(StringTo(args[1]), StringTo(args[2])); try { StringTo(args[0]); @@ -9591,7 +9591,7 @@ std::string Caller::pulse(int action) { // generate code for each action if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 3) { - defs::xy c = + defs::xy const c = defs::xy(StringTo(args[1]), StringTo(args[2])); auto arg0 = StringTo(args[0]); det->pulsePixel(arg0, c, std::vector{det_id}); @@ -9665,7 +9665,7 @@ std::string Caller::pulsenmove(int action) { } if (args.size() == 3) { - defs::xy c = + defs::xy const c = defs::xy(StringTo(args[1]), StringTo(args[2])); try { StringTo(args[0]); @@ -9685,7 +9685,7 @@ std::string Caller::pulsenmove(int action) { // generate code for each action if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 3) { - defs::xy c = + defs::xy const c = defs::xy(StringTo(args[1]), StringTo(args[2])); auto arg0 = StringTo(args[0]); det->pulsePixelNMove(arg0, c, std::vector{det_id}); @@ -12180,7 +12180,7 @@ std::string Caller::scan(int action) { if (args.size() == 5) { try { std::string tmp_time(args[4]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto t = StringTo(tmp_time, unit); } catch (...) { throw RuntimeError("Could not convert argument to time::ns"); @@ -12228,7 +12228,7 @@ std::string Caller::scan(int action) { if (args.size() == 5) { std::string tmp_time(args[4]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto t = StringTo(tmp_time, unit); if (det_id != -1) { throw RuntimeError("Cannot execute scan at module level"); @@ -12871,7 +12871,7 @@ std::string Caller::slowadcindex(int action) { } if (args.size() == 1) { - defs::dacIndex index = defs::SLOW_ADC0; + defs::dacIndex const index = defs::SLOW_ADC0; } } @@ -12885,7 +12885,7 @@ std::string Caller::slowadcindex(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - defs::dacIndex index = defs::SLOW_ADC0; + defs::dacIndex const index = defs::SLOW_ADC0; if (det->getDetectorType().squash(defs::GENERIC) != defs::CHIPTESTBOARD && det->getDetectorType().squash(defs::GENERIC) != @@ -12999,7 +12999,7 @@ std::string Caller::slowadcname(int action) { } if (args.size() == 1) { - defs::dacIndex index = defs::SLOW_ADC0; + defs::dacIndex const index = defs::SLOW_ADC0; } } @@ -13010,7 +13010,7 @@ std::string Caller::slowadcname(int action) { } if (args.size() == 2) { - defs::dacIndex index = defs::SLOW_ADC0; + defs::dacIndex const index = defs::SLOW_ADC0; } } @@ -13024,7 +13024,7 @@ std::string Caller::slowadcname(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - defs::dacIndex index = defs::SLOW_ADC0; + defs::dacIndex const index = defs::SLOW_ADC0; if (det->getDetectorType().squash(defs::GENERIC) != defs::CHIPTESTBOARD && det->getDetectorType().squash(defs::GENERIC) != @@ -13043,7 +13043,7 @@ std::string Caller::slowadcname(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 2) { - defs::dacIndex index = defs::SLOW_ADC0; + defs::dacIndex const index = defs::SLOW_ADC0; if (det->getDetectorType().squash(defs::GENERIC) != defs::CHIPTESTBOARD && det->getDetectorType().squash(defs::GENERIC) != @@ -13096,7 +13096,7 @@ std::string Caller::slowadcvalues(int action) { if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 0) { - std::string suffix = " uV"; + std::string const suffix = " uV"; auto t = det->getSlowADCList(); auto names = det->getSlowADCNames(); @@ -13350,7 +13350,7 @@ std::string Caller::storagecell_delay(int action) { if (args.size() == 1) { try { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); } catch (...) { throw RuntimeError("Could not convert argument to time::ns"); @@ -13389,7 +13389,7 @@ std::string Caller::storagecell_delay(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 1) { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); det->setStorageCellDelay(converted_time, std::vector{det_id}); os << args[0] << '\n'; @@ -13500,7 +13500,7 @@ std::string Caller::subdeadtime(int action) { if (args.size() == 1) { try { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); } catch (...) { throw RuntimeError("Could not convert argument to time::ns"); @@ -13539,7 +13539,7 @@ std::string Caller::subdeadtime(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 1) { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); det->setSubDeadTime(converted_time, std::vector{det_id}); os << args[0] << '\n'; @@ -13588,7 +13588,7 @@ std::string Caller::subexptime(int action) { if (args.size() == 1) { try { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); } catch (...) { throw RuntimeError("Could not convert argument to time::ns"); @@ -13627,7 +13627,7 @@ std::string Caller::subexptime(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 1) { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); auto converted_time = StringTo(tmp_time, unit); det->setSubExptime(converted_time, std::vector{det_id}); os << args[0] << '\n'; @@ -14404,7 +14404,7 @@ std::string Caller::tempvalues(int action) { if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 0) { - std::string suffix = " °C"; + std::string const suffix = " °C"; auto t = det->getTemperatureList(); os << '['; if (t.size() > 0) { @@ -14864,7 +14864,7 @@ std::string Caller::trigger(int action) { } if (args.size() == 0) { - bool block = false; + bool const block = false; } } @@ -14878,7 +14878,7 @@ std::string Caller::trigger(int action) { // generate code for each action if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 0) { - bool block = false; + bool const block = false; if (det_id != -1) { throw RuntimeError("Cannot execute trigger at module level"); } @@ -17290,7 +17290,7 @@ std::string Caller::vetoalg(int action) { } if (args.size() == 1) { - defs::streamingInterface interface = + defs::streamingInterface const interface = StringTo(args[0]); } @@ -17302,8 +17302,8 @@ std::string Caller::vetoalg(int action) { } if (args.size() == 2) { - defs::vetoAlgorithm alg = StringTo(args[0]); - defs::streamingInterface interface = + defs::vetoAlgorithm const alg = StringTo(args[0]); + defs::streamingInterface const interface = StringTo(args[1]); } @@ -17318,7 +17318,7 @@ std::string Caller::vetoalg(int action) { // generate code for each action if (action == slsDetectorDefs::GET_ACTION) { if (args.size() == 1) { - defs::streamingInterface interface = + defs::streamingInterface const interface = StringTo(args[0]); if (interface == defs::streamingInterface::NONE) { throw RuntimeError( @@ -17331,8 +17331,8 @@ std::string Caller::vetoalg(int action) { if (action == slsDetectorDefs::PUT_ACTION) { if (args.size() == 2) { - defs::vetoAlgorithm alg = StringTo(args[0]); - defs::streamingInterface interface = + defs::vetoAlgorithm const alg = StringTo(args[0]); + defs::streamingInterface const interface = StringTo(args[1]); if (interface == defs::streamingInterface::NONE) { throw RuntimeError( diff --git a/slsDetectorSoftware/src/CallerSpecial.cpp b/slsDetectorSoftware/src/CallerSpecial.cpp index b21f7332c..886215a8b 100644 --- a/slsDetectorSoftware/src/CallerSpecial.cpp +++ b/slsDetectorSoftware/src/CallerSpecial.cpp @@ -102,7 +102,7 @@ std::string Caller::list(int action) { /* Network Configuration (Detector<->Receiver) */ IpAddr Caller::getDstIpFromAuto() { - std::string rxHostname = + std::string const rxHostname = det->getRxHostname(std::vector{det_id}).squash("none"); // Hostname could be ip try to decode otherwise look up the hostname auto val = IpAddr{rxHostname}; @@ -113,7 +113,7 @@ IpAddr Caller::getDstIpFromAuto() { } IpAddr Caller::getSrcIpFromAuto() { - std::string hostname = + std::string const hostname = det->getHostname(std::vector{det_id}).squash("none"); // Hostname could be ip try to decode otherwise look up the hostname auto val = IpAddr{hostname}; @@ -128,9 +128,9 @@ UdpDestination Caller::getUdpEntry() { udpDestination.entry = rx_id; for (auto it : args) { - size_t pos = it.find('='); - std::string key = it.substr(0, pos); - std::string value = it.substr(pos + 1); + size_t const pos = it.find('='); + std::string const key = it.substr(0, pos); + std::string const value = it.substr(pos + 1); if (key == "ip") { if (value == "auto") { auto val = getDstIpFromAuto(); @@ -177,7 +177,7 @@ int Caller::GetLevelAndInsertIntoArgs(std::string levelSeparatedCommand) { LOG(logWARNING) << "This command is deprecated and will be removed. " "Please migrate to " << levelSeparatedCommand; - int level = cmd[cmd.find_first_of("012")] - '0'; + int const level = cmd[cmd.find_first_of("012")] - '0'; args.insert(args.begin(), std::to_string(level)); return true; } @@ -295,8 +295,8 @@ std::string Caller::versions(int action) { bool receiver = false; std::string vReceiver = "Unknown"; - std::string vRelease = det->getPackageVersion(); - std::string vClient = det->getClientVersion(); + std::string const vRelease = det->getPackageVersion(); + std::string const vClient = det->getClientVersion(); if (det->size() != 0) { // shared memory has detectors @@ -382,7 +382,7 @@ std::string Caller::threshold(int action) { if (!args.empty()) { WrongNumberOfParameters(0); } - defs::detectorType type = det->getDetectorType().squash(); + defs::detectorType const type = det->getDetectorType().squash(); if (type == defs::EIGER) { auto t = det->getThresholdEnergy(std::vector{det_id}); os << OutString(t) << '\n'; @@ -393,7 +393,7 @@ std::string Caller::threshold(int action) { throw RuntimeError("Not implemented for this detector\n"); } } else if (action == defs::PUT_ACTION) { - defs::detectorType type = det->getDetectorType().squash(); + defs::detectorType const type = det->getDetectorType().squash(); if (type == defs::EIGER && args.size() != 1 && args.size() != 2) { WrongNumberOfParameters(1); } @@ -401,7 +401,7 @@ std::string Caller::threshold(int action) { WrongNumberOfParameters(1); } - bool trimbits = (cmd == "thresholdnotb") ? false : true; + bool const trimbits = (cmd == "thresholdnotb") ? false : true; std::array energy = {StringTo(args[0]), 0, 0}; energy[1] = energy[0]; energy[2] = energy[0]; @@ -708,7 +708,7 @@ std::string Caller::rx_hostname(int action) { return os.str(); } std::string Caller::rx_zmqip(int action) { - std::string helpMessage = + std::string const helpMessage = "\n\t[deprecated] The receiver zmq socket (publisher) will " "listen to all interfaces ('tcp://0.0.0.0:[port]'to all interfaces " "(from v9.0.0). This command does nothing and will be removed " @@ -729,7 +729,7 @@ std::string Caller::rx_zmqip(int action) { std::string Caller::rx_roi(int action) { std::ostringstream os; - std::string helpMessage = + std::string const helpMessage = std::string("[xmin] [xmax] [ymin] [ymax]\n") + "\tDefines a single region of interest (ROI) in the receiver.\n" "\tFor example, to set a single ROI: 0 100 20 30\n\n" @@ -771,7 +771,7 @@ std::string Caller::rx_roi(int action) { } // Support multiple args with bracketed ROIs, or single arg with // semicolon-separated vector in quotes - bool isVectorInput = + bool const isVectorInput = std::all_of(args.begin(), args.end(), [](const std::string &a) { return a.find('[') != std::string::npos && a.find(']') != std::string::npos; @@ -870,7 +870,7 @@ std::string Caller::ratecorr(int action) { if (args.size() != 1) { WrongNumberOfParameters(1); } - int tau = StringTo(args[0]); + int const tau = StringTo(args[0]); if (tau == -1) { det->setDefaultRateCorrection(std::vector{det_id}); auto t = det->getRateCorrection(std::vector{det_id}); @@ -905,7 +905,7 @@ std::string Caller::burstmode(int action) { } defs::burstMode t; try { - int ival = StringTo(args[0]); + int const ival = StringTo(args[0]); switch (ival) { case 0: t = defs::BURST_INTERNAL; @@ -1001,7 +1001,7 @@ std::string Caller::counters(int action) { // convert vector to counter enable mask uint32_t mask = 0; for (size_t i = 0; i < args.size(); ++i) { - int val = StringTo(args[i]); + int const val = StringTo(args[i]); // already enabled earlier if (mask & (1 << val)) { std::ostringstream oss; @@ -1036,9 +1036,9 @@ std::string Caller::samples(int action) { auto d = det->getNumberOfDigitalSamples(std::vector{det_id}); auto t = det->getNumberOfTransceiverSamples(std::vector{det_id}); - int as = a.squash(-1); - int ds = d.squash(-1); - int ts = t.squash(-1); + int const as = a.squash(-1); + int const ds = d.squash(-1); + int const ts = t.squash(-1); if (as == -1 || ds == -1 || ts == -1 || as != ds || as != ts) { // check if a == d? throw RuntimeError( @@ -1077,7 +1077,7 @@ std::string Caller::slowadc(int action) { if (args.size() != 1) { WrongNumberOfParameters(0); } - int nchan = StringTo(args[0]); + int const nchan = StringTo(args[0]); if (nchan < 0 || nchan > 7) { throw RuntimeError("Unknown adc argument " + args[0]); } @@ -1109,7 +1109,7 @@ std::string Caller::patwaittime(int action) { } // parse level - bool deprecated_cmd = GetLevelAndInsertIntoArgs("patwaittime"); + bool const deprecated_cmd = GetLevelAndInsertIntoArgs("patwaittime"); int level = 0; try { if (args.size() > 0) @@ -1141,7 +1141,7 @@ std::string Caller::patwaittime(int action) { // clocks (all digits) if (args.size() == 2 && std::all_of(args[1].begin(), args[1].end(), ::isdigit)) { - uint64_t waittime = StringTo(args[1]); + uint64_t const waittime = StringTo(args[1]); det->setPatternWaitClocks(level, waittime, std::vector{det_id}); os << waittime << '\n'; @@ -1152,7 +1152,7 @@ std::string Caller::patwaittime(int action) { try { if (args.size() == 2) { std::string tmp_time(args[1]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); converted_time = StringTo(tmp_time, unit); } else { converted_time = StringTo(args[1], args[2]); @@ -1205,7 +1205,7 @@ std::string Caller::rx_dbitlist(int action) { } // 'none' option already covered as t is empty by default else if (args[0] != "none") { - unsigned int ntrim = args.size(); + unsigned int const ntrim = args.size(); t.resize(ntrim); for (unsigned int i = 0; i < ntrim; ++i) { t[i] = StringTo(args[i]); @@ -1421,7 +1421,7 @@ std::string Caller::sleep(int action) { try { if (args.size() == 1) { std::string tmp_time(args[0]); - std::string unit = RemoveUnit(tmp_time); + std::string const unit = RemoveUnit(tmp_time); converted_time = StringTo(tmp_time, unit); } else { converted_time = StringTo(args[0], args[1]); diff --git a/slsDetectorSoftware/src/CmdApp.cpp b/slsDetectorSoftware/src/CmdApp.cpp index 70f5855ea..45a721240 100644 --- a/slsDetectorSoftware/src/CmdApp.cpp +++ b/slsDetectorSoftware/src/CmdApp.cpp @@ -83,7 +83,7 @@ int main(int argc, char *argv[]) { try { if (action == -1) { action = inferAction.infer(parser); - std::string actionString = + std::string const actionString = (action == slsDetectorDefs::GET_ACTION) ? "GET" : "PUT"; std::cout << "inferred action: " << actionString << std::endl; } diff --git a/slsDetectorSoftware/src/Detector.cpp b/slsDetectorSoftware/src/Detector.cpp index f6dd395af..26a8ff924 100644 --- a/slsDetectorSoftware/src/Detector.cpp +++ b/slsDetectorSoftware/src/Detector.cpp @@ -128,7 +128,7 @@ Detector &Detector::operator=(Detector &&other) noexcept = default; // Configuration void Detector::loadConfig(const std::string &fname) { - int shm_id = getShmId(); + const int shm_id = getShmId(); freeSharedMemory(shm_id); pimpl = make_unique(shm_id); LOG(logINFO) << "Loading configuration file: " << fname; @@ -205,7 +205,7 @@ int Detector::getShmId() const { return pimpl->getDetectorIndex(); } std::string Detector::getPackageVersion() const { return SLS_DET_VERSION; } std::string Detector::getClientVersion() const { - Version v(APILIB); + const Version v(APILIB); return v.concise(); } @@ -266,7 +266,7 @@ defs::xy Detector::getPortPerModuleGeometry() const { Result Detector::getPortSize(Positions pos) const { Result res = pimpl->Parallel(&Module::getNumberOfChannels, pos); - defs::xy portGeometry = getPortPerModuleGeometry(); + const defs::xy portGeometry = getPortPerModuleGeometry(); if ((portGeometry.x != 1 && portGeometry.x != 2) || (portGeometry.y != 1 && portGeometry.y != 2)) { throw RuntimeError( @@ -346,9 +346,9 @@ Detector::getAllThresholdEnergy(Positions pos) const { void Detector::setThresholdEnergy(int threshold_ev, defs::detectorSettings settings, bool trimbits, Positions pos) { - defs::detectorType type = getDetectorType().squash(); + const defs::detectorType type = getDetectorType().squash(); if (type == defs::MYTHEN3) { - std::array energy = {threshold_ev, threshold_ev, threshold_ev}; + const std::array energy = {threshold_ev, threshold_ev, threshold_ev}; setThresholdEnergy(energy, settings, trimbits, pos); return; } @@ -753,7 +753,6 @@ void Detector::setImageTestMode(int value, Positions pos) { } std::vector Detector::getTemperatureList() const { - std::vector retval; switch (getDetectorType().squash()) { case defs::CHIPTESTBOARD: return std::vector{defs::SLOW_ADC_TEMP}; @@ -1096,9 +1095,9 @@ void Detector::setNumberofUDPInterfaces_(int n, Positions pos) { if (!size()) { throw RuntimeError("No modules added."); } - bool previouslyClientStreaming = pimpl->getDataStreamingToClient(); - uint16_t clientStartingPort = getClientZmqPort({0}).squash(0); - bool useReceiver = getUseReceiverFlag().squash(false); + const bool previouslyClientStreaming = pimpl->getDataStreamingToClient(); + const uint16_t clientStartingPort = getClientZmqPort({0}).squash(0); + const bool useReceiver = getUseReceiverFlag().squash(false); bool previouslyReceiverStreaming = false; uint16_t rxStartingPort = 0; if (useReceiver) { @@ -1564,7 +1563,7 @@ Result Detector::getRxZmqPort(Positions pos) const { } void Detector::setRxZmqPort(uint16_t port, int module_id) { - bool previouslyReceiverStreaming = + const bool previouslyReceiverStreaming = getRxZmqDataStream(std::vector{module_id}).squash(false); if (module_id == -1) { std::vector port_list = getValidPortNumbers(port); @@ -1587,7 +1586,7 @@ Result Detector::getClientZmqPort(Positions pos) const { } void Detector::setClientZmqPort(uint16_t port, int module_id) { - bool previouslyClientStreaming = pimpl->getDataStreamingToClient(); + const bool previouslyClientStreaming = pimpl->getDataStreamingToClient(); if (module_id == -1) { std::vector port_list = getValidPortNumbers(port); for (int idet = 0; idet < size(); ++idet) { @@ -1609,7 +1608,7 @@ Result Detector::getClientZmqIp(Positions pos) const { } void Detector::setClientZmqIp(const IpAddr ip, Positions pos) { - bool previouslyClientStreaming = pimpl->getDataStreamingToClient(); + const bool previouslyClientStreaming = pimpl->getDataStreamingToClient(); pimpl->Parallel(&Module::setClientStreamingIP, pos, ip); if (previouslyClientStreaming) { pimpl->setDataStreamingToClient(false); @@ -1628,7 +1627,7 @@ Result Detector::getRxZmqHwm(Positions pos) const { } void Detector::setRxZmqHwm(const int limit) { - bool previouslyReceiverStreaming = getRxZmqDataStream().squash(false); + const bool previouslyReceiverStreaming = getRxZmqDataStream().squash(false); pimpl->Parallel(&Module::setReceiverStreamingHwm, {}, limit); if (previouslyReceiverStreaming) { setRxZmqDataStream(false, {}); @@ -1994,15 +1993,15 @@ Result Detector::getVetoStream(Positions pos) const { void Detector::setVetoStream(defs::streamingInterface interface, Positions pos) { // 3gbe - bool LOW_LATENCY_LINK = + const bool LOW_LATENCY_LINK = ((interface & defs::streamingInterface::LOW_LATENCY_LINK) == defs::streamingInterface::LOW_LATENCY_LINK); pimpl->Parallel(&Module::setVetoStream, pos, LOW_LATENCY_LINK); // 10gbe (debugging interface) opens 2nd udp interface in receiver - int old_numinterfaces = getNumberofUDPInterfaces(pos).tsquash( + const int old_numinterfaces = getNumberofUDPInterfaces(pos).tsquash( "retrieved inconsistent number of udp interfaces"); - int numinterfaces = + const int numinterfaces = (((interface & defs::streamingInterface::ETHERNET_10GB) == defs::streamingInterface::ETHERNET_10GB) ? 2 @@ -2730,7 +2729,7 @@ void Detector::programFPGA(const std::string &fname, const bool forceDeleteNormalFile, Positions pos) { LOG(logINFO) << "Updating Firmware..."; LOG(logINFO) << "Hardware Version: " << getHardwareVersion(); - std::vector buffer = pimpl->readProgrammingFile(fname); + const std::vector buffer = pimpl->readProgrammingFile(fname); pimpl->Parallel(&Module::programFPGA, pos, buffer, forceDeleteNormalFile); rebootController(pos); } @@ -2741,8 +2740,8 @@ void Detector::resetFPGA(Positions pos) { void Detector::updateDetectorServer(const std::string &fname, Positions pos) { LOG(logINFO) << "Updating Detector Server (no tftp)..."; - std::vector buffer = readBinaryFile(fname, "Update Detector Server"); - std::string filename = getFileNameFromFilePath(fname); + const std::vector buffer = readBinaryFile(fname, "Update Detector Server"); + const std::string filename = getFileNameFromFilePath(fname); pimpl->Parallel(&Module::updateDetectorServer, pos, buffer, filename); if (getDetectorType().squash() != defs::EIGER) { rebootController(pos); @@ -2751,7 +2750,7 @@ void Detector::updateDetectorServer(const std::string &fname, Positions pos) { void Detector::updateKernel(const std::string &fname, Positions pos) { LOG(logINFO) << "Updating Kernel..."; - std::vector buffer = readBinaryFile(fname, "Update Kernel"); + const std::vector buffer = readBinaryFile(fname, "Update Kernel"); pimpl->Parallel(&Module::updateKernel, pos, buffer); rebootController(pos); } @@ -2765,8 +2764,8 @@ void Detector::updateFirmwareAndServer(const std::string &sname, Positions pos) { LOG(logINFO) << "Updating Firmware and Detector Server (no tftp)..."; LOG(logINFO) << "Updating Detector Server (no tftp)..."; - std::vector buffer = readBinaryFile(sname, "Update Detector Server"); - std::string filename = getFileNameFromFilePath(sname); + const std::vector buffer = readBinaryFile(sname, "Update Detector Server"); + const std::string filename = getFileNameFromFilePath(sname); pimpl->Parallel(&Module::updateDetectorServer, pos, buffer, filename); programFPGA(fname, false, pos); } @@ -2882,7 +2881,7 @@ Result Detector::getMeasurementTime(Positions pos) const { } std::vector Detector::getValidPortNumbers(uint16_t start_port) { - int num_sockets_per_detector = getNumberofUDPInterfaces({}).tsquash( + const int num_sockets_per_detector = getNumberofUDPInterfaces({}).tsquash( "Number of UDP Interfaces is not consistent among modules"); validatePortRange(start_port, size() * num_sockets_per_detector); @@ -2890,7 +2889,7 @@ std::vector Detector::getValidPortNumbers(uint16_t start_port) { std::vector res; res.reserve(size()); for (int idet = 0; idet < size(); ++idet) { - uint16_t port = start_port + (idet * num_sockets_per_detector); + const uint16_t port = start_port + (idet * num_sockets_per_detector); res.push_back(port); } return res; diff --git a/slsDetectorSoftware/src/DetectorImpl.cpp b/slsDetectorSoftware/src/DetectorImpl.cpp index fceba4cb8..d8e4f4772 100644 --- a/slsDetectorSoftware/src/DetectorImpl.cpp +++ b/slsDetectorSoftware/src/DetectorImpl.cpp @@ -198,11 +198,11 @@ void DetectorImpl::setHostname(const std::vector &name) { void DetectorImpl::addModule(const std::string &name) { LOG(logINFO) << "Adding module " << name; auto host = verifyUniqueDetHost(name); - std::string hostname = host.first; - uint16_t port = host.second; + std::string const hostname = host.first; + uint16_t const port = host.second; // get type by connecting - detectorType type = Module::getTypeFromDetector(hostname, port); + detectorType const type = Module::getTypeFromDetector(hostname, port); // gotthard2 cannot have more than 2 modules (50um=1, 25um=2 if (type == GOTTHARD2 && modules.size() > 2) { @@ -227,7 +227,7 @@ void DetectorImpl::addModule(const std::string &name) { modules[pos]->updateNumberofUDPInterfaces(); // update zmq port in case numudpinterfaces changed - int numInterfaces = modules[pos]->getNumberofUDPInterfacesFromShm(); + int const numInterfaces = modules[pos]->getNumberofUDPInterfacesFromShm(); modules[pos]->setClientStreamingPort(DEFAULT_ZMQ_CL_PORTNO + pos * numInterfaces); } @@ -245,7 +245,7 @@ void DetectorImpl::updateDetectorSize() { int nModx = 0, nMody = 0; // 1d, add modules along x axis if (modSize.y == 1) { - int detSizeX = shm()->numberOfChannels.x; + int const detSizeX = shm()->numberOfChannels.x; int maxChanX = modSize.x * size(); // user given detsizex used only within max value if (detSizeX > 1 && detSizeX <= maxChanX) { @@ -271,7 +271,7 @@ void DetectorImpl::updateDetectorSize() { } // 2d, add modules along y axis (due to eiger top/bottom) else { - int detSizeY = shm()->numberOfChannels.y; + int const detSizeY = shm()->numberOfChannels.y; int maxChanY = modSize.y * size(); // user given detsizey used only within max value if (detSizeY > 1 && detSizeY <= maxChanY) { @@ -467,7 +467,7 @@ void DetectorImpl::createReceivingDataSockets() { if (shm()->detType == GOTTHARD2) { numUDPInterfaces = 1; } - size_t numSockets = modules.size() * numUDPInterfaces; + size_t const numSockets = modules.size() * numUDPInterfaces; for (size_t iSocket = 0; iSocket < numSockets; ++iSocket) { uint32_t portnum = @@ -481,7 +481,7 @@ void DetectorImpl::createReceivingDataSockets() { .c_str(), portnum)); // set high water mark - int hwm = shm()->zmqHwm; + int const hwm = shm()->zmqHwm; if (hwm >= 0) { zmqSocket[iSocket]->SetReceiveHighWaterMark(hwm); // need not reconnect. cannot be connected (detector idle) @@ -504,7 +504,7 @@ void DetectorImpl::createReceivingDataSockets() { void DetectorImpl::readFrameFromReceiver() { - bool gapPixels = shm()->gapPixels; + bool const gapPixels = shm()->gapPixels; LOG(logDEBUG) << "Gap pixels: " << gapPixels; int nX = 0; int nY = 0; @@ -644,10 +644,10 @@ void DetectorImpl::readFrameFromReceiver() { // creating multi image { - uint32_t xoffset = coordX * nPixelsX * bytesPerPixel; - uint32_t yoffset = coordY * nPixelsY; + uint32_t const xoffset = coordX * nPixelsX * bytesPerPixel; + uint32_t const yoffset = coordY * nPixelsY; uint32_t singledetrowoffset = nPixelsX * bytesPerPixel; - uint32_t rowoffset = nX * singledetrowoffset; + uint32_t const rowoffset = nX * singledetrowoffset; if (shm()->detType == CHIPTESTBOARD || shm()->detType == defs::XILINX_CHIPTESTBOARD) { singledetrowoffset = size; @@ -694,7 +694,7 @@ void DetectorImpl::readFrameFromReceiver() { int nDetActualPixelsY = nDetPixelsY; if (gapPixels) { - int n = insertGapPixels(multiframe.get(), multigappixels, + int const n = insertGapPixels(multiframe.get(), multigappixels, quadEnable, dynamicRange, nDetActualPixelsX, nDetActualPixelsY); callbackImage = multigappixels; @@ -742,38 +742,38 @@ int DetectorImpl::insertGapPixels(char *image, char *&gpImage, bool quadEnable, << "\n\t quadEnable: " << quadEnable << "\n\t dr: " << dr; // inter module gap pixels - int modGapPixelsx = 8; - int modGapPixelsy = 36; + int const modGapPixelsx = 8; + int const modGapPixelsy = 36; // inter chip gap pixels - int chipGapPixelsx = 2; - int chipGapPixelsy = 2; + int const chipGapPixelsx = 2; + int const chipGapPixelsy = 2; // number of pixels in a chip - int nChipPixelsx = 256; - int nChipPixelsy = 256; + int const nChipPixelsx = 256; + int const nChipPixelsy = 256; // 1 module // number of chips in a module int nMod1Chipx = 4; - int nMod1Chipy = 2; + int const nMod1Chipy = 2; if (quadEnable) { nMod1Chipx = 2; } // number of pixels in a module - int nMod1Pixelsx = nChipPixelsx * nMod1Chipx; - int nMod1Pixelsy = nChipPixelsy * nMod1Chipy; + int const nMod1Pixelsx = nChipPixelsx * nMod1Chipx; + int const nMod1Pixelsy = nChipPixelsy * nMod1Chipy; // number of gap pixels in a module - int nMod1GapPixelsx = (nMod1Chipx - 1) * chipGapPixelsx; - int nMod1GapPixelsy = (nMod1Chipy - 1) * chipGapPixelsy; + int const nMod1GapPixelsx = (nMod1Chipx - 1) * chipGapPixelsx; + int const nMod1GapPixelsy = (nMod1Chipy - 1) * chipGapPixelsy; // total number of modules - int nModx = nPixelsx / nMod1Pixelsx; - int nMody = nPixelsy / nMod1Pixelsy; + int const nModx = nPixelsx / nMod1Pixelsx; + int const nMody = nPixelsy / nMod1Pixelsy; // check if not full modules // (setting gap pixels and then adding half module or disabling quad) if (nPixelsy / nMod1Pixelsy == 0) { LOG(logERROR) << "Gap pixels can only be enabled with full modules. " "Sending dummy data without gap pixels.\n"; - double bytesPerPixel = (double)dr / 8.00; - int imagesize = nPixelsy * nPixelsx * bytesPerPixel; + double const bytesPerPixel = (double)dr / 8.00; + int const imagesize = nPixelsy * nPixelsx * bytesPerPixel; if (gpImage == nullptr) { gpImage = new char[imagesize]; } @@ -782,28 +782,28 @@ int DetectorImpl::insertGapPixels(char *image, char *&gpImage, bool quadEnable, } // total number of pixels - int nTotx = + int const nTotx = nPixelsx + (nMod1GapPixelsx * nModx) + (modGapPixelsx * (nModx - 1)); - int nToty = + int const nToty = nPixelsy + (nMod1GapPixelsy * nMody) + (modGapPixelsy * (nMody - 1)); // total number of chips - int nChipx = nPixelsx / nChipPixelsx; - int nChipy = nPixelsy / nChipPixelsy; + int const nChipx = nPixelsx / nChipPixelsx; + int const nChipy = nPixelsy / nChipPixelsy; - double bytesPerPixel = (double)dr / 8.00; - int imagesize = nTotx * nToty * bytesPerPixel; + double const bytesPerPixel = (double)dr / 8.00; + int const imagesize = nTotx * nToty * bytesPerPixel; - int nChipBytesx = nChipPixelsx * bytesPerPixel; // 1 chip bytes in x - int nChipGapBytesx = chipGapPixelsx * bytesPerPixel; // 2 pixel bytes - int nModGapBytesx = modGapPixelsx * bytesPerPixel; // 8 pixel bytes - int nChipBytesy = nChipPixelsy * nTotx * bytesPerPixel; // 1 chip bytes in y - int nChipGapBytesy = chipGapPixelsy * nTotx * bytesPerPixel; // 2 lines - int nModGapBytesy = modGapPixelsy * nTotx * + int const nChipBytesx = nChipPixelsx * bytesPerPixel; // 1 chip bytes in x + int const nChipGapBytesx = chipGapPixelsx * bytesPerPixel; // 2 pixel bytes + int const nModGapBytesx = modGapPixelsx * bytesPerPixel; // 8 pixel bytes + int const nChipBytesy = nChipPixelsy * nTotx * bytesPerPixel; // 1 chip bytes in y + int const nChipGapBytesy = chipGapPixelsy * nTotx * bytesPerPixel; // 2 lines + int const nModGapBytesy = modGapPixelsy * nTotx * bytesPerPixel; // 36 lines // 4 bit mode, its 1 byte (because for 4 // bit mode, we handle 1 byte at a time) - int pixel1 = (int)(ceil(bytesPerPixel)); - int row1Bytes = nTotx * bytesPerPixel; + int const pixel1 = (int)(ceil(bytesPerPixel)); + int const row1Bytes = nTotx * bytesPerPixel; int nMod1TotPixelsx = nMod1Pixelsx + nMod1GapPixelsx; if (dr == 4) { nMod1TotPixelsx /= 2; @@ -811,7 +811,7 @@ int DetectorImpl::insertGapPixels(char *image, char *&gpImage, bool quadEnable, // eiger requires inter chip gap pixels are halved // jungfrau/moench prefers same inter chip gap pixels as the boundary pixels int divisionValue = 2; - slsDetectorDefs::detectorType detType = shm()->detType; + slsDetectorDefs::detectorType const detType = shm()->detType; if (detType == JUNGFRAU || detType == MOENCH) { divisionValue = 1; } @@ -1053,7 +1053,7 @@ int DetectorImpl::getClientStreamingHwm() const { for (auto &it : zmqSocket) { result.push_back(it->GetReceiveHighWaterMark()); } - int res = result.tsquash("Inconsistent zmq receive hwm values"); + int const res = result.tsquash("Inconsistent zmq receive hwm values"); return res; } @@ -1110,7 +1110,7 @@ int DetectorImpl::acquire() { struct timespec begin, end; clock_gettime(CLOCK_REALTIME, &begin); - bool receiver = Parallel(&Module::getUseReceiverFlag, {}).squash(false); + bool const receiver = Parallel(&Module::getUseReceiverFlag, {}).squash(false); if (dataReady == nullptr) { setJoinThreadFlag(false); @@ -1172,7 +1172,7 @@ int DetectorImpl::acquire() { // progress auto a = Parallel(&Module::getReceiverProgress, {}); - double progress = (*std::max_element(a.begin(), a.end())); + double const progress = (*std::max_element(a.begin(), a.end())); // callback acquisition_finished(progress, static_cast(status), @@ -1340,7 +1340,7 @@ void DetectorImpl::processData(bool receiver) { } } // get and print progress - double temp = + double const temp = (double)Parallel(&Module::getReceiverProgress, {0}) .squash(); if (temp != progress) { @@ -1365,12 +1365,12 @@ void DetectorImpl::processData(bool receiver) { } bool DetectorImpl::getJoinThreadFlag() const { - std::lock_guard lock(mp); + std::lock_guard const lock(mp); return jointhread; } void DetectorImpl::setJoinThreadFlag(bool value) { - std::lock_guard lock(mp); + std::lock_guard const lock(mp); jointhread = value; } @@ -1430,11 +1430,11 @@ std::vector DetectorImpl::readProgrammingFile(const std::string &fname) { } // get srcSize to print progress - ssize_t srcSize = getFileSize(src, "Program FPGA"); + ssize_t const srcSize = getFileSize(src, "Program FPGA"); // create temp destination file char destfname[] = "/tmp/SLS_DET_MCB.XXXXXX"; - int dst = mkstemp(destfname); // create temporary file and open it in r/w + int const dst = mkstemp(destfname); // create temporary file and open it in r/w if (dst == -1) { fclose(src); throw RuntimeError(std::string("Could not create destination file " @@ -1466,7 +1466,7 @@ std::vector DetectorImpl::readProgrammingFile(const std::string &fname) { int oldProgress = 0; while (!feof(src)) { // print progress - int progress = (int)(((double)(dstFilePos) / srcSize) * 100); + int const progress = (int)(((double)(dstFilePos) / srcSize) * 100); if (oldProgress != progress) { printf("%d%%\r", progress); fflush(stdout); @@ -1477,7 +1477,7 @@ std::vector DetectorImpl::readProgrammingFile(const std::string &fname) { break; } // read source - int s = fgetc(src); + int const s = fgetc(src); if (s < 0) { break; } @@ -1547,13 +1547,13 @@ DetectorImpl::verifyUniqueDetHost(const std::string &name) { // extract port // C++17 could be auto [hostname, port] = ParseHostPort(name); auto res = ParseHostPort(name); - std::string hostname = res.first; + std::string const hostname = res.first; uint16_t port = res.second; if (port == 0) { port = DEFAULT_TCP_CNTRL_PORTNO; } - int detSize = size(); + int const detSize = size(); // mod not yet added std::vector> hosts(detSize + 1); hosts[detSize].first = hostname; @@ -1573,8 +1573,8 @@ DetectorImpl::verifyUniqueRxHost(const std::string &name, // extract port // C++17 could be auto [hostname, port] = ParseHostPort(name); auto res = ParseHostPort(name); - std::string hostname = res.first; - uint16_t port = res.second; + std::string const hostname = res.first; + uint16_t const port = res.second; // hostname and port for given positions if (positions.empty() || (positions.size() == 1 && positions[0] == -1)) { @@ -1669,7 +1669,7 @@ void DetectorImpl::validateROIs(const std::vector &rois) { if (roi.noRoi()) { throw RuntimeError("Invalid Roi of size 0. Roi: " + ToString(roi)); } - bool is2D = (modules[0]->getNumberOfChannels().y > 1 ? true : false); + bool const is2D = (modules[0]->getNumberOfChannels().y > 1 ? true : false); if (roi.completeRoi()) { std::ostringstream oss; oss << "Did you mean the clear roi command (API: clearRxROI, cmd: " @@ -1730,9 +1730,9 @@ defs::xy DetectorImpl::getPortGeometry() const { } defs::xy DetectorImpl::calculatePosition(int moduleIndex) const { - int maxYMods = shm()->numberOfModules.y; - int y = (moduleIndex % maxYMods); - int x = (moduleIndex / maxYMods); + int const maxYMods = shm()->numberOfModules.y; + int const y = (moduleIndex % maxYMods); + int const x = (moduleIndex / maxYMods); return defs::xy{x, y}; } @@ -1771,13 +1771,13 @@ void DetectorImpl::convertGlobalRoiToPortLevel( defs::ROI portRoi = moduleRoi; // Recalculate port ROI boundaries (split vertically or horizontally) if (portGeometry.x == 2) { - int midX = (moduleRoi.xmin + moduleRoi.xmax) / 2; + int const midX = (moduleRoi.xmin + moduleRoi.xmax) / 2; if (port == 0) portRoi.xmax = midX; else portRoi.xmin = midX + 1; } else if (portGeometry.y == 2) { - int midY = (moduleRoi.ymin + moduleRoi.ymax) / 2; + int const midY = (moduleRoi.ymin + moduleRoi.ymax) / 2; if (port == 0) portRoi.ymax = midY; else @@ -1823,7 +1823,7 @@ void DetectorImpl::setRxROI(const std::vector &args) { } validateROIs(args); - int nPortsPerModule = + int const nPortsPerModule = Parallel(&Module::getNumberofUDPInterfacesFromShm, {}) .tsquash("Inconsistent number of udp ports set up per module"); @@ -1845,7 +1845,7 @@ void DetectorImpl::setRxROI(const std::vector &args) { } void DetectorImpl::clearRxROI() { - int nPortsPerModule = + int const nPortsPerModule = Parallel(&Module::getNumberofUDPInterfacesFromShm, {}) .tsquash("Inconsistent number of udp ports set up per module"); for (size_t iModule = 0; iModule < modules.size(); ++iModule) { @@ -1890,7 +1890,7 @@ void DetectorImpl::getBadChannels(const std::string &fname, } void DetectorImpl::setBadChannels(const std::string &fname, Positions pos) { - std::vector list = sls::getChannelsFromFile(fname); + std::vector const list = sls::getChannelsFromFile(fname); if (list.empty()) { throw RuntimeError("Bad channel file is empty."); } @@ -1913,8 +1913,8 @@ void DetectorImpl::setBadChannels(const std::vector list, Positions pos) { std::to_string(badchannel) + " out of bounds."); } - int ch = badchannel % nchan; - size_t imod = badchannel / nchan; + int const ch = badchannel % nchan; + size_t const imod = badchannel / nchan; if (imod >= modules.size()) { throw RuntimeError("Invalid bad channel list. " + std::to_string(badchannel) + diff --git a/slsDetectorSoftware/src/DetectorImpl.h b/slsDetectorSoftware/src/DetectorImpl.h index fddccfe2f..12839669c 100644 --- a/slsDetectorSoftware/src/DetectorImpl.h +++ b/slsDetectorSoftware/src/DetectorImpl.h @@ -90,7 +90,7 @@ class DetectorImpl : public virtual slsDetectorDefs { } std::vector> futures; futures.reserve(positions.size()); - for (size_t i : positions) { + for (const size_t i : positions) { if (i >= modules.size()) throw RuntimeError("Module out of range"); futures.push_back(std::async(std::launch::async, somefunc, @@ -118,7 +118,7 @@ class DetectorImpl : public virtual slsDetectorDefs { } std::vector> futures; futures.reserve(positions.size()); - for (size_t i : positions) { + for (const size_t i : positions) { if (i >= modules.size()) throw RuntimeError("Module out of range"); futures.push_back(std::async(std::launch::async, somefunc, @@ -145,7 +145,7 @@ class DetectorImpl : public virtual slsDetectorDefs { } std::vector> futures; futures.reserve(positions.size()); - for (size_t i : positions) { + for (const size_t i : positions) { if (i >= modules.size()) throw RuntimeError("Module out of range"); futures.push_back(std::async(std::launch::async, somefunc, @@ -170,7 +170,7 @@ class DetectorImpl : public virtual slsDetectorDefs { } std::vector> futures; futures.reserve(positions.size()); - for (size_t i : positions) { + for (const size_t i : positions) { if (i >= modules.size()) throw RuntimeError("Module out of range"); futures.push_back(std::async(std::launch::async, somefunc, diff --git a/slsDetectorSoftware/src/Module.cpp b/slsDetectorSoftware/src/Module.cpp index 8cde3f072..75a4d22a3 100644 --- a/slsDetectorSoftware/src/Module.cpp +++ b/slsDetectorSoftware/src/Module.cpp @@ -86,7 +86,7 @@ std::string Module::getControlServerLongVersion() const { } // throw with old server version (sends 8 bytes) catch (RuntimeError &e) { - std::string emsg = std::string(e.what()); + std::string const emsg = std::string(e.what()); if (emsg.find(F_GET_SERVER_VERSION) && emsg.find("8 bytes")) { throwDeprecatedServerVersion(); } @@ -95,7 +95,7 @@ std::string Module::getControlServerLongVersion() const { } void Module::throwDeprecatedServerVersion() const { - uint64_t res = sendToDetectorStop(F_GET_SERVER_VERSION); + uint64_t const res = sendToDetectorStop(F_GET_SERVER_VERSION); std::cout << std::endl; std::ostringstream os; os << "Detector Server (Control) version (0x" << std::hex << res @@ -110,7 +110,7 @@ std::string Module::getStopServerLongVersion() const { } std::string Module::getDetectorServerVersion() const { - Version v(getControlServerLongVersion()); + Version const v(getControlServerLongVersion()); return v.concise(); } @@ -139,7 +139,7 @@ std::string Module::getReceiverLongVersion() const { } std::string Module::getReceiverSoftwareVersion() const { - Version v(getReceiverLongVersion()); + Version const v(getReceiverLongVersion()); return v.concise(); } @@ -183,7 +183,7 @@ slsDetectorDefs::xy Module::getNumberOfChannels() const { void Module::updateNumberOfModule(slsDetectorDefs::xy det) { shm()->numberOfModule = det; - int args[2] = {shm()->numberOfModule.y, moduleIndex}; + int const args[2] = {shm()->numberOfModule.y, moduleIndex}; sendToDetector(F_SET_POSITION, args, nullptr); } @@ -218,14 +218,14 @@ void Module::setThresholdEnergy(int e_eV, detectorSettings isettings, throw RuntimeError("This energy " + std::to_string(e_eV) + " not defined for this module!"); } - bool interpolate = + bool const interpolate = std::all_of(shm()->trimEnergies.begin(), shm()->trimEnergies.end(), [e_eV](const int &e) { return e != e_eV; }); sls_detector_module myMod{shm()->detType}; if (!interpolate) { - std::string settingsfname = getTrimbitFilename(isettings, e_eV); + std::string const settingsfname = getTrimbitFilename(isettings, e_eV); LOG(logDEBUG1) << "Settings File is " << settingsfname; myMod = readSettingsFile(settingsfname, trimbits); } else { @@ -238,8 +238,8 @@ void Module::setThresholdEnergy(int e_eV, detectorSettings isettings, break; } } - std::string settingsfname1 = getTrimbitFilename(isettings, trim1); - std::string settingsfname2 = getTrimbitFilename(isettings, trim2); + std::string const settingsfname1 = getTrimbitFilename(isettings, trim1); + std::string const settingsfname2 = getTrimbitFilename(isettings, trim2); LOG(logDEBUG1) << "Settings Files are " << settingsfname1 << " and " << settingsfname2; auto myMod1 = readSettingsFile(settingsfname1, trimbits); @@ -291,17 +291,17 @@ void Module::setAllThresholdEnergy(std::array e_eV, std::vector myMods; for (size_t i = 0; i < energy.size(); ++i) { if (energy[i] == -1) { - sls_detector_module mod = getModule(); + sls_detector_module const mod = getModule(); myMods.push_back(mod); continue; } - sls_detector_module mod{shm()->detType}; + sls_detector_module const mod{shm()->detType}; myMods.push_back(mod); // don't interpolate if (shm()->trimEnergies.anyEqualTo(energy[i])) { - std::string settingsfname = + std::string const settingsfname = getTrimbitFilename(isettings, energy[i]); LOG(logDEBUG1) << "Settings File is " << settingsfname; myMods[i] = readSettingsFile(settingsfname, trimbits); @@ -335,8 +335,8 @@ void Module::setAllThresholdEnergy(std::array e_eV, LOG(logINFO) << "e_eV:" << energy[i] << " [" << trim1 << ", " << trim2 << "]"; - std::string settingsfname1 = getTrimbitFilename(isettings, trim1); - std::string settingsfname2 = getTrimbitFilename(isettings, trim2); + std::string const settingsfname1 = getTrimbitFilename(isettings, trim1); + std::string const settingsfname2 = getTrimbitFilename(isettings, trim2); LOG(logDEBUG1) << "Settings Files are " << settingsfname1 << " and " << settingsfname2; auto myMod1 = readSettingsFile(settingsfname1, trimbits); @@ -755,17 +755,17 @@ int Module::getClockDivider(int clkIndex) const { } void Module::setClockDivider(int clkIndex, int value) { - int args[]{clkIndex, value}; + int const args[]{clkIndex, value}; sendToDetector(F_SET_CLOCK_DIVIDER, args, nullptr); } int Module::getClockPhase(int clkIndex, bool inDegrees) const { - int args[]{clkIndex, static_cast(inDegrees)}; + int const args[]{clkIndex, static_cast(inDegrees)}; return sendToDetector(F_GET_CLOCK_PHASE, args); } void Module::setClockPhase(int clkIndex, int value, bool inDegrees) { - int args[]{clkIndex, value, static_cast(inDegrees)}; + int const args[]{clkIndex, value, static_cast(inDegrees)}; sendToDetector(F_SET_CLOCK_PHASE, args, nullptr); } @@ -778,22 +778,22 @@ int Module::getClockFrequency(int clkIndex) const { } void Module::setClockFrequency(int clkIndex, int value) { - int args[]{clkIndex, value}; + int const args[]{clkIndex, value}; sendToDetector(F_SET_CLOCK_FREQUENCY, args, nullptr); } int Module::getDAC(dacIndex index, bool mV) const { - int args[]{static_cast(index), static_cast(mV), GET_FLAG}; + int const args[]{static_cast(index), static_cast(mV), GET_FLAG}; return sendToDetector(F_SET_DAC, args); } int Module::getDefaultDac(slsDetectorDefs::dacIndex index, slsDetectorDefs::detectorSettings sett) { - int args[]{static_cast(index), static_cast(sett)}; + int const args[]{static_cast(index), static_cast(sett)}; return sendToDetector(F_GET_DEFAULT_DAC, args); } void Module::setDefaultDac(slsDetectorDefs::dacIndex index, int defaultValue, defs::detectorSettings sett) { - int args[]{static_cast(index), static_cast(sett), defaultValue}; + int const args[]{static_cast(index), static_cast(sett), defaultValue}; return sendToDetector(F_SET_DEFAULT_DAC, args, nullptr); } @@ -803,7 +803,7 @@ void Module::resetToDefaultDacs(const bool hardReset) { } void Module::setDAC(int val, dacIndex index, bool mV) { - int args[]{static_cast(index), static_cast(mV), val}; + int const args[]{static_cast(index), static_cast(mV), val}; sendToDetector(F_SET_DAC, args); } @@ -844,13 +844,13 @@ int Module::getADC(dacIndex index) const { } int Module::getOnChipDAC(slsDetectorDefs::dacIndex index, int chipIndex) const { - int args[]{static_cast(index), chipIndex}; + int const args[]{static_cast(index), chipIndex}; return sendToDetector(F_GET_ON_CHIP_DAC, args); } void Module::setOnChipDAC(slsDetectorDefs::dacIndex index, int chipIndex, int value) { - int args[]{static_cast(index), chipIndex, value}; + int const args[]{static_cast(index), chipIndex, value}; sendToDetector(F_SET_ON_CHIP_DAC, args, nullptr); } @@ -861,7 +861,7 @@ Module::getExternalSignalFlags(int signalIndex) const { } void Module::setExternalSignalFlags(int signalIndex, externalSignalFlag type) { - int args[]{signalIndex, static_cast(type)}; + int const args[]{signalIndex, static_cast(type)}; sendToDetector(F_SET_EXTERNAL_SIGNAL_FLAG, args, nullptr); } @@ -1483,7 +1483,7 @@ void Module::setPartialFramesPadding(bool padding) { } int Module::getReceiverUDPSocketBufferSize() const { - int arg = GET_FLAG; + int const arg = GET_FLAG; return sendToReceiver(F_RECEIVER_UDP_SOCK_BUF_SIZE, arg); } @@ -1809,7 +1809,7 @@ int64_t Module::getRateCorrection() const { } void Module::setDefaultRateCorrection() { - int64_t arg = -1; + int64_t const arg = -1; sendToDetector(F_SET_RATE_CORRECT, arg, nullptr); } @@ -1860,7 +1860,7 @@ bool Module::getActivate() const { } void Module::setActivate(const bool enable) { - int arg = static_cast(enable); + int const arg = static_cast(enable); auto retval = sendToDetector(F_ACTIVATE, arg); sendToDetectorStop(F_ACTIVATE, arg); if (shm()->useReceiverFlag) { @@ -1894,7 +1894,7 @@ void Module::pulseChip(int n_pulses) { bool Module::getQuad() const { return sendToDetector(F_GET_QUAD) != 0; } void Module::setQuad(const bool enable) { - int value = enable ? 1 : 0; + int const value = enable ? 1 : 0; sendToDetector(F_SET_QUAD, value, nullptr); if (shm()->useReceiverFlag) { sendToReceiver(F_SET_RECEIVER_QUAD, value, nullptr); @@ -1906,7 +1906,7 @@ bool Module::getDataStream(const portPosition port) const { } void Module::setDataStream(const portPosition port, const bool enable) { - int args[]{static_cast(port), static_cast(enable)}; + int const args[]{static_cast(port), static_cast(enable)}; sendToDetector(F_SET_DATASTREAM, args, nullptr); if (shm()->useReceiverFlag) { sendToReceiver(F_RECEIVER_SET_DATASTREAM, args, nullptr); @@ -2076,7 +2076,7 @@ std::array Module::getInjectChannel() const { void Module::setInjectChannel(const int offsetChannel, const int incrementChannel) { - int args[]{offsetChannel, incrementChannel}; + int const args[]{offsetChannel, incrementChannel}; sendToDetector(F_SET_INJECT_CHANNEL, args, nullptr); } @@ -2331,18 +2331,18 @@ slsDetectorDefs::vetoAlgorithm Module::getVetoAlgorithm( void Module::setVetoAlgorithm( const slsDetectorDefs::vetoAlgorithm alg, const slsDetectorDefs::streamingInterface interface) { - int args[]{static_cast(alg), static_cast(interface)}; + int const args[]{static_cast(alg), static_cast(interface)}; sendToDetector(F_SET_VETO_ALGORITHM, args, nullptr); } int Module::getADCConfiguration(const int chipIndex, const int adcIndex) const { - int args[]{chipIndex, adcIndex}; + int const args[]{chipIndex, adcIndex}; return sendToDetector(F_GET_ADC_CONFIGURATION, args); } void Module::setADCConfiguration(const int chipIndex, const int adcIndex, int value) { - int args[]{chipIndex, adcIndex, value}; + int const args[]{chipIndex, adcIndex, value}; sendToDetector(F_SET_ADC_CONFIGURATION, args, nullptr); } @@ -2417,7 +2417,7 @@ bool Module::getInterpolation() const { void Module::setInterpolation(const bool enable) { sendToDetector(F_SET_INTERPOLATION, static_cast(enable), nullptr); - int mask = getCounterMask(); + int const mask = getCounterMask(); if (shm()->useReceiverFlag) { sendToReceiver(F_RECEIVER_SET_COUNTER_MASK, mask, nullptr); } @@ -2578,7 +2578,7 @@ void Module::setReceiverDbitList(std::vector list) { if(r) LOG(logWARNING) << "Removed duplicated from receiver dbit list"; - StaticVector arg = list; + StaticVector const arg = list; sendToReceiver(F_SET_RECEIVER_DBIT_LIST, arg, nullptr); } @@ -2600,7 +2600,7 @@ void Module::setReceiverDbitReorder(bool reorder) { } void Module::setDigitalIODelay(uint64_t pinMask, int delay) { - uint64_t args[]{pinMask, static_cast(delay)}; + uint64_t const args[]{pinMask, static_cast(delay)}; sendToDetector(F_DIGITAL_IO_DELAY, args, nullptr); } @@ -2657,57 +2657,57 @@ void Module::setPatternIOControl(uint64_t word) { } uint64_t Module::getPatternWord(int addr) const { - uint64_t args[]{static_cast(addr), + uint64_t const args[]{static_cast(addr), static_cast(GET_FLAG)}; return sendToDetector(F_SET_PATTERN_WORD, args); } void Module::setPatternWord(int addr, uint64_t word) { - uint64_t args[]{static_cast(addr), word}; + uint64_t const args[]{static_cast(addr), word}; sendToDetector(F_SET_PATTERN_WORD, args); } std::array Module::getPatternLoopAddresses(int level) const { - int args[]{level, GET_FLAG, GET_FLAG}; + int const args[]{level, GET_FLAG, GET_FLAG}; std::array retvals{}; sendToDetector(F_SET_PATTERN_LOOP_ADDRESSES, args, retvals); return retvals; } void Module::setPatternLoopAddresses(int level, int start, int stop) { - int args[]{level, start, stop}; + int const args[]{level, start, stop}; std::array retvals{}; sendToDetector(F_SET_PATTERN_LOOP_ADDRESSES, args, retvals); } int Module::getPatternLoopCycles(int level) const { - int args[]{level, GET_FLAG}; + int const args[]{level, GET_FLAG}; return sendToDetector(F_SET_PATTERN_LOOP_CYCLES, args); } void Module::setPatternLoopCycles(int level, int n) { - int args[]{level, n}; + int const args[]{level, n}; sendToDetector(F_SET_PATTERN_LOOP_CYCLES, args); } int Module::getPatternWaitAddr(int level) const { - int args[]{level, GET_FLAG}; + int const args[]{level, GET_FLAG}; return sendToDetector(F_SET_PATTERN_WAIT_ADDR, args); } void Module::setPatternWaitAddr(int level, int addr) { - int args[]{level, addr}; + int const args[]{level, addr}; sendToDetector(F_SET_PATTERN_WAIT_ADDR, args); } uint64_t Module::getPatternWaitClocks(int level) const { - uint64_t args[]{static_cast(level), + uint64_t const args[]{static_cast(level), static_cast(GET_FLAG)}; return sendToDetector(F_SET_PATTERN_WAIT_CLOCKS, args); } void Module::setPatternWaitClocks(int level, uint64_t t) { - uint64_t args[]{static_cast(level), t}; + uint64_t const args[]{static_cast(level), t}; sendToDetector(F_SET_PATTERN_WAIT_CLOCKS, args); } @@ -2715,7 +2715,7 @@ uint64_t Module::getPatternWaitInterval(int level) const { return sendToDetector(F_GET_PATTERN_WAIT_INTERVAL, level); } void Module::setPatternWaitInterval(int level, uint64_t t) { - uint64_t args[]{static_cast(level), t}; + uint64_t const args[]{static_cast(level), t}; sendToDetector(F_SET_PATTERN_WAIT_INTERVAL, args, nullptr); } @@ -2919,24 +2919,24 @@ uint32_t Module::readRegister(uint32_t addr) const { } void Module::writeRegister(uint32_t addr, uint32_t val, bool validate) { - uint32_t args[]{addr, val, static_cast(validate)}; + uint32_t const args[]{addr, val, static_cast(validate)}; return sendToDetectorStop(F_WRITE_REGISTER, args, nullptr); } void Module::setBit(uint32_t addr, int n, bool validate) { - uint32_t args[] = {addr, static_cast(n), + uint32_t const args[] = {addr, static_cast(n), static_cast(validate)}; sendToDetectorStop(F_SET_BIT, args, nullptr); } void Module::clearBit(uint32_t addr, int n, bool validate) { - uint32_t args[] = {addr, static_cast(n), + uint32_t const args[] = {addr, static_cast(n), static_cast(validate)}; sendToDetectorStop(F_CLEAR_BIT, args, nullptr); } int Module::getBit(uint32_t addr, int n) { - uint32_t args[2] = {addr, static_cast(n)}; + uint32_t const args[2] = {addr, static_cast(n)}; return sendToDetectorStop(F_GET_BIT, args); } @@ -2945,7 +2945,7 @@ void Module::executeFirmwareTest() { sendToDetector(F_SET_FIRMWARE_TEST); } void Module::executeBusTest() { sendToDetector(F_SET_BUS_TEST); } void Module::writeAdcRegister(uint32_t addr, uint32_t val) { - uint32_t args[]{addr, val}; + uint32_t const args[]{addr, val}; sendToDetector(F_WRITE_ADC_REG, args, nullptr); } @@ -3449,7 +3449,7 @@ void Module::initializeModuleStructure(detectorType type) { shm()->stoppedFlag = false; // get the Module parameters based on type - detParameters parameters{type}; + detParameters const parameters{type}; shm()->nChan.x = parameters.nChanX; shm()->nChan.y = parameters.nChanY; shm()->nChip.x = parameters.nChipX; @@ -3463,12 +3463,12 @@ void Module::initialDetectorServerChecks() { } void Module::checkDetectorVersionCompatibility() { - std::string detServers[2] = {getControlServerLongVersion(), + std::string const detServers[2] = {getControlServerLongVersion(), getStopServerLongVersion()}; for (int i = 0; i != 2; ++i) { // det and client (sem. versioning) - Version det(detServers[i]); - Version client(APILIB); + Version const det(detServers[i]); + Version const client(APILIB); if (det.hasSemanticVersioning() && client.hasSemanticVersioning()) { if (!det.isBackwardCompatible(client)) { std::ostringstream oss; @@ -3482,7 +3482,7 @@ void Module::checkDetectorVersionCompatibility() { } // comparing dates(exact match to expected) else { - Version expectedDetector(getDetectorAPI()); + Version const expectedDetector(getDetectorAPI()); if (det != expectedDetector) { std::ostringstream oss; oss << "Detector (" << (i == 0 ? "Control" : "Stop") @@ -3521,8 +3521,8 @@ const std::string Module::getDetectorAPI() const { void Module::checkReceiverVersionCompatibility() { // rxr and client (sem. versioning) - Version rxr(getReceiverLongVersion()); - Version client(APILIB); + Version const rxr(getReceiverLongVersion()); + Version const client(APILIB); if (rxr.hasSemanticVersioning() && client.hasSemanticVersioning()) { if (!rxr.isBackwardCompatible(client)) { std::ostringstream oss; @@ -3535,7 +3535,7 @@ void Module::checkReceiverVersionCompatibility() { } // comparing dates(exact match to expected) else { - Version expectedReceiver(APIRECEIVER); + Version const expectedReceiver(APIRECEIVER); if (rxr != expectedReceiver) { std::ostringstream oss; oss << "Receiver version (" << rxr.getDate() @@ -3666,7 +3666,7 @@ void Module::sendModule(sls_detector_module *myMod, ClientSocket &client) { ts += n; LOG(level) << "channels sent. " << n << " bytes"; - int expectedBytesSent = sizeof(sls_detector_module) - sizeof(myMod->dacs) - + int const expectedBytesSent = sizeof(sls_detector_module) - sizeof(myMod->dacs) - sizeof(myMod->chanregs) + (myMod->ndac * sizeof(int)) + (myMod->nchan * sizeof(int)); @@ -3732,7 +3732,7 @@ sls_detector_module Module::interpolateTrim(sls_detector_module *a, "Interpolation of Trim values not implemented for this detector!"); } - sls_detector_module myMod{shm()->detType}; + sls_detector_module const myMod{shm()->detType}; // create copy and interpolate dac lists std::vector dacs_to_copy, dacs_to_interpolate; @@ -3878,7 +3878,7 @@ sls_detector_module Module::readSettingsFile(const std::string &fname, // mythen3 (dacs, trimbits) else if (shm()->detType == MYTHEN3) { - int expected_size = sizeof(int) * myMod.ndac + + int const expected_size = sizeof(int) * myMod.ndac + sizeof(int) * myMod.nchan + sizeof(myMod.reg); if (file_size != expected_size) { throw RuntimeError("The size of the settings file: " + fname + @@ -3957,7 +3957,7 @@ void Module::sendProgram(bool blackfin, std::vector buffer, client.Send(filesize); // send checksum - std::string checksum = md5_calculate_checksum(buffer.data(), filesize); + std::string const checksum = md5_calculate_checksum(buffer.data(), filesize); LOG(logDEBUG1) << "Checksum:" << checksum; char cChecksum[MAX_STR_LENGTH] = {0}; strcpy(cChecksum, checksum.c_str()); diff --git a/slsDetectorSoftware/src/Pattern.cpp b/slsDetectorSoftware/src/Pattern.cpp index 1a5f7b80c..f8a604c0c 100644 --- a/slsDetectorSoftware/src/Pattern.cpp +++ b/slsDetectorSoftware/src/Pattern.cpp @@ -114,14 +114,14 @@ size_t Pattern::load(const std::string &fname) { it, std::istream_iterator()); std::string cmd = args[0]; - int nargs = args.size() - 1; + int const nargs = args.size() - 1; if (cmd == "patword") { if (nargs != 2) { throw RuntimeError("Invalid arguments for " + ToString(args)); } - uint32_t addr = StringTo(args[1]); + uint32_t const addr = StringTo(args[1]); if (addr >= MAX_PATTERN_LENGTH) { throw RuntimeError("Invalid address for " + ToString(args)); } @@ -162,8 +162,8 @@ size_t Pattern::load(const std::string &fname) { throw RuntimeError("Invalid Pattern level. Options 0-" + std::to_string(MAX_PATTERN_LEVELS - 1)); } - int loop1 = StringTo(args[iArg++]); - int loop2 = StringTo(args[iArg++]); + int const loop1 = StringTo(args[iArg++]); + int const loop2 = StringTo(args[iArg++]); pat->startloop[level] = loop1; pat->stoploop[level] = loop2; } else if (cmd == "patnloop0" || cmd == "patnloop1" || diff --git a/slsDetectorSoftware/src/SharedMemory.h b/slsDetectorSoftware/src/SharedMemory.h index 2265d2f96..2c7501c18 100644 --- a/slsDetectorSoftware/src/SharedMemory.h +++ b/slsDetectorSoftware/src/SharedMemory.h @@ -154,7 +154,7 @@ template class SharedMemory { std::string getName() const { return name; } bool exists() { - int tempfd = shm_open(name.c_str(), O_RDWR, 0); + const int tempfd = shm_open(name.c_str(), O_RDWR, 0); if ((tempfd < 0) && (errno == ENOENT)) { return false; } @@ -163,7 +163,7 @@ template class SharedMemory { } void createSharedMemory() { - int fd = shm_open(name.c_str(), O_CREAT | O_TRUNC | O_EXCL | O_RDWR, + const int fd = shm_open(name.c_str(), O_CREAT | O_TRUNC | O_EXCL | O_RDWR, S_IRUSR | S_IWUSR); if (fd < 0) { std::string msg = @@ -184,9 +184,9 @@ template class SharedMemory { } void openSharedMemory(bool verifySize) { - int fd = shm_open(name.c_str(), O_RDWR, 0); + const int fd = shm_open(name.c_str(), O_RDWR, 0); if (fd < 0) { - std::string msg = "Open existing shared memory " + name + + const std::string msg = "Open existing shared memory " + name + " failed: " + strerror(errno); throw SharedMemoryError(msg); } @@ -198,7 +198,7 @@ template class SharedMemory { void unmapSharedMemory() { if (shared_struct != nullptr) { if (munmap(shared_struct, sizeof(T)) < 0) { - std::string msg = "Unmapping shared memory " + name + + const std::string msg = "Unmapping shared memory " + name + " failed: " + strerror(errno); throw SharedMemoryError(msg); } @@ -213,7 +213,7 @@ template class SharedMemory { // silent exit if shm did not exist anyway if (errno == ENOENT) return; - std::string msg = + const std::string msg = "Free Shared Memory " + name + " Failed: " + strerror(errno); throw SharedMemoryError(msg); } @@ -244,7 +244,7 @@ template class SharedMemory { std::string shm_name = ss.str(); if (shm_name.length() > NAME_MAX_LENGTH) { - std::string msg = + const std::string msg = "Shared memory initialization failed. " + shm_name + " has " + std::to_string(shm_name.length()) + " characters. \n" + "Maximum is " + std::to_string(NAME_MAX_LENGTH) + @@ -262,7 +262,7 @@ template class SharedMemory { mmap(nullptr, sizeof(T), PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); close(fd); if (addr == MAP_FAILED) { - std::string msg = + const std::string msg = "Mapping shared memory " + name + " failed: " + strerror(errno); throw SharedMemoryError(msg); } @@ -272,7 +272,7 @@ template class SharedMemory { void checkSize(int fd) { struct stat sb; if (fstat(fd, &sb) < 0) { - std::string msg = "Could not verify existing shared memory " + + const std::string msg = "Could not verify existing shared memory " + name + " size match " + "(could not fstat): " + strerror(errno); close(fd); @@ -287,7 +287,7 @@ template class SharedMemory { auto actual_size = static_cast(sb.st_size); auto expected_size = sizeof(T); if (actual_size != expected_size) { - std::string msg = + const std::string msg = "Existing shared memory " + name + " size does not match. " + "Expected " + std::to_string(expected_size) + ", found " + std::to_string(actual_size) + diff --git a/slsDetectorSoftware/tests/Caller/test-Caller-acquire.cpp b/slsDetectorSoftware/tests/Caller/test-Caller-acquire.cpp index 299125b99..4ceb4a4cc 100644 --- a/slsDetectorSoftware/tests/Caller/test-Caller-acquire.cpp +++ b/slsDetectorSoftware/tests/Caller/test-Caller-acquire.cpp @@ -29,18 +29,18 @@ TEST_CASE("jungfrau_or_moench_acquire_check_file_size", auto num_udp_interfaces = det.getNumberofUDPInterfaces().tsquash( "inconsistent number of udp interfaces"); - int num_frames_to_acquire = 2; + int const num_frames_to_acquire = 2; create_files_for_acquire(det, caller, num_frames_to_acquire); // check file size (assuming local pc) { - detParameters par(det_type); - int bytes_per_pixel = det.getDynamicRange().squash() / 8; + detParameters const par(det_type); + int const bytes_per_pixel = det.getDynamicRange().squash() / 8; // if 2 udp interfaces, data split into half - size_t expected_image_size = (par.nChanX * par.nChanY * par.nChipX * + size_t const expected_image_size = (par.nChanX * par.nChanY * par.nChipX * par.nChipY * bytes_per_pixel) / num_udp_interfaces; - testFileInfo test_file_info; + testFileInfo const test_file_info; test_acquire_binary_file_size(test_file_info, num_frames_to_acquire, expected_image_size); } @@ -55,23 +55,23 @@ TEST_CASE("eiger_acquire_check_file_size", "[.cmdcall][.cmdacquire]") { if (det_type == defs::EIGER) { - int dynamic_range = det.getDynamicRange().squash(); + int const dynamic_range = det.getDynamicRange().squash(); if (dynamic_range != 16) { throw RuntimeError( "Eiger detector must have dynamic range 16 to test"); } - int num_frames_to_acquire = 2; + int const num_frames_to_acquire = 2; create_files_for_acquire(det, caller, num_frames_to_acquire); // check file size (assuming local pc) { - detParameters par(det_type); + detParameters const par(det_type); // data split into half due to 2 udp interfaces per half module - int num_chips = (par.nChipX / 2); - int bytes_per_pixel = (dynamic_range / 8); - size_t expected_image_size = + int const num_chips = (par.nChipX / 2); + int const bytes_per_pixel = (dynamic_range / 8); + size_t const expected_image_size = par.nChanX * par.nChanY * num_chips * bytes_per_pixel; - testFileInfo test_file_info; + testFileInfo const test_file_info; test_acquire_binary_file_size(test_file_info, num_frames_to_acquire, expected_image_size); } @@ -86,25 +86,25 @@ TEST_CASE("mythen3_acquire_check_file_size", "[.cmdcall][.cmdacquire]") { if (det_type == defs::MYTHEN3) { - int dynamic_range = det.getDynamicRange().squash(); - int counter_mask = det.getCounterMask().squash(); + int const dynamic_range = det.getDynamicRange().squash(); + int const counter_mask = det.getCounterMask().squash(); if (dynamic_range != 16 && counter_mask != 0x3) { throw RuntimeError("Mythen3 detector must have dynamic range 16 " "and counter mask 0x3 to test"); } - int num_counters = __builtin_popcount(counter_mask); - int num_frames_to_acquire = 2; + int const num_counters = __builtin_popcount(counter_mask); + int const num_frames_to_acquire = 2; create_files_for_acquire(det, caller, num_frames_to_acquire); // check file size (assuming local pc) { - detParameters par(det_type); - int bytes_per_pixel = dynamic_range / 8; - int num_channels_per_counter = par.nChanX / 3; - size_t expected_image_size = num_channels_per_counter * + detParameters const par(det_type); + int const bytes_per_pixel = dynamic_range / 8; + int const num_channels_per_counter = par.nChanX / 3; + size_t const expected_image_size = num_channels_per_counter * num_counters * par.nChipX * bytes_per_pixel; - testFileInfo test_file_info; + testFileInfo const test_file_info; test_acquire_binary_file_size(test_file_info, num_frames_to_acquire, expected_image_size); } @@ -119,16 +119,16 @@ TEST_CASE("gotthard2_acquire_check_file_size", "[.cmdcall][.cmdacquire]") { if (det_type == defs::GOTTHARD2) { - int num_frames_to_acquire = 2; + int const num_frames_to_acquire = 2; create_files_for_acquire(det, caller, num_frames_to_acquire); // check file size (assuming local pc) { - detParameters par(det_type); - int bytes_per_pixel = det.getDynamicRange().squash() / 8; - size_t expected_image_size = + detParameters const par(det_type); + int const bytes_per_pixel = det.getDynamicRange().squash() / 8; + size_t const expected_image_size = par.nChanX * par.nChipX * bytes_per_pixel; - testFileInfo test_file_info; + testFileInfo const test_file_info; test_acquire_binary_file_size(test_file_info, num_frames_to_acquire, expected_image_size); } @@ -143,9 +143,9 @@ void test_ctb_file_size_with_acquire(Detector &det, Caller &caller, create_files_for_acquire(det, caller, num_frames, test_info); // check file size (assuming local pc) - uint64_t expected_image_size = + uint64_t const expected_image_size = calculate_ctb_image_size(test_info, isXilinxCtb).first; - testFileInfo test_file_info; + testFileInfo const test_file_info; REQUIRE_NOTHROW(test_acquire_binary_file_size(test_file_info, num_frames, expected_image_size)); } @@ -158,8 +158,8 @@ TEST_CASE("ctb_acquire_check_file_size", "[.cmdcall][.cmdacquire]") { if (det_type == defs::CHIPTESTBOARD || det_type == defs::XILINX_CHIPTESTBOARD) { - bool isXilinxCtb = (det_type == defs::XILINX_CHIPTESTBOARD); - int num_frames_to_acquire = 2; + bool const isXilinxCtb = (det_type == defs::XILINX_CHIPTESTBOARD); + int const num_frames_to_acquire = 2; // all the test cases { testCtbAcquireInfo test_ctb_config{}; diff --git a/slsDetectorSoftware/tests/Caller/test-Caller-chiptestboard.cpp b/slsDetectorSoftware/tests/Caller/test-Caller-chiptestboard.cpp index 2bc827476..a0990cc76 100644 --- a/slsDetectorSoftware/tests/Caller/test-Caller-chiptestboard.cpp +++ b/slsDetectorSoftware/tests/Caller/test-Caller-chiptestboard.cpp @@ -26,8 +26,8 @@ TEST_CASE("dacname", "[.cmdcall]") { if (det_type == defs::CHIPTESTBOARD || det_type == defs::XILINX_CHIPTESTBOARD) { - defs::dacIndex ind = static_cast(2); - std::string str_dac_index = "2"; + defs::dacIndex const ind = static_cast(2); + std::string const str_dac_index = "2"; auto prev = det.getDacName(ind); // 1 arg throw @@ -61,8 +61,8 @@ TEST_CASE("dacindex", "[.cmdcall]") { if (det_type == defs::CHIPTESTBOARD || det_type == defs::XILINX_CHIPTESTBOARD) { - defs::dacIndex ind = static_cast(2); - std::string str_dac_index = "2"; + defs::dacIndex const ind = static_cast(2); + std::string const str_dac_index = "2"; // 1 arg throw REQUIRE_THROWS(caller.call("dacindex", {"2", "2"}, -1, PUT)); @@ -120,8 +120,8 @@ TEST_CASE("adcname", "[.cmdcall]") { if (det_type == defs::CHIPTESTBOARD || det_type == defs::XILINX_CHIPTESTBOARD) { - int ind = 2; - std::string str_adc_index = "2"; + int const ind = 2; + std::string const str_adc_index = "2"; auto prev = det.getAdcName(ind); // 1 arg throw @@ -155,8 +155,8 @@ TEST_CASE("adcindex", "[.cmdcall]") { if (det_type == defs::CHIPTESTBOARD || det_type == defs::XILINX_CHIPTESTBOARD) { - int ind = 2; - std::string str_adc_index = "2"; + int const ind = 2; + std::string const str_adc_index = "2"; // 1 arg throw REQUIRE_THROWS(caller.call("adcindex", {"2", "2"}, -1, PUT)); @@ -214,8 +214,8 @@ TEST_CASE("signalname", "[.cmdcall]") { if (det_type == defs::CHIPTESTBOARD || det_type == defs::XILINX_CHIPTESTBOARD) { - int ind = 2; - std::string str_signal_index = "2"; + int const ind = 2; + std::string const str_signal_index = "2"; auto prev = det.getSignalName(ind); // 1 arg throw @@ -249,8 +249,8 @@ TEST_CASE("signalindex", "[.cmdcall]") { if (det_type == defs::CHIPTESTBOARD || det_type == defs::XILINX_CHIPTESTBOARD) { - int ind = 2; - std::string str_signal_index = "2"; + int const ind = 2; + std::string const str_signal_index = "2"; // 1 arg throw REQUIRE_THROWS(caller.call("signalindex", {"2", "2"}, -1, PUT)); @@ -309,8 +309,8 @@ TEST_CASE("powername", "[.cmdcall]") { if (det_type == defs::CHIPTESTBOARD || det_type == defs::XILINX_CHIPTESTBOARD) { - defs::dacIndex ind = static_cast(2 + defs::V_POWER_A); - std::string str_power_index = "2"; + defs::dacIndex const ind = static_cast(2 + defs::V_POWER_A); + std::string const str_power_index = "2"; auto prev = det.getPowerName(ind); // 1 arg throw @@ -344,8 +344,8 @@ TEST_CASE("powerindex", "[.cmdcall]") { if (det_type == defs::CHIPTESTBOARD || det_type == defs::XILINX_CHIPTESTBOARD) { - defs::dacIndex ind = static_cast(2 + defs::V_POWER_A); - std::string str_power_index = "2"; + defs::dacIndex const ind = static_cast(2 + defs::V_POWER_A); + std::string const str_power_index = "2"; // 1 arg throw REQUIRE_THROWS(caller.call("powerindex", {"2", "2"}, -1, PUT)); @@ -430,8 +430,8 @@ TEST_CASE("slowadcname", "[.cmdcall]") { if (det_type == defs::CHIPTESTBOARD || det_type == defs::XILINX_CHIPTESTBOARD) { - defs::dacIndex ind = static_cast(2 + defs::SLOW_ADC0); - std::string str_slowadc_index = "2"; + defs::dacIndex const ind = static_cast(2 + defs::SLOW_ADC0); + std::string const str_slowadc_index = "2"; auto prev = det.getSlowADCName(ind); // 1 arg throw @@ -466,8 +466,8 @@ TEST_CASE("slowadcindex", "[.cmdcall]") { if (det_type == defs::CHIPTESTBOARD || det_type == defs::XILINX_CHIPTESTBOARD) { - defs::dacIndex ind = static_cast(2 + defs::SLOW_ADC0); - std::string str_slowadc_index = "2"; + defs::dacIndex const ind = static_cast(2 + defs::SLOW_ADC0); + std::string const str_slowadc_index = "2"; // 1 arg throw REQUIRE_THROWS(caller.call("slowadcindex", {"2", "2"}, -1, PUT)); diff --git a/slsDetectorSoftware/tests/Caller/test-Caller-eiger.cpp b/slsDetectorSoftware/tests/Caller/test-Caller-eiger.cpp index ae6a6c824..e1b3fcb59 100644 --- a/slsDetectorSoftware/tests/Caller/test-Caller-eiger.cpp +++ b/slsDetectorSoftware/tests/Caller/test-Caller-eiger.cpp @@ -27,7 +27,7 @@ TEST_CASE("temp_fpgaext", "[.cmdcall]") { REQUIRE_NOTHROW(caller.call("temp_fpgaext", {}, -1, GET)); std::ostringstream oss; REQUIRE_NOTHROW(caller.call("temp_fpgaext", {}, 0, GET, oss)); - std::string s = (oss.str()).erase(0, strlen("temp_fpgaext ")); + std::string const s = (oss.str()).erase(0, strlen("temp_fpgaext ")); REQUIRE(std::stoi(s) != -1); } else { REQUIRE_THROWS(caller.call("temp_fpgaext", {}, -1, GET)); @@ -42,7 +42,7 @@ TEST_CASE("temp_10ge", "[.cmdcall]") { REQUIRE_NOTHROW(caller.call("temp_10ge", {}, -1, GET)); std::ostringstream oss; REQUIRE_NOTHROW(caller.call("temp_10ge", {}, 0, GET, oss)); - std::string s = (oss.str()).erase(0, strlen("temp_10ge ")); + std::string const s = (oss.str()).erase(0, strlen("temp_10ge ")); REQUIRE(std::stoi(s) != -1); } else { REQUIRE_THROWS(caller.call("temp_10ge", {}, -1, GET)); @@ -57,7 +57,7 @@ TEST_CASE("temp_dcdc", "[.cmdcall]") { REQUIRE_NOTHROW(caller.call("temp_dcdc", {}, -1, GET)); std::ostringstream oss; REQUIRE_NOTHROW(caller.call("temp_dcdc", {}, 0, GET, oss)); - std::string s = (oss.str()).erase(0, strlen("temp_dcdc ")); + std::string const s = (oss.str()).erase(0, strlen("temp_dcdc ")); REQUIRE(std::stoi(s) != -1); } else { REQUIRE_THROWS(caller.call("temp_dcdc", {}, -1, GET)); @@ -72,7 +72,7 @@ TEST_CASE("temp_sodl", "[.cmdcall]") { REQUIRE_NOTHROW(caller.call("temp_sodl", {}, -1, GET)); std::ostringstream oss; REQUIRE_NOTHROW(caller.call("temp_sodl", {}, 0, GET, oss)); - std::string s = (oss.str()).erase(0, strlen("temp_sodl ")); + std::string const s = (oss.str()).erase(0, strlen("temp_sodl ")); REQUIRE(std::stoi(s) != -1); } else { REQUIRE_THROWS(caller.call("temp_sodl", {}, -1, GET)); @@ -87,7 +87,7 @@ TEST_CASE("temp_sodr", "[.cmdcall]") { REQUIRE_NOTHROW(caller.call("temp_sodr", {}, -1, GET)); std::ostringstream oss; REQUIRE_NOTHROW(caller.call("temp_sodr", {}, 0, GET, oss)); - std::string s = (oss.str()).erase(0, strlen("temp_sodr ")); + std::string const s = (oss.str()).erase(0, strlen("temp_sodr ")); REQUIRE(std::stoi(s) != -1); } else { REQUIRE_THROWS(caller.call("temp_sodr", {}, -1, GET)); @@ -102,7 +102,7 @@ TEST_CASE("temp_fpgafl", "[.cmdcall]") { REQUIRE_NOTHROW(caller.call("temp_fpgafl", {}, -1, GET)); std::ostringstream oss; REQUIRE_NOTHROW(caller.call("temp_fpgafl", {}, 0, GET, oss)); - std::string s = (oss.str()).erase(0, strlen("temp_fpgafl ")); + std::string const s = (oss.str()).erase(0, strlen("temp_fpgafl ")); REQUIRE(std::stoi(s) != -1); } else { REQUIRE_THROWS(caller.call("temp_fpgafl", {}, -1, GET)); @@ -117,7 +117,7 @@ TEST_CASE("temp_fpgafr", "[.cmdcall]") { REQUIRE_NOTHROW(caller.call("temp_fpgafr", {}, -1, GET)); std::ostringstream oss; REQUIRE_NOTHROW(caller.call("temp_fpgafr", {}, 0, GET, oss)); - std::string s = (oss.str()).erase(0, strlen("temp_fpgafr ")); + std::string const s = (oss.str()).erase(0, strlen("temp_fpgafr ")); REQUIRE(std::stoi(s) != -1); } else { REQUIRE_THROWS(caller.call("temp_fpgafr", {}, -1, GET)); @@ -421,7 +421,7 @@ TEST_CASE("measuredperiod", "[.cmdcall]") { } else { s = st.erase(0, strlen("measuredperiod ")); } - double val = std::stod(s); + double const val = std::stod(s); // REQUIRE(val >= 1.0); REQUIRE(val < 2.0); for (int i = 0; i != det.size(); ++i) { @@ -460,7 +460,7 @@ TEST_CASE("measuredsubperiod", "[.cmdcall]") { } else { s = st.erase(0, strlen("measuredsubperiod ")); } - double val = std::stod(s); + double const val = std::stod(s); REQUIRE(val >= 0); REQUIRE(val < 1000); for (int i = 0; i != det.size(); ++i) { diff --git a/slsDetectorSoftware/tests/Caller/test-Caller-global.cpp b/slsDetectorSoftware/tests/Caller/test-Caller-global.cpp index c27ff05d5..137022c06 100644 --- a/slsDetectorSoftware/tests/Caller/test-Caller-global.cpp +++ b/slsDetectorSoftware/tests/Caller/test-Caller-global.cpp @@ -22,9 +22,9 @@ void test_valid_port_caller(const std::string &command, if (arg.empty()) arg.push_back("0"); - int test_values[3] = {77797, -1, 0}; + int const test_values[3] = {77797, -1, 0}; for (int i = 0; i != 3; ++i) { - int port_number = test_values[i]; + int const port_number = test_values[i]; arg[arg.size() - 1] = std::to_string(port_number); REQUIRE_THROWS(caller.call(command, arg, detector_id, action)); /*REQUIRE_THROWS_WITH(proxy.Call(command, arguments, detector_id, @@ -72,7 +72,7 @@ void test_onchip_dac_caller(defs::dacIndex index, const std::string &dacname, REQUIRE_THROWS( caller.call(dacname, {"-1", "0x400"}, -1, PUT)); // max val is 0x3ff - int chipIndex = -1; // for now, it is -1 only + int const chipIndex = -1; // for now, it is -1 only auto prev_val = det.getOnChipDAC(index, chipIndex); auto dacValueStr = ToStringHex(dacvalue); auto chipIndexStr = std::to_string(chipIndex); @@ -115,10 +115,10 @@ void test_acquire_binary_file_size(const testFileInfo &file_info, uint64_t num_frames_to_acquire, uint64_t expected_image_size) { assert(file_info.file_format == defs::BINARY); - std::string fname = file_info.file_path + "/" + file_info.file_prefix + + std::string const fname = file_info.file_path + "/" + file_info.file_prefix + "_d0_f0_" + std::to_string(file_info.file_acq_index) + ".raw"; - uint64_t expected_file_size = + uint64_t const expected_file_size = num_frames_to_acquire * (expected_image_size + sizeof(defs::sls_receiver_header)); auto actual_file_size = std::filesystem::file_size(fname); @@ -136,7 +136,7 @@ void test_acquire_with_receiver(Caller &caller, const Detector &det) { REQUIRE_NOTHROW(caller.call("start", {}, -1, PUT)); bool idle = false; while (!idle) { - std::ostringstream oss; + std::ostringstream const oss; REQUIRE_NOTHROW(caller.call("status", {}, -1, GET)); auto statusList = det.getDetectorStatus(); if (statusList.any(defs::ERROR)) { @@ -154,7 +154,7 @@ void create_files_for_acquire( const std::optional &test_info) { // save previous state - testFileInfo prev_file_info = get_file_state(det); + testFileInfo const prev_file_info = get_file_state(det); auto prev_num_frames = det.getNumberOfFrames().tsquash( "Inconsistent number of frames to acquire"); std::optional prev_ctb_config_info{}; @@ -163,7 +163,7 @@ void create_files_for_acquire( } // set state for acquire - testFileInfo test_file_info; + testFileInfo const test_file_info; set_file_state(det, test_file_info); det.setNumberOfFrames(num_frames); if (test_info) { @@ -265,10 +265,10 @@ calculate_ctb_image_size(const testCtbAcquireInfo &test_info, inputs.dbitList = test_info.dbit_list; auto out = computeCtbImageSize(inputs); - uint64_t image_size = + uint64_t const image_size = out.nAnalogBytes + out.nDigitalBytes + out.nTransceiverBytes; LOG(logDEBUG1) << "Expected image size: " << image_size; - int npixelx = out.nPixelsX; + int const npixelx = out.nPixelsX; LOG(logDEBUG1) << "Expected number of pixels in x: " << npixelx; return std::make_pair(image_size, npixelx); } diff --git a/slsDetectorSoftware/tests/Caller/test-Caller-jungfrau.cpp b/slsDetectorSoftware/tests/Caller/test-Caller-jungfrau.cpp index 4563cd32f..b845004ad 100644 --- a/slsDetectorSoftware/tests/Caller/test-Caller-jungfrau.cpp +++ b/slsDetectorSoftware/tests/Caller/test-Caller-jungfrau.cpp @@ -580,9 +580,9 @@ TEST_CASE("pedestalmode", "[.cmdcall]") { REQUIRE(oss.str() == "pedestalmode [disabled]\n"); } - uint8_t pedestalFrames = 50; - uint16_t pedestalLoops = 100; - int64_t expNumFrames = pedestalFrames * pedestalLoops * 2; + uint8_t const pedestalFrames = 50; + uint16_t const pedestalLoops = 100; + int64_t const expNumFrames = pedestalFrames * pedestalLoops * 2; auto origFrames = det.getNumberOfFrames().squash(-1); auto origTriggers = det.getNumberOfTriggers().squash(-1); diff --git a/slsDetectorSoftware/tests/Caller/test-Caller-master-attributes.cpp b/slsDetectorSoftware/tests/Caller/test-Caller-master-attributes.cpp index bf4cf9bac..d95ca2272 100644 --- a/slsDetectorSoftware/tests/Caller/test-Caller-master-attributes.cpp +++ b/slsDetectorSoftware/tests/Caller/test-Caller-master-attributes.cpp @@ -183,7 +183,7 @@ void read_from_json(const Document &doc, const std::string &name, } int index = 0; for (const auto &item : json_values) { - std::string sval = item.GetString(); + std::string const sval = item.GetString(); retval[index++] = StringTo(sval); } } @@ -330,7 +330,7 @@ void test_master_file_version(const Detector &det, // different values for json and hdf5 // hdf5 version in atttribute and not dataset double retval{}; - std::string name = MasterAttributes::N_VERSION.data(); + std::string const name = MasterAttributes::N_VERSION.data(); if (doc.has_value()) { const auto &d = *doc; REQUIRE(d.HasMember(MasterAttributes::N_VERSION.data())); @@ -381,14 +381,14 @@ void test_master_file_image_size(const Detector &det, auto det_type = det.getDetectorType().tsquash("Inconsistent detector types to test"); - int bytes_per_pixel = det.getDynamicRange().squash() / 8; - detParameters par(det_type); + int const bytes_per_pixel = det.getDynamicRange().squash() / 8; + detParameters const par(det_type); int image_size = 0; switch (det_type) { case defs::EIGER: { - int num_chips = (par.nChipX / 2); + int const num_chips = (par.nChipX / 2); image_size = par.nChanX * par.nChanY * num_chips * bytes_per_pixel; } break; @@ -402,9 +402,9 @@ void test_master_file_image_size(const Detector &det, } break; case defs::MYTHEN3: { - int counter_mask = det.getCounterMask().squash(); - int num_counters = __builtin_popcount(counter_mask); - int num_channels_per_counter = par.nChanX / MAX_NUM_COUNTERS; + int const counter_mask = det.getCounterMask().squash(); + int const num_counters = __builtin_popcount(counter_mask); + int const num_channels_per_counter = par.nChanX / MAX_NUM_COUNTERS; image_size = num_channels_per_counter * num_counters * par.nChipX * bytes_per_pixel; } break; @@ -415,7 +415,7 @@ void test_master_file_image_size(const Detector &det, case defs::CHIPTESTBOARD: case defs::XILINX_CHIPTESTBOARD: { - testCtbAcquireInfo test_info{}; + testCtbAcquireInfo const test_info{}; image_size = calculate_ctb_image_size( test_info, (det_type == defs::XILINX_CHIPTESTBOARD)) .first; @@ -439,14 +439,14 @@ void test_master_file_det_size(const Detector &det, // m3 assumes all counters enabled when getting num channels from client // TODO: in future, remove assumption if (det_type == defs::MYTHEN3) { - int nchan = portSize.x / MAX_NUM_COUNTERS; + int const nchan = portSize.x / MAX_NUM_COUNTERS; auto counter_mask = det.getCounterMask().tsquash( "Inconsistent counter mask for Mythen3 detector"); - int num_counters = __builtin_popcount(counter_mask); + int const num_counters = __builtin_popcount(counter_mask); portSize.x = nchan * num_counters; } else if (det_type == defs::CHIPTESTBOARD || det_type == defs::XILINX_CHIPTESTBOARD) { - testCtbAcquireInfo test_info{}; + testCtbAcquireInfo const test_info{}; portSize.x = calculate_ctb_image_size( test_info, det_type == defs::XILINX_CHIPTESTBOARD) .second; @@ -534,7 +534,7 @@ void test_master_file_total_frames(const Detector &det, det.getNumberOfAdditionalStorageCells().tsquash( "Inconsistent number of additional storage cells"); } - uint64_t total_frames = + uint64_t const total_frames = numFrames * repeats * (int64_t)(numAdditionalStorageCells + 1); REQUIRE_NOTHROW(check_master_file( @@ -549,14 +549,14 @@ void test_master_file_rois(const Detector &det, det.getDetectorType().tsquash("Inconsistent detector types to test"); // compensate for m3 channel size and counter mask mess if (det_type == defs::MYTHEN3) { - int nchan = detsize.x / MAX_NUM_COUNTERS; + int const nchan = detsize.x / MAX_NUM_COUNTERS; auto counter_mask = det.getCounterMask().tsquash( "Inconsistent counter mask for Mythen3 detector"); - int num_counters = __builtin_popcount(counter_mask); + int const num_counters = __builtin_popcount(counter_mask); detsize.x = nchan * num_counters; } // replace -1 for complete ROI - bool is2D = (detsize.y > 1); + bool const is2D = (detsize.y > 1); for (auto &roi : rois) { if (roi.completeRoi()) { roi.xmin = 0; @@ -751,7 +751,7 @@ void test_master_file_burst_mode(const Detector &det, void test_master_file_adc_mask(const Detector &det, const std::optional &doc) { - testCtbAcquireInfo test_ctb_config{}; + testCtbAcquireInfo const test_ctb_config{}; auto adc_mask = test_ctb_config.adc_enable_10g; auto det_type = det.getDetectorType().squash(); if (det_type == defs::CHIPTESTBOARD) { @@ -766,7 +766,7 @@ void test_master_file_adc_mask(const Detector &det, void test_master_file_analog_flag(const Detector &det, const std::optional &doc) { - testCtbAcquireInfo test_info{}; + testCtbAcquireInfo const test_info{}; auto romode = test_info.readout_mode; auto analog = static_cast( (romode == defs::ANALOG_ONLY || romode == defs::ANALOG_AND_DIGITAL)); @@ -777,7 +777,7 @@ void test_master_file_analog_flag(const Detector &det, void test_master_file_analog_samples(const Detector &det, const std::optional &doc) { - testCtbAcquireInfo test_info{}; + testCtbAcquireInfo const test_info{}; auto analog_samples = test_info.num_adc_samples; REQUIRE_NOTHROW(check_master_file( @@ -786,7 +786,7 @@ void test_master_file_analog_samples(const Detector &det, void test_master_file_digital_flag(const Detector &det, const std::optional &doc) { - testCtbAcquireInfo test_info{}; + testCtbAcquireInfo const test_info{}; auto romode = test_info.readout_mode; auto digital = static_cast(romode == defs::DIGITAL_ONLY || romode == defs::ANALOG_AND_DIGITAL || @@ -798,7 +798,7 @@ void test_master_file_digital_flag(const Detector &det, void test_master_file_digital_samples(const Detector &det, const std::optional &doc) { - testCtbAcquireInfo test_info{}; + testCtbAcquireInfo const test_info{}; auto digital_samples = test_info.num_dbit_samples; REQUIRE_NOTHROW(check_master_file( @@ -807,7 +807,7 @@ void test_master_file_digital_samples(const Detector &det, void test_master_file_dbit_offset(const Detector &det, const std::optional &doc) { - testCtbAcquireInfo test_info{}; + testCtbAcquireInfo const test_info{}; auto dbit_offset = test_info.dbit_offset; REQUIRE_NOTHROW(check_master_file( @@ -816,7 +816,7 @@ void test_master_file_dbit_offset(const Detector &det, void test_master_file_dbit_reorder(const Detector &det, const std::optional &doc) { - testCtbAcquireInfo test_info{}; + testCtbAcquireInfo const test_info{}; auto dbit_reorder = test_info.dbit_reorder; REQUIRE_NOTHROW(check_master_file( @@ -825,7 +825,7 @@ void test_master_file_dbit_reorder(const Detector &det, void test_master_file_dbit_bitset(const Detector &det, const std::optional &doc) { - testCtbAcquireInfo test_info{}; + testCtbAcquireInfo const test_info{}; uint64_t dbit_bitset = 0; for (auto &i : test_info.dbit_list) { dbit_bitset |= (static_cast(1) << i); @@ -837,7 +837,7 @@ void test_master_file_dbit_bitset(const Detector &det, void test_master_file_transceiver_mask(const Detector &det, const std::optional &doc) { - testCtbAcquireInfo test_info{}; + testCtbAcquireInfo const test_info{}; auto trans_mask = test_info.transceiver_mask; REQUIRE_NOTHROW(check_master_file( @@ -846,7 +846,7 @@ void test_master_file_transceiver_mask(const Detector &det, void test_master_file_transceiver_flag(const Detector &det, const std::optional &doc) { - testCtbAcquireInfo test_info{}; + testCtbAcquireInfo const test_info{}; auto romode = test_info.readout_mode; auto trans = static_cast(romode == defs::DIGITAL_AND_TRANSCEIVER || romode == defs::TRANSCEIVER_ONLY); @@ -857,7 +857,7 @@ void test_master_file_transceiver_flag(const Detector &det, void test_master_file_transceiver_samples(const Detector &det, const std::optional &doc) { - testCtbAcquireInfo test_info{}; + testCtbAcquireInfo const test_info{}; auto trans_samples = test_info.num_trans_samples; REQUIRE_NOTHROW(check_master_file( doc, MasterAttributes::N_TRANSCEIVER_SAMPLES.data(), trans_samples)); @@ -1005,17 +1005,17 @@ Document parse_binary_master_attributes(std::string file_path) { REQUIRE(file.is_open()); std::stringstream buffer; buffer << file.rdbuf(); - std::string json_str = buffer.str(); + std::string const json_str = buffer.str(); Document doc; - ParseResult result = doc.Parse(json_str.c_str()); + ParseResult const result = doc.Parse(json_str.c_str()); if (result == 0) { std::cout << "JSON parse error: " << GetParseError_En(result.Code()) << " (at offset " << result.Offset() << ")" << std::endl; // Optional: Show problematic snippet - size_t offset = result.Offset(); - std::string context = + size_t const offset = result.Offset(); + std::string const context = json_str.substr(std::max(0, (int)offset - 20), 40); std::cout << "Context around error: \"" << context << "\"" << std::endl; } @@ -1039,7 +1039,7 @@ TEST_CASE("check_master_file_attributes", "[.cmdcall][.cmdacquire][.cmdattr]") { auto det_type = det.getDetectorType().tsquash("Inconsistent detector types to test"); - int64_t num_frames = 1; + int64_t const num_frames = 1; switch (det_type) { case defs::EIGER: case defs::JUNGFRAU: @@ -1057,11 +1057,11 @@ TEST_CASE("check_master_file_attributes", "[.cmdcall][.cmdacquire][.cmdattr]") { throw sls::RuntimeError("Unsupported detector type for this test"); } - testFileInfo file_info; - std::string master_file_prefix = file_info.getMasterFileNamePrefix(); + testFileInfo const file_info; + std::string const master_file_prefix = file_info.getMasterFileNamePrefix(); // binary - std::string fname = + std::string const fname = master_file_prefix + ".json"; // /tmp/sls_test_master_0.json auto doc = std::make_optional(parse_binary_master_attributes(fname)); test_master_file_metadata(det, doc); diff --git a/slsDetectorSoftware/tests/Caller/test-Caller-mythen3.cpp b/slsDetectorSoftware/tests/Caller/test-Caller-mythen3.cpp index 16295a3e1..f47c7dca4 100644 --- a/slsDetectorSoftware/tests/Caller/test-Caller-mythen3.cpp +++ b/slsDetectorSoftware/tests/Caller/test-Caller-mythen3.cpp @@ -509,11 +509,11 @@ TEST_CASE("interpolation", "[.cmdcall]") { auto prev_mask = det.getCounterMask(); auto prev_vth3DacVal = det.getDAC(defs::VTH3, 0, {}); - int disabledDacValue = 2800; + int const disabledDacValue = 2800; auto fixedVth3DacVal = 1000; det.setDAC(defs::VTH3, fixedVth3DacVal, 0, {}); // mask with counter 3 disabled and enabled(to test vth3) - uint32_t fixedMask[2] = {0x2, 0x4}; + uint32_t const fixedMask[2] = {0x2, 0x4}; for (int i = 0; i != 2; ++i) { det.setCounterMask(fixedMask[i]); { @@ -532,7 +532,7 @@ TEST_CASE("interpolation", "[.cmdcall]") { REQUIRE(oss.str() == "interpolation 0\n"); REQUIRE(det.getCounterMask().tsquash( "inconsistent counter mask") == fixedMask[i]); - int expectedVth3DacVal = + int const expectedVth3DacVal = (fixedMask[i] & 0x4 ? fixedVth3DacVal : disabledDacValue); REQUIRE(det.getDAC(defs::VTH3, 0, {0}) .tsquash("inconsistent vth3 dac value") == @@ -566,13 +566,13 @@ TEST_CASE("pumpprobe", "[.cmdcall]") { auto prev_vth2DacVal = det.getDAC(defs::VTH2, 0, {}); auto prev_vth3DacVal = det.getDAC(defs::VTH3, 0, {}); - int disabledDacValue = 2800; + int const disabledDacValue = 2800; auto fixedVthDacVal = 1000; det.setDAC(defs::VTH1, fixedVthDacVal, 0, {}); det.setDAC(defs::VTH2, fixedVthDacVal, 0, {}); det.setDAC(defs::VTH3, fixedVthDacVal, 0, {}); // mask with counter 2 disabled and enabled(to test vth2) - uint32_t fixedMask[2] = {0x4, 0x3}; + uint32_t const fixedMask[2] = {0x4, 0x3}; for (int i = 0; i != 2; ++i) { std::cout << "i:" << i << std::endl; det.setCounterMask(fixedMask[i]); diff --git a/slsDetectorSoftware/tests/Caller/test-Caller-pattern.cpp b/slsDetectorSoftware/tests/Caller/test-Caller-pattern.cpp index 60dafd4f4..f55d1c9e9 100644 --- a/slsDetectorSoftware/tests/Caller/test-Caller-pattern.cpp +++ b/slsDetectorSoftware/tests/Caller/test-Caller-pattern.cpp @@ -114,8 +114,8 @@ TEST_CASE("patword", "[.cmdcall]") { if (det_type == defs::CHIPTESTBOARD || det_type == defs::XILINX_CHIPTESTBOARD || det_type == defs::MYTHEN3) { - int addr = 0x23; - std::string saddr = ToStringHex(addr, 4); + int const addr = 0x23; + std::string const saddr = ToStringHex(addr, 4); auto prev_val = det.getPatternWord(addr); { std::ostringstream oss; @@ -189,9 +189,9 @@ TEST_CASE("patloop", "[.cmdcall]") { continue; } auto prev_val = det.getPatternLoopAddresses(iLoop); - std::string sLoop = ToString(iLoop); + std::string const sLoop = ToString(iLoop); if (iLoop < 3) { - std::string deprecatedCmd = "patloop" + sLoop; + std::string const deprecatedCmd = "patloop" + sLoop; { // deprecated std::ostringstream oss; caller.call(deprecatedCmd, {"0x20", "0x5c"}, -1, PUT, oss); @@ -238,9 +238,9 @@ TEST_CASE("patnloop", "[.cmdcall]") { continue; } auto prev_val = det.getPatternLoopCycles(iLoop); - std::string sLoop = ToString(iLoop); + std::string const sLoop = ToString(iLoop); if (iLoop < 3) { - std::string deprecatedCmd = "patnloop" + sLoop; + std::string const deprecatedCmd = "patnloop" + sLoop; { // deprecated std::ostringstream oss; caller.call(deprecatedCmd, {"5"}, -1, PUT, oss); @@ -284,9 +284,9 @@ TEST_CASE("patwait", "[.cmdcall]") { continue; } auto prev_val = det.getPatternWaitAddr(iLoop); - std::string sLoop = ToString(iLoop); + std::string const sLoop = ToString(iLoop); if (iLoop < 3) { - std::string deprecatedCmd = "patwait" + sLoop; + std::string const deprecatedCmd = "patwait" + sLoop; { // deprecated std::ostringstream oss; caller.call(deprecatedCmd, {"0x5c"}, -1, PUT, oss); @@ -330,9 +330,9 @@ TEST_CASE("patwaittime", "[.cmdcall]") { continue; } auto prev_val = det.getPatternWaitClocks(iLoop); - std::string sLoop = ToString(iLoop); + std::string const sLoop = ToString(iLoop); if (iLoop < 3) { - std::string deprecatedCmd = "patwaittime" + sLoop; + std::string const deprecatedCmd = "patwaittime" + sLoop; { // deprecated std::ostringstream oss; caller.call(deprecatedCmd, {"8589936640"}, -1, PUT, oss); diff --git a/slsDetectorSoftware/tests/Caller/test-Caller-rx.cpp b/slsDetectorSoftware/tests/Caller/test-Caller-rx.cpp index 74fa821d8..f469cb161 100644 --- a/slsDetectorSoftware/tests/Caller/test-Caller-rx.cpp +++ b/slsDetectorSoftware/tests/Caller/test-Caller-rx.cpp @@ -30,7 +30,7 @@ TEST_CASE("rx_version", "[.cmdcall][.rx]") { Caller caller(&det); std::ostringstream oss; caller.call("rx_version", {}, -1, GET, oss); - sls::Version v(APIRECEIVER); + sls::Version const v(APIRECEIVER); std::ostringstream vs; vs << "rx_version " << v.concise() << '\n'; REQUIRE(oss.str() == vs.str()); @@ -365,9 +365,9 @@ TEST_CASE("rx_padding", "[.cmdcall][.rx]") { TEST_CASE("rx_udpsocksize", "[.cmdcall][.rx]") { Detector det; Caller caller(&det); - int64_t prev_val = det.getRxUDPSocketBufferSize().tsquash( + int64_t const prev_val = det.getRxUDPSocketBufferSize().tsquash( "Need same udp socket buffer size to test"); - std::string s_new_val = std::to_string(prev_val); + std::string const s_new_val = std::to_string(prev_val); /*std::string s_new_val = std::to_string(prev_val - 1000); { Need permissions std::ostringstream oss; @@ -389,14 +389,14 @@ TEST_CASE("rx_realudpsocksize", "[.cmdcall][.rx]") { { std::ostringstream oss; caller.call("rx_udpsocksize", {}, -1, GET, oss); - std::string s = (oss.str()).erase(0, strlen("rx_udpsocksize ")); + std::string const s = (oss.str()).erase(0, strlen("rx_udpsocksize ")); val = std::stol(s); } { std::ostringstream oss; caller.call("rx_realudpsocksize", {}, -1, GET, oss); - std::string s = (oss.str()).erase(0, strlen("rx_realudpsocksize ")); - uint64_t rval = std::stol(s); + std::string const s = (oss.str()).erase(0, strlen("rx_realudpsocksize ")); + uint64_t const rval = std::stol(s); REQUIRE(rval >= val * 2); } } @@ -476,10 +476,10 @@ TEST_CASE("rx_roi", "[.cmdcall]") { REQUIRE_THROWS(caller.call("rx_roi", {"5", "10"}, -1, PUT)); } else { auto prev_val = det.getRxROI(); - defs::xy detsize = det.getDetectorSize(); + defs::xy const detsize = det.getDetectorSize(); auto portSize = det.getPortSize()[0]; - int delta = 50; - int numinterfaces = det.getNumberofUDPInterfaces().tsquash( + int const delta = 50; + int const numinterfaces = det.getNumberofUDPInterfaces().tsquash( "inconsistent number of interfaces"); // 1d @@ -757,11 +757,11 @@ TEST_CASE("rx_roi", "[.cmdcall]") { // TODO: check roi in master file { REQUIRE_NOTHROW(create_files_for_acquire(det, caller)); - testFileInfo file_info; - std::string master_file_prefix = + testFileInfo const file_info; + std::string const master_file_prefix = file_info.getMasterFileNamePrefix(); - std::string fname = master_file_prefix + ".json"; + std::string const fname = master_file_prefix + ".json"; REQUIRE(std::filesystem::exists(fname) == true); #ifdef HDF5C fname = master_file_prefix + ".h5"; diff --git a/slsDetectorSoftware/tests/Caller/test-Caller.cpp b/slsDetectorSoftware/tests/Caller/test-Caller.cpp index c96f6d4b1..9ccd48734 100644 --- a/slsDetectorSoftware/tests/Caller/test-Caller.cpp +++ b/slsDetectorSoftware/tests/Caller/test-Caller.cpp @@ -24,7 +24,7 @@ TEST_CASE("Calling help doesn't throw or cause segfault") { // Dont add [.cmdcall] tag this should run with normal tests Caller caller(nullptr); std::ostringstream os; - for (std::string cmd : caller.getAllCommands()) + for (std::string const& cmd : caller.getAllCommands()) REQUIRE_NOTHROW( caller.call(cmd, {}, -1, slsDetectorDefs::HELP_ACTION, os)); } @@ -291,7 +291,7 @@ TEST_CASE("threshold", "[.cmdcall]") { auto prev_energies = det.getTrimEnergies().tsquash("inconsistent trim energies to test"); if (!prev_energies.empty()) { - std::string senergy = std::to_string(prev_energies[0]); + std::string const senergy = std::to_string(prev_energies[0]); std::ostringstream oss1, oss2; caller.call("threshold", {senergy, "standard"}, -1, PUT, oss1); REQUIRE(oss1.str() == "threshold [" + senergy + ", standard]\n"); @@ -319,15 +319,15 @@ TEST_CASE("threshold", "[.cmdcall]") { auto prev_energies = det.getTrimEnergies().tsquash("inconsistent trim energies to test"); if (!prev_energies.empty()) { - std::string senergy = std::to_string(prev_energies[0]); + std::string const senergy = std::to_string(prev_energies[0]); std::ostringstream oss1, oss2; caller.call("threshold", {senergy, "standard"}, -1, PUT, oss1); REQUIRE(oss1.str() == "threshold [" + senergy + ", standard]\n"); caller.call("threshold", {}, -1, GET, oss2); REQUIRE(oss2.str() == "threshold [" + senergy + ", " + senergy + ", " + senergy + "]\n"); - std::string senergy2 = std::to_string(prev_energies[1]); - std::string senergy3 = std::to_string(prev_energies[2]); + std::string const senergy2 = std::to_string(prev_energies[1]); + std::string const senergy3 = std::to_string(prev_energies[2]); std::ostringstream oss3, oss4; caller.call("threshold", {senergy, senergy2, senergy3, "standard"}, -1, PUT, oss3); @@ -370,7 +370,7 @@ TEST_CASE("thresholdnotb", "[.cmdcall]") { auto prev_energies = det.getTrimEnergies().tsquash("inconsistent trim energies to test"); if (!prev_energies.empty()) { - std::string senergy = std::to_string(prev_energies[0]); + std::string const senergy = std::to_string(prev_energies[0]); std::ostringstream oss1, oss2; caller.call("thresholdnotb", {senergy, "standard"}, -1, PUT, oss1); REQUIRE(oss1.str() == @@ -398,7 +398,7 @@ TEST_CASE("thresholdnotb", "[.cmdcall]") { auto prev_energies = det.getTrimEnergies().tsquash("inconsistent trim energies to test"); if (!prev_energies.empty()) { - std::string senergy = std::to_string(prev_energies[0]); + std::string const senergy = std::to_string(prev_energies[0]); std::ostringstream oss1, oss2; caller.call("thresholdnotb", {senergy, "standard"}, -1, PUT, oss1); REQUIRE(oss1.str() == @@ -406,8 +406,8 @@ TEST_CASE("thresholdnotb", "[.cmdcall]") { caller.call("threshold", {}, -1, GET, oss2); REQUIRE(oss2.str() == "threshold [" + senergy + ", " + senergy + ", " + senergy + "]\n"); - std::string senergy2 = std::to_string(prev_energies[1]); - std::string senergy3 = std::to_string(prev_energies[2]); + std::string const senergy2 = std::to_string(prev_energies[1]); + std::string const senergy3 = std::to_string(prev_energies[2]); std::ostringstream oss3, oss4; caller.call("thresholdnotb", {senergy, senergy2, senergy3, "standard"}, -1, PUT, @@ -528,8 +528,8 @@ TEST_CASE("gappixels", "[.cmdcall]") { if (det_type == defs::JUNGFRAU || det_type == defs::MOENCH) gapPixelTest = true; else if (det_type == defs::EIGER) { - bool quad = det.getQuad().squash(false); - bool fullModule = (det.getModuleGeometry().y % 2 == 0); + bool const quad = det.getQuad().squash(false); + bool const fullModule = (det.getModuleGeometry().y % 2 == 0); if (quad || fullModule) { gapPixelTest = true; } @@ -658,9 +658,9 @@ TEST_CASE("badchannels", "[.cmdcall]") { REQUIRE_THROWS(caller.call("badchannels", {}, -1, GET)); - std::string fname_put = + std::string const fname_put = getAbsolutePathFromCurrentProcess(TEST_FILE_NAME_BAD_CHANNELS); - std::string fname_get = "/tmp/sls_test_channels.txt"; + std::string const fname_get = "/tmp/sls_test_channels.txt"; REQUIRE_NOTHROW(caller.call("badchannels", {fname_put}, 0, PUT)); REQUIRE_NOTHROW(caller.call("badchannels", {fname_get}, 0, GET)); @@ -976,7 +976,7 @@ TEST_CASE("dr", "[.cmdcall]") { auto det_type = det.getDetectorType().squash(); if (det_type == defs::EIGER) { auto dr = det.getDynamicRange().squash(); - std::array vals{4, 8, 16, 32}; + std::array const vals{4, 8, 16, 32}; for (const auto val : vals) { std::ostringstream oss1, oss2; caller.call("dr", {std::to_string(val)}, -1, PUT, oss1); @@ -988,7 +988,7 @@ TEST_CASE("dr", "[.cmdcall]") { } else if (det_type == defs::MYTHEN3) { auto dr = det.getDynamicRange().squash(); // not updated in firmware to support dr 1 - std::array vals{8, 16, 32}; + std::array const vals{8, 16, 32}; for (const auto val : vals) { std::ostringstream oss1, oss2; caller.call("dr", {std::to_string(val)}, -1, PUT, oss1); @@ -1542,7 +1542,7 @@ TEST_CASE("powerchip", "[.cmdcall]") { "Inconsistent virtual detector " "server to test powerchip command")) { det.setPowerChip(1); - int hv = det.getHighVoltage().tsquash( + int const hv = det.getHighVoltage().tsquash( "Inconsistent high voltage to test " "powerchip command"); @@ -1976,7 +1976,7 @@ TEST_CASE("temp_adc", "[.cmdcall]") { REQUIRE_NOTHROW(caller.call("temp_adc", {}, -1, GET)); std::ostringstream oss; REQUIRE_NOTHROW(caller.call("temp_adc", {}, 0, GET, oss)); - std::string s = (oss.str()).erase(0, strlen("temp_adc ")); + std::string const s = (oss.str()).erase(0, strlen("temp_adc ")); REQUIRE(std::stoi(s) != -1); } else { REQUIRE_THROWS(caller.call("temp_adc", {}, -1, GET)); @@ -1991,7 +1991,7 @@ TEST_CASE("temp_fpga", "[.cmdcall]") { REQUIRE_NOTHROW(caller.call("temp_fpga", {}, -1, GET)); std::ostringstream oss; REQUIRE_NOTHROW(caller.call("temp_fpga", {}, 0, GET, oss)); - std::string s = (oss.str()).erase(0, strlen("temp_fpga ")); + std::string const s = (oss.str()).erase(0, strlen("temp_fpga ")); REQUIRE(std::stoi(s) != -1); } else { REQUIRE_THROWS(caller.call("temp_fpga", {}, -1, GET)); @@ -2075,7 +2075,7 @@ TEST_CASE("defaultdac", "[.cmdcall]") { } } if (det_type == defs::JUNGFRAU) { - std::vector daclist = { + std::vector const daclist = { defs::VREF_PRECH, defs::VREF_DS, defs::VREF_COMP}; for (auto it : daclist) { auto dacname = ToString(it); @@ -2955,7 +2955,7 @@ TEST_CASE("txdelay_frame", "[.cmdcall]") { det_type == defs::MYTHEN3) { val = 5; } - std::string sval = std::to_string(val); + std::string const sval = std::to_string(val); { std::ostringstream oss1, oss2; caller.call("txdelay_frame", {sval}, -1, PUT, oss1); @@ -2983,8 +2983,8 @@ TEST_CASE("txdelay", "[.cmdcall]") { det_type == defs::MYTHEN3) && (det.size() < 2)) { REQUIRE_THROWS(caller.call("txdelay", {}, -1, GET)); - int val = 5; - std::string sval = std::to_string(val); + int const val = 5; + std::string const sval = std::to_string(val); { std::ostringstream oss1; caller.call("txdelay", {sval}, -1, PUT, oss1); @@ -3006,7 +3006,7 @@ TEST_CASE("txdelay", "[.cmdcall]") { det_type == defs::MYTHEN3) { val = 5; } - std::string sval = std::to_string(val); + std::string const sval = std::to_string(val); { std::ostringstream oss1, oss2; caller.call("txdelay", {sval}, -1, PUT, oss1); @@ -3279,7 +3279,7 @@ TEST_CASE("reg", "[.cmdcall]") { if (det_type == defs::GOTTHARD2) { addr = 0x298; } - std::string saddr = ToStringHex(addr); + std::string const saddr = ToStringHex(addr); auto prev_val = det.readRegister(addr); { std::ostringstream oss1, oss2; @@ -3338,7 +3338,7 @@ TEST_CASE("setbit", "[.cmdcall]") { if (det_type == defs::GOTTHARD2) { addr = 0x298; } - std::string saddr = ToStringHex(addr); + std::string const saddr = ToStringHex(addr); auto prev_val = det.readRegister(addr); { std::ostringstream oss1, oss2, oss3; @@ -3368,7 +3368,7 @@ TEST_CASE("clearbit", "[.cmdcall]") { if (det_type == defs::GOTTHARD2) { addr = 0x298; } - std::string saddr = ToStringHex(addr); + std::string const saddr = ToStringHex(addr); auto prev_val = det.readRegister(addr); { std::ostringstream oss1, oss2, oss3; @@ -3398,7 +3398,7 @@ TEST_CASE("getbit", "[.cmdcall]") { if (det_type == defs::GOTTHARD2) { addr = 0x298; } - std::string saddr = ToStringHex(addr); + std::string const saddr = ToStringHex(addr); auto prev_val = det.readRegister(addr); { std::ostringstream oss1, oss2; diff --git a/slsDetectorSoftware/tests/test-CmdParser.cpp b/slsDetectorSoftware/tests/test-CmdParser.cpp index cec60358e..6fd698697 100644 --- a/slsDetectorSoftware/tests/test-CmdParser.cpp +++ b/slsDetectorSoftware/tests/test-CmdParser.cpp @@ -15,7 +15,7 @@ using vs = std::vector; SCENARIO("Construction", "[support]") { GIVEN("A default constructed CmdParser") { - CmdParser p; + CmdParser const p; THEN("The state of the object is valid") { REQUIRE(p.detector_id() == -1); REQUIRE(p.multi_id() == 0); @@ -31,7 +31,7 @@ SCENARIO("Parsing a string with the command line parser", "[support]") { GIVEN("A CmdParser") { CmdParser p; WHEN("Parsing an empty string") { - std::string s; + std::string const s; p.Parse(s); THEN("command and arguments are empty") { REQUIRE(p.detector_id() == -1); @@ -42,7 +42,7 @@ SCENARIO("Parsing a string with the command line parser", "[support]") { } } WHEN("Parsing a string with a single command") { - std::string s = "vrf"; + std::string const s = "vrf"; p.Parse(s); THEN("command is assigned and id's remain default") { REQUIRE(p.command() == "vrf"); @@ -53,7 +53,7 @@ SCENARIO("Parsing a string with the command line parser", "[support]") { } } WHEN("Parsing a string with command and value") { - std::string s = "vthreshold 1500"; + std::string const s = "vthreshold 1500"; p.Parse(s); THEN("cmd and value are assigned and id's remain default") { REQUIRE(p.command() == "vthreshold"); @@ -98,7 +98,7 @@ SCENARIO("Parsing a string with the command line parser", "[support]") { } WHEN("Parsing string with cmd and multiple arguments") { - std::string s = "trimen 5000 6000 7000"; + std::string const s = "trimen 5000 6000 7000"; p.Parse(s); THEN("cmd and args are correct") { REQUIRE(p.command() == "trimen"); @@ -115,7 +115,7 @@ SCENARIO("Parsing strings with -h or --help", "[support]") { GIVEN("A parser") { CmdParser p; WHEN("Parsing a string with a command and help ") { - std::string s = "-h list"; + std::string const s = "-h list"; THEN("the command is correct and isHelp is set") { p.Parse(s); @@ -128,7 +128,7 @@ SCENARIO("Parsing strings with -h or --help", "[support]") { } } WHEN("Parsing a string with -h at a different position") { - std::string s = "list -h something"; + std::string const s = "list -h something"; THEN("its also done right") { p.Parse(s); REQUIRE(p.isHelp()); @@ -138,7 +138,7 @@ SCENARIO("Parsing strings with -h or --help", "[support]") { } } WHEN("Parsing a string with -help at a different position") { - std::string s = "list --help something"; + std::string const s = "list --help something"; THEN("its also done right") { p.Parse(s); REQUIRE(p.isHelp()); @@ -186,7 +186,7 @@ TEST_CASE("Parse with no arguments results in no command and default id", "[support]") { // build up argc and argv // first argument is the command used to call the binary - int argc = 1; + int const argc = 1; const char *const argv[]{"call"}; CmdParser p; p.Parse(argc, argv); @@ -200,7 +200,7 @@ TEST_CASE("Parse with no arguments results in no command and default id", TEST_CASE( "Parse a command without client id and detector id results in default", "[support]") { - int argc = 2; + int const argc = 2; const char *const argv[]{"caller", "vrf"}; CmdParser p; p.Parse(argc, argv); @@ -213,7 +213,7 @@ TEST_CASE( TEST_CASE("Parse a command with value but without client or detector id", "[support]") { - int argc = 3; + int const argc = 3; const char *const argv[]{"caller", "vrf", "3000"}; CmdParser p; p.Parse(argc, argv); @@ -226,7 +226,7 @@ TEST_CASE("Parse a command with value but without client or detector id", } TEST_CASE("Decodes position") { - int argc = 2; + int const argc = 2; const char *const argv[]{"caller", "7:vrf"}; CmdParser p; @@ -239,7 +239,7 @@ TEST_CASE("Decodes position") { } TEST_CASE("Decodes double digit position", "[support]") { - int argc = 2; + int const argc = 2; const char *const argv[]{"caller", "73:vcmp"}; CmdParser p; p.Parse(argc, argv); @@ -251,7 +251,7 @@ TEST_CASE("Decodes double digit position", "[support]") { } TEST_CASE("Decodes position and id", "[support]") { - int argc = 2; + int const argc = 2; const char *const argv[]{"caller", "5-8:vrf"}; CmdParser p; p.Parse(argc, argv); @@ -263,7 +263,7 @@ TEST_CASE("Decodes position and id", "[support]") { } TEST_CASE("Double digit id", "[support]") { - int argc = 2; + int const argc = 2; const char *const argv[]{"caller", "56-8:vrf"}; CmdParser p; p.Parse(argc, argv); diff --git a/slsDetectorSoftware/tests/test-CtbConfig.cpp b/slsDetectorSoftware/tests/test-CtbConfig.cpp index bb69fecdc..745521e8f 100644 --- a/slsDetectorSoftware/tests/test-CtbConfig.cpp +++ b/slsDetectorSoftware/tests/test-CtbConfig.cpp @@ -14,7 +14,7 @@ TEST_CASE("Default construction") { (2 * sizeof(int) + (18 + 32 + 64 + 5 + 8) * 20), "Size of CtbConfig does not match "); - CtbConfig c; + CtbConfig const c; auto dacnames = c.getDacNames(); REQUIRE(dacnames.size() == 18); REQUIRE(dacnames[0] == "DAC0"); @@ -81,7 +81,7 @@ TEST_CASE("Copy a CTB config") { TEST_CASE("Move CtbConfig ") { CtbConfig c1; c1.setDacName(3, "yetanothername"); - CtbConfig c2(std::move(c1)); + CtbConfig const c2(std::move(c1)); REQUIRE(c2.getDacName(3) == "yetanothername"); } diff --git a/slsDetectorSoftware/tests/test-Module.cpp b/slsDetectorSoftware/tests/test-Module.cpp index 39d9ef568..c64a4b2b8 100644 --- a/slsDetectorSoftware/tests/test-Module.cpp +++ b/slsDetectorSoftware/tests/test-Module.cpp @@ -10,7 +10,7 @@ namespace sls { using dt = slsDetectorDefs::detectorType; TEST_CASE("Construction with a defined detector type") { freeSharedMemory(0, 0); // clean up to start test - Module m(dt::EIGER); + Module const m(dt::EIGER); REQUIRE(m.getDetectorType() == dt::EIGER); freeSharedMemory(0, 0); // clean up SharedMemory moduleShm(0, 0); @@ -19,10 +19,10 @@ TEST_CASE("Construction with a defined detector type") { TEST_CASE("Read back detector type from shm") { // Create specific detector in order to create shm - Module m(dt::JUNGFRAU); + Module const m(dt::JUNGFRAU); // New detector that reads type from shm - Module m2; + Module const m2; REQUIRE(m2.getDetectorType() == dt::JUNGFRAU); // Now both objects point to the same shm so we can only @@ -33,7 +33,7 @@ TEST_CASE("Read back detector type from shm") { } TEST_CASE("Is shm fixed pattern shm compatible") { - Module m(dt::JUNGFRAU); + Module const m(dt::JUNGFRAU); // Should be true since we just created the shm REQUIRE(m.isFixedPatternSharedMemoryCompatible() == true); @@ -53,7 +53,7 @@ TEST_CASE("Is shm fixed pattern shm compatible") { } TEST_CASE("Get default control port") { - Module m(dt::MYTHEN3); + Module const m(dt::MYTHEN3); REQUIRE(m.getControlPort() == 1952); freeSharedMemory(0, 0); SharedMemory moduleShm(0, 0); @@ -61,7 +61,7 @@ TEST_CASE("Get default control port") { } TEST_CASE("Get default stop port") { - Module m(dt::GOTTHARD2); + Module const m(dt::GOTTHARD2); REQUIRE(m.getStopPort() == 1953); freeSharedMemory(0, 0); SharedMemory moduleShm(0, 0); @@ -69,7 +69,7 @@ TEST_CASE("Get default stop port") { } TEST_CASE("Get default receiver TCP port") { - Module m(dt::MYTHEN3); + Module const m(dt::MYTHEN3); REQUIRE(m.getReceiverPort() == 1954); freeSharedMemory(0, 0); SharedMemory moduleShm(0, 0); diff --git a/slsDetectorSoftware/tests/test-Pattern.cpp b/slsDetectorSoftware/tests/test-Pattern.cpp index 5d74d530f..af488f165 100644 --- a/slsDetectorSoftware/tests/test-Pattern.cpp +++ b/slsDetectorSoftware/tests/test-Pattern.cpp @@ -20,7 +20,7 @@ TEST_CASE("Copy construct pattern") { } TEST_CASE("Compare patterns") { - Pattern p; + Pattern const p; Pattern p1; REQUIRE(p == p1); diff --git a/slsDetectorSoftware/tests/test-Result.cpp b/slsDetectorSoftware/tests/test-Result.cpp index c921dcfb1..e4aa56626 100644 --- a/slsDetectorSoftware/tests/test-Result.cpp +++ b/slsDetectorSoftware/tests/test-Result.cpp @@ -13,7 +13,7 @@ TEST_CASE("Result looks and behaves like a standard container") { } TEST_CASE("Default construction is possible and gives an empty result") { - Result res; + Result const res; REQUIRE(res.size() == 0); REQUIRE(res.empty() == true); } @@ -38,7 +38,7 @@ TEST_CASE("Like vector it can be constructed from size and value") { } TEST_CASE("Result can be iterated using modern syntax") { - Result res{0, 1, 2, 3, 4, 5}; + Result const res{0, 1, 2, 3, 4, 5}; int i = 0; for (const auto &r : res) @@ -46,28 +46,28 @@ TEST_CASE("Result can be iterated using modern syntax") { } TEST_CASE("Calling squash on an empty Result produces default value") { - Result res; + Result const res; REQUIRE(res.squash() == 0.); - Result res2; + Result const res2; REQUIRE(res2.squash() == 0u); - Result res3; + Result const res3; REQUIRE(res3.squash() == ""); } TEST_CASE("When equal squash gives the front value") { - Result res{3, 3, 3}; + Result const res{3, 3, 3}; REQUIRE(res.squash() == 3); } TEST_CASE("When elements are not equal squash gives default value") { - Result res{3, 3, 3, 5}; + Result const res{3, 3, 3, 5}; REQUIRE(res.squash() == 0); } TEST_CASE("String compare with squash") { - Result res{"hej", "hej", "hej"}; + Result const res{"hej", "hej", "hej"}; REQUIRE(res.squash() == "hej"); } @@ -113,13 +113,13 @@ TEST_CASE("Check if elements are equal") { TEST_CASE("Result can be converted to std::vector") { Result res{1, 2, 3, 4, 5}; - std::vector vec{1, 2, 3, 4, 5}; - std::vector vec2 = res; + std::vector const vec{1, 2, 3, 4, 5}; + std::vector const vec2 = res; REQUIRE(vec2 == vec); } TEST_CASE("Result can be printed using <<") { - Result res{1, 2, 3}; + Result const res{1, 2, 3}; std::ostringstream os; os << res; REQUIRE(os.str() == "[1, 2, 3]"); @@ -139,8 +139,8 @@ TEST_CASE("Convert from Result to Result") { TEST_CASE("Result of vectors") { using VecVec = std::vector>; - VecVec vecvec{{1, 2, 3}, {4, 5, 6}}; - Result res{vecvec}; + VecVec const vecvec{{1, 2, 3}, {4, 5, 6}}; + Result const res{vecvec}; } TEST_CASE("Free function begin end") { @@ -159,30 +159,30 @@ TEST_CASE("Sorting a Result") { } TEST_CASE("Printing Result") { - Result res{"ein", "zwei", "drei"}; + Result const res{"ein", "zwei", "drei"}; std::ostringstream os; os << res; REQUIRE(os.str() == "[ein, zwei, drei]"); } TEST_CASE("Printing Result") { - Result res{1, 2, 3}; + Result const res{1, 2, 3}; std::ostringstream os; os << res; REQUIRE(os.str() == "[1, 2, 3]"); } TEST_CASE("String conversions") { - Result res{1, 2, 3}; + Result const res{1, 2, 3}; REQUIRE(ToString(res) == "[1, 2, 3]"); - Result res2{"one", "two", "three"}; + Result const res2{"one", "two", "three"}; REQUIRE(ToString(res2) == "[one, two, three]"); using Smap = std::map; Smap m; m["one"] = "1"; - Result res3{m, m, m}; + Result const res3{m, m, m}; REQUIRE(res3.size() == 3); REQUIRE(ToString(res3) == "[{one: 1}, {one: 1}, {one: 1}]"); @@ -191,25 +191,25 @@ TEST_CASE("String conversions") { m2["two"] = "2"; m2["three"] = "3"; - Result res4{m, m2, m}; + Result const res4{m, m2, m}; REQUIRE(ToString(res4) == "[{one: 1}, {one: 1, three: 3, two: 2}, {one: 1}]"); } TEST_CASE("Any element is equal") { - Result r{1, 2, 3, 4, 5}; + Result const r{1, 2, 3, 4, 5}; REQUIRE(r.any(3)); REQUIRE_FALSE(r.any(9)); } TEST_CASE("Result contains only the specified elements") { - Result r{1, 1, 1}; + Result const r{1, 1, 1}; REQUIRE(r.contains_only(1)); REQUIRE(r.contains_only(1, 1)); } TEST_CASE("Only with multiple values") { - Result r{1, 1, 2, 1, 2, 1, 1}; + Result const r{1, 1, 2, 1, 2, 1, 1}; REQUIRE_FALSE(r.contains_only(1)); REQUIRE_FALSE(r.contains_only(2)); REQUIRE(r.contains_only(1, 2)); diff --git a/slsDetectorSoftware/tests/test-SharedMemory.cpp b/slsDetectorSoftware/tests/test-SharedMemory.cpp index c81f9643d..404144b94 100644 --- a/slsDetectorSoftware/tests/test-SharedMemory.cpp +++ b/slsDetectorSoftware/tests/test-SharedMemory.cpp @@ -105,7 +105,7 @@ TEST_CASE("Create SharedMemory read and write", "[detector][shm]") { shm.createSharedMemory(); const char *env_p = std::getenv(SHM_ENV_NAME); - std::string env_name = env_p ? ("_" + std::string(env_p)) : ""; + std::string const env_name = env_p ? ("_" + std::string(env_p)) : ""; CHECK(shm.getName() == std::string(SHM_DETECTOR_PREFIX) + std::to_string(shm_id) + env_name); shm()->x = 3; @@ -177,7 +177,7 @@ TEST_CASE("Open two shared memories to the same place", "[detector][shm]") { TEST_CASE("Move SharedMemory", "[detector][shm]") { const char *env_p = std::getenv(SHM_ENV_NAME); - std::string env_name = env_p ? ("_" + std::string(env_p)) : ""; + std::string const env_name = env_p ? ("_" + std::string(env_p)) : ""; SharedMemory shm(shm_id, -1); CHECK(shm.getName() == std::string(SHM_DETECTOR_PREFIX) + @@ -198,7 +198,7 @@ TEST_CASE("Move SharedMemory", "[detector][shm]") { TEST_CASE("Create several shared memories", "[detector][shm]") { const char *env_p = std::getenv(SHM_ENV_NAME); - std::string env_name = env_p ? ("_" + std::string(env_p)) : ""; + std::string const env_name = env_p ? ("_" + std::string(env_p)) : ""; constexpr int N = 5; std::vector> v; @@ -225,9 +225,9 @@ TEST_CASE("Create several shared memories", "[detector][shm]") { TEST_CASE("Create create a shared memory with a tag") { const char *env_p = std::getenv(SHM_ENV_NAME); - std::string env_name = env_p ? ("_" + std::string(env_p)) : ""; + std::string const env_name = env_p ? ("_" + std::string(env_p)) : ""; - SharedMemory shm(0, -1, "ctbdacs"); + SharedMemory const shm(0, -1, "ctbdacs"); REQUIRE(shm.getName() == std::string(SHM_DETECTOR_PREFIX) + "0" + env_name + "_ctbdacs"); } @@ -242,7 +242,7 @@ TEST_CASE("Create create a shared memory with a tag when SLSDETNAME is set") { unsetenv(SHM_ENV_NAME); setenv(SHM_ENV_NAME, "myprefix", 1); - SharedMemory shm(0, -1, "ctbdacs"); + SharedMemory const shm(0, -1, "ctbdacs"); REQUIRE(shm.getName() == std::string(SHM_DETECTOR_PREFIX) + "0_myprefix_ctbdacs"); // Clean up after us diff --git a/slsReceiverSoftware/src/Arping.cpp b/slsReceiverSoftware/src/Arping.cpp index 7633e041b..fbdc59fc9 100644 --- a/slsReceiverSoftware/src/Arping.cpp +++ b/slsReceiverSoftware/src/Arping.cpp @@ -38,7 +38,7 @@ void Arping::SetInterfacesAndIps(const int index, const std::string &interface, // create commands to arping std::ostringstream os; os << "arping -c 1 -U -I " << interface << " " << ip; - std::string cmd = os.str(); + std::string const cmd = os.str(); commands[index] = cmd; } @@ -84,7 +84,7 @@ void Arping::StopProcess() { void Arping::ProcessExecution() { while (true) { - std::string error = ExecuteCommands(); + std::string const error = ExecuteCommands(); // just print (was already tested at Process start) if (!error.empty()) { LOG(logERROR) << error; @@ -101,7 +101,7 @@ void Arping::TestForErrors() { "Could not arping. Interface not set up in arping Process"); } // test if arping commands throw an error - std::string error = ExecuteCommands(); + std::string const error = ExecuteCommands(); if (!error.empty()) { throw RuntimeError(error); } diff --git a/slsReceiverSoftware/src/ClientInterface.cpp b/slsReceiverSoftware/src/ClientInterface.cpp index 7acf59e2e..597872a77 100644 --- a/slsReceiverSoftware/src/ClientInterface.cpp +++ b/slsReceiverSoftware/src/ClientInterface.cpp @@ -57,14 +57,14 @@ std::string ClientInterface::getReceiverVersion() { return APIRECEIVER; } /***callback functions***/ void ClientInterface::registerCallBackStartAcquisition( void (*func)(const startCallbackHeader, void *), void *arg) { - std::lock_guard lock(callbackMutex); + std::lock_guard const lock(callbackMutex); startAcquisitionCallBack = func; pStartAcquisition = arg; } void ClientInterface::registerCallBackAcquisitionFinished( void (*func)(const endCallbackHeader, void *), void *arg) { - std::lock_guard lock(callbackMutex); + std::lock_guard const lock(callbackMutex); acquisitionFinishedCallBack = func; pAcquisitionFinished = arg; } @@ -73,7 +73,7 @@ void ClientInterface::registerCallBackRawDataReady( void (*func)(sls_receiver_header &, dataCallbackHeader, char *, size_t &, void *), void *arg) { - std::lock_guard lock(callbackMutex); + std::lock_guard const lock(callbackMutex); rawDataReadyCallBack = func; pRawDataReady = arg; } @@ -338,15 +338,15 @@ int ClientInterface::setup_receiver(Interface &socket) { // udp setup // update retvals only if detmac is not the same as in detector if (arg.udp_dstip != 0) { - MacAddr r = setUdpIp(IpAddr(arg.udp_dstip)); - MacAddr detMac{arg.udp_dstmac}; + MacAddr const r = setUdpIp(IpAddr(arg.udp_dstip)); + MacAddr const detMac{arg.udp_dstmac}; if (detMac != r) { retvals[0] = r; } } if (arg.udp_dstip2 != 0) { - MacAddr r = setUdpIp2(IpAddr(arg.udp_dstip2)); - MacAddr detMac{arg.udp_dstmac2}; + MacAddr const r = setUdpIp2(IpAddr(arg.udp_dstip2)); + MacAddr const detMac{arg.udp_dstmac2}; if (detMac != r) { retvals[1] = r; } @@ -467,7 +467,7 @@ void ClientInterface::setDetectorType(detectorType arg) { } // callbacks after (in setdetectortype, the object is reinitialized) { - std::lock_guard lock(callbackMutex); + std::lock_guard const lock(callbackMutex); if (startAcquisitionCallBack != nullptr) impl()->registerCallBackStartAcquisition(startAcquisitionCallBack, pStartAcquisition); @@ -586,8 +586,8 @@ int ClientInterface::set_num_digital_samples(Interface &socket) { int ClientInterface::set_exptime(Interface &socket) { int64_t args[2]{-1, -1}; socket.Receive(args); - int gateIndex = static_cast(args[0]); - ns value = std::chrono::nanoseconds(args[1]); + int const gateIndex = static_cast(args[0]); + ns const value = std::chrono::nanoseconds(args[1]); LOG(logDEBUG1) << "Setting exptime to " << ToString(value) << " (gateIndex: " << gateIndex << ")"; switch (gateIndex) { @@ -635,7 +635,7 @@ int ClientInterface::set_period(Interface &socket) { int ClientInterface::set_subexptime(Interface &socket) { auto value = std::chrono::nanoseconds(socket.Receive()); LOG(logDEBUG1) << "Setting period to " << ToString(value); - ns subdeadtime = impl()->getSubPeriod() - impl()->getSubExpTime(); + ns const subdeadtime = impl()->getSubPeriod() - impl()->getSubExpTime(); impl()->setSubExpTime(value); impl()->setSubPeriod(impl()->getSubExpTime() + subdeadtime); return socket.Send(OK); @@ -780,7 +780,7 @@ int ClientInterface::get_file_dir(Interface &socket) { } int ClientInterface::set_file_name(Interface &socket) { - std::string fname = socket.Receive(MAX_STR_LENGTH); + std::string const fname = socket.Receive(MAX_STR_LENGTH); if (fname.empty()) { throw RuntimeError("Cannot set empty file name"); } @@ -1115,7 +1115,7 @@ int ClientInterface::set_additional_json_header(Interface &socket) { } int ClientInterface::get_additional_json_header(Interface &socket) { - std::map json = impl()->getAdditionalJsonHeader(); + std::map const json = impl()->getAdditionalJsonHeader(); LOG(logDEBUG1) << "additional json header:" << ToString(json); std::ostringstream oss; for (auto &it : json) { @@ -1319,7 +1319,7 @@ int ClientInterface::set_quad_type(Interface &socket) { std::string(e.what()) + ']'); } } - int retval = impl()->getQuad() ? 1 : 0; + int const retval = impl()->getQuad() ? 1 : 0; validate(quadEnable, retval, "set quad", DEC); LOG(logDEBUG1) << "quad retval:" << retval; return socket.Send(OK); @@ -1336,7 +1336,7 @@ int ClientInterface::set_read_n_rows(Interface &socket) { LOG(logDEBUG1) << "Setting number of rows:" << arg; impl()->setReadNRows(arg); } - int retval = impl()->getReadNRows(); + int const retval = impl()->getReadNRows(); validate(arg, retval, "set number of rows", DEC); LOG(logDEBUG1) << "read number of rows:" << retval; return socket.Send(OK); @@ -1516,7 +1516,7 @@ int ClientInterface::set_additional_json_parameter(Interface &socket) { } int ClientInterface::get_additional_json_parameter(Interface &socket) { - std::string key = socket.Receive(SHORT_STR_LENGTH); + std::string const key = socket.Receive(SHORT_STR_LENGTH); std::string value = impl()->getAdditionalJsonParameter(key); value.resize(SHORT_STR_LENGTH); return socket.sendResult(value); @@ -1541,7 +1541,7 @@ int ClientInterface::set_num_gates(Interface &socket) { int ClientInterface::set_gate_delay(Interface &socket) { int64_t args[2]{-1, -1}; socket.Receive(args); - int gateIndex = static_cast(args[0]); + int const gateIndex = static_cast(args[0]); auto value = std::chrono::nanoseconds(args[1]); LOG(logDEBUG1) << "Setting gate delay to " << ToString(value) << " (gateIndex: " << gateIndex << ")"; @@ -1657,7 +1657,7 @@ int ClientInterface::set_all_threshold(Interface &socket) { int ClientInterface::set_detector_datastream(Interface &socket) { int args[2]{-1, -1}; socket.Receive(args); - portPosition port = static_cast(args[0]); + portPosition const port = static_cast(args[0]); switch (port) { case LEFT: case RIGHT: @@ -1665,7 +1665,7 @@ int ClientInterface::set_detector_datastream(Interface &socket) { default: throw RuntimeError("Invalid port type"); } - bool enable = static_cast(args[1]); + bool const enable = static_cast(args[1]); LOG(logDEBUG1) << "Setting datastream (" << ToString(port) << ") to " << ToString(enable); if (detType != EIGER) diff --git a/slsReceiverSoftware/src/CommandLineOptions.cpp b/slsReceiverSoftware/src/CommandLineOptions.cpp index dbc0c72ae..026546612 100644 --- a/slsReceiverSoftware/src/CommandLineOptions.cpp +++ b/slsReceiverSoftware/src/CommandLineOptions.cpp @@ -21,7 +21,7 @@ ParsedOptions CommandLineOptions::parse(const std::vector &args) { for (const auto &arg : args) { argv.push_back(const_cast(arg.c_str())); } - int argc = static_cast(argv.size()); + int const argc = static_cast(argv.size()); return parse(argc, argv.data()); } @@ -76,7 +76,7 @@ ParsedOptions CommandLineOptions::parse(int argc, char *argv[]) { } // parse deprecated arguments - std::vector args(argv, argv + argc); + std::vector const args(argv, argv + argc); auto [p, n, o] = ParseDeprecated(args); // set options base.port = p; @@ -251,7 +251,7 @@ void CommandLineOptions::handleAppSpecificOption(int opt, const char *optarg, std::tuple CommandLineOptions::ParseDeprecated(const std::vector &args) { - size_t nargs = args.size(); + size_t const nargs = args.size(); if (nargs != 1 && nargs != 3 && nargs != 4) { throw sls::RuntimeError("Invalid number of arguments."); } @@ -266,8 +266,8 @@ CommandLineOptions::ParseDeprecated(const std::vector &args) { } // parse deprecated arguments - uint16_t p = parsePort(args[1].c_str()); - uint16_t n = parseNumReceivers(args[2].c_str()); + uint16_t const p = parsePort(args[1].c_str()); + uint16_t const n = parseNumReceivers(args[2].c_str()); bool o = false; if (nargs == 4) { try { diff --git a/slsReceiverSoftware/src/DataProcessor.cpp b/slsReceiverSoftware/src/DataProcessor.cpp index 8631af36c..efab3d3ee 100644 --- a/slsReceiverSoftware/src/DataProcessor.cpp +++ b/slsReceiverSoftware/src/DataProcessor.cpp @@ -93,7 +93,7 @@ void DataProcessor::SetNumberofTotalFrames(uint64_t value) { void DataProcessor::SetAdditionalJsonHeader( const std::map &json) { - std::lock_guard lock(additionalJsonMutex); + std::lock_guard const lock(additionalJsonMutex); additionalJsonHeader = json; isAdditionalJsonUpdated = true; } @@ -254,7 +254,7 @@ std::string DataProcessor::CreateMasterFile( attr->framesInFile = numFramesCaught; - std::unique_ptr masterFile{nullptr}; + std::unique_ptr const masterFile{nullptr}; switch (fileFormatType) { #ifdef HDF5C case HDF5: @@ -325,11 +325,11 @@ void DataProcessor::StopProcessing(char *buf) { void DataProcessor::ProcessAnImage(sls_receiver_header &header, size_t &size, size_t &firstImageIndex, char *data) { - uint64_t fnum = header.detHeader.frameNumber; + uint64_t const fnum = header.detHeader.frameNumber; LOG(logDEBUG1) << "DataProcessing " << index << ": fnum:" << fnum; currentFrameIndex = fnum; numFramesCaught++; - uint32_t nump = header.detHeader.packetNumber; + uint32_t const nump = header.detHeader.packetNumber; if (!startedFlag) { RecordFirstIndex(fnum); @@ -390,16 +390,16 @@ void DataProcessor::ProcessAnImage(sls_receiver_header &header, size_t &size, // callbacks if (rawDataReadyCallBack != nullptr) { - uint64_t frameIndex = fnum - firstIndex; + uint64_t const frameIndex = fnum - firstIndex; // update local copy only if it was updated (to prevent locking each // time) if (isAdditionalJsonUpdated) { - std::lock_guard lock(additionalJsonMutex); + std::lock_guard const lock(additionalJsonMutex); localAdditionalJsonHeader = additionalJsonHeader; isAdditionalJsonUpdated = false; } - dataCallbackHeader callbackHeader = { + dataCallbackHeader const callbackHeader = { udpPortNumber, {static_cast(generalData->nPixelsX), static_cast(generalData->nPixelsY)}, @@ -446,7 +446,7 @@ bool DataProcessor::CheckTimer() { auto elapsed_s = (end.tv_sec - timerbegin.tv_sec) + (end.tv_nsec - timerbegin.tv_nsec) / 1e9; - double timer_s = streamingTimerInMs / 1e3; + double const timer_s = streamingTimerInMs / 1e3; LOG(logDEBUG1) << index << " Timer elapsed time:" << elapsed_s << " seconds"; @@ -480,7 +480,7 @@ void DataProcessor::registerCallBackRawDataReady( void DataProcessor::PadMissingPackets(sls_receiver_header header, char *data) { LOG(logDEBUG) << index << ": Padding Missing Packets"; - uint32_t pperFrame = generalData->packetsPerFrame; + uint32_t const pperFrame = generalData->packetsPerFrame; uint32_t nmissing = pperFrame - header.detHeader.packetNumber; sls_bitset pmask = header.packetsMask; @@ -489,7 +489,7 @@ void DataProcessor::PadMissingPackets(sls_receiver_header header, char *data) { if (generalData->detType == GOTTHARD2 && index != 0) { dsize = generalData->vetoDataSize; } - uint32_t corrected_dsize = + uint32_t const corrected_dsize = dsize - ((pperFrame * dsize) - generalData->imageSize); LOG(logDEBUG1) << "bitmask: " << pmask.to_string(); @@ -571,7 +571,7 @@ void DataProcessor::ArrangeDbitData(size_t &size, char *data) { const auto ctbDbitList = generalData->ctbDbitList; // TODO! (Erik) Refactor and add tests - int ctbDigitalDataBytes = nDigitalDataBytes - ctbDbitOffset; + int const ctbDigitalDataBytes = nDigitalDataBytes - ctbDbitOffset; // no digital data if (ctbDigitalDataBytes == 0) { @@ -618,13 +618,13 @@ void DataProcessor::ArrangeDbitData(size_t &size, char *data) { ++dest; } - uint8_t byte_index = bi / 8; + uint8_t const byte_index = bi / 8; // loop through the frame digital data for (auto *ptr = source + byte_index; ptr < (source + 8 * numDigitalSamples); ptr += 8) { // get selected bit from each 8 bit - uint8_t bit = (*ptr >> bi % 8) & 1; + uint8_t const bit = (*ptr >> bi % 8) & 1; *dest |= bit << bitoffset; // stored as least significant ++bitoffset; // extract destination in 8 bit batches @@ -648,9 +648,9 @@ void DataProcessor::ArrangeDbitData(size_t &size, char *data) { // loop through digital bit enable vector for (auto bi : ctbDbitList) { // get selected bit from each 64 bit - uint8_t byte_index = bi / 8; + uint8_t const byte_index = bi / 8; - uint8_t bit = (*(ptr + byte_index) >> (bi % 8)) & 1; + uint8_t const bit = (*(ptr + byte_index) >> (bi % 8)) & 1; *dest |= bit << bitoffset; ++bitoffset; // extract destination in 8 bit batches @@ -684,12 +684,12 @@ void DataProcessor::ArrangeDbitData(size_t &size, char *data) { void DataProcessor::CropImage(size_t &size, char *data) { LOG(logDEBUG1) << "Cropping Image to ROI " << ToString(portRoi); - int nPixelsX = generalData->nPixelsX; - int xmin = portRoi.xmin; - int xmax = portRoi.xmax; + int const nPixelsX = generalData->nPixelsX; + int const xmin = portRoi.xmin; + int const xmax = portRoi.xmax; int ymin = portRoi.ymin; - int ymax = portRoi.ymax; - int xwidth = xmax - xmin + 1; + int const ymax = portRoi.ymax; + int const xwidth = xmax - xmin + 1; int ywidth = ymax - ymin + 1; if (ymin == -1 || ymax == -1) { ywidth = 1; @@ -697,11 +697,11 @@ void DataProcessor::CropImage(size_t &size, char *data) { } // calculate total roi size - double bytesPerPixel = generalData->dynamicRange / 8.00; - int startOffset = (int)((nPixelsX * ymin + xmin) * bytesPerPixel); + double const bytesPerPixel = generalData->dynamicRange / 8.00; + int const startOffset = (int)((nPixelsX * ymin + xmin) * bytesPerPixel); // write size into memory - std::size_t roiImageSize = xwidth * ywidth * bytesPerPixel; + std::size_t const roiImageSize = xwidth * ywidth * bytesPerPixel; LOG(logDEBUG) << "roiImageSize:" << roiImageSize; size = roiImageSize; diff --git a/slsReceiverSoftware/src/DataStreamer.cpp b/slsReceiverSoftware/src/DataStreamer.cpp index 8a8e83833..04e2b1942 100644 --- a/slsReceiverSoftware/src/DataStreamer.cpp +++ b/slsReceiverSoftware/src/DataStreamer.cpp @@ -48,7 +48,7 @@ void DataStreamer::SetNumberofTotalFrames(uint64_t value) { void DataStreamer::SetAdditionalJsonHeader( const std::map &json) { - std::lock_guard lock(additionalJsonMutex); + std::lock_guard const lock(additionalJsonMutex); additionalJsonHeader = json; isAdditionalJsonUpdated = true; } @@ -77,7 +77,7 @@ void DataStreamer::RecordFirstIndex(uint64_t fnum, size_t firstImageIndex) { } void DataStreamer::CreateZmqSockets(uint16_t port, int hwm) { - uint16_t portnum = port + index; + uint16_t const portnum = port + index; try { zmqSocket = new ZmqSocket(portnum); @@ -149,7 +149,7 @@ void DataStreamer::StopProcessing(char *buf) { void DataStreamer::ProcessAnImage(sls_detector_header header, size_t size, char *data) { - uint64_t fnum = header.frameNumber; + uint64_t const fnum = header.frameNumber; LOG(logDEBUG1) << "DataStreamer " << index << ": fnum:" << fnum; if (!SendDataHeader(header, size, generalData->nPixelsX, @@ -177,8 +177,8 @@ int DataStreamer::SendDataHeader(sls_detector_header header, uint32_t size, zHeader.data = true; zHeader.jsonversion = SLS_DETECTOR_JSON_HEADER_VERSION; - uint64_t frameIndex = header.frameNumber - firstIndex; - uint64_t acquisitionIndex = header.frameNumber; + uint64_t const frameIndex = header.frameNumber - firstIndex; + uint64_t const acquisitionIndex = header.frameNumber; zHeader.dynamicRange = generalData->dynamicRange; zHeader.fileIndex = fileIndex; @@ -212,7 +212,7 @@ int DataStreamer::SendDataHeader(sls_detector_header header, uint32_t size, // update local copy only if it was updated (to prevent locking each time) if (isAdditionalJsonUpdated) { - std::lock_guard lock(additionalJsonMutex); + std::lock_guard const lock(additionalJsonMutex); localAdditionalJsonHeader = additionalJsonHeader; isAdditionalJsonUpdated = false; } diff --git a/slsReceiverSoftware/src/Fifo.cpp b/slsReceiverSoftware/src/Fifo.cpp index 1bec44e12..d5549df27 100644 --- a/slsReceiverSoftware/src/Fifo.cpp +++ b/slsReceiverSoftware/src/Fifo.cpp @@ -41,13 +41,13 @@ void Fifo::CreateFifos(size_t fifoItemSize) { fifoFree = new CircularFifo(fifoDepth); fifoStream = new CircularFifo(fifoDepth); // allocate memory - size_t mem_len = fifoItemSize * (size_t)fifoDepth * sizeof(char); + size_t const mem_len = fifoItemSize * (size_t)fifoDepth * sizeof(char); memory = (char *)malloc(mem_len); if (memory == nullptr) { throw RuntimeError("Could not allocate memory for fifos"); } memset(memory, 0, mem_len); - int pagesize = getpagesize(); + int const pagesize = getpagesize(); for (size_t i = 0; i < mem_len; i += pagesize) { strcpy(memory + i, "memory"); } @@ -84,14 +84,14 @@ void Fifo::DestroyFifos() { void Fifo::FreeAddress(char *&address) { fifoFree->push(address); } void Fifo::GetNewAddress(char *&address) { - int temp = fifoFree->getDataValue(); + int const temp = fifoFree->getDataValue(); if (temp < status_fifoFree) status_fifoFree = temp; fifoFree->pop(address); } void Fifo::PushAddress(char *&address) { - int temp = fifoBound->getDataValue(); + int const temp = fifoBound->getDataValue(); if (temp > status_fifoBound) status_fifoBound = temp; while (!fifoBound->push(address)) @@ -108,13 +108,13 @@ void Fifo::PushAddressToStream(char *&address) { fifoStream->push(address); } void Fifo::PopAddressToStream(char *&address) { fifoStream->pop(address); } int Fifo::GetMaxLevelForFifoBound() { - int temp = status_fifoBound; + int const temp = status_fifoBound; status_fifoBound = 0; return temp; } int Fifo::GetMinLevelForFifoFree() { - int temp = status_fifoFree; + int const temp = status_fifoFree; status_fifoFree = fifoDepth; return temp; } diff --git a/slsReceiverSoftware/src/FrameSynchronizerApp.cpp b/slsReceiverSoftware/src/FrameSynchronizerApp.cpp index fc48814a9..fb5e58eda 100644 --- a/slsReceiverSoftware/src/FrameSynchronizerApp.cpp +++ b/slsReceiverSoftware/src/FrameSynchronizerApp.cpp @@ -65,7 +65,7 @@ FrameStatus *global_frame_status = nullptr; void cleanup() { if (global_frame_status) { - std::lock_guard lock(global_frame_status->mtx); + std::lock_guard const lock(global_frame_status->mtx); for (auto &outer_pair : global_frame_status->frames) { for (auto &inner_pair : outer_pair.second) { for (zmq_msg_t *msg : inner_pair.second) { @@ -146,11 +146,11 @@ std::set get_valid_fnums(const PortFrameMap &port_frame_map) { } int zmq_send_multipart(void *socket, const ZmqMsgList &messages) { - size_t num_messages = messages.size(); + size_t const num_messages = messages.size(); for (size_t i = 0; i != num_messages; ++i) { zmq_msg_t *msg = messages[i]; // determine flags: ZMQ_SNDMORE for all messages except the last - int flags = (i == num_messages - 1) ? 0 : ZMQ_SNDMORE; + int const flags = (i == num_messages - 1) ? 0 : ZMQ_SNDMORE; if (zmq_msg_send(msg, socket, flags) == -1) { LOG(sls::logERROR) << "Error sending message: " << zmq_strerror(zmq_errno()); @@ -164,7 +164,7 @@ void Correlate(FrameStatus *stat) { void *context = zmq_ctx_new(); void *socket = zmq_socket(context, ZMQ_PUSH); - int rc = zmq_bind(socket, "tcp://*:5555"); + int const rc = zmq_bind(socket, "tcp://*:5555"); if (rc != 0) { LOG(sls::logERROR) << "failed to bind"; } @@ -172,7 +172,7 @@ void Correlate(FrameStatus *stat) { while (true) { sem_wait(&(stat->available)); { - std::lock_guard lock(stat->mtx); + std::lock_guard const lock(stat->mtx); if (stat->terminate) { break; @@ -304,10 +304,10 @@ void StartAcquisitionCallback( } oss << "}\n"; - std::string message = oss.str(); + std::string const message = oss.str(); LOG(sls::logDEBUG) << "Start Acquisition message:" << std::endl << message; - int length = message.length(); + int const length = message.length(); char *hdata = new char[length]; memcpy(hdata, message.c_str(), length); zmq_msg_t *hmsg = new zmq_msg_t; @@ -316,7 +316,7 @@ void StartAcquisitionCallback( // push zmq msg into stat to be processed FrameStatus *stat = static_cast(objectPointer); { - std::lock_guard lock(stat->mtx); + std::lock_guard const lock(stat->mtx); stat->headers.push_back(hmsg); stat->starting = true; // clean up old frames @@ -355,8 +355,8 @@ void AcquisitionFinishedCallback( << sls::ToString(callbackHeader.completeFrames) << ", \"lastFrameIndex\":" << sls::ToString(callbackHeader.lastFrameIndex) << "}\n"; - std::string message = oss.str(); - int length = message.length(); + std::string const message = oss.str(); + int const length = message.length(); LOG(sls::logDEBUG) << "Acquisition Finished message:" << std::endl << message; @@ -368,7 +368,7 @@ void AcquisitionFinishedCallback( // push zmq msg into stat to be processed FrameStatus *stat = static_cast(objectPointer); { - std::lock_guard lock(stat->mtx); + std::lock_guard const lock(stat->mtx); stat->ends.push_back(hmsg); } sem_post(&stat->available); @@ -379,7 +379,7 @@ void GetDataCallback(slsDetectorDefs::sls_receiver_header &header, char *dataPointer, size_t &imageSize, void *objectPointer) { - slsDetectorDefs::sls_detector_header detectorHeader = header.detHeader; + slsDetectorDefs::sls_detector_header const detectorHeader = header.detHeader; if (printHeadersLevel < sls::logDEBUG) { // print in different color for each udp port @@ -468,11 +468,11 @@ void GetDataCallback(slsDetectorDefs::sls_receiver_header &header, oss << " } "; } oss << "}\n"; - std::string message = oss.str(); + std::string const message = oss.str(); LOG(sls::logDEBUG) << "Data message:" << std::endl << message; // creating header part of data packet - int length = message.length(); + int const length = message.length(); char *hdata = new char[length]; memcpy(hdata, message.c_str(), length); zmq_msg_t *hmsg = new zmq_msg_t; @@ -486,7 +486,7 @@ void GetDataCallback(slsDetectorDefs::sls_receiver_header &header, // push both parts into stat to be processed FrameStatus *stat = static_cast(objectPointer); { - std::lock_guard lock(stat->mtx); + std::lock_guard const lock(stat->mtx); stat->frames[callbackHeader.udpPort][header.detHeader.frameNumber] .push_back(hmsg); stat->frames[callbackHeader.udpPort][header.detHeader.frameNumber] @@ -544,7 +544,7 @@ int main(int argc, char *argv[]) { std::exception_ptr threadException = nullptr; for (int i = 0; i != f.numReceivers; ++i) { - uint16_t port = f.port + i; + uint16_t const port = f.port + i; sem_t *semaphore = &semaphores[i]; threads.emplace_back( [i, semaphore, port, user_data, &threadException]() { @@ -581,7 +581,7 @@ int main(int argc, char *argv[]) { cleanup(); { - std::lock_guard lock(stat.mtx); + std::lock_guard const lock(stat.mtx); stat.terminate = true; sem_post(&stat.available); } diff --git a/slsReceiverSoftware/src/Implementation.cpp b/slsReceiverSoftware/src/Implementation.cpp index afffb317d..7004c9feb 100644 --- a/slsReceiverSoftware/src/Implementation.cpp +++ b/slsReceiverSoftware/src/Implementation.cpp @@ -238,9 +238,9 @@ const slsDetectorDefs::xy Implementation::GetPortGeometry() const { } void Implementation::setDetectorSize(const slsDetectorDefs::xy size) { - xy portGeometry = GetPortGeometry(); + xy const portGeometry = GetPortGeometry(); - std::string log_message = "Detector Size (ports): ("; + std::string const log_message = "Detector Size (ports): ("; numModules = size; numPorts.x = portGeometry.x * numModules.x; numPorts.y = portGeometry.y * numModules.y; @@ -262,7 +262,7 @@ void Implementation::setModulePositionId(const int id) { LOG(logINFO) << "Module Position Id:" << modulePos; // update zmq port - xy portGeometry = GetPortGeometry(); + xy const portGeometry = GetPortGeometry(); streamingPort = DEFAULT_ZMQ_RX_PORTNO + modulePos * portGeometry.x; assert(numModules.y != 0); @@ -285,14 +285,14 @@ void Implementation::setModulePositionId(const int id) { void Implementation::setRow(const int value) { for (unsigned int i = 0; i < listener.size(); ++i) { - int col = listener[i]->GetHardCodedPosition().second; + int const col = listener[i]->GetHardCodedPosition().second; listener[i]->SetHardCodedPosition(value, col); } } void Implementation::setColumn(const int value) { for (unsigned int i = 0; i < listener.size(); ++i) { - int row = listener[i]->GetHardCodedPosition().first; + int const row = listener[i]->GetHardCodedPosition().first; listener[i]->SetHardCodedPosition(row, value); } } @@ -405,16 +405,16 @@ std::vector Implementation::getPortROIs() const { } void Implementation::ResetRois() { - int numports = generalData->numUDPInterfaces; - std::vector rois(numports); - std::vector multiRoi(1); + int const numports = generalData->numUDPInterfaces; + std::vector const rois(numports); + std::vector const multiRoi(1); setPortROIs(rois); setMultiROIMetadata(multiRoi); } void Implementation::setPortROIs(const std::vector &args) { - int nx = static_cast(generalData->nPixelsX); - int ny = static_cast(generalData->nPixelsY); + int const nx = static_cast(generalData->nPixelsX); + int const ny = static_cast(generalData->nPixelsY); // validate rois for (auto &it : args) { if (it.completeRoi() || it.noRoi()) { @@ -614,7 +614,7 @@ double Implementation::getProgress() const { std::vector Implementation::getNumMissingPackets() const { std::vector mp(generalData->numUDPInterfaces); for (int i = 0; i < generalData->numUDPInterfaces; ++i) { - int np = generalData->packetsPerFrame; + int const np = generalData->packetsPerFrame; uint64_t totnp = np; // ReadNRows if (readNRows != (int)generalData->maxRowsPerReadout) { @@ -646,7 +646,7 @@ void Implementation::startReceiver() { for (size_t i = 0; i != listener.size(); ++i) { udpPort.push_back(udpPortNum[i]); } - startCallbackHeader callbackHeader = { + startCallbackHeader const callbackHeader = { udpPort, generalData->dynamicRange, numPorts, @@ -731,7 +731,7 @@ void Implementation::stopReceiver() { // print summary uint64_t tot = 0; for (int i = 0; i < generalData->numUDPInterfaces; i++) { - int nf = listener[i]->GetNumCompleteFramesCaught(); + int const nf = listener[i]->GetNumCompleteFramesCaught(); tot += nf; std::string mpMessage = std::to_string(mp[i]); if (mp[i] < 0) { @@ -756,7 +756,7 @@ void Implementation::stopReceiver() { summary = os.str(); } - TLogLevel lev = ((mp[i]) > 0) ? logINFORED : logINFOGREEN; + TLogLevel const lev = ((mp[i]) > 0) ? logINFORED : logINFOGREEN; LOG(lev) << "Summary of Port " << udpPortNum[i] << " (" << eth[i] << ')' << summary; } @@ -774,7 +774,7 @@ void Implementation::stopReceiver() { lastFrameIndexCaught.push_back( listener[i]->GetLastFrameIndexCaught()); } - endCallbackHeader callHeader = {udpPort, completeFramesCaught, + endCallbackHeader const callHeader = {udpPort, completeFramesCaught, lastFrameIndexCaught}; acquisitionFinishedCallBack(callHeader, pAcquisitionFinished); } catch (const std::exception &e) { @@ -852,7 +852,7 @@ void Implementation::ResetParametersforNewAcquisition() { if (dataStreamEnable) { std::ostringstream os; os << filePath << '/' << fileName; - std::string fnametostream = os.str(); + std::string const fnametostream = os.str(); for (const auto &it : dataStreamer) it->ResetParametersforNewAcquisition(fnametostream); } @@ -884,7 +884,7 @@ void Implementation::SetupWriter() { std::ostringstream os; os << filePath << "/" << fileName << "_d" << (modulePos * generalData->numUDPInterfaces + i); - std::string fileNamePrefix = os.str(); + std::string const fileNamePrefix = os.str(); dataProcessor[i]->CreateFirstFiles(fileNamePrefix, fileIndex, overwriteEnable, silentMode, detectorDataStream[i]); @@ -919,8 +919,8 @@ void Implementation::StartMasterWriter() { // complete ROI (for each port TODO?) if (multiRoiMetadata.size() == 1 && multiRoiMetadata[0].completeRoi()) { - int nTotalPixelsX = (generalData->nPixelsX * numPorts.x); - int nTotalPixelsY = (generalData->nPixelsY * numPorts.y); + int const nTotalPixelsX = (generalData->nPixelsX * numPorts.x); + int const nTotalPixelsY = (generalData->nPixelsY * numPorts.y); if (nTotalPixelsY == 1) { masterAttributes.rois.push_back(ROI{0, nTotalPixelsX - 1}); } else { @@ -1180,7 +1180,7 @@ int Implementation::getUDPSocketBufferSize() const { } void Implementation::setUDPSocketBufferSize(const int s) { - size_t listSize = listener.size(); + size_t const listSize = listener.size(); if ((generalData->detType == JUNGFRAU || generalData->detType == MOENCH || generalData->detType == GOTTHARD2) && (int)listSize != generalData->numUDPInterfaces) { @@ -1572,7 +1572,7 @@ void Implementation::setCounterMask(const uint32_t i) { SetupFifoStructure(); } LOG(logINFO) << "Counter mask: " << ToStringHex(generalData->counterMask); - int ncounters = __builtin_popcount(generalData->counterMask); + int const ncounters = __builtin_popcount(generalData->counterMask); LOG(logINFO) << "Number of counters: " << ncounters; } @@ -1661,13 +1661,13 @@ void Implementation::setActivate(bool enable) { } bool Implementation::getDetectorDataStream(const portPosition port) const { - int index = (port == LEFT ? 0 : 1); + int const index = (port == LEFT ? 0 : 1); return detectorDataStream[index]; } void Implementation::setDetectorDataStream(const portPosition port, const bool enable) { - int index = (port == LEFT ? 0 : 1); + int const index = (port == LEFT ? 0 : 1); detectorDataStream10GbE[index] = enable; LOG(logINFO) << "Detector 10GbE datastream (" << ToString(port) << " Port): " << ToString(detectorDataStream10GbE[index]); diff --git a/slsReceiverSoftware/src/Listener.cpp b/slsReceiverSoftware/src/Listener.cpp index f1450e847..637a0921b 100644 --- a/slsReceiverSoftware/src/Listener.cpp +++ b/slsReceiverSoftware/src/Listener.cpp @@ -193,10 +193,10 @@ void Listener::DeleteUDPSocket() { void Listener::CreateDummySocketForUDPSocketBufferSize(int s, int &actualSize) { // custom setup (s != 0) // default setup at startup (s = 0) - int size = (s == 0 ? generalData->udpSocketBufferSize : s); + int const size = (s == 0 ? generalData->udpSocketBufferSize : s); LOG(logINFO) << "Testing UDP Socket Buffer size " << size << " with test port " << udpPortNumber; - int previousSize = generalData->udpSocketBufferSize; + int const previousSize = generalData->udpSocketBufferSize; generalData->udpSocketBufferSize = size; if (disabledPort) { @@ -217,7 +217,7 @@ void Listener::CreateDummySocketForUDPSocketBufferSize(int s, int &actualSize) { std::string ip; if (eth.length() > 0) ip = InterfaceNameToIp(eth).str(); - UdpRxSocket g(udpPortNumber, packetSize, + UdpRxSocket const g(udpPortNumber, packetSize, (ip.empty() ? nullptr : ip.c_str()), generalData->udpSocketBufferSize); @@ -268,7 +268,7 @@ void Listener::ThreadExecution() { // reset header and size and get data memset(memImage, 0, IMAGE_STRUCTURE_HEADER_SIZE); - int rc = ListenToAnImage(memImage->header, memImage->data); + int const rc = ListenToAnImage(memImage->header, memImage->data); // end of acquisition or discarding image if (rc <= 0) { @@ -320,9 +320,9 @@ uint32_t Listener::ListenToAnImage(sls_receiver_header &dstHeader, hsize = generalData->vetoHsize; standardHeader = false; } - uint32_t pperFrame = generalData->packetsPerFrame; + uint32_t const pperFrame = generalData->packetsPerFrame; bool isHeaderEmpty = true; - uint32_t corrected_dsize = dsize - ((pperFrame * dsize) - imageSize); + uint32_t const corrected_dsize = dsize - ((pperFrame * dsize) - imageSize); sls_detector_header *srcDetHeader = nullptr; // carry over packet @@ -516,9 +516,9 @@ void Listener::PrintFifoStatistics() { << " packetsperframe:" << generalData->packetsPerFrame; // calculate packet loss - int64_t totalP = numFramesStatistic * (generalData->packetsPerFrame); - int64_t loss = totalP - numPacketsStatistic; - int lossPercent = ((double)loss / (double)totalP) * 100.00; + int64_t const totalP = numFramesStatistic * (generalData->packetsPerFrame); + int64_t const loss = totalP - numPacketsStatistic; + int const lossPercent = ((double)loss / (double)totalP) * 100.00; numPacketsStatistic = 0; numFramesStatistic = 0; diff --git a/slsReceiverSoftware/src/MasterAttributes.cpp b/slsReceiverSoftware/src/MasterAttributes.cpp index 76907ea04..0ca762bf2 100644 --- a/slsReceiverSoftware/src/MasterAttributes.cpp +++ b/slsReceiverSoftware/src/MasterAttributes.cpp @@ -756,7 +756,7 @@ void MasterAttributes::WriteHDF5Version(H5::H5File *fd) { #endif void MasterAttributes::WriteBinaryTimestamp(writer *w) { - time_t t = std::time(nullptr); + time_t const t = std::time(nullptr); std::string sTime(ctime(&t)); std::replace(sTime.begin(), sTime.end(), '\n', '\0'); WriteBinary(w, N_TIMESTAMP.data(), sTime); diff --git a/slsReceiverSoftware/src/MultiReceiverApp.cpp b/slsReceiverSoftware/src/MultiReceiverApp.cpp index a1bc4cb83..a8ca6e5db 100644 --- a/slsReceiverSoftware/src/MultiReceiverApp.cpp +++ b/slsReceiverSoftware/src/MultiReceiverApp.cpp @@ -76,7 +76,7 @@ void GetData(slsDetectorDefs::sls_receiver_header &header, slsDetectorDefs::dataCallbackHeader callbackHeader, char *dataPointer, size_t &imageSize, void *objectPointer) { - slsDetectorDefs::sls_detector_header detectorHeader = header.detHeader; + slsDetectorDefs::sls_detector_header const detectorHeader = header.detHeader; PRINT_IN_COLOR( (callbackHeader.udpPort % 10), @@ -169,7 +169,7 @@ int main(int argc, char *argv[]) { for (int i = 0; i < m.numReceivers; ++i) { /** - fork process to create child process */ - pid_t pid = fork(); + pid_t const pid = fork(); /** - if fork failed, raise SIGINT and properly destroy all child * processes */ @@ -185,7 +185,7 @@ int main(int argc, char *argv[]) { << "Child process " << i << " [ Tid: " << gettid() << ']'; try { - uint16_t port = m.port + i; + uint16_t const port = m.port + i; sls::Receiver receiver(port); /** - register callbacks. remember to set file write enable @@ -236,7 +236,7 @@ int main(int argc, char *argv[]) { /** - Parent process waits for all child processes to exit */ for (;;) { int status; - pid_t childPid = waitpid(-1, &status, 0); + pid_t const childPid = waitpid(-1, &status, 0); // no child closed if (childPid == -1) { diff --git a/slsReceiverSoftware/src/ReceiverApp.cpp b/slsReceiverSoftware/src/ReceiverApp.cpp index 92ff84b50..b90ae3531 100644 --- a/slsReceiverSoftware/src/ReceiverApp.cpp +++ b/slsReceiverSoftware/src/ReceiverApp.cpp @@ -54,7 +54,7 @@ int main(int argc, char *argv[]) { sem_init(&semaphore, 1, 0); try { - sls::Receiver r(o.port); + sls::Receiver const r(o.port); LOG(sls::logINFO) << "[ Press \'Ctrl+c\' to exit ]"; sem_wait(&semaphore); sem_destroy(&semaphore); diff --git a/slsReceiverSoftware/tests/test-Apps.cpp b/slsReceiverSoftware/tests/test-Apps.cpp index fbbd2ff96..e366f803d 100644 --- a/slsReceiverSoftware/tests/test-Apps.cpp +++ b/slsReceiverSoftware/tests/test-Apps.cpp @@ -14,19 +14,19 @@ template constexpr bool is_type() { } TEST_CASE("CommandLineOption construction", "[detector]") { - CommandLineOptions s(AppType::SingleReceiver); + CommandLineOptions const s(AppType::SingleReceiver); REQUIRE(s.getTypeString() == "slsReceiver"); REQUIRE(s.getVersion() == std::string("slsReceiver Version: ") + APIRECEIVER); REQUIRE_NOTHROW(s.getHelpMessage()); - CommandLineOptions m(AppType::MultiReceiver); + CommandLineOptions const m(AppType::MultiReceiver); REQUIRE(m.getTypeString() == "slsMultiReceiver"); REQUIRE(m.getVersion() == std::string("slsMultiReceiver Version: ") + APIRECEIVER); REQUIRE_NOTHROW(m.getHelpMessage()); - CommandLineOptions f(AppType::FrameSynchronizer); + CommandLineOptions const f(AppType::FrameSynchronizer); REQUIRE(f.getTypeString() == "slsFrameSynchronizer"); REQUIRE(f.getVersion() == std::string("slsFrameSynchronizer Version: ") + APIRECEIVER); @@ -49,7 +49,7 @@ TEST_CASE("Parse Help", "[detector]") { } TEST_CASE("Validate common options", "[detector]") { - std::string uidStr = std::to_string(getuid()); + std::string const uidStr = std::to_string(getuid()); for (auto app : {AppType::SingleReceiver, AppType::MultiReceiver, AppType::FrameSynchronizer}) { @@ -65,7 +65,7 @@ TEST_CASE("Validate common options", "[detector]") { } TEST_CASE("Validate specific options", "[detector]") { - std::string uidStr = std::to_string(getuid()); + std::string const uidStr = std::to_string(getuid()); CommandLineOptions s(AppType::SingleReceiver); REQUIRE_NOTHROW(s.parse({"", "-t", "1955"})); @@ -141,9 +141,9 @@ TEST_CASE("Parse version and help", "[detector]") { // TODO: fails on gitea CI due to uid issue, fix later TEST_CASE("Parse port and uid", "[.failsongitea][detector]") { uid_t uid = getuid(); - std::string uidStr = std::to_string(uid); - uid_t invalidUid = uid + 1000; - std::string invalidUidStr = std::to_string(invalidUid); + std::string const uidStr = std::to_string(uid); + uid_t const invalidUid = uid + 1000; + std::string const invalidUidStr = std::to_string(invalidUid); for (auto app : {AppType::SingleReceiver, AppType::MultiReceiver, AppType::FrameSynchronizer}) { diff --git a/slsReceiverSoftware/tests/test-ArrangeDataBasedOnBitList.cpp b/slsReceiverSoftware/tests/test-ArrangeDataBasedOnBitList.cpp index db278658e..a115c4a1b 100644 --- a/slsReceiverSoftware/tests/test-ArrangeDataBasedOnBitList.cpp +++ b/slsReceiverSoftware/tests/test-ArrangeDataBasedOnBitList.cpp @@ -109,9 +109,9 @@ class DataProcessorTestFixture { void set_data(const std::bitset<8> pattern = 0xFF) { delete[] data; - uint64_t max_bytes_per_bit = + uint64_t const max_bytes_per_bit = num_samples % 8 == 0 ? num_samples / 8 : num_samples / 8 + 1; - uint64_t reserved_size = + uint64_t const reserved_size = get_size() - num_digital_bytes + max_bytes_per_bit * 64; data = new char[reserved_size]; @@ -148,7 +148,7 @@ TEST_CASE_METHOD(DataProcessorTestFixture, "Remove Trailing Bits", generaldata->SetCtbDbitOffset(num_random_offset_bytes); - size_t expected_size = get_size() - num_random_offset_bytes; + size_t const expected_size = get_size() - num_random_offset_bytes; char *expected_data = new char[expected_size]; memset(expected_data, dummy_value, num_analog_bytes); // set to 125 @@ -287,7 +287,7 @@ TEST_CASE_METHOD(DataProcessorTestFixture, "Arrange bitlist with reorder false", set_num_samples(num_samples); set_data(0b01010101); // set digital data to 0x55 to have alternating bits - size_t expected_size = + size_t const expected_size = num_analog_bytes + num_transceiver_bytes + expected_num_digital_bytes; // create expected data @@ -343,7 +343,7 @@ TEST_CASE_METHOD(DataProcessorTestFixture, "Arrange bitlist with reorder true", set_num_samples(num_samples); set_data(0b01010101); - size_t expected_size = + size_t const expected_size = num_analog_bytes + num_transceiver_bytes + expected_num_digital_bytes; // create expected data @@ -371,8 +371,8 @@ TEST_CASE_METHOD(DataProcessorTestFixture, "Arrange bitlist and remove trailing bits", "[.dataprocessor][.retrievebitlist]") { - size_t num_random_offset_bytes = 3; - std::vector bitlist{1, 4, 5}; + size_t const num_random_offset_bytes = 3; + std::vector const bitlist{1, 4, 5}; set_random_offset_bytes(num_random_offset_bytes); set_data(); @@ -386,7 +386,7 @@ TEST_CASE_METHOD(DataProcessorTestFixture, std::vector expected_digital_part{0b00000111}; const size_t expected_num_digital_bytes = 5; - size_t expected_size = + size_t const expected_size = num_analog_bytes + num_transceiver_bytes + expected_num_digital_bytes; // create expected data diff --git a/slsSupportLib/include/sls/sls_detector_defs.h b/slsSupportLib/include/sls/sls_detector_defs.h index d028d4238..33ce2764a 100644 --- a/slsSupportLib/include/sls/sls_detector_defs.h +++ b/slsSupportLib/include/sls/sls_detector_defs.h @@ -788,9 +788,9 @@ typedef struct { explicit sls_detector_module(slsDetectorDefs::detectorType type) : sls_detector_module() { - detParameters parameters{type}; - int nch = parameters.nChanX * parameters.nChanY; - int nc = parameters.nChipX * parameters.nChipY; + const detParameters parameters{type}; //used to initialize + const int nch = parameters.nChanX * parameters.nChanY; + const int nc = parameters.nChipX * parameters.nChipY; ndac = parameters.nDacs; nchip = nc; nchan = nch * nc; diff --git a/slsSupportLib/src/ClientSocket.cpp b/slsSupportLib/src/ClientSocket.cpp index 117e7621c..6341af111 100644 --- a/slsSupportLib/src/ClientSocket.cpp +++ b/slsSupportLib/src/ClientSocket.cpp @@ -24,7 +24,7 @@ ClientSocket::ClientSocket(std::string stype, const std::string &host, hints.ai_flags |= AI_CANONNAME; if (getaddrinfo(host.c_str(), nullptr, &hints, &result) != 0) { - std::string msg = "ClientSocket cannot decode host:" + host + + std::string const msg = "ClientSocket cannot decode host:" + host + " on port " + std::to_string(port) + "\n"; throw SocketError(msg); } @@ -40,7 +40,7 @@ ClientSocket::ClientSocket(std::string stype, const std::string &host, if (::connect(getSocketId(), (struct sockaddr *)&serverAddr, sizeof(serverAddr)) != 0) { freeaddrinfo(result); - std::string msg = "ClientSocket: Cannot connect to " + socketType + + std::string const msg = "ClientSocket: Cannot connect to " + socketType + ":" + host + " on port " + std::to_string(port) + "\n"; throw SocketError(msg); @@ -54,7 +54,7 @@ ClientSocket::ClientSocket(std::string sType, struct sockaddr_in addr) if (::connect(getSocketId(), (struct sockaddr *)&addr, sizeof(addr)) != 0) { char address[INET_ADDRSTRLEN]; inet_ntop(AF_INET, &addr.sin_addr, address, INET_ADDRSTRLEN); - std::string msg = "ClientSocket: Cannot connect to " + socketType + + std::string const msg = "ClientSocket: Cannot connect to " + socketType + ":" + address + " on port " + std::to_string(addr.sin_port) + "\n"; throw SocketError(msg); @@ -77,7 +77,7 @@ void ClientSocket::readReply(int &ret, void *retval, size_t retval_size) { try { Receive(&ret, sizeof(ret)); if (ret == slsDetectorDefs::FAIL) { - std::string mess = readErrorMessage(); + std::string const mess = readErrorMessage(); // Do we need to know hostname here? // In that case save it??? if (socketType == "Receiver") { diff --git a/slsSupportLib/src/DataSocket.cpp b/slsSupportLib/src/DataSocket.cpp index 25d016d0b..827c63508 100644 --- a/slsSupportLib/src/DataSocket.cpp +++ b/slsSupportLib/src/DataSocket.cpp @@ -48,7 +48,7 @@ void DataSocket::setFnum(const int fnum) { fnum_ = fnum; } int DataSocket::Receive(void *buffer, size_t size) { // TODO!(Erik) Add sleep? how many reties? - int bytes_expected = static_cast(size); // signed size + int const bytes_expected = static_cast(size); // signed size int bytes_read = 0; while (bytes_read < bytes_expected) { auto this_read = @@ -79,7 +79,7 @@ std::string DataSocket::Receive(size_t length) { } int DataSocket::Send(const void *buffer, size_t size) { int bytes_sent = 0; - int data_size = static_cast(size); // signed size + int const data_size = static_cast(size); // signed size while (bytes_sent < (data_size)) { auto this_send = ::write(getSocketId(), buffer, size); if (this_send <= 0) diff --git a/slsSupportLib/src/ServerSocket.cpp b/slsSupportLib/src/ServerSocket.cpp index e61c5d132..e139c884a 100644 --- a/slsSupportLib/src/ServerSocket.cpp +++ b/slsSupportLib/src/ServerSocket.cpp @@ -47,7 +47,7 @@ ServerInterface ServerSocket::accept() { lastClient = thisClient; // update from previous connection struct sockaddr_in clientAddr; socklen_t addr_size = sizeof clientAddr; - int newSocket = + int const newSocket = ::accept(getSocketId(), (struct sockaddr *)&clientAddr, &addr_size); if (newSocket == -1) { throw SocketError("Server ERROR: socket accept failed\n"); diff --git a/slsSupportLib/src/ToString.cpp b/slsSupportLib/src/ToString.cpp index 98790f7cd..65e7ef4de 100644 --- a/slsSupportLib/src/ToString.cpp +++ b/slsSupportLib/src/ToString.cpp @@ -614,7 +614,7 @@ std::string ToString(const defs::portPosition s) { std::string ToString(const defs::streamingInterface s) { std::ostringstream os; - std::string rs; + std::string const rs; switch (s) { case defs::streamingInterface::NONE: return std::string("none"); @@ -1128,8 +1128,8 @@ template <> defs::collectionMode StringTo(const std::string &s) { } template <> uint8_t StringTo(const std::string &s) { - int base = s.find("0x") != std::string::npos ? 16 : 10; - int value = std::stoi(s, nullptr, base); + int const base = s.find("0x") != std::string::npos ? 16 : 10; + int const value = std::stoi(s, nullptr, base); if (value < std::numeric_limits::min() || value > std::numeric_limits::max()) { throw RuntimeError("Cannot scan uint8_t from string '" + s + @@ -1139,8 +1139,8 @@ template <> uint8_t StringTo(const std::string &s) { } template <> uint16_t StringTo(const std::string &s) { - int base = s.find("0x") != std::string::npos ? 16 : 10; - int value = std::stoi(s, nullptr, base); + int const base = s.find("0x") != std::string::npos ? 16 : 10; + int const value = std::stoi(s, nullptr, base); if (value < std::numeric_limits::min() || value > std::numeric_limits::max()) { throw RuntimeError("Cannot scan uint16_t from string '" + s + @@ -1150,22 +1150,22 @@ template <> uint16_t StringTo(const std::string &s) { } template <> uint32_t StringTo(const std::string &s) { - int base = s.find("0x") != std::string::npos ? 16 : 10; + int const base = s.find("0x") != std::string::npos ? 16 : 10; return std::stoul(s, nullptr, base); } template <> uint64_t StringTo(const std::string &s) { - int base = s.find("0x") != std::string::npos ? 16 : 10; + int const base = s.find("0x") != std::string::npos ? 16 : 10; return std::stoull(s, nullptr, base); } template <> int StringTo(const std::string &s) { - int base = s.find("0x") != std::string::npos ? 16 : 10; + int const base = s.find("0x") != std::string::npos ? 16 : 10; return std::stoi(s, nullptr, base); } template <> bool StringTo(const std::string &s) { - int i = std::stoi(s, nullptr, 10); + int const i = std::stoi(s, nullptr, 10); switch (i) { case 0: return false; @@ -1177,7 +1177,7 @@ template <> bool StringTo(const std::string &s) { } template <> int64_t StringTo(const std::string &s) { - int base = s.find("0x") != std::string::npos ? 16 : 10; + int const base = s.find("0x") != std::string::npos ? 16 : 10; return std::stol(s, nullptr, base); } diff --git a/slsSupportLib/src/ZmqSocket.cpp b/slsSupportLib/src/ZmqSocket.cpp index 2fafe4799..42fd8f25e 100644 --- a/slsSupportLib/src/ZmqSocket.cpp +++ b/slsSupportLib/src/ZmqSocket.cpp @@ -305,8 +305,8 @@ int ZmqSocket::SendHeader(int index, zmqHeader header) { oss << ", \"rx_roi\":[" << header.rx_roi[0] << ", " << header.rx_roi[1] << ", " << header.rx_roi[2] << ", " << header.rx_roi[3] << "]"; oss << "}\n"; - std::string message = oss.str(); - int length = message.length(); + std::string const message = oss.str(); + int const length = message.length(); #ifdef ZMQ_DETAIL // if(!index) LOG(logINFOBLUE) << index << " : Streamer: buf: " << message; @@ -436,7 +436,7 @@ int ZmqSocket::ParseHeader(const int index, int length, char *buff, int ZmqSocket::ReceiveData(const int index, char *buf, const int size) { zmq_msg_t message; zmq_msg_init(&message); - int length = ReceiveMessage(index, message); + int const length = ReceiveMessage(index, message); if (length == size) { memcpy(buf, (char *)zmq_msg_data(&message), size); } else if (length < size) { @@ -453,7 +453,7 @@ int ZmqSocket::ReceiveData(const int index, char *buf, const int size) { } int ZmqSocket::ReceiveMessage(const int index, zmq_msg_t &message) { - int length = zmq_msg_recv(&message, sockfd.socketDescriptor, 0); + int const length = zmq_msg_recv(&message, sockfd.socketDescriptor, 0); if (length == -1) { PrintError(); LOG(logERROR) << "Could not read header for socket " << index; diff --git a/slsSupportLib/src/file_utils.cpp b/slsSupportLib/src/file_utils.cpp index 3b82a5a9f..a62afa858 100644 --- a/slsSupportLib/src/file_utils.cpp +++ b/slsSupportLib/src/file_utils.cpp @@ -52,7 +52,7 @@ int readDataFile(std::ifstream &infile, short int *data, int nch, int offset) { int readDataFile(std::string fname, short int *data, int nch) { std::ifstream infile; int iline = 0; - std::string str; + std::string const str; infile.open(fname.c_str(), std::ios_base::in); if (infile.is_open()) { iline = readDataFile(infile, data, nch, 0); @@ -80,7 +80,7 @@ std::vector readBinaryFile(const std::string &fname, } // get file size to print progress - ssize_t filesize = getFileSize(fp, errorPrefix); + ssize_t const filesize = getFileSize(fp, errorPrefix); std::vector buffer(filesize, 0); if ((ssize_t)fread(buffer.data(), sizeof(char), filesize, fp) != filesize) { @@ -142,14 +142,14 @@ void mkdir_p(const std::string &path, std::string dir) { int getFileSize(std::ifstream &ifs) { auto current_pos = ifs.tellg(); ifs.seekg(0, std::ios::end); - int file_size = ifs.tellg(); + int const file_size = ifs.tellg(); ifs.seekg(current_pos); return file_size; } std::string getFileNameFromFilePath(const std::string &fpath) { std::string fname(fpath); - std::size_t slashPos = fpath.rfind('/'); + std::size_t const slashPos = fpath.rfind('/'); if (slashPos != std::string::npos) { fname = fpath.substr(slashPos + 1, fpath.size() - 1); } @@ -161,7 +161,7 @@ ssize_t getFileSize(FILE *fd, const std::string &prependErrorString) { throw RuntimeError(prependErrorString + std::string(" (Seek error in src file)")); } - size_t fileSize = ftell(fd); + size_t const fileSize = ftell(fd); if (fileSize <= 0) { throw RuntimeError( prependErrorString + @@ -181,7 +181,7 @@ getChannelsFromStringList(const std::vector list) { begin(line), end(line), [](char c) { return (c == ','); }, ' '); // split line (delim space) - std::vector vec = split(line, ' '); + std::vector const vec = split(line, ' '); // for every channel separated by space for (auto it : vec) { @@ -189,8 +189,8 @@ getChannelsFromStringList(const std::vector list) { auto result = it.find(':'); if (result != std::string::npos) { try { - int istart = StringTo(it.substr(0, result)); - int istop = StringTo( + int const istart = StringTo(it.substr(0, result)); + int const istop = StringTo( it.substr(result + 1, it.length() - result - 1)); LOG(logDEBUG1) << "istart:" << istart << " istop:" << istop; std::vector range(istop - istart); @@ -275,7 +275,7 @@ std::string getAbsolutePathFromCurrentProcess(const std::string &fname) { #else - ssize_t len = readlink("/proc/self/exe", path.data(), PATH_MAX - 1); + ssize_t const len = readlink("/proc/self/exe", path.data(), PATH_MAX - 1); if (len < 0) { throw RuntimeError("Could not get absolute path for " + fname); } diff --git a/slsSupportLib/src/network_utils.cpp b/slsSupportLib/src/network_utils.cpp index 166d9ccf0..0861a16fd 100644 --- a/slsSupportLib/src/network_utils.cpp +++ b/slsSupportLib/src/network_utils.cpp @@ -115,7 +115,7 @@ IpAddr HostnameToIp(const char *hostname) { throw RuntimeError("Could not convert hostname (" + std::string(hostname) + ") to ip"); } - uint32_t ip = ((sockaddr_in *)result->ai_addr)->sin_addr.s_addr; + uint32_t const ip = ((sockaddr_in *)result->ai_addr)->sin_addr.s_addr; freeaddrinfo(result); return IpAddr(ip); } @@ -189,7 +189,7 @@ MacAddr InterfaceNameToMac(const std::string &inf) { const int mac_len = sizeof(mac); memset(mac, 0, mac_len); - int sock = socket(PF_INET, SOCK_STREAM, 0); + int const sock = socket(PF_INET, SOCK_STREAM, 0); strncpy(ifr.ifr_name, inf.c_str(), sizeof(ifr.ifr_name) - 1); ifr.ifr_name[sizeof(ifr.ifr_name) - 1] = '\0'; diff --git a/slsSupportLib/tests/test-StaticVector.cpp b/slsSupportLib/tests/test-StaticVector.cpp index fc40f1a0f..dcc0ce0a4 100644 --- a/slsSupportLib/tests/test-StaticVector.cpp +++ b/slsSupportLib/tests/test-StaticVector.cpp @@ -15,9 +15,9 @@ TEST_CASE("StaticVector is a container") { } TEST_CASE("Comparing StaticVector containers") { - StaticVector a{0, 1, 2}; - StaticVector b{0, 1, 2}; - StaticVector c{0, 1, 2, 4}; + StaticVector const a{0, 1, 2}; + StaticVector const b{0, 1, 2}; + StaticVector const c{0, 1, 2, 4}; REQUIRE(a == b); REQUIRE_FALSE(a != b); @@ -29,9 +29,9 @@ TEST_CASE("Comparing StaticVector containers") { } TEST_CASE("Compare array and fixed capacity container") { - std::array arr{1, 2, 3}; - std::array arr2{1, 7, 3}; - StaticVector fcc{1, 2, 3}; + std::array const arr{1, 2, 3}; + std::array const arr2{1, 7, 3}; + StaticVector const fcc{1, 2, 3}; REQUIRE(fcc == arr); REQUIRE(arr == fcc); REQUIRE_FALSE(fcc != arr); @@ -41,9 +41,9 @@ TEST_CASE("Compare array and fixed capacity container") { } TEST_CASE("Compare vector and fixed capacity container") { - std::vector vec{1, 2, 3}; - std::vector vec2{10, 2, 3}; - StaticVector fcc{1, 2, 3}; + std::vector const vec{1, 2, 3}; + std::vector const vec2{10, 2, 3}; + StaticVector const fcc{1, 2, 3}; REQUIRE(fcc == vec); REQUIRE(vec == fcc); REQUIRE_FALSE(fcc != vec); @@ -53,46 +53,46 @@ TEST_CASE("Compare vector and fixed capacity container") { } TEST_CASE("Construct from vector") { - std::vector vec{1, 2, 3}; - StaticVector fcc{vec}; + std::vector const vec{1, 2, 3}; + StaticVector const fcc{vec}; REQUIRE(fcc == vec); } TEST_CASE("Copy construct from vector") { - std::vector vec{1, 2, 3}; - StaticVector fcc = vec; + std::vector const vec{1, 2, 3}; + StaticVector const fcc = vec; REQUIRE(fcc == vec); } TEST_CASE("Copy assignment from vector") { - std::vector vec{1, 2, 3}; + std::vector const vec{1, 2, 3}; StaticVector fcc; fcc = vec; REQUIRE(fcc == vec); } TEST_CASE("Construct from array") { - std::array arr{1, 2, 3}; - StaticVector fcc{arr}; + std::array const arr{1, 2, 3}; + StaticVector const fcc{arr}; REQUIRE(fcc == arr); } TEST_CASE("Copy assign from array") { - std::array arr{1, 2, 3}; + std::array const arr{1, 2, 3}; StaticVector fcc; fcc = arr; REQUIRE(fcc == arr); } TEST_CASE("Copy construct from array") { - std::array arr{1, 2, 3}; - StaticVector fcc = arr; + std::array const arr{1, 2, 3}; + StaticVector const fcc = arr; REQUIRE(fcc == arr); } TEST_CASE("Construct from a smaller StaticVector") { - StaticVector sv{1, 2, 3}; - StaticVector sv2{sv}; + StaticVector const sv{1, 2, 3}; + StaticVector const sv2{sv}; REQUIRE(sv == sv2); } @@ -183,7 +183,7 @@ SCENARIO("StaticVectors can be sized and resized", "[support]") { } GIVEN("An std::vector of size 3") { - std::vector standard_vector{5, 2, 1}; + std::vector const standard_vector{5, 2, 1}; WHEN("we construct a fixed capacity container from it") { StaticVector vec(standard_vector); THEN("size and data matches") { @@ -202,7 +202,7 @@ SCENARIO("StaticVectors can be sized and resized", "[support]") { SCENARIO("Comparison of StaticVectors", "[support]") { GIVEN("Two containers containers that are equal at the start") { StaticVector a{0, 1, 2}; - StaticVector b{0, 1, 2}; + StaticVector const b{0, 1, 2}; REQUIRE(a == b); REQUIRE_FALSE(a != b); @@ -211,7 +211,7 @@ SCENARIO("Comparison of StaticVectors", "[support]") { THEN("they are not equal anymore") { REQUIRE(a != b); } } WHEN("Compared to a StaticVector with different capacity") { - StaticVector c{0, 1, 2}; + StaticVector const c{0, 1, 2}; THEN("The comparison still holds") { REQUIRE(a == c); REQUIRE_FALSE(a != c); @@ -316,7 +316,7 @@ SCENARIO("Converting to vector", "[support]") { GIVEN("a StaticVector") { StaticVector a{1, 2, 3}; WHEN("Converted into a vector") { - std::vector b(a); + std::vector const b(a); THEN("Data and size matches") { REQUIRE(a == b); REQUIRE(a.size() == b.size()); diff --git a/slsSupportLib/tests/test-ToString.cpp b/slsSupportLib/tests/test-ToString.cpp index 76ee87245..730c6e4e6 100644 --- a/slsSupportLib/tests/test-ToString.cpp +++ b/slsSupportLib/tests/test-ToString.cpp @@ -59,7 +59,7 @@ TEST_CASE("conversion from duration to string", "[support]") { } TEST_CASE("Convert vector of time", "[support]") { - std::vector vec{ns(150), us(10), ns(600)}; + std::vector const vec{ns(150), us(10), ns(600)}; REQUIRE(ToString(vec) == "[150ns, 10us, 600ns]"); REQUIRE(ToString(vec, "ns") == "[150ns, 10000ns, 600ns]"); } @@ -93,26 +93,26 @@ TEST_CASE("Vector of double", "[support]") { } TEST_CASE("Array") { - std::array arr{1, 2, 3}; + std::array const arr{1, 2, 3}; REQUIRE(ToString(arr) == "[1, 2, 3]"); } TEST_CASE("Convert types with str method") { - IpAddr addr; + IpAddr const addr; REQUIRE(ToString(addr) == "0.0.0.0"); REQUIRE(ToString(IpAddr{}) == "0.0.0.0"); } TEST_CASE("String to string", "[support]") { - std::string s = "hej"; + std::string const s = "hej"; REQUIRE(ToString(s) == "hej"); } TEST_CASE("vector of strings") { - std::vector vec{"5", "s"}; + std::vector const vec{"5", "s"}; REQUIRE(ToString(vec) == "[5, s]"); - std::vector vec2{"some", "strange", "words", "75"}; + std::vector const vec2{"some", "strange", "words", "75"}; REQUIRE(ToString(vec2) == "[some, strange, words, 75]"); } @@ -150,7 +150,7 @@ TEST_CASE("string to detectorType") { TEST_CASE("vec") { using rs = slsDetectorDefs::runStatus; - std::vector vec{rs::ERROR, rs::IDLE}; + std::vector const vec{rs::ERROR, rs::IDLE}; REQUIRE(ToString(vec) == "[error, idle]"); } @@ -232,25 +232,25 @@ TEST_CASE("Detector type") { } TEST_CASE("Formatting slsDetectorDefs::ROI") { - slsDetectorDefs::ROI roi(5, 159); + slsDetectorDefs::ROI const roi(5, 159); REQUIRE(ToString(roi) == "[5, 159]"); - slsDetectorDefs::ROI roi1(5, 159, 6, 170); + slsDetectorDefs::ROI const roi1(5, 159, 6, 170); REQUIRE(ToString(roi1) == "[5, 159, 6, 170]"); } TEST_CASE("Streaming of slsDetectorDefs::ROI") { using namespace sls; - slsDetectorDefs::ROI roi(-10, 1); + slsDetectorDefs::ROI const roi(-10, 1); std::ostringstream oss, oss1; oss << roi; REQUIRE(oss.str() == "[-10, 1]"); - slsDetectorDefs::ROI roi1(-10, 1, 5, 11); + slsDetectorDefs::ROI const roi1(-10, 1, 5, 11); oss1 << roi1; REQUIRE(oss1.str() == "[-10, 1, 5, 11]"); } TEST_CASE("std::array") { - std::array arr{4, 6, 7}; + std::array const arr{4, 6, 7}; REQUIRE(ToString(arr) == "[4, 6, 7]"); } @@ -267,14 +267,14 @@ TEST_CASE("dac index to string") { } TEST_CASE("convert vector of strings to dac index") { - std::vector dacs{"vcassh", "vth2", "vrshaper"}; - std::vector daci{defs::VCASSH, defs::VTH2, defs::VRSHAPER}; + std::vector const dacs{"vcassh", "vth2", "vrshaper"}; + std::vector const daci{defs::VCASSH, defs::VTH2, defs::VRSHAPER}; auto r = StringTo(dacs); REQUIRE(r == daci); } TEST_CASE("vector of dac index to string") { - std::vector daci{defs::VCASSH, defs::VTH2, defs::VRSHAPER}; + std::vector const daci{defs::VCASSH, defs::VTH2, defs::VRSHAPER}; auto r = ToString(daci); REQUIRE(r == "[vcassh, vth2, vrshaper]"); } @@ -284,7 +284,7 @@ TEST_CASE("int or uin64_t to a string in hex") { REQUIRE(ToStringHex(65535, 8) == "0x0000ffff"); REQUIRE(ToStringHex(8927748192) == "0x21422a060"); REQUIRE(ToStringHex(8927748192, 16) == "0x000000021422a060"); - std::vector temp{244, 65535, 1638582}; + std::vector const temp{244, 65535, 1638582}; auto r = ToStringHex(temp); REQUIRE(r == "[0xf4, 0xffff, 0x1900b6]"); r = ToStringHex(temp, 8); @@ -294,20 +294,20 @@ TEST_CASE("int or uin64_t to a string in hex") { TEST_CASE("Streaming of slsDetectorDefs::scanParameters") { using namespace sls; { - defs::scanParameters t{}; + defs::scanParameters const t{}; std::ostringstream oss; oss << t; REQUIRE(oss.str() == "[disabled]"); } { - defs::scanParameters t{defs::VTH2, 500, 1500, 500}; + defs::scanParameters const t{defs::VTH2, 500, 1500, 500}; std::ostringstream oss; oss << t; REQUIRE(oss.str() == "[enabled\ndac vth2\nstart 500\nstop 1500\nstep " "500\nsettleTime 1ms\n]"); } { - defs::scanParameters t{defs::VTH2, 500, 1500, 500, + defs::scanParameters const t{defs::VTH2, 500, 1500, 500, std::chrono::milliseconds{500}}; std::ostringstream oss; oss << t; @@ -317,17 +317,17 @@ TEST_CASE("Streaming of slsDetectorDefs::scanParameters") { } TEST_CASE("Printing c style arrays of int") { - int arr[]{3, 5}; + int const arr[]{3, 5}; REQUIRE(ToString(arr) == "[3, 5]"); } TEST_CASE("Printing c style arrays of uint8") { - uint8_t arr[]{1, 2, 3, 4, 5}; + uint8_t const arr[]{1, 2, 3, 4, 5}; REQUIRE(ToString(arr) == "[1, 2, 3, 4, 5]"); } TEST_CASE("Printing c style arrays of double") { - double arr[]{3.4, 5.3, 6.2}; + double const arr[]{3.4, 5.3, 6.2}; REQUIRE(ToString(arr) == "[3.4, 5.3, 6.2]"); } diff --git a/slsSupportLib/tests/test-UdpRxSocket.cpp b/slsSupportLib/tests/test-UdpRxSocket.cpp index 645fed8c1..bdf789af3 100644 --- a/slsSupportLib/tests/test-UdpRxSocket.cpp +++ b/slsSupportLib/tests/test-UdpRxSocket.cpp @@ -35,7 +35,7 @@ int open_socket(int port) { if (getaddrinfo(host, portname.c_str(), &hints, &res)) { throw RuntimeError("Failed at getaddrinfo with " + std::string(host)); } - int fd = socket(res->ai_family, res->ai_socktype, res->ai_protocol); + int const fd = socket(res->ai_family, res->ai_socktype, res->ai_protocol); if (fd == -1) { throw RuntimeError("Failed to create UDP RX socket"); } @@ -50,7 +50,7 @@ int open_socket(int port) { TEST_CASE("Get packet size returns the packet size we set in the constructor") { constexpr int port = 50001; constexpr ssize_t packet_size = 8000; - UdpRxSocket s{port, packet_size}; + UdpRxSocket const s{port, packet_size}; CHECK(s.getPacketSize() == packet_size); } @@ -58,12 +58,12 @@ TEST_CASE("Receive data from a vector") { constexpr int port = 50001; std::vector data_to_send{4, 5, 3, 2, 5, 7, 2, 3}; std::vector data_received(data_to_send.size()); - ssize_t packet_size = + ssize_t const packet_size = sizeof(decltype(data_to_send)::value_type) * data_to_send.size(); UdpRxSocket udpsock{port, packet_size}; - int fd = open_socket(port); + int const fd = open_socket(port); auto n = write(fd, data_to_send.data(), packet_size); CHECK(n == packet_size); diff --git a/slsSupportLib/tests/test-Version.cpp b/slsSupportLib/tests/test-Version.cpp index 9c1f1d3f8..0a70cae52 100644 --- a/slsSupportLib/tests/test-Version.cpp +++ b/slsSupportLib/tests/test-Version.cpp @@ -11,7 +11,7 @@ TEST_CASE("check if version is semantic", "[.version]") { GENERATE(std::make_tuple("developer 0x250512", false), std::make_tuple("0.0.0 0x250512", false)); - Version version(version_string); + Version const version(version_string); CHECK(version.hasSemanticVersioning() == has_semantic_version); } diff --git a/slsSupportLib/tests/test-bit_utils.cpp b/slsSupportLib/tests/test-bit_utils.cpp index 9217f9ec0..09e859dc9 100644 --- a/slsSupportLib/tests/test-bit_utils.cpp +++ b/slsSupportLib/tests/test-bit_utils.cpp @@ -31,7 +31,7 @@ TEST_CASE("Get set bits from 3") { } TEST_CASE("All bits set") { - uint8_t val = -1; + uint8_t const val = -1; auto vec = getSetBits(val); REQUIRE(vec == std::vector{0, 1, 2, 3, 4, 5, 6, 7}); } diff --git a/slsSupportLib/tests/test-container_utils.cpp b/slsSupportLib/tests/test-container_utils.cpp index b43eaf814..5c3b85cad 100644 --- a/slsSupportLib/tests/test-container_utils.cpp +++ b/slsSupportLib/tests/test-container_utils.cpp @@ -9,7 +9,7 @@ namespace sls { TEST_CASE("Equality of an empty vector", "[support]") { - std::vector v; + std::vector const v; REQUIRE(v.empty()); REQUIRE_FALSE(allEqual(v)); REQUIRE_FALSE(allEqualWithTol(v, 2)); @@ -19,7 +19,7 @@ TEST_CASE("Equality of an empty vector", "[support]") { } TEST_CASE("Equality of a vector with one element", "[support]") { - std::vector v{5}; + std::vector const v{5}; REQUIRE(v.size() == 1); REQUIRE(allEqual(v)); REQUIRE(allEqualWithTol(v, 1)); @@ -55,7 +55,7 @@ TEST_CASE("A larger vector of the same elements", "[support]") { } TEST_CASE("A vector of double with different values", "[support]") { - std::vector v{1.2, 2., 4.2, 4, 1.1}; + std::vector const v{1.2, 2., 4.2, 4, 1.1}; REQUIRE(allEqual(v) == false); REQUIRE(allEqualWithTol(v, 0.3) == false); @@ -63,19 +63,19 @@ TEST_CASE("A vector of double with different values", "[support]") { } TEST_CASE("Sum of empty vector", "[support]") { - std::vector v; + std::vector const v; REQUIRE(sum(v) == Approx(0)); } TEST_CASE("Sum of vector", "[support]") { - std::vector v{1.2, 2., 4.2, 4, 1.13}; + std::vector const v{1.2, 2., 4.2, 4, 1.13}; REQUIRE(sum(v) == Approx(12.53)); } TEST_CASE("Minus one if different", "[support]") { std::vector v; REQUIRE(v.empty()); - double d = -1; + double const d = -1; REQUIRE(minusOneIfDifferent(v) == d); SECTION("single element") { @@ -102,11 +102,11 @@ TEST_CASE("minus one does not have side effects", "[support]") { TEST_CASE("Compare a vector containing two vectors", "[support]") { std::vector> a{{0, 1, 2, 3, 4, 5}, {0, 1, 2, 3, 4, 5}}; - std::vector> b{{0, 1, 2, 3, 4, 5}, {0, 1, 2, 3, 3, 5}}; - std::vector> c{{0, 1, 2, 3, 4}, {0, 1, 2, 3, 3, 5}}; + std::vector> const b{{0, 1, 2, 3, 4, 5}, {0, 1, 2, 3, 3, 5}}; + std::vector> const c{{0, 1, 2, 3, 4}, {0, 1, 2, 3, 3, 5}}; std::vector> d{ {0, 1, 2, 3, 4}, {0, 1, 2, 3, 4}, {0, 1, 2, 3, 4}}; - std::vector e{0, 1, 2, 3, 4, 5}; + std::vector const e{0, 1, 2, 3, 4, 5}; CHECK(minusOneIfDifferent(a) == a[0]); CHECK(minusOneIfDifferent(a) == e); @@ -116,9 +116,9 @@ TEST_CASE("Compare a vector containing two vectors", "[support]") { } TEST_CASE("vector of bool", "[support]") { - std::vector a{true, true, true}; - std::vector b{false, false, false}; - std::vector c{true, false, true}; + std::vector const a{true, true, true}; + std::vector const b{false, false, false}; + std::vector const c{true, false, true}; CHECK(minusOneIfDifferent(a) == 1); CHECK(minusOneIfDifferent(b) == 0); @@ -127,17 +127,17 @@ TEST_CASE("vector of bool", "[support]") { TEST_CASE("compare a vector of arrays", "[support]") { - std::vector> vec0{{5, 6, 8}, {5, 6, 8}, {5, 6, 8}}; + std::vector> const vec0{{5, 6, 8}, {5, 6, 8}, {5, 6, 8}}; CHECK(minusOneIfDifferent(vec0) == std::array{5, 6, 8}); std::array arr; arr.fill(-1); - std::vector> vec1{{5, 90, 8}, {5, 6, 8}, {5, 6, 8}}; + std::vector> const vec1{{5, 90, 8}, {5, 6, 8}, {5, 6, 8}}; CHECK(minusOneIfDifferent(vec1) == arr); } TEST_CASE("check if vector has duplicates") { - std::vector vec{1, 0, 2, 5, 3, 1, 8, 6}; + std::vector const vec{1, 0, 2, 5, 3, 1, 8, 6}; REQUIRE(hasDuplicates(vec) == true); } diff --git a/slsSupportLib/tests/test-file_utils.cpp b/slsSupportLib/tests/test-file_utils.cpp index cf33951a3..157dd645e 100644 --- a/slsSupportLib/tests/test-file_utils.cpp +++ b/slsSupportLib/tests/test-file_utils.cpp @@ -22,7 +22,7 @@ TEST_CASE("Get size of file with data") { constexpr size_t n_bytes = 137; std::vector data(n_bytes); char fname[] = "temfile_XXXXXX"; - int fh = mkstemp(fname); + int const fh = mkstemp(fname); write(fh, data.data(), n_bytes); std::ifstream ifs(fname); @@ -32,11 +32,11 @@ TEST_CASE("Get size of file with data") { } TEST_CASE("Channel file reading") { - std::string fname = + std::string const fname = getAbsolutePathFromCurrentProcess(TEST_FILE_NAME_BAD_CHANNELS); std::vector list; REQUIRE_NOTHROW(list = getChannelsFromFile(fname)); - std::vector expected = {0, 12, 15, 40, 41, 42, 43, 44, 1279}; + std::vector const expected = {0, 12, 15, 40, 41, 42, 43, 44, 1279}; REQUIRE(list == expected); } diff --git a/slsSupportLib/tests/test-logger.cpp b/slsSupportLib/tests/test-logger.cpp index 320b2fb30..3addbd56f 100644 --- a/slsSupportLib/tests/test-logger.cpp +++ b/slsSupportLib/tests/test-logger.cpp @@ -30,7 +30,7 @@ TEST_CASE("Test output") { Logger::ReportingLevel() = logERROR; // Redirect std::clog to local buffer - std::ostringstream local; + std::ostringstream const local; auto clog_buff = std::clog.rdbuf(); std::clog.rdbuf(local.rdbuf()); diff --git a/slsSupportLib/tests/test-network_utils.cpp b/slsSupportLib/tests/test-network_utils.cpp index 0828cef56..6ed2aacad 100644 --- a/slsSupportLib/tests/test-network_utils.cpp +++ b/slsSupportLib/tests/test-network_utils.cpp @@ -33,12 +33,12 @@ TEST_CASE("Convert mac address using classes", "[support]") { } TEST_CASE("Hex representation of MAC", "[support]") { - MacAddr m{346856806822}; + MacAddr const m{346856806822}; CHECK(m.hex() == "0050c246d9a6"); CHECK(m.str() == "00:50:c2:46:d9:a6"); CHECK_FALSE(m == 7); - MacAddr m2{"00:50:c2:46:d9:c4"}; + MacAddr const m2{"00:50:c2:46:d9:c4"}; CHECK(m2 == 346856806852); CHECK(m2.hex() == "0050c246d9c4"); CHECK(m2.str() == "00:50:c2:46:d9:c4"); @@ -79,12 +79,12 @@ TEST_CASE("Strange input gives 0", "[support]") { } TEST_CASE("Convert to uint for sending over network", "[support]") { - MacAddr addr{346856806822}; - uint64_t a = addr.uint64(); + MacAddr const addr{346856806822}; + uint64_t const a = addr.uint64(); CHECK(a == 346856806822); - IpAddr addr2{"129.129.205.242"}; - uint32_t b = addr2.uint32(); + IpAddr const addr2{"129.129.205.242"}; + uint32_t const b = addr2.uint32(); CHECK(b == 4073554305); } @@ -93,7 +93,7 @@ TEST_CASE("Hostname lookup failed throws", "[support]") { } TEST_CASE("IP Output operator gives same result as string", "[support]") { - IpAddr addr{"129.129.205.242"}; + IpAddr const addr{"129.129.205.242"}; std::ostringstream os; os << addr; CHECK(os.str() == "129.129.205.242"); @@ -101,7 +101,7 @@ TEST_CASE("IP Output operator gives same result as string", "[support]") { } TEST_CASE("MAC Output operator gives same result as string", "[support]") { - MacAddr addr{"00:50:c2:46:d9:a6"}; + MacAddr const addr{"00:50:c2:46:d9:a6"}; std::ostringstream os; os << addr; CHECK(os.str() == "00:50:c2:46:d9:a6"); @@ -109,15 +109,15 @@ TEST_CASE("MAC Output operator gives same result as string", "[support]") { } TEST_CASE("Copy construct a MacAddr") { - MacAddr addr{"00:50:c2:46:d9:a6"}; - MacAddr addr2(addr); + MacAddr const addr{"00:50:c2:46:d9:a6"}; + MacAddr const addr2(addr); CHECK(addr == addr2); } TEST_CASE("udp dst struct basic properties") { static_assert(sizeof(UdpDestination) == 32, "udpDestination struct size does not match"); - UdpDestination dst{}; + UdpDestination const dst{}; REQUIRE(dst.entry == 0); REQUIRE(dst.port == 0); REQUIRE(dst.port2 == 0); diff --git a/slsSupportLib/tests/test-sls_detector_defs.cpp b/slsSupportLib/tests/test-sls_detector_defs.cpp index b7f2421c5..3c11ef1d1 100644 --- a/slsSupportLib/tests/test-sls_detector_defs.cpp +++ b/slsSupportLib/tests/test-sls_detector_defs.cpp @@ -8,7 +8,7 @@ namespace sls { using dt = slsDetectorDefs::detectorType; TEST_CASE("sls_detector_module default construction", "[support][new]") { - sls_detector_module m; + sls_detector_module const m; CHECK(m.serialnumber == 0); CHECK(m.nchan == 0); CHECK(m.nchip == 0); @@ -24,7 +24,7 @@ TEST_CASE("sls_detector_module default construction", "[support][new]") { } TEST_CASE("sls_detector_module from type", "[support]") { - sls_detector_module m(dt::EIGER); + sls_detector_module const m(dt::EIGER); CHECK(m.serialnumber == 0); CHECK(m.nchan == 256 * 256 * 4); CHECK(m.nchip == 4); @@ -60,7 +60,7 @@ TEST_CASE("assign module", "[support]") { } TEST_CASE("default construct scanParameters") { - slsDetectorDefs::scanParameters p; + slsDetectorDefs::scanParameters const p; CHECK(p.dacSettleTime_ns == 0); CHECK(p.dacInd == slsDetectorDefs::DAC_0); CHECK(p.enable == 0); @@ -71,7 +71,7 @@ TEST_CASE("default construct scanParameters") { TEST_CASE("compare two scanParameters") { slsDetectorDefs::scanParameters p0; - slsDetectorDefs::scanParameters p1; + slsDetectorDefs::scanParameters const p1; CHECK(p0 == p1); diff --git a/slsSupportLib/tests/test-string_utils.cpp b/slsSupportLib/tests/test-string_utils.cpp index 15dcb7dbc..0b5c0a906 100644 --- a/slsSupportLib/tests/test-string_utils.cpp +++ b/slsSupportLib/tests/test-string_utils.cpp @@ -36,7 +36,7 @@ TEST_CASE("copy a long string") { #endif TEST_CASE("split a string with end delimiter") { - std::string s("abra+kadabra+"); + std::string const s("abra+kadabra+"); auto r = split(s, '+'); REQUIRE(r.size() == 2); REQUIRE(r[0] == "abra"); @@ -44,7 +44,7 @@ TEST_CASE("split a string with end delimiter") { } TEST_CASE("split a string without end delimiter") { - std::string s("abra+kadabra+filibom"); + std::string const s("abra+kadabra+filibom"); auto r = split(s, '+'); REQUIRE(r.size() == 3); REQUIRE(r[0] == "abra"); @@ -109,7 +109,7 @@ TEST_CASE("replace --help") { } TEST_CASE("port host") { - std::string hostport = "localhost:1954"; + std::string const hostport = "localhost:1954"; auto res = ParseHostPort(hostport); REQUIRE(res.first == "localhost"); REQUIRE(res.second == 1954); @@ -117,7 +117,7 @@ TEST_CASE("port host") { TEST_CASE("port missing") { // TODO! is this the intended result? - std::string host = "localhost"; + std::string const host = "localhost"; auto res = ParseHostPort(host); REQUIRE(res.first == "localhost"); REQUIRE(res.second == 0); diff --git a/tests/src/testclient.cpp b/tests/src/testclient.cpp index 06983bcf0..57df7eeb1 100644 --- a/tests/src/testclient.cpp +++ b/tests/src/testclient.cpp @@ -85,7 +85,7 @@ int main(int argc, char **argv) { double b = 18.3; float c = -1.2; auto socket = sls::ClientSocket("test", hostname, port); - int s = socket.SendAll(sls::func_id::combined, a, b, c); + int const s = socket.SendAll(sls::func_id::combined, a, b, c); std::cout << "send all: " << s << "\n"; } }