From e0aadbcc0fcbc9762d079e0c80206940f56bca97 Mon Sep 17 00:00:00 2001
From: Dhanya Thattil <dhanya.thattil@psi.ch>
Date: Wed, 9 Jul 2025 10:22:31 +0200
Subject: [PATCH] remove testing code, minor

---
 slsReceiverSoftware/src/CommandLineOptions.cpp | 8 +++-----
 slsReceiverSoftware/src/Receiver.cpp           | 3 ---
 2 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/slsReceiverSoftware/src/CommandLineOptions.cpp b/slsReceiverSoftware/src/CommandLineOptions.cpp
index 392b6bb34..5627c861c 100644
--- a/slsReceiverSoftware/src/CommandLineOptions.cpp
+++ b/slsReceiverSoftware/src/CommandLineOptions.cpp
@@ -11,6 +11,7 @@
 #include <cstring>
 #include <unistd.h>
 
+/** for testing */
 ParsedOptions CommandLineOptions::parse(const std::vector<std::string> &args) {
     std::vector<char *> argv;
     argv.reserve(args.size());
@@ -23,15 +24,12 @@ ParsedOptions CommandLineOptions::parse(const std::vector<std::string> &args) {
 
 ParsedOptions CommandLineOptions::parse(int argc, char *argv[]) {
     CommonOptions base;
-    base.port = DEFAULT_TCP_RX_PORTNO;
-
     MultiReceiverOptions multi;
     FrameSyncOptions frame;
+    base.port = DEFAULT_TCP_RX_PORTNO;
 
-    // leading  '+' to stop parsing at first non-option argument (to allow for deprecated options)
-    auto optString = "+" + buildOptString(); 
+    auto optString = buildOptString(); 
     auto longOptions = buildOptionList();
-
     optind = 0; // reset getopt
     int opt, option_index = 0;
 
diff --git a/slsReceiverSoftware/src/Receiver.cpp b/slsReceiverSoftware/src/Receiver.cpp
index 43906dbe9..d81ecb33a 100644
--- a/slsReceiverSoftware/src/Receiver.cpp
+++ b/slsReceiverSoftware/src/Receiver.cpp
@@ -29,9 +29,6 @@ Receiver::~Receiver() = default;
 
 Receiver::Receiver(uint16_t port) {
     validatePortNumber(port);
-//#ifdef SLS_USE_TESTS
-    if (port == 9999) throw RuntimeError("throwing for 9999 test");
-//#endif
     tcpipInterface = make_unique<ClientInterface>(port);
 }