code review
Build on RHEL8 docker image / build (push) Failing after 33s
Build on RHEL9 docker image / build (push) Successful in 3m58s
Run Simulator Tests on local RHEL9 / build (push) Failing after 6m30s
Run Simulator Tests on local RHEL8 / build (push) Failing after 8m21s

This commit is contained in:
2026-06-29 15:13:27 +02:00
parent 9cd0a81be5
commit b6e8a5df59
7 changed files with 87 additions and 94 deletions
+9 -3
View File
@@ -269,8 +269,13 @@ void Implementation::setModulePositionId(const int id) {
xy portGeometry = GetPortGeometry();
streamingPort = DEFAULT_ZMQ_RX_PORTNO + modulePos * portGeometry.x;
assert(numModules.y !=
0); // TODO why an assert here? should we throw an exception instead?
if (numModules.y == 0) {
LOG(logERROR) << "Number of modules in y direction is 0. Cannot set "
"module position.";
throw RuntimeError("Number of modules in y direction is 0. Cannot set "
"module position.");
}
for (unsigned int i = 0; i < listener.size(); ++i) {
uint16_t row = 0, col = 0;
row = (modulePos % numModules.y) * portGeometry.y;
@@ -1602,7 +1607,8 @@ uint32_t Implementation::getDynamicRange() const {
void Implementation::setDynamicRange(const uint32_t i) {
if (generalData->dynamicRange != i) {
if (generalData->detType == EIGER || generalData->detType == MYTHEN3) {
if (generalData->detType == EIGER || generalData->detType == MYTHEN3 ||
generalData->detType == MATTERHORN) {
generalData->SetDynamicRange(i);
SetupFifoStructure();
}