diff --git a/serverBin/eigerDetectorServerv7.0.0.rc3 b/serverBin/eigerDetectorServerv7.0.0.rc3 deleted file mode 120000 index 10bc1edb5..000000000 --- a/serverBin/eigerDetectorServerv7.0.0.rc3 +++ /dev/null @@ -1 +0,0 @@ -../slsDetectorServers/eigerDetectorServer/bin/eigerDetectorServerv7.0.0.rc3 \ No newline at end of file diff --git a/serverBin/eigerDetectorServerv7.0.0.rc5 b/serverBin/eigerDetectorServerv7.0.0.rc5 new file mode 120000 index 000000000..4b9fe3c6b --- /dev/null +++ b/serverBin/eigerDetectorServerv7.0.0.rc5 @@ -0,0 +1 @@ +../slsDetectorServers/eigerDetectorServer/bin/eigerDetectorServerv7.0.0.rc5 \ No newline at end of file diff --git a/slsDetectorServers/compileAllServers.sh b/slsDetectorServers/compileAllServers.sh index c79f4dc5b..fe48f61fd 100644 --- a/slsDetectorServers/compileAllServers.sh +++ b/slsDetectorServers/compileAllServers.sh @@ -3,12 +3,12 @@ # empty branch = developer branch in updateAPIVersion.sh branch="" -det_list=("ctbDetectorServer" - "gotthardDetectorServer" - "gotthard2DetectorServer" - "jungfrauDetectorServer" - "mythen3DetectorServer" - "moenchDetectorServer" +det_list=("ctbDetectorServer + gotthardDetectorServer + gotthard2DetectorServer + jungfrauDetectorServer + mythen3DetectorServer + moenchDetectorServer" ) usage="\nUsage: compileAllServers.sh [server|all(opt)] [branch(opt)]. \n\tNo arguments mean all servers with 'developer' branch. \n\tNo 'branch' input means 'developer branch'" @@ -25,9 +25,11 @@ elif [ $# -eq 1 ] || [ $# -eq 2 ]; then else # only one server # arg not in list - if [[ $det_list != *$1* ]]; then + echo $det_list | grep -w -q $1 + #if [[ $det_list != *$1* ]]; then + if ! [[ $? ]] ; then echo -e "Invalid argument 1: $1. $usage" - return -1 + return 1 fi declare -a det=("${1}") #echo "Compiling only $1" @@ -37,14 +39,14 @@ elif [ $# -eq 1 ] || [ $# -eq 2 ]; then # arg in list if [[ $det_list == *$2* ]]; then echo -e "Invalid argument 2: $2. $usage" - return -1 + return 1 fi branch+=$2 #echo "with branch $branch" fi else echo -e "Too many arguments.$usage" - return -1 + return 1 fi declare -a deterror=("OK" "OK" "OK" "OK" "OK" "OK") diff --git a/slsDetectorServers/eigerDetectorServer/bin/eigerDetectorServerv7.0.0.rc3 b/slsDetectorServers/eigerDetectorServer/bin/eigerDetectorServerv7.0.0.rc5 similarity index 64% rename from slsDetectorServers/eigerDetectorServer/bin/eigerDetectorServerv7.0.0.rc3 rename to slsDetectorServers/eigerDetectorServer/bin/eigerDetectorServerv7.0.0.rc5 index 291a541d0..ec7b3f1bb 100755 Binary files a/slsDetectorServers/eigerDetectorServer/bin/eigerDetectorServerv7.0.0.rc3 and b/slsDetectorServers/eigerDetectorServer/bin/eigerDetectorServerv7.0.0.rc5 differ diff --git a/slsDetectorServers/eigerDetectorServer/slsDetectorFunctionList.c b/slsDetectorServers/eigerDetectorServer/slsDetectorFunctionList.c index 1686ced7b..b0c895447 100644 --- a/slsDetectorServers/eigerDetectorServer/slsDetectorFunctionList.c +++ b/slsDetectorServers/eigerDetectorServer/slsDetectorFunctionList.c @@ -1457,6 +1457,12 @@ int setHighVoltage(int val) { sharedMemory_unlockLocalLink(); return -3; } + // need to read the file twice to get the proper value + if (!Feb_Control_GetHighVoltage(&eiger_highvoltage)) { + LOG(logERROR, ("Could not read high voltage\n")); + sharedMemory_unlockLocalLink(); + return -3; + } sharedMemory_unlockLocalLink(); // tolerance of 5 diff --git a/slsDetectorServers/jungfrauDetectorServer/bin/jungfrauDetectorServerv7.0.0.rc3 b/slsDetectorServers/jungfrauDetectorServer/bin/jungfrauDetectorServerv7.0.0.rc3 deleted file mode 100755 index ee8303d35..000000000 Binary files a/slsDetectorServers/jungfrauDetectorServer/bin/jungfrauDetectorServerv7.0.0.rc3 and /dev/null differ diff --git a/slsDetectorServers/jungfrauDetectorServer/bin/jungfrauDetectorServerv7.0.0.rc5 b/slsDetectorServers/jungfrauDetectorServer/bin/jungfrauDetectorServerv7.0.0.rc5 new file mode 100755 index 000000000..3b7ac210f Binary files /dev/null and b/slsDetectorServers/jungfrauDetectorServer/bin/jungfrauDetectorServerv7.0.0.rc5 differ diff --git a/slsDetectorServers/jungfrauDetectorServer/slsDetectorFunctionList.c b/slsDetectorServers/jungfrauDetectorServer/slsDetectorFunctionList.c index e7d474840..3eb11d2aa 100644 --- a/slsDetectorServers/jungfrauDetectorServer/slsDetectorFunctionList.c +++ b/slsDetectorServers/jungfrauDetectorServer/slsDetectorFunctionList.c @@ -2798,6 +2798,7 @@ int softwareTrigger(int block) { LOG(logINFO, ("Sending Software Trigger\n")); bus_w(CONTROL_REG, bus_r(CONTROL_REG) | CONTROL_SOFTWARE_TRIGGER_MSK); + bus_w(CONTROL_REG, bus_r(CONTROL_REG) & ~CONTROL_SOFTWARE_TRIGGER_MSK); #ifndef VIRTUAL // block till frame is sent out diff --git a/slsDetectorSoftware/tests/test-CmdProxy.cpp b/slsDetectorSoftware/tests/test-CmdProxy.cpp index d4615dfeb..2ba4c7a9c 100644 --- a/slsDetectorSoftware/tests/test-CmdProxy.cpp +++ b/slsDetectorSoftware/tests/test-CmdProxy.cpp @@ -524,11 +524,20 @@ TEST_CASE("gappixels", "[.cmd]") { Detector det; CmdProxy proxy(&det); auto det_type = det.getDetectorType().squash(); - bool quad = det.getQuad().squash(false); - bool fullModule = (det.getModuleGeometry().y % 2 == 0); - if (det_type == defs::JUNGFRAU || - (det_type == defs::EIGER && (quad || fullModule))) { + // test only for jungfrau and eiger(quad or full module only) + bool gapPixelTest = false; + if (det_type == defs::JUNGFRAU) + gapPixelTest = true; + else if (det_type == defs::EIGER) { + bool quad = det.getQuad().squash(false); + bool fullModule = (det.getModuleGeometry().y % 2 == 0); + if (quad || fullModule) { + gapPixelTest = true; + } + } + + if (gapPixelTest) { auto prev_val = det.getGapPixelsinCallback(); { std::ostringstream oss; diff --git a/slsSupportLib/include/sls/versionAPI.h b/slsSupportLib/include/sls/versionAPI.h index af24f1709..eb42ea312 100644 --- a/slsSupportLib/include/sls/versionAPI.h +++ b/slsSupportLib/include/sls/versionAPI.h @@ -5,9 +5,9 @@ #define APICTB "7.0.0.rc3 0x230130" #define APIGOTTHARD "7.0.0.rc3 0x230130" #define APIGOTTHARD2 "7.0.0.rc3 0x230130" -#define APIJUNGFRAU "7.0.0.rc3 0x230130" #define APIMYTHEN3 "7.0.0.rc3 0x230130" #define APIMOENCH "7.0.0.rc3 0x230130" -#define APIEIGER "7.0.0.rc3 0x230130" #define APILIB "7.0.0.rc4 0x230214" #define APIRECEIVER "7.0.0.rc4 0x230214" +#define APIJUNGFRAU "7.0.0.rc5 0x230216" +#define APIEIGER "7.0.0.rc5 0x230220"