Add slsReceiverUsers(int tcpip_port_no) overload

Use std::unique_ptr<> instead of raw pointers
This commit is contained in:
Samuel Debionne 2019-02-12 16:23:55 +01:00
parent 031a11c4f7
commit b18391330e
4 changed files with 33 additions and 24 deletions

View File

@ -4,10 +4,9 @@
* @short creates the UDP and TCP class objects
***********************************************/
#include <memory>
class slsReceiverTCPIPInterface;
#include "slsReceiverTCPIPInterface.h"
#include "sls_detector_defs.h"
@ -29,9 +28,13 @@ class slsReceiver : private virtual slsDetectorDefs {
slsReceiver(int argc, char *argv[]);
/**
* Destructor
* Constructor
* Starts up a Receiver server. Reads configuration file, options, and
* assembles a Receiver using TCP and UDP detector interfaces
* throws an exception in case of failure
* @param tcpip_port_no TCP/IP port number
*/
~slsReceiver();
slsReceiver(int tcpip_port_no = 1954);
/**
* starts listening on the TCP port for client comminication
@ -95,6 +98,5 @@ class slsReceiver : private virtual slsDetectorDefs {
private:
slsReceiverTCPIPInterface* tcpipInterface;
std::unique_ptr<slsReceiverTCPIPInterface> tcpipInterface;
};

View File

@ -3,8 +3,9 @@
#include <stdio.h>
#include <stdint.h>
#include <memory>
class slsReceiver;
#include "slsReceiver.h"
/**
@short Class for implementing the SLS data receiver in the users application. Callbacks can be defined for processing and/or saving data
@ -24,9 +25,13 @@ public:
*/
slsReceiverUsers(int argc, char *argv[], int &success);
/** Destructor */
~slsReceiverUsers();
/**
* Constructor
* reads config file, creates socket, assigns function table
* @param tcpip_port_no TCP/IP port
* @throws
*/
slsReceiverUsers(int tcpip_port_no = 1954);
/**
* starts listening on the TCP port for client comminication
@ -83,6 +88,5 @@ public:
char* datapointer, uint32_t &revDatasize, void*),void *arg);
//receiver object
slsReceiver* receiver;
std::unique_ptr<slsReceiver> receiver;
};

View File

@ -78,14 +78,17 @@ slsReceiver::slsReceiver(int argc, char *argv[]):
}
// might throw an exception
tcpipInterface = new slsReceiverTCPIPInterface(tcpip_port_no);
//tcpipInterface = std::make_unique<slsReceiverTCPIPInterface>(tcpip_port_no);
tcpipInterface = std::unique_ptr<slsReceiverTCPIPInterface>(new slsReceiverTCPIPInterface(tcpip_port_no));
}
slsReceiver::~slsReceiver() {
if(tcpipInterface)
delete tcpipInterface;
slsReceiver::slsReceiver(int tcpip_port_no)
{
// might throw an exception
//tcpipInterface = std::make_unique<slsReceiverTCPIPInterface>(tcpip_port_no);
tcpipInterface = std::unique_ptr<slsReceiverTCPIPInterface>(new slsReceiverTCPIPInterface(tcpip_port_no));
}

View File

@ -1,19 +1,19 @@
#include "slsReceiverUsers.h"
#include "slsReceiver.h"
slsReceiverUsers::slsReceiverUsers(int argc, char *argv[], int &success) {
// catch the exception here to limit it to within the library (for current version)
try {
slsReceiver* r = new slsReceiver(argc, argv);
receiver = r;
//receiver = std::make_unique<slsReceiver>(argc, argv);
receiver = std::unique_ptr<slsReceiver>(new slsReceiver(argc, argv));
success = slsDetectorDefs::OK;
} catch (...) {
success = slsDetectorDefs::FAIL;
}
}
slsReceiverUsers::~slsReceiverUsers() {
delete receiver;
slsReceiverUsers::slsReceiverUsers(int tcpip_port_no) {
//receiver = std::make_unique<slsReceiver>(tcpip_port_no);
receiver = std::unique_ptr<slsReceiver>(new slsReceiver(tcpip_port_no));
}
int slsReceiverUsers::start() {