changing signature from std::string to const std::string& for client receiver ip functions

This commit is contained in:
maliakal_d 2019-01-15 13:14:43 +01:00
parent f2669adda7
commit a9fb476543
4 changed files with 6 additions and 6 deletions

View File

@ -1766,7 +1766,7 @@ int multiSlsDetector::getReceiverStreamingPort(int detPos) {
return sls::minusOneIfDifferent(r); return sls::minusOneIfDifferent(r);
} }
void multiSlsDetector::setClientDataStreamingInIP(std::string ip, void multiSlsDetector::setClientDataStreamingInIP(const std::string& ip,
int detPos) { int detPos) {
if (ip.length()) { if (ip.length()) {
int prev_streaming = enableDataStreamingToClient(-1); int prev_streaming = enableDataStreamingToClient(-1);
@ -1800,7 +1800,7 @@ std::string multiSlsDetector::getClientStreamingIP(int detPos) {
return sls::concatenateIfDifferent(r); return sls::concatenateIfDifferent(r);
} }
void multiSlsDetector::setReceiverDataStreamingOutIP(std::string ip, void multiSlsDetector::setReceiverDataStreamingOutIP(const std::string& ip,
int detPos) { int detPos) {
if (ip.length()) { if (ip.length()) {
int prev_streaming = enableDataStreamingFromReceiver(-1, detPos); int prev_streaming = enableDataStreamingFromReceiver(-1, detPos);

View File

@ -998,7 +998,7 @@ class multiSlsDetector : public virtual slsDetectorDefs,
* By default, it is the IP of receiver hostname * By default, it is the IP of receiver hostname
* @param detPos -1 for all detectors in list or specific detector position * @param detPos -1 for all detectors in list or specific detector position
*/ */
void setClientDataStreamingInIP(std::string ip = "", void setClientDataStreamingInIP(const std::string& ip = "",
int detPos = -1); int detPos = -1);
/** /**
@ -1016,7 +1016,7 @@ class multiSlsDetector : public virtual slsDetectorDefs,
* By default, it is the IP of receiver hostname * By default, it is the IP of receiver hostname
* @param detPos -1 for all detectors in list or specific detector position * @param detPos -1 for all detectors in list or specific detector position
*/ */
void setReceiverDataStreamingOutIP(std::string ip = "", void setReceiverDataStreamingOutIP(const std::string& ip = "",
int detPos = -1); int detPos = -1);
/** /**

View File

@ -2902,7 +2902,7 @@ int slsDetector::getReceiverStreamingPort() {
return thisDetector->receiver_zmqport; return thisDetector->receiver_zmqport;
} }
void slsDetector::setClientStreamingIP(std::string sourceIP) { void slsDetector::setClientStreamingIP(const std::string& sourceIP) {
struct addrinfo *result; struct addrinfo *result;
// on failure to convert to a valid ip // on failure to convert to a valid ip
if (dataSocket->ConvertHostnameToInternetAddress(sourceIP.c_str(), &result)) { if (dataSocket->ConvertHostnameToInternetAddress(sourceIP.c_str(), &result)) {

View File

@ -979,7 +979,7 @@ public:
* Sets the client zmq ip\sa sharedSlsDetector * Sets the client zmq ip\sa sharedSlsDetector
* @param sourceIP client zmq ip * @param sourceIP client zmq ip
*/ */
void setClientStreamingIP(std::string sourceIP); void setClientStreamingIP(const std::string& sourceIP);
/** /**
* Returns the client zmq ip \sa sharedSlsDetector * Returns the client zmq ip \sa sharedSlsDetector