From a4ae0ca2f0ec73f6d0e52336a20d7ad617fe4df4 Mon Sep 17 00:00:00 2001 From: Erik Frojdh Date: Thu, 28 Apr 2022 16:33:46 +0200 Subject: [PATCH] only add warning when target is defined --- CMakeLists.txt | 22 +++++++--------------- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 3cf81f698..b691f1ca2 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -109,21 +109,6 @@ else() message(STATUS "Building without link time optimization") endif() -#Testing for minimum version for compilers -if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang") - if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 3.2) - message(FATAL_ERROR "Clang version must be at least 3.2!") - endif() -elseif ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU") - if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.8) - message(FATAL_ERROR "GCC version must be at least 4.8!") - endif() - if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5) - target_compile_options(slsProjectWarnings INTERFACE - -Wno-missing-field-initializers) - endif() -endif() - if(SLS_EXT_BUILD) # Find ourself in case of external build @@ -161,6 +146,13 @@ if (NOT TARGET slsProjectWarnings) sls_enable_cxx_warning("-Wnull-dereference") sls_enable_cxx_warning("-Wduplicated-cond") sls_disable_cxx_warning("-Wclass-memaccess") + + if (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5 AND "${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU") + target_compile_options(slsProjectWarnings INTERFACE + -Wno-missing-field-initializers) +endif() + + endif()