From 92fd3f060902b4eb16483ccee712e68afd35a181 Mon Sep 17 00:00:00 2001 From: Dhanya Thattil Date: Tue, 1 Jul 2025 17:34:40 +0200 Subject: [PATCH] modified comments about ctb and xilinx not using roi --- slsDetectorSoftware/include/sls/Detector.h | 2 +- slsDetectorSoftware/src/CallerSpecial.cpp | 3 ++- slsDetectorSoftware/src/Detector.cpp | 1 - 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/slsDetectorSoftware/include/sls/Detector.h b/slsDetectorSoftware/include/sls/Detector.h index ef4b9c251..743c80b77 100644 --- a/slsDetectorSoftware/include/sls/Detector.h +++ b/slsDetectorSoftware/include/sls/Detector.h @@ -995,7 +995,7 @@ class Detector { /** only at multi module level without gap pixels. If more than 1 ROI per * UDP port, it will throw. Setting number of udp interfaces will clear the - * roi */ + * roi. Cannot be set for CTB or Xilinx CTB */ void setRxROI(const std::vector &args); void clearRxROI(); diff --git a/slsDetectorSoftware/src/CallerSpecial.cpp b/slsDetectorSoftware/src/CallerSpecial.cpp index f7c08a5bd..7ff78d8ef 100644 --- a/slsDetectorSoftware/src/CallerSpecial.cpp +++ b/slsDetectorSoftware/src/CallerSpecial.cpp @@ -745,7 +745,8 @@ std::string Caller::rx_roi(int action) { "get command.\n" "\t- Use the command 'rx_clearroi' to clear all ROIs.\n" "\t- Changing the number of UDP interfaces will automatically clear " - "the current ROIs.\n"; + "the current ROIs.\n\n" + "\t- Cannot be set for CTB or Xilinx CTB.\n"; if (action == defs::HELP_ACTION) { os << helpMessage; diff --git a/slsDetectorSoftware/src/Detector.cpp b/slsDetectorSoftware/src/Detector.cpp index cb7e33018..14a6d7cc0 100644 --- a/slsDetectorSoftware/src/Detector.cpp +++ b/slsDetectorSoftware/src/Detector.cpp @@ -1387,7 +1387,6 @@ std::vector Detector::getRxROI(int module_id) const { return pimpl->getRxROI(module_id); } -// RxROIs can be set for all types except CTB. At multi level without gap pixels void Detector::setRxROI(const std::vector &args) { pimpl->setRxROI(args); }