Dev/ctb separate dac and power (#1420)

* not allowing power names for dac names to prevent duplicate names

* wip

* v_abcd commands should be removed to prevent unintentional usage and throw with a suggestion command for dac and power

* binary in

* dacs with power dac names should work and do not take in dac units to avoid ambiguity, test with 0 value for power dacs should fail, to do: implement power commands

* wip: power in client, tests, and fixed server interfaces and ctb implementation, not tested

* wip. client and xilinx todo

* wip: ctb power works, tests left

* fixed some tests

* added vchip check

* python cmds still left. wip

* fixed xilinx. python left

* wip

* wip. xilinx

* fixed powerchip for ctb

* power all returns all

* configtransceiver is removed

* wip python

* wip

* wip

* wip

* wip

* wip

* wip

* wip xilinx

* wip

* wip

* wip

* pybindings

* fix getdacindex and getdacname for normal detectors to throw if random index that doesnt fit to the detector

* wip

* fixed tests

* fixes for python api

* wip

* python: moved powerlist to Ctb

* fixed tests to work for powelist in Ctb

* moved signallist, adclist, slowadc, slowadclist to Ctb

* throw approperiate error when no modules added for powers

* added dac test

* fix dac default names and test for dacs

* ctb dacs, yet to do othe rdacs

* dacs should work now even in tests

* run all tests

* DetectorPowers->NamedPowers in ctb

* comments

* removed unnecessary test code

* removed hard coded dac names in python NamedDacs and NamedPowers

* minor

* minor

* fixed error messages

* changed power to  be able to set DAC directly, using enable and disable methods with enabled to get

slsDetectorSoftware/src/CtbConfig.cpp

@@ -20,11 +20,11 @@ CtbConfig::CtbConfig() {
     for (size_t i = 0; i != num_signals; ++i) {
         setSignalName(i, "BIT" + ToString(i));
     }
-    setPowerName(0, "VA");
-    setPowerName(1, "VB");
-    setPowerName(2, "VC");
-    setPowerName(3, "VD");
-    setPowerName(4, "VIO");
+    setPowerName(static_cast<int>(defs::V_POWER_A), "VA");
+    setPowerName(static_cast<int>(defs::V_POWER_B), "VB");
+    setPowerName(static_cast<int>(defs::V_POWER_C), "VC");
+    setPowerName(static_cast<int>(defs::V_POWER_D), "VD");
+    setPowerName(static_cast<int>(defs::V_POWER_IO), "VIO");
     for (size_t i = 0; i != num_slowADCs; ++i) {
         setSlowADCName(i, "SLOWADC" + ToString(i));
     }
@@ -80,6 +80,15 @@ CtbConfig::getNames(size_t expected_size,
 
 void CtbConfig::setDacName(size_t index, const std::string &name) {
     check_index(index, num_dacs, "DAC");
+    std::vector<std::string> powers = {"v_a", "v_b", "v_c", "v_d", "v_io",
+                                       "va",  "vb",  "vc",  "vd",  "vio"};
+    std::string lower = name;
+    std::transform(lower.begin(), lower.end(), lower.begin(),
+                   [](unsigned char c) { return std::tolower(c); });
+    if (std::find(powers.begin(), powers.end(), lower) != powers.end()) {
+        throw RuntimeError("DAC name cannot be a power name (VA, VB, VC, VD, "
+                           "VIO, V_A, V_B, V_C, V_D, V_IO)");
+    }
     set_name(name, dacnames, index);
 }