Dev/ctb separate dac and power (#1420)

* not allowing power names for dac names to prevent duplicate names

* wip

* v_abcd commands should be removed to prevent unintentional usage and throw with a suggestion command for dac and power

* binary in

* dacs with power dac names should work and do not take in dac units to avoid ambiguity, test with 0 value for power dacs should fail, to do: implement power commands

* wip: power in client, tests, and fixed server interfaces and ctb implementation, not tested

* wip. client and xilinx todo

* wip: ctb power works, tests left

* fixed some tests

* added vchip check

* python cmds still left. wip

* fixed xilinx. python left

* wip

* wip. xilinx

* fixed powerchip for ctb

* power all returns all

* configtransceiver is removed

* wip python

* wip

* wip

* wip

* wip

* wip

* wip

* wip xilinx

* wip

* wip

* wip

* pybindings

* fix getdacindex and getdacname for normal detectors to throw if random index that doesnt fit to the detector

* wip

* fixed tests

* fixes for python api

* wip

* python: moved powerlist to Ctb

* fixed tests to work for powelist in Ctb

* moved signallist, adclist, slowadc, slowadclist to Ctb

* throw approperiate error when no modules added for powers

* added dac test

* fix dac default names and test for dacs

* ctb dacs, yet to do othe rdacs

* dacs should work now even in tests

* run all tests

* DetectorPowers->NamedPowers in ctb

* comments

* removed unnecessary test code

* removed hard coded dac names in python NamedDacs and NamedPowers

* minor

* minor

* fixed error messages

* changed power to  be able to set DAC directly, using enable and disable methods with enabled to get

python/tests/test_det_api.py

@@ -394,3 +394,324 @@ def test_patternstart(session_simulator, request):
         assert "not implemented" in str(exc_info.value)
 
     Log(LogLevel.INFOGREEN, f"✅ {request.node.name} passed")
+
+
+@pytest.mark.detectorintegration
+def test_v_limit(session_simulator, request):
+    """Test v_limit."""
+    det_type, num_interfaces, num_mods, d = session_simulator
+    assert d is not None
+
+    if det_type in ['ctb', 'xilinx_ctb']:
+
+        # save previous value
+        prev_val = d.getVoltageLimit()
+        from slsdet import dacIndex, powerIndex
+        prev_dac_val = d.getDAC(dacIndex.DAC_0, False)
+        prev_power_dac_val = d.getPowerDAC(powerIndex.V_POWER_A)
+
+        with pytest.raises(Exception):
+            d.v_limit = (1200, 'mV') #mV unit not supported, should be 'no unit'
+
+        with pytest.raises(Exception):
+            d.v_limit = -100 # previously worked but not allowing now
+
+        # setting dac and power dac with no vlimit should work
+        d.v_limit = 0
+        assert d.v_limit == 0
+        d.setDAC(dacIndex.DAC_0, 1200, True, [0])
+        d.setPowerDAC(powerIndex.V_POWER_A, 1200)
+
+        # setting vlimit should throw setting values above vlimit
+        d.v_limit = 1500
+        assert d.v_limit == 1500
+
+        with pytest.raises(Exception):
+            d.setDAC(dacIndex.DAC_0, 1501, True, [0])
+
+        with pytest.raises(Exception):
+            d.setPowerDAC(powerIndex.V_POWER_A, 1501)
+        
+        # setting dac and power dac below vlimit should still work
+        d.setDAC(dacIndex.DAC_0, 1210, True, [0])
+        d.setPowerDAC(powerIndex.V_POWER_A, 1210)
+
+        # restore previous value
+        d.setVoltageLimit(prev_val)
+        d.setPowerDAC(powerIndex.V_POWER_A, prev_power_dac_val)
+        for i in range(len(d)):
+            d.setDAC(dacIndex.DAC_0, prev_dac_val[i], False, [i])
+
+    else:
+        with pytest.raises(Exception) as exc_info:
+            d.v_limit
+        assert "not implemented" in str(exc_info.value)
+
+    Log(LogLevel.INFOGREEN, f"✅ {request.node.name} passed")
+
+
+@pytest.mark.detectorintegration
+def test_v_abcd(session_simulator, request):
+    """Test v_a, v_b, v_c, v_d, v_io are deprecated comands."""
+    det_type, num_interfaces, num_mods, d = session_simulator
+    assert d is not None
+
+
+    with pytest.raises(Exception):
+        d.v_a
+
+    with pytest.raises(Exception):
+        d.v_b
+
+    with pytest.raises(Exception):
+        d.v_c
+
+    with pytest.raises(Exception):
+        d.v_d
+
+    with pytest.raises(Exception):
+        d.v_io
+
+    Log(LogLevel.INFOGREEN, f"✅ {request.node.name} passed")
+
+
+
+@pytest.mark.detectorintegration
+def test_powers(session_simulator, request):
+    """Test powers and powerlist."""
+    det_type, num_interfaces, num_mods, d = session_simulator
+    assert d is not None
+
+    from slsdet import Ctb
+    c = Ctb()
+    
+    if det_type in ['ctb', 'xilinx_ctb']:
+
+        c.powerlist
+
+        # save previous value
+        from slsdet import powerIndex
+        prev_val_dac = {power: c.getPowerDAC(power) for power in c.getPowerList()}
+        prev_val = {power: c.isPowerEnabled(power) for power in c.getPowerList()}
+
+        # invalid
+        invalid_assignments = [
+            (c.powers, "random", True), # set random power
+            (c.powers, "random", True), # set random attribute of power
+            (c.powers.VA, "dac", "1200"),
+            (c.powers.VA, "enabled", "True"),
+            (c.powers, "VA", "-100"),
+            (c.powers, "VA", "-1"),
+            (c.powers, "VA", "4096")
+        ]
+        for obj, attr, value in invalid_assignments:
+            with pytest.raises(Exception):
+                setattr(obj, attr, value)
+        # vchip power can only be accessed via pybindings because it cannot be enabled/disabled
+        with pytest.raises(Exception):
+            c.powers.VCHIP
+
+        # valid
+        c.powers
+        c.powers.VA = 1200
+        assert c.powers.VA == 1200
+        assert c.powers.VA.dac == 1200
+
+        c.powers.VA.enable()
+        assert c.powers.VA.enabled == True
+
+        c.setPowerEnabled([powerIndex.V_POWER_B, powerIndex.V_POWER_C], True)
+        assert c.powers.VB.enabled == True
+        assert c.powers.VC.enabled == True
+
+        c.powers.VA = 1500
+        assert c.powers.VA == 1500
+        assert c.powers.VA.dac == 1500
+
+        # change power name and test same value 
+        temp = c.powers.VB
+        c.powerlist = ["VA", "m_VB", "VC", "VD", "VIO"]
+        assert c.powers.m_VB.enabled == True
+        assert c.powers.m_VB == temp
+
+        # restore previous value
+        for power in c.getPowerList():
+            c.setPowerDAC(power, prev_val_dac[power])
+            c.setPowerEnabled([power], prev_val[power])
+    else:
+        with pytest.raises(Exception) as exc_info:
+            c.powerlist
+        assert "only for CTB" in str(exc_info.value)
+
+    Log(LogLevel.INFOGREEN, f"✅ {request.node.name} passed")
+
+
+@pytest.mark.detectorintegration
+def test_adclist(session_simulator, request):
+    """Test ADC list."""
+    det_type, num_interfaces, num_mods, d = session_simulator
+    assert d is not None
+
+    from slsdet import Ctb
+    c = Ctb()
+    
+    if det_type in ['ctb', 'xilinx_ctb']:
+        c.adclist
+        c.adclist = ["1", "2", "3", "test", "5", "6", "7", "8", "9", "10", "11", "12", "13", "14", "15", "16", "17", "18", "19", "20", "21", "22", "23", "24", "25", "26", "27", "28", "29", "30", "31", "32"]
+        c.adclist
+
+    else:
+        with pytest.raises(Exception) as exc_info:
+            c.adclist
+        assert "only for CTB" in str(exc_info.value)
+
+    Log(LogLevel.INFOGREEN, f"✅ {request.node.name} passed")
+
+
+@pytest.mark.detectorintegration
+def test_signallist(session_simulator, request):
+    """Test signal list."""
+    det_type, num_interfaces, num_mods, d = session_simulator
+    assert d is not None
+
+    from slsdet import Ctb
+    c = Ctb()
+    
+    if det_type in ['ctb', 'xilinx_ctb']:
+        c.signallist
+        c.signallist = ["1", "2", "3", "test", "5", "6", "7", "8", "9", "10", "11", "12", "13", "14", "15", "16", "17", "18", "19", "20", "21", "22", "23", "24", "25", "26", "27", "28", "29", "30", "31", "32", "33", "34", "35", "36", "37", "38", "39", "40", "41", "42", "43", "44", "45", "46", "47", "48", "49", "50", "51", "52", "53", "54", "55", "56", "57", "58", "59", "60", "61", "62", "63", "64"]
+        c.signallist
+
+    else:
+        with pytest.raises(Exception) as exc_info:
+            c.signallist
+        assert "only for CTB" in str(exc_info.value)
+
+    Log(LogLevel.INFOGREEN, f"✅ {request.node.name} passed")
+
+
+@pytest.mark.detectorintegration
+def test_slowadc(session_simulator, request):
+    """Test slow ADC and slow adc list."""
+    det_type, num_interfaces, num_mods, d = session_simulator
+    assert d is not None
+
+    from slsdet import Ctb
+    c = Ctb()
+    
+    if det_type in ['ctb', 'xilinx_ctb']:
+        c.slowadc
+        c.slowadc.SLOWADC5
+        c.slowadclist = ["1", "2", "3", "test", "5", "6", "7", "8"]
+        c.slowadc.test
+
+    else:
+        with pytest.raises(Exception) as exc_info:
+            c.signallist
+        assert "only for CTB" in str(exc_info.value)
+
+    Log(LogLevel.INFOGREEN, f"✅ {request.node.name} passed")
+
+
+
+
+@pytest.mark.detectorintegration
+def test_dac(session_simulator, request):
+    """Test dac."""
+    det_type, num_interfaces, num_mods, d = session_simulator
+    assert d is not None
+    from slsdet import dacIndex
+
+    if det_type in ['ctb', 'xilinx_ctb']:
+        
+        from slsdet import Ctb
+        c = Ctb()
+
+        # valid
+        c.daclist
+        c.dacvalues
+       
+        # save previous value
+        prev_val = {dac: c.getDAC(dac, False) for dac in c.getDacList()}
+        prev_dac_list = c.daclist
+
+        # invalid
+        invalid_assignments = [
+            (c.dacs, "vb_comp", "1200"), # set random dac
+            (c.dacs, "DAC18", "1200"), # set dac 18
+            (c.dacs, "DAC0", "-1"),
+            (c.dacs, "DAC0", "4096")
+        ]
+        for obj, attr, value in invalid_assignments:
+            with pytest.raises(Exception):
+                setattr(obj, attr, value)
+
+        # valid
+        c.dacs.DAC0 = 1200
+        assert c.getDAC(dacIndex.DAC_0, False)[0] == 1200
+
+        c.dacs.DAC0 = 0
+        assert c.dacs.DAC0[0] == 0
+
+        # restore previous value
+        for dac in c.getDacList():
+            c.setDAC(dac, prev_val[dac][0], False)
+        c.daclist = prev_dac_list
+
+    else:
+        with pytest.raises(Exception):
+            d.dacs.DAC0
+
+        # valid
+        d.daclist
+        d.dacvalues
+
+        # remember first dac name and index to test later
+        dacname = d.daclist[0]
+        assert dacname
+        dacIndex = d.getDacList()[0]
+
+        # save previous value
+        prev_val = d.getDAC(dacIndex, False)
+
+        if det_type == 'eiger':
+            from slsdet import Eiger
+            c = Eiger()
+        elif det_type == 'jungfrau':
+            from slsdet import Jungfrau
+            c = Jungfrau()
+        elif det_type == 'gotthard2':
+            from slsdet import Gotthard2
+            c = Gotthard2()
+        elif det_type == 'mythen3':
+            from slsdet import Mythen3
+            c = Mythen3()
+        elif det_type == 'moench':
+            from slsdet import Moench
+            c = Moench()    
+        else:
+            raise RuntimeError("Unknown detector type to test dac: " + det_type)
+        # invalid checks
+        invalid_assignments = [
+            (c.dacs, "random", "1200"), # set random dac
+            (c.dacs, "DAC0", "1200"), # set random dac
+            (c.dacs, dacname, "-1"),
+            (c.dacs, dacname, "4096")
+        ]
+        for obj, attr, value in invalid_assignments:
+            with pytest.raises(Exception):
+                setattr(obj, attr, value)
+
+        # valid, have to use setattr because c is different for each detector 
+        # and we cannot hardcode the dac name
+        setattr(c.dacs, dacname, 1200)
+        assert c.getDAC(dacIndex, False)[0] == 1200
+        setattr(c.dacs, dacname, 0)
+        assert getattr(c.dacs, dacname)[0] == 0
+
+        # restore previous value
+        for i in range(len(d)):
+            d.setDAC(dacIndex, prev_val[i], False, [i])
+   
+
+    Log(LogLevel.INFOGREEN, f"✅ {request.node.name} passed")