From 44aa3f655bf42cac041fcaba334d3019de1e3546 Mon Sep 17 00:00:00 2001
From: Erik Frojdh <erik.frojdh@gmail.com>
Date: Tue, 2 Jul 2019 12:11:45 +0200
Subject: [PATCH 1/2] cmath + cleaning

---
 slsDetectorGui/CMakeLists.txt          | 31 +++++++++-----------------
 slsDetectorGui/src/qTabMeasurement.cpp |  2 +-
 2 files changed, 12 insertions(+), 21 deletions(-)

diff --git a/slsDetectorGui/CMakeLists.txt b/slsDetectorGui/CMakeLists.txt
index ec1968c31..e1da0e3b7 100755
--- a/slsDetectorGui/CMakeLists.txt
+++ b/slsDetectorGui/CMakeLists.txt
@@ -51,26 +51,12 @@ set(HEADERS
     include/qTabDebugging.h
     include/qTabDeveloper.h
     include/qTabMessages.h
-    ../slsDetectorSoftware/include
-    ../slsSupportLib/include/versionAPI.h
-    ../slsSupportLib/include/ServerSocket.h
-    ../slsSupportLib/include/ServerInterface2.h
 )
 set(RESOURCES
     include/icons.qrc
 )
 qt4_add_resources(RESOURCES_SRCS ${RESOURCES})
 
-include_directories(
-    include
-    slsDetectorPlotting/include
-    ../slsSupportLib/include  
-    ${QT_INCLUDE_DIR}
-    ${QT_QTCORE_INCLUDE_DIR}
-    ${QT_QTGUI_INCLUDE_DIR}
-    ${QWT_INCLUDE_DIR}
-    ${CMAKE_CURRENT_BINARY_DIR}
-)
 
 add_definitions(
     -DPRINT_LOG #-DVERBOSE 
@@ -83,17 +69,22 @@ add_executable(slsDetectorGui
     ${RESOURCES_SRCS}
 )
 
+target_include_directories(slsDetectorGui PUBLIC
+    "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>"
+    "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/slsDetectorPlotting/include>"
+    "$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>"
+    "$<BUILD_INTERFACE:${QT_INCLUDE_DIR}>"
+    "$<BUILD_INTERFACE:${QT_QTCORE_INCLUDE_DIR}>"
+    "$<BUILD_INTERFACE:${QT_QTGUI_INCLUDE_DIR}>"
+    "$<BUILD_INTERFACE:${QWT_INCLUDE_DIR}>"
+    "$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}>"
+)
+
 target_link_libraries(slsDetectorGui PUBLIC
-    slsProjectOptions
-    slsProjectWarnings
-    slsSupportLib
     slsDetectorShared
     ${QT_QTCORE_LIBRARIES}
     ${QT_QTGUI_LIBRARIES}
     ${QWT_LIBRARIES}
-    pthread
-    ${ZeroMQ_LIBRARIES}
-    rt
     png
     z
     Qt4::QtOpenGL
diff --git a/slsDetectorGui/src/qTabMeasurement.cpp b/slsDetectorGui/src/qTabMeasurement.cpp
index 5006ff86e..2e8c6c302 100755
--- a/slsDetectorGui/src/qTabMeasurement.cpp
+++ b/slsDetectorGui/src/qTabMeasurement.cpp
@@ -3,7 +3,7 @@
 #include "qDrawPlot.h"
 
 #include "string_utils.h"
-
+#include <cmath>
 #include <QStandardItemModel>
 #include <QTimer>
 

From 00eaad3416bf6720faac34d43697b77bbc0dd41f Mon Sep 17 00:00:00 2001
From: Erik Frojdh <erik.frojdh@gmail.com>
Date: Tue, 2 Jul 2019 12:42:58 +0200
Subject: [PATCH 2/2] cmake

---
 CMakeLists.txt                | 4 ++--
 slsDetectorGui/CMakeLists.txt | 8 ++++++++
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 442156c0c..f71c21930 100755
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -125,8 +125,8 @@ install(TARGETS slsProjectOptions slsProjectWarnings rapidjson
 
 set(CMAKE_POSITION_INDEPENDENT_CODE ON)
 set(CMAKE_INSTALL_RPATH "$ORIGIN")
-set(CMAKE_BUILD_WITH_INSTALL_RPATH TRUE)
-
+# set(CMAKE_BUILD_WITH_INSTALL_RPATH TRUE)
+set(CMAKE_BUILD_WITH_INSTALL_RPATH FALSE)
 
 
 find_package(Doxygen)
diff --git a/slsDetectorGui/CMakeLists.txt b/slsDetectorGui/CMakeLists.txt
index e1da0e3b7..0e5fcda2f 100755
--- a/slsDetectorGui/CMakeLists.txt
+++ b/slsDetectorGui/CMakeLists.txt
@@ -95,3 +95,11 @@ set_target_properties(slsDetectorGui PROPERTIES
     RUNTIME_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin
 )
 
+install(TARGETS slsDetectorGui
+    EXPORT "${TARGETS_EXPORT_NAME}"
+    RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}
+    LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}
+    ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}
+    PUBLIC_HEADER DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
+)
+