detectors/slsDetectorPackage
25
0
Fork 0
mirror of https://github.com/slsdetectorgroup/slsDetectorPackage.git synced 2025-06-06 18:10:40 +02:00
Code Issues Actions Packages Releases Activity

storagecells not updated in rx and allowing it in idle mode (#485)

Browse Source
This commit is contained in:
Dhanya Thattil 2022-06-09 13:42:18 +02:00 committed by GitHub
parent 8ca8185d41
commit 5490daa0a1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
RELEASE.txt
View File

@ -82,6 +82,7 @@ This document describes the differences between v7.0.0 and v6.x.x
- rxr mem size changed (fifo header size from 8 to 16) due to sls rxr header = 112.. 112+ 16=128 (reduces packet losss especially for g2) - rxr mem size changed (fifo header size from 8 to 16) due to sls rxr header = 112.. 112+ 16=128 (reduces packet losss especially for g2)
-udp_srcip and udp_Srcip2: can set to auto (for virtual or 1g data networks) -udp_srcip and udp_Srcip2: can set to auto (for virtual or 1g data networks)
- set dataset name for all hdf5 files to "data" only - set dataset name for all hdf5 files to "data" only
- number of storage cells is not updated in teh receiver. done. and also allowing it to be modified in running status
2. Resolved Issues 2. Resolved Issues
================== ==================

3
slsDetectorSoftware/src/Module.cpp
View File

@ -1768,6 +1768,9 @@ int Module::getNumberOfAdditionalStorageCells() const {
void Module::setNumberOfAdditionalStorageCells(int value) { void Module::setNumberOfAdditionalStorageCells(int value) {
sendToDetector(F_SET_NUM_ADDITIONAL_STORAGE_CELLS, value, nullptr); sendToDetector(F_SET_NUM_ADDITIONAL_STORAGE_CELLS, value, nullptr);
if (shm()->useReceiverFlag) {
sendToReceiver(F_SET_RECEIVER_NUM_ADD_STORAGE_CELLS, value, nullptr);
}
} }
int Module::getStorageCellStart() const { int Module::getStorageCellStart() const {

2
slsReceiverSoftware/src/ClientInterface.cpp
View File

@ -581,7 +581,7 @@ int ClientInterface::set_num_add_storage_cells(Interface &socket) {
throw RuntimeError("Invalid number of additional storage cells " + throw RuntimeError("Invalid number of additional storage cells " +
std::to_string(value)); std::to_string(value));
} }
verifyIdle(socket); // allowing this to be done even when receiver not idle
LOG(logDEBUG1) << "Setting num additional storage cells to " << value; LOG(logDEBUG1) << "Setting num additional storage cells to " << value;
impl()->setNumberOfAdditionalStorageCells(value); impl()->setNumberOfAdditionalStorageCells(value);
return socket.Send(OK); return socket.Send(OK);