diff --git a/slsReceiverSoftware/src/CommandLineOptions.cpp b/slsReceiverSoftware/src/CommandLineOptions.cpp index 1df0ba577..c0aaf51ef 100644 --- a/slsReceiverSoftware/src/CommandLineOptions.cpp +++ b/slsReceiverSoftware/src/CommandLineOptions.cpp @@ -2,10 +2,10 @@ // Copyright (C) 2021 Contributors to the SLS Detector Package #include "CommandLineOptions.h" -#include "sls/sls_detector_defs.h" -#include "sls/versionAPI.h" #include "sls/ToString.h" #include "sls/logger.h" +#include "sls/sls_detector_defs.h" +#include "sls/versionAPI.h" #include #include @@ -28,7 +28,7 @@ ParsedOptions CommandLineOptions::parse(int argc, char *argv[]) { FrameSyncOptions frame; base.port = DEFAULT_TCP_RX_PORTNO; - auto optString = buildOptString(); + auto optString = buildOptString(); auto longOptions = buildOptionList(); optind = 0; // reset getopt int opt, option_index = 0; @@ -40,12 +40,10 @@ ParsedOptions CommandLineOptions::parse(int argc, char *argv[]) { case 'h': handleCommonOption(opt, optarg, base); return base; // exit after version/help - case 'p': case 'u': handleCommonOption(opt, optarg, base); break; - case 'c': case 'n': case 't': @@ -60,10 +58,12 @@ ParsedOptions CommandLineOptions::parse(int argc, char *argv[]) { if (optind < argc) { // deprecated and current options => invalid - if (base.port != DEFAULT_TCP_RX_PORTNO || - multi.numReceivers != 1 || frame.numReceivers != 1 || multi.callbackEnabled != false || frame.printHeaders != false) { - LOG(sls::logWARNING) - << "Cannot use both deprecated options and the valid options simultaneously. Please move away from the deprecated options.\n"; + if (base.port != DEFAULT_TCP_RX_PORTNO || multi.numReceivers != 1 || + frame.numReceivers != 1 || multi.callbackEnabled != false || + frame.printHeaders != false) { + LOG(sls::logWARNING) << "Cannot use both deprecated options and " + "the valid options simultaneously. Please " + "move away from the deprecated options.\n"; } // unsupported deprecated arguments @@ -74,7 +74,6 @@ ParsedOptions CommandLineOptions::parse(int argc, char *argv[]) { // parse deprecated arguments std::vector args(argv, argv + argc); auto [p, n, o] = ParseDeprecated(args); - // set options base.port = p; if (appType_ == AppType::MultiReceiver) { @@ -113,9 +112,9 @@ ParsedOptions CommandLineOptions::parse(int argc, char *argv[]) { std::vector