From 318b19ad79a2af88ccd6e2fdc21e6f0c1302ad41 Mon Sep 17 00:00:00 2001
From: Dhanya Thattil <dhanya.thattil@psi.ch>
Date: Mon, 7 Jul 2025 17:36:40 +0200
Subject: [PATCH] wip test

---
 .../src/CommandLineOptions.cpp                | 217 ++++++++++--------
 slsReceiverSoftware/src/CommandLineOptions.h  |  14 +-
 slsReceiverSoftware/tests/test-Apps.cpp       | 153 ++++++++++++
 3 files changed, 281 insertions(+), 103 deletions(-)
 create mode 100644 slsReceiverSoftware/tests/test-Apps.cpp

diff --git a/slsReceiverSoftware/src/CommandLineOptions.cpp b/slsReceiverSoftware/src/CommandLineOptions.cpp
index a7d91f8cb..3cb573371 100644
--- a/slsReceiverSoftware/src/CommandLineOptions.cpp
+++ b/slsReceiverSoftware/src/CommandLineOptions.cpp
@@ -11,6 +11,16 @@
 #include <cstring>
 #include <unistd.h>
 
+ParsedOptions CommandLineOptions::parse(const std::vector<std::string> &args) {
+    std::vector<char *> argv;
+    argv.reserve(args.size());
+    for (const auto &arg : args) {
+        argv.push_back(const_cast<char *>(arg.c_str()));
+    }
+    int argc = static_cast<int>(argv.size());
+    return parse(argc, argv.data());
+}
+
 ParsedOptions CommandLineOptions::parse(int argc, char *argv[]) {
     CommonOptions base;
     base.port = DEFAULT_TCP_RX_PORTNO;
@@ -24,26 +34,26 @@ ParsedOptions CommandLineOptions::parse(int argc, char *argv[]) {
     auto optString = buildOptString();
     auto longOptions = buildOptionList();
 
-    int opt;
-    int option_index = 0;
+    optind = 0; // reset getopt
+    int opt, option_index = 0;
 
     while ((opt = getopt_long(argc, argv, optString.c_str(), longOptions.data(),
                               &option_index)) != -1) {
         switch (opt) {
-
         case 'v':
         case 'h':
+            handleCommonOption(opt, optarg, base);
+            return base; // exit after version/help
+
         case 'p':
         case 'u':
             handleCommonOption(opt, optarg, base);
             break;
-
         case 'c':
         case 'n':
         case 't':
             handleAppSpecificOption(opt, optarg, base, multi, frame);
             break;
-
         default:
             throw sls::RuntimeError("Invalid arguments." + getHelpMessage());
         }
@@ -51,38 +61,50 @@ ParsedOptions CommandLineOptions::parse(int argc, char *argv[]) {
 
     // remaining arguments
     if (optind < argc) {
-        // maintain backward compatibility of [start port] [num receivers]
-        // [optional arg] ( for multi receiver and frame synchronizer )
-        if (appType_ != AppType::SingleReceiver &&
-            GetDeprecated(argc, argv, base.port, numReceivers, optionalArg)) {
-            if (appType_ == AppType::MultiReceiver) {
-                multi.numReceivers = numReceivers;
-                multi.callbackEnabled = optionalArg;
-            } else if (appType_ == AppType::FrameSynchronizer) {
-                frame.numReceivers = numReceivers;
-                frame.printHeaders = optionalArg;
-            }
-        } else {
+
+        // no deprecated arguments
+        if (appType_ == AppType::SingleReceiver) {
             throw sls::RuntimeError("Invalid arguments." + getHelpMessage());
         }
+
+        // maintain backward compatibility of [start port] [num receivers]
+        // [optional arg]
+        if (argc != 3 && argc != 4) {
+            throw sls::RuntimeError("Invalid number of arguments." +
+                                    getHelpMessage());
+        }
+
+        GetDeprecated(argc, argv, base.port, numReceivers, optionalArg);
+        if (appType_ == AppType::MultiReceiver) {
+            multi.numReceivers = numReceivers;
+            multi.callbackEnabled = optionalArg;
+        } else if (appType_ == AppType::FrameSynchronizer) {
+            frame.numReceivers = numReceivers;
+            frame.printHeaders = optionalArg;
+        }
     }
 
+    // Logging
     LOG(sls::logINFO) << "Number of receivers: " << numReceivers;
     LOG(sls::logINFO) << "TCP Port: " << base.port;
+    if (appType_ == AppType::MultiReceiver) {
+        LOG(sls::logINFO) << "Callback enabled: " << multi.callbackEnabled;
+    } else if (appType_ == AppType::FrameSynchronizer) {
+        LOG(sls::logINFO) << "Print headers: " << frame.printHeaders;
+    }
+
     switch (appType_) {
     case AppType::SingleReceiver:
         return base;
     case AppType::MultiReceiver:
-        LOG(sls::logINFO) << "Call back enable: " << multi.callbackEnabled;
         static_cast<CommonOptions &>(multi) = base;
         return multi;
     case AppType::FrameSynchronizer:
-        LOG(sls::logINFO) << "Print headers: " << frame.printHeaders;
         static_cast<CommonOptions &>(frame) = base;
         return frame;
+    default:
+        throw sls::RuntimeError("Unknown AppType in CommandLineOptions::parse");
     }
-
-    throw std::logic_error("Unknown AppType");
 }
 
 std::vector<option> CommandLineOptions::buildOptionList() const {
@@ -122,6 +144,52 @@ std::string CommandLineOptions::buildOptString() const {
     return optstr;
 }
 
+uint16_t CommandLineOptions::parsePort(const char *optarg) {
+    uint16_t val = 0;
+    try {
+        val = sls::StringTo<uint16_t>(optarg);
+    } catch (...) {
+        throw sls::RuntimeError("Could not parse port number " +
+                                std::string(optarg));
+    }
+    if (val < 1024) {
+        throw sls::RuntimeError(
+            "Invalid/ privileged port number parsed. Min: 1024.");
+    }
+    return val;
+}
+
+uint16_t CommandLineOptions::parseNumReceivers(const char *optarg) {
+    uint16_t val = 0;
+    try {
+        val = sls::StringTo<uint16_t>(optarg);
+    } catch (...) {
+        throw sls::RuntimeError("Could not parse number of receivers " +
+                                std::string(optarg));
+    }
+    if (val == 0 || val > MAX_RECEIVERS) {
+        throw sls::RuntimeError(
+            "Invalid number of receivers parsed. Options: 1 - " +
+            std::to_string(MAX_RECEIVERS));
+    }
+    return val;
+}
+
+uid_t CommandLineOptions::parseUID(const char *optarg) {
+    uid_t val = -1;
+    try {
+        val = sls::StringTo<uid_t>(optarg);
+    } catch (...) {
+        throw sls::RuntimeError("Could not parse UID " + std::string(optarg));
+    }
+    if (val == static_cast<uid_t>(-1)) {
+        throw sls::RuntimeError(
+            "Could not parse UID. Expected a valid user ID." +
+            std::string(optarg));
+    }
+    return val;
+}
+
 void CommandLineOptions::handleCommonOption(int opt, const char *optarg,
                                             CommonOptions &base) {
     switch (opt) {
@@ -134,21 +202,11 @@ void CommandLineOptions::handleCommonOption(int opt, const char *optarg,
         std::cout << getHelpMessage() << std::endl;
         break;
     case 'p':
-        try {
-            base.port = sls::StringTo<uint16_t>(optarg);
-        } catch (...) {
-            throw sls::RuntimeError("Invalid port number parsed.");
-        }
+        base.port = parsePort(optarg);
         break;
     case 'u':
-        try {
-            base.userid = sls::StringTo<uid_t>(optarg);
-            if (base.userid != static_cast<uid_t>(-1)) {
-                setEffectiveUID(base.userid);
-            }
-        } catch (...) {
-            throw sls::RuntimeError("Invalid uid parsed.");
-        }
+        base.userid = parseUID(optarg);
+        setEffectiveUID(base.userid);
         break;
     }
 }
@@ -167,18 +225,7 @@ void CommandLineOptions::handleAppSpecificOption(int opt, const char *optarg,
         break;
 
     case 'n': {
-        uint16_t val = 1;
-        try {
-            val = sls::StringTo<uint16_t>(optarg);
-        } catch (...) {
-            throw sls::RuntimeError("Invalid number of receivers parsed." +
-                                    std::to_string(val));
-        }
-        if (val == 0 || val > MAX_RECEIVERS) {
-            throw sls::RuntimeError(
-                "Invalid number of receivers. Options: 1 - " +
-                std::to_string(MAX_RECEIVERS));
-        }
+        auto val = parseNumReceivers(optarg);
         if (appType_ == AppType::MultiReceiver)
             multi.numReceivers = val;
         else if (appType_ == AppType::FrameSynchronizer)
@@ -189,81 +236,55 @@ void CommandLineOptions::handleAppSpecificOption(int opt, const char *optarg,
     case 't':
         LOG(sls::logWARNING) << "Deprecated option 't' and '--rx_tcport'. Use "
                                 "'p' or '--port' instead.";
-        try {
-            base.port = sls::StringTo<uint16_t>(optarg);
-        } catch (...) {
-            throw sls::RuntimeError("Invalid port number parsed.");
-        }
+        base.port = parsePort(optarg);
         break;
     }
 }
 
-int CommandLineOptions::GetDeprecated(int argc, char *argv[],
-                                      uint16_t &startPort,
-                                      uint16_t &numReceivers,
-                                      bool &optionalArg) {
-    std::string deprecatedMessage =
-        "Detected deprecated Options. Please update.\n";
+void CommandLineOptions::GetDeprecated(int argc, char *argv[],
+                                       uint16_t &startPort,
+                                       uint16_t &numReceivers,
+                                       bool &optionalArg) {
     if (argc > 1) {
-        try {
-            if (argc == 3 || argc == 4) {
+        if (argc == 3 || argc == 4) {
+            LOG(sls::logWARNING)
+                << "Detected deprecated Options. Please update.\n";
+
+            startPort = parsePort(argv[1]);
+            numReceivers = parseNumReceivers(argv[2]);
+
+            if (argc == 4) {
                 try {
-                    startPort = sls::StringTo<uint16_t>(argv[1]);
-                    numReceivers = sls::StringTo<uint16_t>(argv[2]);
+                    optionalArg = sls::StringTo<bool>(argv[3]);
                 } catch (...) {
-                    throw sls::RuntimeError(
-                        "Invalid port number or number of receivers parsed.");
+                    throw sls::RuntimeError("Invalid optional argument "
+                                            "parsed. Expected 1 (true) or "
+                                            "0 (false).");
                 }
-                if (numReceivers > MAX_RECEIVERS) {
-                    LOG(sls::logERROR)
-                        << "Did you mix up the order of the arguments? Max "
-                           "number of recievers: " << MAX_RECEIVERS;
-                    return 0;
-                }
-                if (numReceivers == 0) {
-                    LOG(sls::logERROR)
-                        << "Invalid number of receivers. Options:1 - "
-                        << MAX_RECEIVERS;
-                    return slsDetectorDefs::FAIL;
-                }
-                if (argc == 4) {
-                    try {
-                        optionalArg = sls::StringTo<bool>(argv[3]);
-                    } catch (...) {
-                        throw sls::RuntimeError("Invalid optional argument "
-                                                "parsed. Expected 1 (true) or "
-                                                "0 (false).");
-                    }
-                }
-            } else
-                throw std::runtime_error("Invalid number of arguments");
-        } catch (const std::exception &e) {
-            LOG(sls::logWARNING) << deprecatedMessage;
-            LOG(sls::logERROR) << e.what();
-            return 0;
-        }
+            }
+        } else
+            throw std::runtime_error("Invalid number of arguments");
     }
-    return 1;
 }
 
-std::string CommandLineOptions::getTypeString() {
+std::string CommandLineOptions::getTypeString() const {
     switch (appType_) {
     case AppType::SingleReceiver:
-        return "SingleReceiver";
+        return "slsReceiver";
     case AppType::MultiReceiver:
-        return "MultiReceiver";
+        return "slsMultiReceiver";
     case AppType::FrameSynchronizer:
-        return "FrameSynchronizer";
+        return "slsFrameSynchronizer";
     default:
         return "Unknown";
     }
 }
 
-std::string CommandLineOptions::getVersion() {
+std::string CommandLineOptions::getVersion() const {
     return getTypeString() + " Version: " + APIRECEIVER;
 }
 
-std::string CommandLineOptions::getHelpMessage() {
+std::string CommandLineOptions::getHelpMessage() const {
     switch (appType_) {
     case AppType::SingleReceiver:
         return std::string("\nUsage: ") + getTypeString() + " Options:\n" +
diff --git a/slsReceiverSoftware/src/CommandLineOptions.h b/slsReceiverSoftware/src/CommandLineOptions.h
index 8ecf7e2ee..04e81f4a6 100644
--- a/slsReceiverSoftware/src/CommandLineOptions.h
+++ b/slsReceiverSoftware/src/CommandLineOptions.h
@@ -37,10 +37,11 @@ using ParsedOptions = std::variant<CommonOptions, MultiReceiverOptions, FrameSyn
 class CommandLineOptions {
   public:
     constexpr explicit CommandLineOptions(AppType app) : appType_(app) {}
+    ParsedOptions parse(const std::vector<std::string> &args); // for testing
     ParsedOptions parse(int argc, char *argv[]);
-    std::string getTypeString();
-    std::string getVersion();
-    std::string getHelpMessage();
+    std::string getTypeString() const;
+    std::string getVersion() const;
+    std::string getHelpMessage() const;
     static void setupSignalHandler(int signal, void (*handler)(int));
     static void setEffectiveUID(uid_t uid);
 
@@ -49,14 +50,17 @@ class CommandLineOptions {
     std::vector<option> buildOptionList() const;
     std::string buildOptString() const;
 
+    static uint16_t parsePort(const char *optarg);
+    static uint16_t parseNumReceivers(const char *optarg);
+    static uid_t parseUID(const char *optarg);
     void handleCommonOption(int opt, const char *optarg, CommonOptions &base);
     void handleAppSpecificOption(int opt, const char *optarg,
                                  CommonOptions &base,
                                  MultiReceiverOptions &multi,
                                  FrameSyncOptions &frame);
 
-    static int GetDeprecated(int argc, char *argv[], uint16_t &startPort,
-                             uint16_t &numReceivers, bool &optionalArg);
+    static void GetDeprecated(int argc, char *argv[], uint16_t &startPort,
+                              uint16_t &numReceivers, bool &optionalArg);
 
     static constexpr uint16_t MAX_RECEIVERS = 1000;
 };
diff --git a/slsReceiverSoftware/tests/test-Apps.cpp b/slsReceiverSoftware/tests/test-Apps.cpp
new file mode 100644
index 000000000..06139b036
--- /dev/null
+++ b/slsReceiverSoftware/tests/test-Apps.cpp
@@ -0,0 +1,153 @@
+// SPDX-License-Identifier: LGPL-3.0-or-other
+// Copyright (C) 2021 Contributors to the SLS Detector Package
+#include "catch.hpp"
+#include "CommandLineOptions.h"
+#include "sls/versionAPI.h"
+
+namespace sls {
+
+    TEST_CASE("CommandLineOption construction", "[.rxcmdcall]") {
+        CommandLineOptions s(AppType::SingleReceiver);
+        REQUIRE(s.getTypeString() == "slsReceiver");
+        REQUIRE(s.getVersion() == std::string("slsReceiver Version: ") + APIRECEIVER);
+        REQUIRE_NOTHROW(s.getHelpMessage());
+
+        CommandLineOptions m(AppType::MultiReceiver);
+        REQUIRE(m.getTypeString() == "slsMultiReceiver");
+        REQUIRE(m.getVersion() == std::string("slsMultiReceiver Version: ") + APIRECEIVER);
+        REQUIRE_NOTHROW(m.getHelpMessage());
+
+        CommandLineOptions f(AppType::FrameSynchronizer);
+        REQUIRE(f.getTypeString() == "slsFrameSynchronizer");
+        REQUIRE(f.getVersion() == std::string("slsFrameSynchronizer Version: ") + APIRECEIVER);
+        REQUIRE_NOTHROW(f.getHelpMessage());
+    }
+
+    TEST_CASE("Validate slsReceiver options", "[.rxcmdcall]") {
+        CommandLineOptions s(AppType::SingleReceiver);
+        // valid options
+        REQUIRE_NOTHROW(s.parse({}));
+        REQUIRE_NOTHROW(s.parse({"", "-v"}));
+        REQUIRE_NOTHROW(s.parse({"", "-h"}));
+        REQUIRE_NOTHROW(s.parse({"", "-h", "gdfg"})); // ignored extra args
+        REQUIRE_NOTHROW(s.parse({"", "-p", "1955"}));
+        REQUIRE_NOTHROW(s.parse({"", "-u", "1001"}));
+        REQUIRE_NOTHROW(s.parse({"", "-p", "1234", "-u", "1001"}));
+        REQUIRE_NOTHROW(s.parse({"", "-t", "1955"}));
+        // invalid options
+        REQUIRE_THROWS(s.parse({"", "-c"}));
+        REQUIRE_THROWS(s.parse({"", "-n", "2"}));
+        REQUIRE_THROWS(s.parse({"", "-m", "2"}));
+    }
+
+    TEST_CASE("Validate slsMultiReceiver options", "[.rxcmdcall]") {
+        CommandLineOptions s(AppType::MultiReceiver);
+        // valid options
+        REQUIRE_NOTHROW(s.parse({}));
+        REQUIRE_NOTHROW(s.parse({"", "-v"}));
+        REQUIRE_NOTHROW(s.parse({"", "-h"}));
+        REQUIRE_NOTHROW(s.parse({"", "-h", "gdfg"})); // ignored extra args
+        REQUIRE_NOTHROW(s.parse({"", "-p", "1955"}));
+        REQUIRE_NOTHROW(s.parse({"", "-u", "1001"}));
+        REQUIRE_NOTHROW(s.parse({"", "-p", "1234", "-u", "1001"}));
+        REQUIRE_NOTHROW(s.parse({"", "-c"}));
+        REQUIRE_NOTHROW(s.parse({"", "-n", "2"}));
+        REQUIRE_NOTHROW(s.parse({"", "-p", "1234", "-u", "1001", "-c", "-n", "2"}));
+        // invalid options
+        REQUIRE_THROWS(s.parse({"", "-t", "1955"}));
+        REQUIRE_THROWS(s.parse({"", "-m", "2"}));
+    }
+
+    TEST_CASE("Validate slsFrameSynchronizer options", "[.rxcmdcall]") {
+        CommandLineOptions s(AppType::FrameSynchronizer);
+        // valid options
+        REQUIRE_NOTHROW(s.parse({}));
+        REQUIRE_NOTHROW(s.parse({"", "-v"}));
+        REQUIRE_NOTHROW(s.parse({"", "-h"}));
+        REQUIRE_NOTHROW(s.parse({"", "-h", "gdfg"})); // ignored extra args
+        REQUIRE_NOTHROW(s.parse({"", "-p", "1955"}));
+        REQUIRE_NOTHROW(s.parse({"", "-u", "1001"}));
+        REQUIRE_NOTHROW(s.parse({"", "-p", "1234", "-u", "1001"}));
+        REQUIRE_NOTHROW(s.parse({"", "-c"}));
+        REQUIRE_NOTHROW(s.parse({"", "-n", "2"}));
+        REQUIRE_NOTHROW(s.parse({"", "-p", "1234", "-u", "1001", "-c", "-n", "2"}));
+        // invalid options
+        REQUIRE_THROWS(s.parse({"", "-t", "1955"}));
+        REQUIRE_THROWS(s.parse({"", "-m", "2"}));
+    }
+
+    TEST_CASE("Parse version and help", "[.rxcmdcall]") {
+        CommandLineOptions s(AppType::SingleReceiver);
+        auto opts = s.parse({});
+        auto &o = std::get<CommonOptions>(opts);
+        REQUIRE(o.versionRequested == false);
+        REQUIRE(o.helpRequested == false);
+
+        opts = s.parse({"", "-v"});
+        o = std::get<CommonOptions>(opts);
+        REQUIRE(o.versionRequested == true);
+        REQUIRE(o.helpRequested == false);
+
+        opts = s.parse({"", "-h"});
+        o = std::get<CommonOptions>(opts);
+        REQUIRE(o.versionRequested == false);
+        REQUIRE(o.helpRequested == true);
+
+        opts = s.parse({"", "-h", "-v"});
+        o = std::get<CommonOptions>(opts);
+        REQUIRE(o.versionRequested == false); // because it exits after help
+        REQUIRE(o.helpRequested == true);
+
+        opts = s.parse({"", "-v", "-h"});
+        o = std::get<CommonOptions>(opts);
+        REQUIRE(o.helpRequested == false); // because it exits after version
+        REQUIRE(o.versionRequested == true);
+
+        opts = s.parse({"", "-v", "-h", "sdfsf"}); // should ignore extra args
+        o = std::get<CommonOptions>(opts);
+        REQUIRE(o.helpRequested == false); // because it exits after version
+        REQUIRE(o.versionRequested == true);
+    }
+
+    TEST_CASE("Parse port and uid", "[.rxcmdcall]") {
+        for (auto app : {AppType::SingleReceiver, AppType::MultiReceiver, AppType::FrameSynchronizer}) {
+            CommandLineOptions s(app);
+            REQUIRE_THROWS(s.parse({"", "-p", "1234", "-u", "1000"})); // invalid uid
+            REQUIRE_THROWS(s.parse({"", "-p", "500"})); // invalid port
+            
+            auto opts = s.parse({"", "-p", "1234", "-u", "1001"});
+            auto &o = std::get<CommonOptions>(opts);
+            REQUIRE(o.port == 1234);
+            REQUIRE(o.userid == 1001);
+
+            opts = s.parse({"", "-p", "5678"});
+            o = std::get<CommonOptions>(opts);
+            REQUIRE(o.port == 5678);
+            REQUIRE(o.userid == static_cast<uid_t>(-1)); // default value
+
+            opts = s.parse({});
+            o = std::get<CommonOptions>(opts);
+            REQUIRE(o.port == 1954); // default value
+            REQUIRE(o.userid == static_cast<uid_t>(-1)); // default value
+        }
+    }
+
+    TEST_CASE("Parse number of receivers and optional arg", "[.rxcmdcall]") {
+        CommandLineOptions s(AppType::MultiReceiver);
+        // invalid options
+        REQUIRE_THROWS(s.parse({"", "-n", "0"})); // invalid number of receivers
+        REQUIRE_THROWS(s.parse({"", "-n", "1001"})); // exceeds max receivers
+        // valid options
+        REQUIRE_NOTHROW(s.parse({"", "-n", "10"})); // valid number of receivers
+
+        auto opts = s.parse({"", "-n", "5"});
+        auto &m = std::get<MultiReceiverOptions>(opts);
+        REQUIRE(m.numReceivers == 5);
+        REQUIRE(m.callbackEnabled == false); // default value
+
+        opts = s.parse({"", "-c", "-n", "3"});
+        m = std::get<MultiReceiverOptions>(opts);
+        REQUIRE(m.numReceivers == 3);
+        REQUIRE(m.callbackEnabled == true);
+    }
+}
\ No newline at end of file