From 274a338520e4b195be8c07d2e104c7e24491e767 Mon Sep 17 00:00:00 2001 From: Dhanya Thattil Date: Tue, 1 Jul 2025 16:58:27 +0200 Subject: [PATCH] redundant getRxROI in Detector class for multi level and module level --- slsDetectorSoftware/include/sls/Detector.h | 9 +++------ slsDetectorSoftware/src/Detector.cpp | 2 -- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/slsDetectorSoftware/include/sls/Detector.h b/slsDetectorSoftware/include/sls/Detector.h index 5acd767c8..ef4b9c251 100644 --- a/slsDetectorSoftware/include/sls/Detector.h +++ b/slsDetectorSoftware/include/sls/Detector.h @@ -989,12 +989,9 @@ class Detector { * every minute. Useful in 10G mode. */ void setRxArping(bool value, Positions pos = {}); - /** Returns multi level ROIs */ - std::vector getRxROI() const; - - /** Returns port level ROIs. Max 2 ports and hence max 2 elements per - * readout */ - std::vector getRxROI(int module_id) const; + /** If module_id is -1, returns multi level ROIs. Else it returns port + * level ROIs. Max 2 ports and hence max 2 elements per readout */ + std::vector getRxROI(int module_id = -1) const; /** only at multi module level without gap pixels. If more than 1 ROI per * UDP port, it will throw. Setting number of udp interfaces will clear the diff --git a/slsDetectorSoftware/src/Detector.cpp b/slsDetectorSoftware/src/Detector.cpp index 06e44a308..cb7e33018 100644 --- a/slsDetectorSoftware/src/Detector.cpp +++ b/slsDetectorSoftware/src/Detector.cpp @@ -1383,8 +1383,6 @@ void Detector::setRxArping(bool value, Positions pos) { pimpl->Parallel(&Module::setRxArping, pos, value); } -std::vector Detector::getRxROI() const { return pimpl->getRxROI(); } - std::vector Detector::getRxROI(int module_id) const { return pimpl->getRxROI(module_id); }