detectors/aare
25
0
Fork 0
mirror of https://github.com/slsdetectorgroup/aare.git synced 2026-06-04 18:38:42 +02:00
Code Issues Actions Packages Releases Activity

removed sync fill
Build on RHEL9 / build (push) Successful in 2m30s
Details
Build on RHEL8 / build (push) Successful in 3m5s
Details
Run tests using data on local RHEL8 / build (push) Successful in 3m55s
Details

Browse Source
This commit is contained in:
Lars Erik Fröjd
2026-06-01 14:59:57 +02:00
parent 1f78c9f7d1
commit c10bcb8075
8 changed files with 103 additions and 216 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/bind_PedestalTrackingPixelHistogram.hpp
+4 -25
View File
@@ -73,7 +73,7 @@ void define_pedestal_tracking_pixel_histogram_bindings(py::module &m) {
its running sums. Drains pending async fills first, then
dispatches the update to the worker pool so the writes to
each shard happen on the same thread that reads them in
fill().
fill_async().
)",
py::call_guard<py::gil_scoped_release>())
@@ -98,27 +98,6 @@ void define_pedestal_tracking_pixel_histogram_bindings(py::module &m) {
containing the current cached pedestal mean.
)")
.def("fill",
[](PedestalTrackingPixelHistogram &self,
py::array_t<PedestalTrackingPixelHistogram::FrameType, 0>
image) {
auto view = make_view_2d(image);
self.fill(view);
},
R"(
Fill the histogram with image data (blocking).
The pedestal-subtracted residual `image - pedestal_mean`
is computed per pixel inside the worker loop, so the
pedestal must already have been bootstrapped via
push_pedestal_no_update() + update_mean() for this to be
meaningful.
Args:
image: A 2D numpy array of raw pixel values (dtype: uint16)
)",
py::arg("image").noconvert())
.def("fill_async",
[](PedestalTrackingPixelHistogram &self,
py::array_t<PedestalTrackingPixelHistogram::FrameType, 0>
@@ -189,9 +168,9 @@ void define_pedestal_tracking_pixel_histogram_bindings(py::module &m) {
for monitoring/diagnostics.
)")
.def("hdata",
.def("values",
[](const PedestalTrackingPixelHistogram &self) {
// hdata() implicitly flushes - release the GIL while it
// values() implicitly flushes - release the GIL while it
// does so. Allocation/copy into the NDArray runs without
// the GIL too; only the numpy wrapping needs it.
NDArray<PedestalTrackingPixelHistogram::StorageType, 3>
@@ -200,7 +179,7 @@ void define_pedestal_tracking_pixel_histogram_bindings(py::module &m) {
py::gil_scoped_release release;
ptr = new NDArray<
PedestalTrackingPixelHistogram::StorageType, 3>(
self.hdata());
self.values());
}
return return_image_data(ptr);
},
python/src/bind_PixelHistogram.hpp
+3 -17
View File
@@ -32,20 +32,6 @@ void define_pixel_histogram_bindings(py::module &m) {
py::arg("xmin"), py::arg("xmax"), py::arg("n_threads") = 1,
py::arg("max_pending") = std::size_t{16})
.def("fill",
[](PixelHistogram &self,
py::array_t<PixelHistogram::AxisType, 0> image) {
auto view = make_view_2d(image);
self.fill(view);
},
R"(
Fill the histogram with image data (blocking).
Args:
image: A 2D numpy array of pixel values (dtype: float32)
)",
py::arg("image").noconvert())
.def("fill_async",
[](PixelHistogram &self,
py::array_t<PixelHistogram::AxisType, 0> image) {
@@ -89,15 +75,15 @@ void define_pixel_histogram_bindings(py::module &m) {
for monitoring/diagnostics.
)")
.def("hdata",
.def("values",
[](const PixelHistogram &self) {
// hdata() implicitly flushes - release the GIL while it
// values() implicitly flushes - release the GIL while it
// does so. Allocation/copy into the NDArray runs without
// the GIL too; only the numpy wrapping needs it.
NDArray<PixelHistogram::StorageType, 3>* ptr = nullptr;
{
py::gil_scoped_release release;
ptr = new NDArray<PixelHistogram::StorageType, 3>(self.hdata());
ptr = new NDArray<PixelHistogram::StorageType, 3>(self.values());
}
return return_image_data(ptr);
},