Reduce helper apis

dbconn/src/channelconfig.rs

@@ -72,14 +72,7 @@ pub async fn chconf_from_database(channel: &Channel, ncc: &NodeConfigCached) ->
     }
     // TODO use a common already running worker pool for these queries:
     let dbconf = &ncc.node_config.cluster.database;
-    let dburl = format!(
-        "postgresql://{}:{}@{}:{}/{}",
-        dbconf.user, dbconf.pass, dbconf.host, dbconf.port, dbconf.name
-    );
-    let (pgclient, pgconn) = tokio_postgres::connect(&dburl, tokio_postgres::NoTls)
-        .await
-        .err_conv()?;
-    tokio::spawn(pgconn);
+    let pgclient = crate::create_connection(dbconf).await?;
     if let Some(series) = channel.series() {
         let res = pgclient
             .query(

dbconn/src/dbconn.rs

@@ -49,6 +49,7 @@ pub async fn delay_io_medium() {
 }
 
 pub async fn create_connection(db_config: &Database) -> Result<Client, Error> {
+    // TODO use a common already running worker pool for these queries:
     let d = db_config;
     let uri = format!("postgresql://{}:{}@{}:{}/{}", d.user, d.pass, d.host, 5432, d.name);
     let (cl, conn) = tokio_postgres::connect(&uri, NoTls)

dbconn/src/scan.rs

@@ -2,8 +2,7 @@ use crate::{create_connection, delay_io_medium, delay_io_short, ErrConv};
 use async_channel::{bounded, Receiver};
 use chrono::{DateTime, Utc};
 use err::Error;
-use futures_core::Stream;
-use futures_util::FutureExt;
+use futures_util::{FutureExt, Stream};
 use netpod::log::*;
 use netpod::{Database, NodeConfigCached};
 use parse::channelconfig::NErr;