When not going through pre-binned the read bytes are exact

This commit is contained in:
Dominik Werder
2021-05-06 18:25:45 +02:00
parent af9c11bdd8
commit a89e1cfc50
4 changed files with 6 additions and 6 deletions
+1
View File
@@ -65,6 +65,7 @@ impl BinnedStream {
} }
Ok(PreBinnedItem::RangeComplete) => Some(Ok(MinMaxAvgScalarBinBatchStreamItem::RangeComplete)), Ok(PreBinnedItem::RangeComplete) => Some(Ok(MinMaxAvgScalarBinBatchStreamItem::RangeComplete)),
Ok(PreBinnedItem::EventDataReadStats(stats)) => { Ok(PreBinnedItem::EventDataReadStats(stats)) => {
info!("BinnedStream observes stats {:?}", stats);
Some(Ok(MinMaxAvgScalarBinBatchStreamItem::EventDataReadStats(stats))) Some(Ok(MinMaxAvgScalarBinBatchStreamItem::EventDataReadStats(stats)))
} }
Ok(PreBinnedItem::Log(item)) => Some(Ok(MinMaxAvgScalarBinBatchStreamItem::Log(item))), Ok(PreBinnedItem::Log(item)) => Some(Ok(MinMaxAvgScalarBinBatchStreamItem::Log(item))),
+4 -1
View File
@@ -112,7 +112,10 @@ impl PreBinnedValueStream {
match k { match k {
Ok(Values(k)) => Ok(PreBinnedItem::Batch(k)), Ok(Values(k)) => Ok(PreBinnedItem::Batch(k)),
Ok(RangeComplete) => Ok(PreBinnedItem::RangeComplete), Ok(RangeComplete) => Ok(PreBinnedItem::RangeComplete),
Ok(EventDataReadStats(stats)) => Ok(PreBinnedItem::EventDataReadStats(stats)), Ok(EventDataReadStats(stats)) => {
info!("PreBinnedValueStream ✙ ✙ ✙ ✙ ✙ ✙ ✙ ✙ ✙ ✙ ✙ ✙ ✙ stats {:?}", stats);
Ok(PreBinnedItem::EventDataReadStats(stats))
}
Ok(Log(item)) => Ok(PreBinnedItem::Log(item)), Ok(Log(item)) => Ok(PreBinnedItem::Log(item)),
Err(e) => Err(e), Err(e) => Err(e),
} }
-4
View File
@@ -198,10 +198,6 @@ where
} }
} }
// This can:
// Do nothing if all have Val or Finished.
// But if some is None:
// We might get some Pending from upstream. In that case, caller also wants to abort here.
fn replenish(self: &mut Pin<&mut Self>, cx: &mut Context) -> Poll<Result<(), Error>> { fn replenish(self: &mut Pin<&mut Self>, cx: &mut Context) -> Poll<Result<(), Error>> {
use Poll::*; use Poll::*;
let mut pending = 0; let mut pending = 0;
+1 -1
View File
@@ -50,7 +50,7 @@ async fn get_binned_0_inner() -> Result<(), Error> {
get_binned_channel( get_binned_channel(
"wave-f64-be-n21", "wave-f64-be-n21",
"1970-01-01T00:20:10.000Z", "1970-01-01T00:20:10.000Z",
"1970-01-01T00:20:51.000Z", "1970-01-01T00:20:15.000Z",
4, 4,
&cluster, &cluster,
) )