From b23f32f1f352f8392b9d2b9309ed125baca7a36f Mon Sep 17 00:00:00 2001
From: Dominik Werder <dominik.werder@gmail.com>
Date: Fri, 6 Jun 2025 14:57:58 +0200
Subject: [PATCH] Add error msg

---
 src/binning/timeweight/timeweight_bins.rs     |  8 ++++--
 .../timeweight/timeweight_bins_lazy.rs        | 16 ++++++++++-
 src/binning/timeweight/timeweight_events.rs   | 27 +++++++++++--------
 3 files changed, 37 insertions(+), 14 deletions(-)

diff --git a/src/binning/timeweight/timeweight_bins.rs b/src/binning/timeweight/timeweight_bins.rs
index 701665a..f3657d8 100644
--- a/src/binning/timeweight/timeweight_bins.rs
+++ b/src/binning/timeweight/timeweight_bins.rs
@@ -161,8 +161,8 @@ where
 
     fn ingest_bins(&mut self, bins: &ContainerBins<EVT, BVT>) -> Result<(), BinningggError> {
         trace_ingest_bin!(
-            "\n\n+++++++++++++\n\ningest_bins  active_beg {active_beg}",
-            active_beg = self.active_beg
+            "\n\n+++++++++++++\n\ningest_bins  active_beg {}",
+            self.active_beg
         );
         for (((((((&ts1, &ts2), &cnt), min), max), agg), lst), &fnl) in bins.zip_iter() {
             let grid = self.range.bin_len_dt_ns();
@@ -209,6 +209,10 @@ where
     EVT: EventValueType,
     BVT: BinAggedType,
 {
+    fn cnt_zero_enable(&mut self) {
+        self.cnt_zero_enable();
+    }
+
     fn ingest(&mut self, bins: &BinsBoxed) -> Result<(), BinningggError> {
         if let Some(bins) = bins.as_any_ref().downcast_ref::<ContainerBins<EVT, BVT>>() {
             self.ingest_bins(bins)
diff --git a/src/binning/timeweight/timeweight_bins_lazy.rs b/src/binning/timeweight/timeweight_bins_lazy.rs
index e4c8a60..ea4b314 100644
--- a/src/binning/timeweight/timeweight_bins_lazy.rs
+++ b/src/binning/timeweight/timeweight_bins_lazy.rs
@@ -9,6 +9,7 @@ use netpod::TsNano;
 pub struct BinnedBinsTimeweightLazy {
     range: BinnedRange<TsNano>,
     binned: Option<Box<dyn BinnedBinsTimeweightTrait>>,
+    produce_cnt_zero: bool,
 }
 
 impl BinnedBinsTimeweightLazy {
@@ -16,12 +17,25 @@ impl BinnedBinsTimeweightLazy {
         Self {
             range,
             binned: None,
+            produce_cnt_zero: false,
         }
     }
 
+    pub fn set_cnt_zero(self) -> Self {
+        let mut ret = self;
+        ret.produce_cnt_zero = true;
+        ret
+    }
+
     pub fn ingest(&mut self, evs: &BinsBoxed) -> Result<(), BinningggError> {
         self.binned
-            .get_or_insert_with(|| evs.binned_bins_timeweight_traitobj(self.range.clone()))
+            .get_or_insert_with(|| {
+                let mut binner = evs.binned_bins_timeweight_traitobj(self.range.clone());
+                if self.produce_cnt_zero {
+                    binner.cnt_zero_enable();
+                }
+                binner
+            })
             .ingest(evs)
     }
 
diff --git a/src/binning/timeweight/timeweight_events.rs b/src/binning/timeweight/timeweight_events.rs
index 5dda5e1..506b111 100644
--- a/src/binning/timeweight/timeweight_events.rs
+++ b/src/binning/timeweight/timeweight_events.rs
@@ -58,8 +58,6 @@ fn cold() {}
 
 const DEBUG_CHECKS: bool = true;
 
-pub type RefStr = &'static str;
-
 autoerr::create_error_v1!(
     name(Error, "BinnedEventsTimeweight"),
     enum variants {
@@ -74,8 +72,8 @@ autoerr::create_error_v1!(
         NoMinMaxAfterInit,
         ExpectEventWithinRange,
         IngestNoProgress(usize, usize),
-        EventActiveRangeBefore,
-        EventActiveRangeAfter(RefStr),
+        EventActiveRangeBefore(String),
+        EventActiveRangeAfter(String),
         EventActiveRangeLE,
     },
 );
@@ -190,7 +188,7 @@ where
                     return Err(Error::EventActiveRangeLE);
                 }
                 if ev.ts >= self.active_end {
-                    return Err(Error::EventActiveRangeAfter(selfname));
+                    return Err(Error::EventActiveRangeAfter(selfname.into()));
                 }
             }
             self.ingest_event_with_lst_gt_range_beg(ev.clone(), LstMut(lst.0), minmax)?;
@@ -242,10 +240,10 @@ where
         if let Some(ts0) = evs.ts_first() {
             trace_ingest_event!("{selfname}  EVENT TIMESTAMP FRONT  {:?}", ts0);
             if ts0 < self.active_beg {
-                Err(Error::EventActiveRangeBefore)
+                Err(Error::EventActiveRangeBefore(selfname.into()))
             } else if ts0 >= self.active_end {
                 info!("ts0 >= self.active_end  {}  {}", ts0, self.active_end);
-                Err(Error::EventActiveRangeAfter(selfname))
+                Err(Error::EventActiveRangeAfter(selfname.into()))
             } else {
                 self.ingest_with_lst_ge_range_beg(evs, lst, minmax)
             }
@@ -333,9 +331,9 @@ where
                 let beg = b.active_beg;
                 let end = b.active_end;
                 if ev.ts < beg {
-                    return Err(Error::EventActiveRangeBefore);
+                    return Err(Error::EventActiveRangeBefore(selfname.into()));
                 } else if ev.ts >= end {
-                    return Err(Error::EventActiveRangeAfter(selfname));
+                    return Err(Error::EventActiveRangeAfter(selfname.into()));
                 } else {
                     if ev.ts == beg {
                         self.init_minmax(&ev);
@@ -505,9 +503,16 @@ where
         let selfname = "ingest_event_without_lst";
         let b = &self.inner_a.inner_b;
         if ev.ts < b.active_beg {
-            Err(Error::EventActiveRangeBefore)
+            if false {
+                return Err(Error::EventActiveRangeBefore(selfname.into()));
+            }
+            trace_ingest_init_lst!("{selfname}  set lst  {:?}", ev);
+            self.lst = Some((&ev).into());
+            trace_ingest_minmax!("{selfname}  call init_minmax");
+            self.inner_a.init_minmax(&ev);
+            Ok(())
         } else if ev.ts >= b.active_end {
-            Err(Error::EventActiveRangeAfter(selfname))
+            Err(Error::EventActiveRangeAfter(selfname.into()))
         } else {
             trace_ingest_init_lst!("{selfname}  set lst  {:?}", ev);
             self.lst = Some((&ev).into());